)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e7f7a09984d3a8d6afd60cd7286a26ad4fbfb07d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-04-27 09:54:51 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow-up patch for fixing coverage issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: HeroicHitesh \u003cemail.hiteshkumar@gmail.com\u003e"},{"line_number":10,"context_line":"Change-Id: Ief1c7eb6b3f3d28e9321280718df59eebaca786f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5bd8fb9f_541779d7","line":8,"updated":"2021-04-27 06:51:15.000000000","message":"try to write more descriptive commit messages (it\u0027s a must in case of more complicated reviews).\nCommit message should include details so that a reviewer can quickly understand the context of the change, why it\u0027s need, what it fixes, ... all this will help reviewers to review.\n\nIn this case I\u0027d write a commit message like this:\n\n```\nFixing coverage issue\n\nThe patch fixes coverage tox environment and adds a new\njob, openstack-cover-jobs, to run the coverage in Zuul.\n```\n\nSee an example commit message doc: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#rebasing-a-commit\nSee the commit messages in:\n* one of my simple patches: https://review.opendev.org/c/osf/python-tempestconf/+/787904\n* a more complex change: https://review.opendev.org/c/openstack/tempest/+/768583","commit_id":"096b484a7c7f3cf75995ddd86b54c9d11cf73482"},{"author":{"_account_id":33370,"name":"Hitesh Kumar","display_name":"HeroicHitesh","email":"email.hiteshkumar@gmail.com","username":"heroichitesh"},"change_message_id":"8959f1b9da77a0ced05a8776ee3dd54ab4c0d587","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-04-27 09:54:51 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow-up patch for fixing coverage issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Signed-off-by: HeroicHitesh \u003cemail.hiteshkumar@gmail.com\u003e"},{"line_number":10,"context_line":"Change-Id: Ief1c7eb6b3f3d28e9321280718df59eebaca786f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"36cc2ca7_c01515af","line":8,"in_reply_to":"5bd8fb9f_541779d7","updated":"2021-04-29 06:14:39.000000000","message":"Sure, I\u0027ll keep this in mind.","commit_id":"096b484a7c7f3cf75995ddd86b54c9d11cf73482"}],"tox.ini":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aac483fd23a2907a7db8eff25eb22b3611f56544","unresolved":true,"context_lines":[{"line_number":21,"context_line":"[testenv:venv]"},{"line_number":22,"context_line":"commands \u003d {posargs}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[testenv:cover]"},{"line_number":25,"context_line":"basepython \u003d python3"},{"line_number":26,"context_line":"setenv \u003d"},{"line_number":27,"context_line":"  {[testenv]setenv}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"eea4cc54_e71e7cbd","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":15},"updated":"2021-04-26 08:31:57.000000000","message":"set also the following in this section (somewhere before commands):\nallowlist_externals \u003d find\n\notherwise tox will be throwing the following error:\nWARNING: test command found but not installed in testenv\n  cmd: /usr/bin/find\n  env: /tmp/python-vitrageclient/.tox/cover\nMaybe you forgot to specify a dependency? See also the allowlist_externals envconfig setting.\n\nDEPRECATION WARNING: this will be an error in tox 4 and above!","commit_id":"3cda0605801bc93f1be0836cc99d51b5b0cb44e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aac483fd23a2907a7db8eff25eb22b3611f56544","unresolved":true,"context_lines":[{"line_number":25,"context_line":"basepython \u003d python3"},{"line_number":26,"context_line":"setenv \u003d"},{"line_number":27,"context_line":"  {[testenv]setenv}"},{"line_number":28,"context_line":"  PYTHON\u003dcoverage run --source python_vitrageclient --parallel-mode"},{"line_number":29,"context_line":"commands \u003d"},{"line_number":30,"context_line":"  coverage erase"},{"line_number":31,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"e6542d95_8d245835","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":51},"updated":"2021-04-26 08:31:57.000000000","message":"this is supposed to be just \u0027vitrageclient\u0027 .. there is no python_vitrageclient dir, however, the project dir is called vitrageclient - due to this mismatch the cover job was failing on \u0027Module python_vitrageclient was never imported\u0027 and that has lead to no data collection and a failure of coverage calculation","commit_id":"3cda0605801bc93f1be0836cc99d51b5b0cb44e8"}]}