)]}'
{"id":"openstack%2Fpython-watcherclient~408924","triplet_id":"openstack%2Fpython-watcherclient~master~Ic6af69d5b4b36f3dd02aab0f9c446aa54970f388","project":"openstack/python-watcherclient","branch":"master","topic":"bug/gengchc","hashtags":[],"change_id":"Ic6af69d5b4b36f3dd02aab0f9c446aa54970f388","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2016-12-09 03:10:37.000000000","updated":"2016-12-16 16:34:15.000000000","submitted":"2016-12-16 16:34:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8704337829437ab5ad8eff447492c69150d70483","_number":408924,"virtual_id_number":408924,"owner":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-12-16 16:34:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-12-13 19:51:35.000000000","_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-16 16:27:44.000000000","_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-16 16:27:44.000000000","updated_by":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"reviewer":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"state":"REVIEWER"},{"updated":"2016-12-16 16:34:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"948193952fff41d399c914fe1f766bb874651d50","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2016-12-09 03:10:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1ae8dec220f1a5a539cc06c8d35b338ea35887f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-09 03:17:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-watcherclient-docs-ubuntu-xenial http://docs-draft.openstack.org/24/408924/1/check/gate-python-watcherclient-docs-ubuntu-xenial/80feef2//doc/build/html/ : SUCCESS in 1m 48s\n- gate-python-watcherclient-pep8-ubuntu-xenial http://logs.openstack.org/24/408924/1/check/gate-python-watcherclient-pep8-ubuntu-xenial/f1a040a/ : SUCCESS in 3m 14s\n- gate-python-watcherclient-python27-ubuntu-xenial http://logs.openstack.org/24/408924/1/check/gate-python-watcherclient-python27-ubuntu-xenial/84bf03f/ : SUCCESS in 1m 46s\n- gate-python-watcherclient-python34 http://logs.openstack.org/24/408924/1/check/gate-python-watcherclient-python34/328eb3d/ : SUCCESS in 2m 46s\n- gate-python-watcherclient-python35-nv http://logs.openstack.org/24/408924/1/check/gate-python-watcherclient-python35-nv/69e6ff3/ : SUCCESS in 4m 39s (non-voting)\n- check-osc-plugins http://logs.openstack.org/24/408924/1/check/check-osc-plugins/4ae542e/ : FAILURE in 3m 43s (non-voting)\n- python-watcherclient-coverage-ubuntu-xenial http://logs.openstack.org/24/408924/1/check/python-watcherclient-coverage-ubuntu-xenial/e00a202/ : SUCCESS in 2m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0dbfd5709072bcc1c6d5c9b4154f843eb2276731","author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"date":"2016-12-13 19:51:35.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8ed96fc9a90dd89a143765e9adf012ba041d761b","author":{"_account_id":12394,"name":"David TARDIVEL","email":"David.TARDIVEL@b-com.com","username":"David.T"},"date":"2016-12-16 16:27:44.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1b754601a36f8544cb0a68458db31716972b06b5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-16 16:27:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d75cad7919a8ee838ffe7b00f594c33904c39e26","date":"2016-12-16 16:34:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"0c324bd4d4b123c786a08ca1b4f34feaf622598c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-16 16:34:15.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-watcherclient-docs-ubuntu-xenial http://docs-draft.openstack.org/24/408924/1/gate/gate-python-watcherclient-docs-ubuntu-xenial/ea72f77//doc/build/html/ : SUCCESS in 3m 32s\n- gate-python-watcherclient-pep8-ubuntu-xenial http://logs.openstack.org/24/408924/1/gate/gate-python-watcherclient-pep8-ubuntu-xenial/392f824/ : SUCCESS in 4m 56s\n- gate-python-watcherclient-python27-ubuntu-xenial http://logs.openstack.org/24/408924/1/gate/gate-python-watcherclient-python27-ubuntu-xenial/e498fce/ : SUCCESS in 2m 36s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b8e3d4d6cce2958aef2c260e3eac36b4e01a7fa","revisions":{"5b8e3d4d6cce2958aef2c260e3eac36b4e01a7fa":{"kind":"REWORK","_number":1,"created":"2016-12-09 03:10:37.000000000","uploader":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"ref":"refs/changes/24/408924/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-watcherclient","ref":"refs/changes/24/408924/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-watcherclient refs/changes/24/408924/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-watcherclient refs/changes/24/408924/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-watcherclient refs/changes/24/408924/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-watcherclient refs/changes/24/408924/1"}}},"commit":{"parents":[{"commit":"fce4e7e10cb767ae8679ed23b924e0ac6c37fea0","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-watcherclient/commit/fce4e7e10cb767ae8679ed23b924e0ac6c37fea0"}]}],"author":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 03:31:24.000000000","tz":480},"committer":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2016-12-09 03:31:24.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ic6af69d5b4b36f3dd02aab0f9c446aa54970f388\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-watcherclient/commit/5b8e3d4d6cce2958aef2c260e3eac36b4e01a7fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-watcherclient/commit/5b8e3d4d6cce2958aef2c260e3eac36b4e01a7fa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}