)]}'
{"id":"openstack%2Fpython-zaqarclient~122591","triplet_id":"openstack%2Fpython-zaqarclient~master~I694aa70b56cade9e0e79020059e7b716601868df","project":"openstack/python-zaqarclient","branch":"master","topic":"bug/remove_grace","hashtags":[],"change_id":"I694aa70b56cade9e0e79020059e7b716601868df","subject":"Remove the grace in claim update method","status":"ABANDONED","created":"2014-09-19 02:09:07.000000000","updated":"2015-06-17 14:49:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b96da9675f30848f85e4a185ae30cca5873287fd","_number":122591,"virtual_id_number":122591,"owner":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2014-10-29 03:10:54.000000000","_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"value":1,"date":"2014-09-19 04:05:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2014-10-28 19:30:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-19 04:05:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-10-28 19:30:25.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"}],"messages":[{"id":"7916833939037b398ce38c84a27ddb0632ab60fe","author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"date":"2014-09-19 02:09:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d09666e52b2ecc12a214b4a7d1bd5d52874b4112","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-19 03:11:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-zaqarclient-python33 http://logs.openstack.org/91/122591/1/check/gate-python-zaqarclient-python33/470a32b : FAILURE in 2m 10s\n- gate-python-zaqarclient-pep8 http://logs.openstack.org/91/122591/1/check/gate-python-zaqarclient-pep8/d5c50bf : SUCCESS in 2m 11s\n- gate-python-zaqarclient-python26 http://logs.openstack.org/91/122591/1/check/gate-python-zaqarclient-python26/322b627 : FAILURE in 1m 52s\n- gate-python-zaqarclient-python27 http://logs.openstack.org/91/122591/1/check/gate-python-zaqarclient-python27/730738c : FAILURE in 1m 55s\n- gate-python-zaqarclient-pypy http://logs.openstack.org/91/122591/1/check/gate-python-zaqarclient-pypy/53ea6d5 : FAILURE in 1m 42s","accounts_in_message":[],"_revision_number":1},{"id":"0cb8da7b6da62af3db7b0c704e8d8c812faaf3f0","author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"date":"2014-09-19 03:20:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"967ae770c8fe47daf6b5984ed8b79e1b0479e6e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-19 04:05:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-zaqarclient-python33 http://logs.openstack.org/91/122591/2/check/gate-python-zaqarclient-python33/b34c6d8 : SUCCESS in 1m 59s\n- gate-python-zaqarclient-pep8 http://logs.openstack.org/91/122591/2/check/gate-python-zaqarclient-pep8/d7c8c94 : SUCCESS in 2m 13s\n- gate-python-zaqarclient-python26 http://logs.openstack.org/91/122591/2/check/gate-python-zaqarclient-python26/6b6e325 : SUCCESS in 1m 34s\n- gate-python-zaqarclient-python27 http://logs.openstack.org/91/122591/2/check/gate-python-zaqarclient-python27/4d568d6 : SUCCESS in 2m 20s\n- gate-python-zaqarclient-pypy http://logs.openstack.org/91/122591/2/check/gate-python-zaqarclient-pypy/fe32cab : SUCCESS in 2m 11s","accounts_in_message":[],"_revision_number":2},{"id":"6663db2f993a2461f903da8032db6d4fabfde017","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2014-10-28 19:30:25.000000000","message":"Patch Set 2: Code-Review-2\n\nCould you provide more insight on why this change is needed? This could cause an inconsistency with the API. In the API both TTL and grace can be updated through the same operation, so in the client it should be the same.","accounts_in_message":[],"_revision_number":2},{"id":"2b5cda29704547ceeb2af32fd62d54adb71a6fad","author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"date":"2014-10-29 03:10:54.000000000","message":"Patch Set 2:\n\npls check the zaqar specs in the wiki page[1][2]. There is no document to tell that the grace field is changeable.\n\nI had asked flaper87[3]. he is agree, too.\n\n\u003e2014-09-18T14:30:36  \u003cjeffrey4l\u003e The grace field in claim is unchangeable, right?\n\u003e2014-09-18T14:50:14  \u003cflaper87\u003e jeffrey4l: right\n\n[1] https://wiki.openstack.org/wiki/Zaqar/specs/api/v1#Update_Claim \n\n[2] https://wiki.openstack.org/wiki/Zaqar/specs/api/v1.1#Renew_Claim\n\n[3] http://eavesdrop.openstack.org/irclogs/%23openstack-zaqar/%23openstack-zaqar.2014-09-18.log","accounts_in_message":[],"_revision_number":2},{"id":"6c62361522077e2272704219ceae6cfb79c00438","author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"date":"2014-11-05 09:10:11.000000000","message":"Patch Set 2:\n\n@vkmc could this PS move on now?","accounts_in_message":[],"_revision_number":2},{"id":"d19e3a756a8f818cbd09509fd0d97fe458f557e9","author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"date":"2015-06-17 14:49:21.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8e018db247d2218a6270c53d05c4966db5e0387a","revisions":{"a28d041e8be7d10616b1787706926d46b99b48c9":{"kind":"REWORK","_number":1,"created":"2014-09-19 02:09:07.000000000","uploader":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"ref":"refs/changes/91/122591/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zaqarclient","ref":"refs/changes/91/122591/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/1"}}},"commit":{"parents":[{"commit":"f96846d3237625c4903dd5ee3aaf36d1339d082a","subject":"Cleanup technical debt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zaqarclient/commit/f96846d3237625c4903dd5ee3aaf36d1339d082a"}]}],"author":{"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","date":"2014-09-19 02:07:45.000000000","tz":480},"committer":{"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","date":"2014-09-19 02:08:16.000000000","tz":480},"subject":"Remove the grace in claim update method","message":"Remove the grace in claim update method\n\nThe grace field can not be update in claim\n\nChange-Id: I694aa70b56cade9e0e79020059e7b716601868df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zaqarclient/commit/a28d041e8be7d10616b1787706926d46b99b48c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zaqarclient/commit/a28d041e8be7d10616b1787706926d46b99b48c9"}]},"branch":"refs/heads/master"},"8e018db247d2218a6270c53d05c4966db5e0387a":{"kind":"REWORK","_number":2,"created":"2014-09-19 03:20:30.000000000","uploader":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"ref":"refs/changes/91/122591/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zaqarclient","ref":"refs/changes/91/122591/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zaqarclient refs/changes/91/122591/2"}}},"commit":{"parents":[{"commit":"f96846d3237625c4903dd5ee3aaf36d1339d082a","subject":"Cleanup technical debt","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zaqarclient/commit/f96846d3237625c4903dd5ee3aaf36d1339d082a"}]}],"author":{"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","date":"2014-09-19 02:07:45.000000000","tz":480},"committer":{"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","date":"2014-09-19 03:20:03.000000000","tz":480},"subject":"Remove the grace in claim update method","message":"Remove the grace in claim update method\n\nThe grace field can not be update in claim\n\nChange-Id: I694aa70b56cade9e0e79020059e7b716601868df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zaqarclient/commit/8e018db247d2218a6270c53d05c4966db5e0387a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zaqarclient/commit/8e018db247d2218a6270c53d05c4966db5e0387a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
