)]}'
{"zaqarclient/queues/v1/queues.py":[{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"8340f4be86100b06e751344ef5787c49682b6595","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        :rtype: `dict`"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        # if not \u0027messages\u0027 then we assume its v1"},{"line_number":109,"context_line":"        if not (\u0027messages\u0027 in messages or isinstance(messages, list)):"},{"line_number":110,"context_line":"            messages \u003d [messages]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        req, trans \u003d self.client._request_and_transport()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_8ea3619d","line":109,"updated":"2014-10-22 03:31:28.000000000","message":"Q: our v1 spec said that the messages should be an array, but with your changes, the user can post just messages(not array) with zaqarclient which will fail with api call directly, such as curl, seems to be inconsistent.","commit_id":"39a084ed8ead3a192421b7a1bc2395a92ea03eb1"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"44ad159f360953133e4279a007bad5a37de568cb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        :rtype: `dict`"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        # if not \u0027messages\u0027 then we assume its v1"},{"line_number":109,"context_line":"        if not (\u0027messages\u0027 in messages or isinstance(messages, list)):"},{"line_number":110,"context_line":"            messages \u003d [messages]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        req, trans \u003d self.client._request_and_transport()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_61dc6f13","line":109,"in_reply_to":"9aa7fdbe_327e4a6c","updated":"2014-10-23 01:39:50.000000000","message":"yes, understand it ,  you are just making sure that the messages for \u0027core.message_post\u0027 below  is [dict] \n\nwith your changes, it\u0027s more robust for the customer that they can either post a single messages(dict) for an array [dict] for the v1.  but the API user, then can only post [dict] for v1. so that\u0027s inconsistent what I said above.","commit_id":"39a084ed8ead3a192421b7a1bc2395a92ea03eb1"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e2fe731a3f865582beb749c1538497615c9fa53a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        :rtype: `dict`"},{"line_number":107,"context_line":"        \"\"\""},{"line_number":108,"context_line":"        # if not \u0027messages\u0027 then we assume its v1"},{"line_number":109,"context_line":"        if not (\u0027messages\u0027 in messages or isinstance(messages, list)):"},{"line_number":110,"context_line":"            messages \u003d [messages]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        req, trans \u003d self.client._request_and_transport()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_327e4a6c","line":109,"in_reply_to":"9aa7fdbe_8ea3619d","updated":"2014-10-22 12:56:00.000000000","message":"A: If a list is received, then it is a set of messages for v1 and the if clause won\u0027t be executed. If a dictionary is received, then its a set of messages for v1.1, a single message for v1.1 or its a single message for v1. In the latter case, the \u0027messages\u0027 key won\u0027t be there and the message will be encapsulated in a list. In the former ones we don\u0027t need to encapsulate the dicts in lists, so they are simply posted.\n\nTo sum up, the only case in which the if clause is executed is when a single message for v1 is posted.\n\nDoes  that make sense? Let me know if I missed something.\n\nMaybe is misleading the fact that I used not (A or B) instead of not A and not B.","commit_id":"39a084ed8ead3a192421b7a1bc2395a92ea03eb1"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2174460d085b7e7fd53d2131f915b35eb4ffd0fe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # if not \u0027messages\u0027 then we assume its v1"},{"line_number":109,"context_line":"        if not (\u0027messages\u0027 in messages or isinstance(messages, list)):"},{"line_number":110,"context_line":"            messages \u003d [messages]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        req, trans \u003d self.client._request_and_transport()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # TODO(flaper87): Return a list of messages"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_425f7b41","line":111,"updated":"2014-10-22 15:17:35.000000000","message":"I think this is missing the step where for v1.1 we wrap the messages in a dict - dict(messages\u003dmessages). The client instance has the version: `self.client.api_version` IIRC","commit_id":"39a084ed8ead3a192421b7a1bc2395a92ea03eb1"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dabc6e400bb49c3669916f42474ac88516ff1dc4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        # if not \u0027messages\u0027 then we assume its v1"},{"line_number":109,"context_line":"        if not (\u0027messages\u0027 in messages or isinstance(messages, list)):"},{"line_number":110,"context_line":"            messages \u003d [messages]"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        req, trans \u003d self.client._request_and_transport()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # TODO(flaper87): Return a list of messages"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_9e5d1c18","line":111,"in_reply_to":"9aa7fdbe_425f7b41","updated":"2014-10-23 14:40:03.000000000","message":"not sure if I understood...\n\nfor v1.1 we expect to get a dict as follows:\n\n1 message -\u003e {\u0027messages\u0027 : [{message1}]}\n1++ messages -\u003e {\u0027messages\u0027 : [{message1}, {message2}, {message3}, ...]}\n\nin either case, we post it as is, we don\u0027t need to wrap anything.\n\nfor v1 we expect a dict or a list as follows:\n\n1 message -\u003e {message1}\n1++ messages -\u003e [{message1}, {message2}, ...]\n\nIn the case of a single message for v1, yes we require to wrap it in a list, and it\u0027s done by the if clause.\n\nI could do it checking the client version, maybe it would make it more readable.","commit_id":"39a084ed8ead3a192421b7a1bc2395a92ea03eb1"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"12182815adc441d40b9b5c4d2271eab9d4268a66","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if self.client.api_version \u003d\u003d 1:"},{"line_number":110,"context_line":"            if not isinstance(messages, list):"},{"line_number":111,"context_line":"                messages \u003d [messages]"},{"line_number":112,"context_line":"        elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":113,"context_line":"            if not isinstance(messages, list):"},{"line_number":114,"context_line":"                messages \u003d {\u0027messages\u0027: [messages]}"},{"line_number":115,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_2a54aafd","line":112,"updated":"2014-10-27 14:05:53.000000000","message":"should this be \u003e\u003d ? or just else ?","commit_id":"a57421eefdf3a722ba802c1fbe85c2de3aaf53ef"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"899cc800e9a561d6383f5bd1ba76c2afb7294d15","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if self.client.api_version \u003d\u003d 1:"},{"line_number":110,"context_line":"            if not isinstance(messages, list):"},{"line_number":111,"context_line":"                messages \u003d [messages]"},{"line_number":112,"context_line":"        elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":113,"context_line":"            if not isinstance(messages, list):"},{"line_number":114,"context_line":"                messages \u003d {\u0027messages\u0027: [messages]}"},{"line_number":115,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_cac79e62","line":112,"in_reply_to":"9aa7fdbe_2a54aafd","updated":"2014-10-27 14:25:35.000000000","message":"Since we are not adding v1.1++ I think the else would work fine... and we avoid an extra comparation. I\u0027ll fix that.","commit_id":"a57421eefdf3a722ba802c1fbe85c2de3aaf53ef"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"12182815adc441d40b9b5c4d2271eab9d4268a66","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            if not isinstance(messages, list):"},{"line_number":114,"context_line":"                messages \u003d {\u0027messages\u0027: [messages]}"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                messages \u003d {\u0027messages\u0027: messages}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        req, trans \u003d self.client._request_and_transport()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_6a7f9266","line":116,"updated":"2014-10-27 14:05:53.000000000","message":"NIT: this could be written like:\n\n  if not isinstance(messages, list):\n      messages \u003d [messages]\n\n  # NOTE(vkmc): blah blah\n  if self.client.api_version \u003e\u003d 1.1:\n      messages \u003d {\u0027messages\u0027: messages}\n\n\nthoughts?","commit_id":"a57421eefdf3a722ba802c1fbe85c2de3aaf53ef"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"899cc800e9a561d6383f5bd1ba76c2afb7294d15","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            if not isinstance(messages, list):"},{"line_number":114,"context_line":"                messages \u003d {\u0027messages\u0027: [messages]}"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                messages \u003d {\u0027messages\u0027: messages}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        req, trans \u003d self.client._request_and_transport()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_2a8f4a2b","line":116,"in_reply_to":"9aa7fdbe_6a7f9266","updated":"2014-10-27 14:25:35.000000000","message":"You are right! Neat!","commit_id":"a57421eefdf3a722ba802c1fbe85c2de3aaf53ef"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"fb2b6b0ecc450a152296f1d031047b7598e6640f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if not isinstance(messages, list):"},{"line_number":109,"context_line":"            messages \u003d [messages]"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if self.client.api_version \u003d\u003d 1.1:"},{"line_number":112,"context_line":"            messages \u003d {\u0027messages\u0027: messages}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        req, trans \u003d self.client._request_and_transport()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_7780498b","line":111,"updated":"2014-10-28 01:11:36.000000000","message":"which one we decide to use ?  \u003d\u003d or \u003e\u003d ?","commit_id":"aac69e5826dda17973e88969cb5161e5098fe3be"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"10de2cc93f02ce4cf1b4b4668ee313d9bb99dae9","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if not isinstance(messages, list):"},{"line_number":109,"context_line":"            messages \u003d [messages]"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if self.client.api_version \u003d\u003d 1.1:"},{"line_number":112,"context_line":"            messages \u003d {\u0027messages\u0027: messages}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        req, trans \u003d self.client._request_and_transport()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_c69bfb63","line":111,"in_reply_to":"9aa7fdbe_7780498b","updated":"2014-10-28 13:37:03.000000000","message":"Changed to \u003e\u003d, lets avoid more changes in the future","commit_id":"aac69e5826dda17973e88969cb5161e5098fe3be"}]}