)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dynarro \u003cdoralynavarro@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-14 16:10:34 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added support to notifications"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Zaqarclient v2 currently has missing features that involve the"},{"line_number":10,"context_line":"management of subscriptions, but in order to these to work it is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa1b9901_2561003a","line":7,"updated":"2015-08-18 14:09:37.000000000","message":"erm, I guess you meant v2 since this patch adds way more than just notifications","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"tests/functional/queues/v2/test_queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from zaqarclient.transport import http"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class QueuesV2QueueHttpFunctionalTest(queues.QueuesV1QueueFunctionalTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    is_functional \u003d True"},{"line_number":24,"context_line":"    transport_cls \u003d http.HttpTransport"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_05a39c50","line":21,"updated":"2015-08-18 14:09:37.000000000","message":"Should there be `QueuesV2QueueFunctionalTests` ?","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"tests/unit/queues/v2/test_core.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_85548c21","line":1,"updated":"2015-08-18 14:09:37.000000000","message":"2015 OpenStack Foundation (you can get it from other files)","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tests.unit.queues.v1 import test_core"},{"line_number":20,"context_line":"from zaqarclient.queues.v1 import core"},{"line_number":21,"context_line":"from zaqarclient.transport import request"},{"line_number":22,"context_line":"from zaqarclient.transport import response"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_454e7497","line":20,"updated":"2015-08-18 14:09:37.000000000","message":"I believe these 2 should import from v2","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"tests/unit/queues/v2/test_message.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from tests.unit.queues.v1 import test_message as msg"},{"line_number":20,"context_line":"from zaqarclient.queues.v1 import iterator as iterate"},{"line_number":21,"context_line":"from zaqarclient.queues.v1 import message"},{"line_number":22,"context_line":"from zaqarclient.transport import http"},{"line_number":23,"context_line":"from zaqarclient.transport import response"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_e53b08ea","line":21,"updated":"2015-08-18 14:09:37.000000000","message":"ditto","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"tests/unit/queues/v2/test_queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_c8361be7","line":1,"updated":"2015-08-18 14:09:37.000000000","message":"copyright line needs to be fixed (please, check all your files) :)","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tests.unit.queues.v1 import test_queues"},{"line_number":17,"context_line":"from zaqarclient.transport import http"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_8819037c","line":16,"updated":"2015-08-18 14:09:37.000000000","message":"v2*","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class QueuesV2QueueHttpUnitTest(test_queues.QueuesV1QueueHttpUnitTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    transport_cls \u003d http.HttpTransport"},{"line_number":23,"context_line":"    url \u003d \u0027http://127.0.0.1:8888/v1\u0027"},{"line_number":24,"context_line":"    version \u003d 2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_queue_exists(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_a8140744","line":23,"updated":"2015-08-18 14:09:37.000000000","message":"v2*","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0171b33284a914e261054e1c2a0b133d2b492fee","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class QueuesV2QueueHttpUnitTest(test_queues.QueuesV1QueueHttpUnitTest):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    transport_cls \u003d http.HttpTransport"},{"line_number":23,"context_line":"    url \u003d \u0027http://127.0.0.1:8888/v1\u0027"},{"line_number":24,"context_line":"    version \u003d 2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_queue_exists(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"da85f559_c2731e14","line":23,"updated":"2015-11-10 15:13:51.000000000","message":"url should be /v2","commit_id":"d9818f4eb03d9c9e8b2b556620c544de6f7c1f8d"}],"zaqarclient/queues/v2/api.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class V2(api.V1_1):"},{"line_number":5,"context_line":"    label \u003d \u0027v2\u0027"},{"line_number":6,"context_line":"    schema \u003d api.V1_1.schema.copy()"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_e80f5fdf","line":6,"updated":"2015-08-18 14:09:37.000000000","message":"I believe there are some v2 specific things missing in the schema. For example, getting messages by id is not allowed anymore.","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"zaqarclient/queues/v2/client.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, url\u003dNone, version\u003d2, conf\u003dNone):"},{"line_number":38,"context_line":"        self.conf \u003d conf or {}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.api_url \u003d url"},{"line_number":41,"context_line":"        self.api_version \u003d version"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_a896474a","line":38,"updated":"2015-08-18 14:09:37.000000000","message":"I guess this method should just call `super` and set the api_version after the parent `__init__` completes.","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"zaqarclient/queues/v2/core.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":40,"context_line":"message_list \u003d core.message_list"},{"line_number":41,"context_line":"message_post \u003d core.message_post"},{"line_number":42,"context_line":"message_delete \u003d core.message_delete"},{"line_number":43,"context_line":"message_delete_many \u003d core.message_delete_many"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_88c0232c","line":43,"updated":"2015-08-18 14:09:37.000000000","message":"message_pop is missing","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}],"zaqarclient/queues/v2/queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c93e52daf6990df444913e23fb7c4fcd37d320","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        req, trans \u003d self.client._request_and_transport()"},{"line_number":34,"context_line":"        if self.client.api_version \u003e\u003d 2:"},{"line_number":35,"context_line":"            raise errors.InvalidOperation(\"Unavailable on versions \u003e\u003d 2\")"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            msg \u003d core.message_get(trans, req, self._name,"},{"line_number":38,"context_line":"                                   message_id)"},{"line_number":39,"context_line":"            return message.Message(self, **msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_28bd5768","line":36,"updated":"2015-08-18 14:09:37.000000000","message":"this else clause shouldn\u0027t exist. We should always raise the error in L35 if someone calls this method. Actually, we could probably simply raise an `AttributeError`","commit_id":"e52b6f08a78e315d443da314342bac8a1de92d0b"}]}