)]}'
{"tests/functional/queues/v1/test_queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e70604159469cbf2010cf870f36a8a8d2e6fe7fd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    url \u003d \u0027http://127.0.0.1:8888\u0027"},{"line_number":35,"context_line":"    version \u003d 1.1"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_queue_metadata_functional(self):"},{"line_number":38,"context_line":"        # v1.1 doesn\u0027t support set queue\u0027s metadata"},{"line_number":39,"context_line":"        test_metadata \u003d {\u0027type\u0027: \u0027Bank Accounts\u0027}"},{"line_number":40,"context_line":"        queue \u003d self.client.queue(\"meta-test\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_1b5b1b56","line":37,"updated":"2016-03-15 11:33:29.000000000","message":"I think these tests should be moved into zaqarclient.tests.queues","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"fd5f3b0a47b3363857fb228423f5de3adfb28a44","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    url \u003d \u0027http://127.0.0.1:8888\u0027"},{"line_number":35,"context_line":"    version \u003d 1.1"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_queue_metadata_functional(self):"},{"line_number":38,"context_line":"        # v1.1 doesn\u0027t support set queue\u0027s metadata"},{"line_number":39,"context_line":"        test_metadata \u003d {\u0027type\u0027: \u0027Bank Accounts\u0027}"},{"line_number":40,"context_line":"        queue \u003d self.client.queue(\"meta-test\")"},{"line_number":41,"context_line":"        self.assertRaises(errors.InvalidOperation,"},{"line_number":42,"context_line":"                          queue.metadata, test_metadata)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_queue_metadata_reload_functional(self):"},{"line_number":45,"context_line":"        # v1.1 doesn\u0027t support set queue\u0027s metadata"},{"line_number":46,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_eb1d98be","line":46,"range":{"start_line":37,"start_character":0,"end_line":46,"end_character":12},"updated":"2016-03-16 00:00:08.000000000","message":"All test cases should be located inside \"python-zaqarclient/zaqarclient/tests directory\".\n\nIn \"python-zaqarclient/tests\" directory we inherit from classes in \"python-zaqarclient/zaqarclient/tests directory\" and just specify class variables.\n\nPlease see how other tests are made. I know the current structure of tests in python-zaqarclient is not very rational. Perhaps, we can refactor them, like we did in Zaqar server. But now we should follow current convention in python-zaqarclient.\n\nSo you should probably move test cases.","commit_id":"2a870ab6ff71b46c64f40813a2c9ecd32ce24ac6"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c3b2403cddbc30e78d15fc0bb9b4124af165fb47","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    url \u003d \u0027http://127.0.0.1:8888\u0027"},{"line_number":35,"context_line":"    version \u003d 1.1"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_queue_metadata_functional(self):"},{"line_number":38,"context_line":"        # v1.1 doesn\u0027t support set queue\u0027s metadata"},{"line_number":39,"context_line":"        test_metadata \u003d {\u0027type\u0027: \u0027Bank Accounts\u0027}"},{"line_number":40,"context_line":"        queue \u003d self.client.queue(\"meta-test\")"},{"line_number":41,"context_line":"        self.assertRaises(errors.InvalidOperation,"},{"line_number":42,"context_line":"                          queue.metadata, test_metadata)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_queue_metadata_reload_functional(self):"},{"line_number":45,"context_line":"        # v1.1 doesn\u0027t support set queue\u0027s metadata"},{"line_number":46,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_2117a1a4","line":46,"range":{"start_line":37,"start_character":0,"end_line":46,"end_character":12},"in_reply_to":"1af94dfe_eb1d98be","updated":"2016-03-16 01:01:55.000000000","message":"We can move them to /zaqarclient/tests/queues, then write new tests for v2.","commit_id":"2a870ab6ff71b46c64f40813a2c9ecd32ce24ac6"}],"tests/unit/queues/v1/test_queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"55dc3480a7f58ab0cc7b5b5a507ff05b92505221","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            self.assertRaises(errors.InvalidOperation,"},{"line_number":50,"context_line":"                              self.queue.metadata, test_metadata)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_queue_metadata_update(self):"},{"line_number":53,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_27be43d4","line":52,"updated":"2016-03-15 00:16:42.000000000","message":"Any reason why we need to add the empty function? Is it part of the base class?","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"03fec8fbbb6c389bcdc0deca76e57fc3d53a5f92","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            self.assertRaises(errors.InvalidOperation,"},{"line_number":50,"context_line":"                              self.queue.metadata, test_metadata)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_queue_metadata_update(self):"},{"line_number":53,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_6aebf2b0","line":52,"in_reply_to":"3afc51ec_27be43d4","updated":"2016-03-15 01:05:47.000000000","message":"Here are some reasons:\n1. v1.1 doesn\u0027t support update metadata. So we should modify this test.\n2. v2 support update metadata and the v2 clsss base on the v1.1 class. So we can\u0027t modify the test in the base class.\n\nThe test at L41 has already tested the \"queue.metadata\" in v1.1. So I skip here to avoid a duplicated check.","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e70604159469cbf2010cf870f36a8a8d2e6fe7fd","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            self.assertRaises(errors.InvalidOperation,"},{"line_number":50,"context_line":"                              self.queue.metadata, test_metadata)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_queue_metadata_update(self):"},{"line_number":53,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_9bd44b48","line":52,"in_reply_to":"3afc51ec_6aebf2b0","updated":"2016-03-15 11:33:29.000000000","message":"Yeah, I know the API. I was asking why we needed to have an empty overloaded method here. I just checked the base classes and it does exist there.\n\nNow, since there\u0027s a base class with these tests. Could you please move them into: zaqarclient/tests/queues/queues.py","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"}],"zaqarclient/queues/v1/cli.py":[{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"11dccf31dacdbf1b0893c7fddb39339d465200a9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        queue_metadata \u003d parsed_args.queue_metadata"},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            client.queue(queue_name, auto_create\u003dFalse).stats"},{"line_number":149,"context_line":"        except errors.ResourceNotFound:"},{"line_number":150,"context_line":"            raise RuntimeError(\"Queue(%s) does not exist.\" % queue_name)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_0bae0485","line":149,"range":{"start_line":149,"start_character":8,"end_line":149,"end_character":38},"updated":"2016-03-15 23:45:18.000000000","message":"I recently made Zaqar to show descriptions inside it\u0027s 404 and 409 error responses.\nAnd python-zaqarclient is made to read these descriptions from server and use them inside errors.\n\nSo there\u0027s no need now in handling unexisting queue situation.\nLet\u0027s do nothing in case of errors.ResourceNotFound or queue_exists\u003d\u003dNone. Let the CLI show server\u0027s description. ;)","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"}],"zaqarclient/queues/v1/queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"55dc3480a7f58ab0cc7b5b5a507ff05b92505221","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if new_meta is not None:"},{"line_number":98,"context_line":"            if self.client.api_version \u003c 1.1:"},{"line_number":99,"context_line":"                core.queue_set_metadata(trans, req, self._name, new_meta)"},{"line_number":100,"context_line":"            elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":101,"context_line":"                raise errors.InvalidOperation(\"Unavailable on versions 1.1\")"},{"line_number":102,"context_line":"            elif not len(new_meta):"},{"line_number":103,"context_line":"                # if metadata is empty dict, clear existing metadata"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_07f347d7","line":100,"updated":"2016-03-15 00:16:42.000000000","message":"This will break the current behavior. If version is 1.1 then the else clause will never be executed.","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"13f04b806f9bef4f36cfdbd4f7a02c01843d2e3c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if new_meta is not None:"},{"line_number":98,"context_line":"            if self.client.api_version \u003c 1.1:"},{"line_number":99,"context_line":"                core.queue_set_metadata(trans, req, self._name, new_meta)"},{"line_number":100,"context_line":"            elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":101,"context_line":"                raise errors.InvalidOperation(\"Unavailable on versions 1.1\")"},{"line_number":102,"context_line":"            elif not len(new_meta):"},{"line_number":103,"context_line":"                # if metadata is empty dict, clear existing metadata"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_3e540553","line":100,"in_reply_to":"1af94dfe_7b817f8f","updated":"2016-03-15 12:10:49.000000000","message":"It makes sense. I agree.","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"11dccf31dacdbf1b0893c7fddb39339d465200a9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if new_meta is not None:"},{"line_number":98,"context_line":"            if self.client.api_version \u003c 1.1:"},{"line_number":99,"context_line":"                core.queue_set_metadata(trans, req, self._name, new_meta)"},{"line_number":100,"context_line":"            elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":101,"context_line":"                raise errors.InvalidOperation(\"Unavailable on versions 1.1\")"},{"line_number":102,"context_line":"            elif not len(new_meta):"},{"line_number":103,"context_line":"                # if metadata is empty dict, clear existing metadata"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_08e60ab4","line":100,"in_reply_to":"1af94dfe_7b817f8f","updated":"2016-03-15 23:45:18.000000000","message":"Yes, Flavio, it\u0027s a breaking change.\nMaybe inside this condition we should write \"pass\" statement? So the behavior will not change for API v1.1.\n\nAlso I don\u0027t agree that we should catch exceptions in CLI level just to show nicer messages.\nFor example, when errors.InvalidOperation is raised here, CLI just shows the exception\u0027s message: \"Unavailable on versions 1.1\".\nSo no need to handle this exception in CLI.\nIf we want to make this message more nice in CLI, why not to make it nice also in library by changing the exception\u0027s text here?\nThat\u0027s my point.\n\nWe have to decide to show this exception or not for API v1.1.","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"03fec8fbbb6c389bcdc0deca76e57fc3d53a5f92","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if new_meta is not None:"},{"line_number":98,"context_line":"            if self.client.api_version \u003c 1.1:"},{"line_number":99,"context_line":"                core.queue_set_metadata(trans, req, self._name, new_meta)"},{"line_number":100,"context_line":"            elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":101,"context_line":"                raise errors.InvalidOperation(\"Unavailable on versions 1.1\")"},{"line_number":102,"context_line":"            elif not len(new_meta):"},{"line_number":103,"context_line":"                # if metadata is empty dict, clear existing metadata"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_eac42260","line":100,"in_reply_to":"3afc51ec_07f347d7","updated":"2016-03-15 01:05:47.000000000","message":"Because the we don\u0027t support update metadata with v1.1 in the server side and it\u0027will do nothing if we use \"queue set metadata\" at client side. So I think we should not allow to set metadata in v1.1.","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e70604159469cbf2010cf870f36a8a8d2e6fe7fd","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if new_meta is not None:"},{"line_number":98,"context_line":"            if self.client.api_version \u003c 1.1:"},{"line_number":99,"context_line":"                core.queue_set_metadata(trans, req, self._name, new_meta)"},{"line_number":100,"context_line":"            elif self.client.api_version \u003d\u003d 1.1:"},{"line_number":101,"context_line":"                raise errors.InvalidOperation(\"Unavailable on versions 1.1\")"},{"line_number":102,"context_line":"            elif not len(new_meta):"},{"line_number":103,"context_line":"                # if metadata is empty dict, clear existing metadata"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_7b817f8f","line":100,"in_reply_to":"3afc51ec_eac42260","updated":"2016-03-15 11:33:29.000000000","message":"The problem with this is that it\u0027s breaking the client.\n\nIf I have a script calling this function for v1.1, it\u0027ll now throw an error instead of doing nothing. That\u0027s what I\u0027m worried about.\n\nI think I\u0027m fine with this throwing an exception at a library level but it shouldn\u0027t fail on the CLI. Instead, I think in the CLI this should be translated into a nice message.","commit_id":"eda911c82f1a3f7652e1defd59b68be15d5c6b6b"}]}
