)]}'
{"zaqarclient/queues/cli.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"d4735065cd536ed35ce20957e567249be33c8c05","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"2\": \"zaqarclient.queues.v2.client.Client\","},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"_MESSAGE_ENDPOINT \u003d None"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def make_client(instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8ad2675a","line":31,"updated":"2016-07-27 04:42:59.000000000","message":"(nit): Can you pls rename it with \u0027_MESSAGING_ENDPOINT\u0027 or just \u0027_ZAQAR_ENDPOINT\u0027","commit_id":"5b14a3fe668529decec9e4d82c51225da4b4cd3a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ca1a4ce6b295cb3976bed2709185475e930fdbd4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        version,"},{"line_number":46,"context_line":"        API_VERSIONS)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # TODO(wangxiyuan): Use public attributes instead of private attributes."},{"line_number":49,"context_line":"    if not _MESSAGING_ENDPOINT:"},{"line_number":50,"context_line":"        _MESSAGING_ENDPOINT \u003d instance.get_endpoint_for_service_type("},{"line_number":51,"context_line":"            API_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_af6c4b9d","line":48,"updated":"2016-07-27 21:27:50.000000000","message":"I don\u0027t really understand this TODO. What do you mean use public attributes?","commit_id":"7d90ea22b481e06f985c7d3f2844e2462715271c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"563e726e5deccd92391fc3dfb35bea601bf52a23","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        version,"},{"line_number":46,"context_line":"        API_VERSIONS)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # TODO(wangxiyuan): Use public attributes instead of private attributes."},{"line_number":49,"context_line":"    if not _MESSAGING_ENDPOINT:"},{"line_number":50,"context_line":"        _MESSAGING_ENDPOINT \u003d instance.get_endpoint_for_service_type("},{"line_number":51,"context_line":"            API_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_07c5743b","line":48,"in_reply_to":"bacf61ea_a6d8ed1e","updated":"2016-07-28 03:11:57.000000000","message":"Ok, got it. Thanks.","commit_id":"7d90ea22b481e06f985c7d3f2844e2462715271c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3e98282f2e7f55efdc8abb75d8f20cd835546455","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        version,"},{"line_number":46,"context_line":"        API_VERSIONS)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # TODO(wangxiyuan): Use public attributes instead of private attributes."},{"line_number":49,"context_line":"    if not _MESSAGING_ENDPOINT:"},{"line_number":50,"context_line":"        _MESSAGING_ENDPOINT \u003d instance.get_endpoint_for_service_type("},{"line_number":51,"context_line":"            API_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a6d8ed1e","line":48,"in_reply_to":"bacf61ea_af6c4b9d","updated":"2016-07-28 01:52:34.000000000","message":"L52 53 59 60 61. They used the private attributes which is bad code style. OpenStack Client has rewrote the base class and provided public attributes now. We should move to use it after openstack client release.","commit_id":"7d90ea22b481e06f985c7d3f2844e2462715271c"}]}