)]}'
{"marconiclient/queues/v1/queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"682d69d185adccbdf0ba215581c59c8882fe5373","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from marconiclient.queues.v1 import message"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class _QueueIterator(object):"},{"line_number":21,"context_line":"    \"\"\"Queue iterator"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This iterator is not meant to be used outside"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BV3g%3D","line":20,"updated":"2014-02-21 18:49:36.000000000","message":"I think these iterators could be made more generic since they all iterate over \u0027links\u0027. \n\nThe base iterator could be an abstract class that requires subclasses to implement a `create_object` method that will be called by `__next__`.\n\nThoughts?","commit_id":"6f03d1cbc1adad520d28aa0ca79dc43cf2fc6d2a"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"49138ee01381755d199409938460817ea8b48b5d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from marconiclient.queues.v1 import message"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class _QueueIterator(object):"},{"line_number":21,"context_line":"    \"\"\"Queue iterator"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    This iterator is not meant to be used outside"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2BVuE%3D","line":20,"in_reply_to":"AAAAUX%2F%2BV3g%3D","updated":"2014-02-21 19:13:34.000000000","message":"They can be definitely be unified. I\u0027m okay with this refactoring happening in another patch.\n\nIt might even be enough (to keep things simple) to just pass in a function that will be used to \u0027create_object\u0027.\n\nFewer classes \u003d\u003d less maintenance, imho. :)","commit_id":"6f03d1cbc1adad520d28aa0ca79dc43cf2fc6d2a"}]}