)]}'
{"marconiclient/queues/v1/iterator.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cd36a0ab2ebe627f54201d4322ace1bea5da2b1a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F5cc%3D","line":1,"updated":"2014-03-03 15:21:28.000000000","message":"2014 and Rackspace :)","commit_id":"4358b0ea2842f7f7354eaebade63ea9409d389b1"},{"author":{"_account_id":7113,"name":"John Heatherington","email":"jheatherington@gmail.com","username":"HorkyPorky"},"change_message_id":"1bccbeda807c782627c626124b63c45d04ea6499","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F1z4%3D","line":1,"in_reply_to":"AAAAVn%2F%2F5cc%3D","updated":"2014-03-03 21:50:02.000000000","message":"Done","commit_id":"4358b0ea2842f7f7354eaebade63ea9409d389b1"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cd36a0ab2ebe627f54201d4322ace1bea5da2b1a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    :param listing_response: Response returned by the listing call"},{"line_number":38,"context_line":"    :type listing_response: Dict"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    def __init__(self, client, listing_response, iter_key, create_function):"},{"line_number":41,"context_line":"        self._client \u003d client"},{"line_number":42,"context_line":"        self._iter_key \u003d iter_key"},{"line_number":43,"context_line":"        self._create_function \u003d create_function"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F5Z8%3D","line":40,"updated":"2014-03-03 15:21:28.000000000","message":"What about passing the class itself and create a new instance instead of passing a function that does that?\n\nI think it is safe to assume that:\n\n  1. Resources will always have a parent\n  2. Resources\u0027 constructors can handle kwargs","commit_id":"4358b0ea2842f7f7354eaebade63ea9409d389b1"},{"author":{"_account_id":7113,"name":"John Heatherington","email":"jheatherington@gmail.com","username":"HorkyPorky"},"change_message_id":"1bccbeda807c782627c626124b63c45d04ea6499","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    :param listing_response: Response returned by the listing call"},{"line_number":38,"context_line":"    :type listing_response: Dict"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":"    def __init__(self, client, listing_response, iter_key, create_function):"},{"line_number":41,"context_line":"        self._client \u003d client"},{"line_number":42,"context_line":"        self._iter_key \u003d iter_key"},{"line_number":43,"context_line":"        self._create_function \u003d create_function"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F10A%3D","line":40,"in_reply_to":"AAAAVn%2F%2F5Z8%3D","updated":"2014-03-03 21:50:02.000000000","message":"The issue with passing in the class itself at the moment lies mainly with #1.\n\nThe parent for a queue is a client, and the parent for a message is a queue.  Client must be retrieved regardless, but the means of doing so depends on whether the iterator is being used to enumerate Queues or Messages.  To account for this, we would have to send in an additional \u0027parent\u0027 argument or include logic that detects which class you\u0027re passing in.\n\nAlso, the default for queue creation is auto_create\u003dtrue, which we should disable when performing a listing.  This means object creation would also necessitate a type check.","commit_id":"4358b0ea2842f7f7354eaebade63ea9409d389b1"}],"marconiclient/queues/v1/message.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cd36a0ab2ebe627f54201d4322ace1bea5da2b1a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        core.message_delete(trans, req, self.queue._name, self._id)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def create_object(parent):"},{"line_number":46,"context_line":"    return lambda args: Message(parent, **args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2F5Zg%3D","line":45,"updated":"2014-03-03 15:21:28.000000000","message":"If we use the class constructor, we won\u0027t need these methods","commit_id":"4358b0ea2842f7f7354eaebade63ea9409d389b1"}]}
