)]}'
{"id":"openstack%2Fpython-zunclient~418175","triplet_id":"openstack%2Fpython-zunclient~master~I3b5eb5ed1f07cd7fb008033c998fb8cfcfb5f463","project":"openstack/python-zunclient","branch":"master","topic":"bug/1654951","hashtags":[],"change_id":"I3b5eb5ed1f07cd7fb008033c998fb8cfcfb5f463","subject":"Modify the description of the parameter cpu","status":"ABANDONED","created":"2017-01-10 02:07:40.000000000","updated":"2017-05-11 03:03:20.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f61024cf6b8226da71533a16cbd3bc60fe6c840e","_number":418175,"virtual_id_number":418175,"owner":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},{"value":-1,"date":"2017-04-27 23:49:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":-1,"date":"2017-03-09 16:03:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-10 11:35:46.000000000","updated_by":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"reviewer":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"state":"REVIEWER"},{"updated":"2017-01-11 07:47:13.000000000","updated_by":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"reviewer":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"state":"REVIEWER"},{"updated":"2017-01-11 08:03:10.000000000","updated_by":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"reviewer":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"state":"REVIEWER"},{"updated":"2017-01-11 08:03:17.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2017-01-11 08:03:23.000000000","updated_by":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"reviewer":{"_account_id":13248,"name":"Wenzhi Yu","email":"wenzhi_yu@163.com","username":"yuywz"},"state":"REVIEWER"},{"updated":"2017-03-09 16:03:36.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2017-04-27 23:49:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bc7e25334b8824d4a82964842759583fb3ecbd02","author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"date":"2017-01-10 02:07:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3068bec6451aec6768539e2b034142d4be96ecd4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-10 02:11:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-zunclient-docs-ubuntu-xenial http://docs-draft.openstack.org/75/418175/1/check/gate-python-zunclient-docs-ubuntu-xenial/93f5229//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-zunclient-pep8-ubuntu-xenial http://logs.openstack.org/75/418175/1/check/gate-python-zunclient-pep8-ubuntu-xenial/829131b/ : SUCCESS in 1m 58s\n- gate-python-zunclient-python27-ubuntu-xenial http://logs.openstack.org/75/418175/1/check/gate-python-zunclient-python27-ubuntu-xenial/b30483c/ : SUCCESS in 3m 06s\n- gate-python-zunclient-python35 http://logs.openstack.org/75/418175/1/check/gate-python-zunclient-python35/19f0ab6/ : SUCCESS in 3m 20s","accounts_in_message":[],"_revision_number":1},{"id":"1404a96e18981b566772c68b57f242bcdcf4cd23","author":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"date":"2017-01-10 11:35:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ea6e8340c499241bf3eb6ae4f7a3e8d92ad94a3e","author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"date":"2017-01-11 07:47:13.000000000","message":"Patch Set 1:\n\nIn our case cpu parameter is matched to --cpu-quota parameter in docker run\n(https://github.com/openstack/zun/blob/master/zun/container/docker/driver.py#L87)\nAfter seeing --cpu-quota definition at (https://docs.docker.com/engine/reference/run/#/cpu-quota-constraint), i dont think its CPU number, i think its percentage of total cpu which one container can use. What do you think?","accounts_in_message":[],"_revision_number":1},{"id":"f2ab5dba0e8bd83ca5727458231d555464d687aa","author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"date":"2017-01-11 08:01:02.000000000","message":"Patch Set 1:\n\n\u003e In our case cpu parameter is matched to --cpu-quota parameter in\n \u003e docker run\n \u003e (https://github.com/openstack/zun/blob/master/zun/container/docker/driver.py#L87)\n \u003e After seeing --cpu-quota definition at (https://docs.docker.com/engine/reference/run/#/cpu-quota-constraint),\n \u003e i dont think its CPU number, i think its percentage of total cpu\n \u003e which one container can use. What do you think?\n\nYes,you are right. How about \"The percentage of cpu resources allocation (relative weight)\" ?","accounts_in_message":[],"_revision_number":1},{"id":"1dcb5f45b4f865655366e3ead3e7c41f05c57f1e","author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"date":"2017-01-11 08:02:43.000000000","message":"Patch Set 1:\n\n\u003e Yes,you are right. How about \"The percentage of cpu resources\n \u003e allocation (relative weight)\" ?\nLets wait for other\u0027s opinion.","accounts_in_message":[],"_revision_number":1},{"id":"c8162e207d4e52827f7ffcdb82bf2d749f89d506","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-01-11 18:41:22.000000000","message":"Patch Set 1:\n\nAdded this to the agenda of next team meeting: https://wiki.openstack.org/wiki/Zun#Agenda_for_2017-01-17_0300_UTC","accounts_in_message":[],"_revision_number":1},{"id":"e6d6046a59878005db729a25a8fa94a98398c9eb","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-01-11 18:41:51.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"7e949a8f243a0ba43382338093b6a0d521eb3612","author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"date":"2017-03-09 08:42:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"021a28a1530499f8b6789a67f4521014a36c0d8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-09 09:18:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-zunclient-docs-ubuntu-xenial http://docs-draft.openstack.org/75/418175/2/check/gate-python-zunclient-docs-ubuntu-xenial/53921cb//doc/build/html/ : SUCCESS in 3m 31s\n- gate-python-zunclient-pep8-ubuntu-xenial http://logs.openstack.org/75/418175/2/check/gate-python-zunclient-pep8-ubuntu-xenial/bde4d99/ : SUCCESS in 3m 55s\n- gate-python-zunclient-python27-ubuntu-xenial http://logs.openstack.org/75/418175/2/check/gate-python-zunclient-python27-ubuntu-xenial/ac832f2/ : SUCCESS in 2m 03s\n- gate-python-zunclient-python35 http://logs.openstack.org/75/418175/2/check/gate-python-zunclient-python35/e6e3261/ : SUCCESS in 2m 37s\n- gate-zunclient-devstack-dsvm-docker-sql-nv http://logs.openstack.org/75/418175/2/check/gate-zunclient-devstack-dsvm-docker-sql-nv/0ec7b9d/ : SUCCESS in 33m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d4c07b368b4ba0c174315fbdc5178631197c5a0d","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-03-09 16:03:36.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"772f613b3e03b089d47b43e011a55c076b6f8da8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-27 23:49:38.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"4f7f9dbcdf77c68782f15d4aee1188ebd76e6803","author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"date":"2017-05-11 03:03:20.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0f3d4515cae345a4c18000ea8f6b89e52da773d3","revisions":{"087b78d2d1a2a954b715194a1a8fb4a13c885d73":{"kind":"REWORK","_number":1,"created":"2017-01-10 02:07:40.000000000","uploader":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"ref":"refs/changes/75/418175/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/75/418175/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/1"}}},"commit":{"parents":[{"commit":"ddb16af7393297de2c5f04314bcd9a120c9083e9","subject":"Add OSC Plugin for openstack appcontainer unpause","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/ddb16af7393297de2c5f04314bcd9a120c9083e9"}]}],"author":{"name":"Feng Shengqin","email":"feng.shengqin@zte.com.cn","date":"2017-01-10 10:03:28.000000000","tz":480},"committer":{"name":"Feng Shengqin","email":"feng.shengqin@zte.com.cn","date":"2017-01-10 10:04:28.000000000","tz":480},"subject":"Modify the description of the parameter cpu","message":"Modify the description of the parameter cpu\n\nChange-Id: I3b5eb5ed1f07cd7fb008033c998fb8cfcfb5f463\nCloses-Bug: #1654951\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/087b78d2d1a2a954b715194a1a8fb4a13c885d73"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/087b78d2d1a2a954b715194a1a8fb4a13c885d73"}]},"branch":"refs/heads/master"},"0f3d4515cae345a4c18000ea8f6b89e52da773d3":{"kind":"REWORK","_number":2,"created":"2017-03-09 08:42:56.000000000","uploader":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"ref":"refs/changes/75/418175/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/75/418175/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/75/418175/2"}}},"commit":{"parents":[{"commit":"c71c6ed785607f413509dd4caf4ffc5fc9e5bcd3","subject":"Fixed an incorrect name of method call","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/c71c6ed785607f413509dd4caf4ffc5fc9e5bcd3"}]}],"author":{"name":"Feng Shengqin","email":"feng.shengqin@zte.com.cn","date":"2017-01-10 10:03:28.000000000","tz":480},"committer":{"name":"Feng Shengqin","email":"feng.shengqin@zte.com.cn","date":"2017-03-09 08:33:18.000000000","tz":480},"subject":"Modify the description of the parameter cpu","message":"Modify the description of the parameter cpu\n\nChange-Id: I3b5eb5ed1f07cd7fb008033c998fb8cfcfb5f463\nCloses-Bug: #1654951\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/0f3d4515cae345a4c18000ea8f6b89e52da773d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/0f3d4515cae345a4c18000ea8f6b89e52da773d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}