)]}'
{"zunclient/osc/v1/containers.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"a3a6d63b9ecc22648825c96eadbdeab0bc79c20d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                 \u0027already exist on the node. \u0027"},{"line_number":85,"context_line":"                 \u0027\"always\": Always pull the image from repositery.\u0027"},{"line_number":86,"context_line":"                 \u0027\"never\": never pull the image\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--restart\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003crestart\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_2cebefb1","line":87,"updated":"2017-01-14 08:58:05.000000000","message":"delete L87","commit_id":"cf529d8b739732a199d5dc863610c5fadf504582"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"dbfad3ce94954476854d8f36e93c4b77673aef85","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                 \u0027already exist on the node. \u0027"},{"line_number":85,"context_line":"                 \u0027\"always\": Always pull the image from repositery.\u0027"},{"line_number":86,"context_line":"                 \u0027\"never\": never pull the image\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--restart\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003crestart\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_96657b1f","line":87,"in_reply_to":"7a3c09a3_2cebefb1","updated":"2017-01-17 09:06:22.000000000","message":"Done","commit_id":"cf529d8b739732a199d5dc863610c5fadf504582"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"a3a6d63b9ecc22648825c96eadbdeab0bc79c20d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        opts[\u0027workdir\u0027] \u003d parsed_args.workdir"},{"line_number":105,"context_line":"        opts[\u0027labels\u0027] \u003d zun_utils.format_args(parsed_args.label)"},{"line_number":106,"context_line":"        opts[\u0027image_pull_policy\u0027] \u003d parsed_args.image_pull_policy"},{"line_number":107,"context_line":"        if parsed_args.restart:"},{"line_number":108,"context_line":"            if \":\" in parsed_args.restart:"},{"line_number":109,"context_line":"                name, count \u003d parsed_args.restart.split(\":\")"},{"line_number":110,"context_line":"                restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_2c020f70","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":31},"updated":"2017-01-14 08:58:05.000000000","message":"L107-114 is the same as L105-111 in container_shell.py.\nI think it\u0027s better to write a paser function in common file.","commit_id":"cf529d8b739732a199d5dc863610c5fadf504582"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"dbfad3ce94954476854d8f36e93c4b77673aef85","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        opts[\u0027workdir\u0027] \u003d parsed_args.workdir"},{"line_number":105,"context_line":"        opts[\u0027labels\u0027] \u003d zun_utils.format_args(parsed_args.label)"},{"line_number":106,"context_line":"        opts[\u0027image_pull_policy\u0027] \u003d parsed_args.image_pull_policy"},{"line_number":107,"context_line":"        if parsed_args.restart:"},{"line_number":108,"context_line":"            if \":\" in parsed_args.restart:"},{"line_number":109,"context_line":"                name, count \u003d parsed_args.restart.split(\":\")"},{"line_number":110,"context_line":"                restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_d66b83ef","line":107,"range":{"start_line":107,"start_character":8,"end_line":107,"end_character":31},"in_reply_to":"7a3c09a3_2c020f70","updated":"2017-01-17 09:06:22.000000000","message":"Thanks shengqin\nDone","commit_id":"cf529d8b739732a199d5dc863610c5fadf504582"}],"zunclient/v1/containers_shell.py":[{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"d462f7de90c9c4e1538c8f30a0a6a3063872cb46","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _check_restart_policy(policy):"},{"line_number":51,"context_line":"    if \":\" in policy:"},{"line_number":52,"context_line":"        name, count \u003d policy.split(\":\")"},{"line_number":53,"context_line":"        restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        restart_policy \u003d {\"Name\": policy,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_9e61d707","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":19},"updated":"2017-01-18 07:10:25.000000000","message":"type(count) is str, I think it should be int.","commit_id":"78999d9da6699c420f8a86674898075e3a018491"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"e0cefaadfb1f863eaea821003c5c38d739180766","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _check_restart_policy(policy):"},{"line_number":51,"context_line":"    if \":\" in policy:"},{"line_number":52,"context_line":"        name, count \u003d policy.split(\":\")"},{"line_number":53,"context_line":"        restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        restart_policy \u003d {\"Name\": policy,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_b9aead2b","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":19},"in_reply_to":"7a3c09a3_9e61d707","updated":"2017-01-18 07:43:45.000000000","message":"@feng, I think its OK, as API is internally converting it to int before passing to docker driver. What do you think?","commit_id":"78999d9da6699c420f8a86674898075e3a018491"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"86e9339a9c297dba3791a9089839c117a20481e1","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _check_restart_policy(policy):"},{"line_number":51,"context_line":"    if \":\" in policy:"},{"line_number":52,"context_line":"        name, count \u003d policy.split(\":\")"},{"line_number":53,"context_line":"        restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        restart_policy \u003d {\"Name\": policy,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_d92e19a4","line":52,"range":{"start_line":52,"start_character":14,"end_line":52,"end_character":19},"in_reply_to":"7a3c09a3_9e61d707","updated":"2017-01-18 07:43:50.000000000","message":"Hi Feng，\n   Thanks for your comment.\n   In the Server side, it will be modified from str to int. So we don\u0027t need to change it here I think.","commit_id":"78999d9da6699c420f8a86674898075e3a018491"},{"author":{"_account_id":16277,"name":"Pradeep Kumar Singh","email":"ps4openstack@gmail.com","username":"pradeep_singh"},"change_message_id":"e0cefaadfb1f863eaea821003c5c38d739180766","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        restart_policy \u003d {\"Name\": policy,"},{"line_number":56,"context_line":"                          \"MaximumRetryCount\": 0}"},{"line_number":57,"context_line":"    return restart_policy"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_793d25dc","line":56,"updated":"2017-01-18 07:43:45.000000000","message":"Here you should use string( as you used in https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/containers.py#L171), but i don\u0027t care much about it.","commit_id":"78999d9da6699c420f8a86674898075e3a018491"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"223ff04a594bcaae8aa1016c991aa2dbbf950b68","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        restart_policy \u003d {\"Name\": name, \"MaximumRetryCount\": count}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        restart_policy \u003d {\"Name\": policy,"},{"line_number":56,"context_line":"                          \"MaximumRetryCount\": 0}"},{"line_number":57,"context_line":"    return restart_policy"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_0b6204d8","line":56,"in_reply_to":"7a3c09a3_793d25dc","updated":"2017-01-18 08:33:10.000000000","message":"Haha, Thanks Pradeep, I find that I forget to add code to Class RunContainer in osc, so I have uploaded new patch and tweak the code here also.","commit_id":"78999d9da6699c420f8a86674898075e3a018491"}]}