)]}'
{"test-requirements.txt":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ad8ad177140e2ce265ac0926ec4fc301df63fc38","unresolved":false,"context_lines":[{"line_number":12,"context_line":"os-testr\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":13,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":14,"context_line":"sphinx!\u003d1.3b1,\u003c1.4,\u003e\u003d1.2.1 # BSD"},{"line_number":15,"context_line":"tempest\u003e\u003d12.1.0 # Apache-2.0"},{"line_number":16,"context_line":"testresources\u003e\u003d0.2.4 # Apache-2.0/BSD"},{"line_number":17,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":18,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":15,"id":"fa31d9ce_7928ac9a","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":16},"updated":"2017-02-15 20:39:08.000000000","message":"It seems you need to update this to 14.0.0. See: https://github.com/openstack/requirements/blob/master/global-requirements.txt","commit_id":"9c056cb84987f611e4c8c581bbc629023d5cd9c7"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"806e6d837857c1b6c6b1b25a36dd7bd599d47094","unresolved":false,"context_lines":[{"line_number":12,"context_line":"os-testr\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":13,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":14,"context_line":"sphinx!\u003d1.3b1,\u003c1.4,\u003e\u003d1.2.1 # BSD"},{"line_number":15,"context_line":"tempest\u003e\u003d12.1.0 # Apache-2.0"},{"line_number":16,"context_line":"testresources\u003e\u003d0.2.4 # Apache-2.0/BSD"},{"line_number":17,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":18,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":15,"id":"fa31d9ce_9e352daa","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":16},"in_reply_to":"fa31d9ce_7928ac9a","updated":"2017-02-16 09:55:00.000000000","message":"Done","commit_id":"9c056cb84987f611e4c8c581bbc629023d5cd9c7"}],"zunclient/tests/functional/base.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dcefd28016661c384308bb78b211a83bfbf5347f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            client \u003d base.CLIClient(cli_dir\u003dcli_dir,"},{"line_number":39,"context_line":"                                    username\u003dconfig[\u0027os_username\u0027],"},{"line_number":40,"context_line":"                                    password\u003dconfig[\u0027os_password\u0027],"},{"line_number":41,"context_line":"                                    tenant_name\u003dconfig[\u0027os_project_name\u0027],"},{"line_number":42,"context_line":"                                    uri\u003dconfig[\u0027os_auth_url\u0027])"},{"line_number":43,"context_line":"            for keystone_object in \u0027user\u0027, \u0027project\u0027:"},{"line_number":44,"context_line":"                domain_attr \u003d \u0027os_%s_domain_id\u0027 % keystone_object"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a430d35_b3bab76c","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":47},"updated":"2017-02-06 19:54:42.000000000","message":"I think it is better to use project_name. OpenStack is moving from \"tenant_*\" to \"project_*\". Possibly, this option will deprecate soon.","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"1e1cb140f951c5b61309a4e597410eeee2776e00","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            client \u003d base.CLIClient(cli_dir\u003dcli_dir,"},{"line_number":39,"context_line":"                                    username\u003dconfig[\u0027os_username\u0027],"},{"line_number":40,"context_line":"                                    password\u003dconfig[\u0027os_password\u0027],"},{"line_number":41,"context_line":"                                    tenant_name\u003dconfig[\u0027os_project_name\u0027],"},{"line_number":42,"context_line":"                                    uri\u003dconfig[\u0027os_auth_url\u0027])"},{"line_number":43,"context_line":"            for keystone_object in \u0027user\u0027, \u0027project\u0027:"},{"line_number":44,"context_line":"                domain_attr \u003d \u0027os_%s_domain_id\u0027 % keystone_object"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_d2b46383","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":47},"in_reply_to":"1a430d35_b3bab76c","updated":"2017-02-14 10:17:27.000000000","message":"tests are failing on changing it to project_name","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"84d970e6534267f616b48546b8b393978d6ad8b6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            client \u003d base.CLIClient(cli_dir\u003dcli_dir,"},{"line_number":39,"context_line":"                                    username\u003dconfig[\u0027os_username\u0027],"},{"line_number":40,"context_line":"                                    password\u003dconfig[\u0027os_password\u0027],"},{"line_number":41,"context_line":"                                    tenant_name\u003dconfig[\u0027os_project_name\u0027],"},{"line_number":42,"context_line":"                                    uri\u003dconfig[\u0027os_auth_url\u0027])"},{"line_number":43,"context_line":"            for keystone_object in \u0027user\u0027, \u0027project\u0027:"},{"line_number":44,"context_line":"                domain_attr \u003d \u0027os_%s_domain_id\u0027 % keystone_object"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_191ed06f","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":47},"in_reply_to":"fa31d9ce_d2b46383","updated":"2017-02-15 20:39:13.000000000","message":"I see.","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dcefd28016661c384308bb78b211a83bfbf5347f","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _zun_osc(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027):"},{"line_number":148,"context_line":"        \"\"\"Execute container commands via OpenStack Client.\"\"\""},{"line_number":149,"context_line":"        config \u003d self._get_config()"},{"line_number":150,"context_line":"        id_api_version \u003d config.get(\u0027functional\u0027, \u0027os_identity_api_version\u0027)"},{"line_number":151,"context_line":"        flags +\u003d \u0027 --os-identity-api-version {0}\u0027.format(id_api_version)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        for keystone_object in \u0027user\u0027, \u0027project\u0027:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a430d35_7c6f37c5","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":22},"updated":"2017-02-06 19:54:42.000000000","message":"nit: i think spelling out the \u0027id\u0027 will look better.","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"1e1cb140f951c5b61309a4e597410eeee2776e00","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _zun_osc(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027):"},{"line_number":148,"context_line":"        \"\"\"Execute container commands via OpenStack Client.\"\"\""},{"line_number":149,"context_line":"        config \u003d self._get_config()"},{"line_number":150,"context_line":"        id_api_version \u003d config.get(\u0027functional\u0027, \u0027os_identity_api_version\u0027)"},{"line_number":151,"context_line":"        flags +\u003d \u0027 --os-identity-api-version {0}\u0027.format(id_api_version)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        for keystone_object in \u0027user\u0027, \u0027project\u0027:"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_3225bfc0","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":22},"in_reply_to":"1a430d35_7c6f37c5","updated":"2017-02-14 10:17:27.000000000","message":"Done","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dcefd28016661c384308bb78b211a83bfbf5347f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        self.assertEqual(sorted(field_names), sorted(table_headers))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def list_containers(self, params\u003d\u0027\u0027):"},{"line_number":192,"context_line":"        return self.zun(\u0027container-list\u0027, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a430d35_9cb4e3d1","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":23},"updated":"2017-02-06 19:54:42.000000000","message":"It seems the following methods are defined but unused? Do you have plan to use them in follow-up patches?\n* def list_containers(self, params\u003d\u0027\u0027):\n* def zun(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027, parse\u003dTrue):\n* def _zun(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027):\n* def get_table_headers(self, action, flags\u003d\u0027\u0027, params\u003d\u0027\u0027):\n* def assertTableHeaders(self, field_names, table_headers):","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"1e1cb140f951c5b61309a4e597410eeee2776e00","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        self.assertEqual(sorted(field_names), sorted(table_headers))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def list_containers(self, params\u003d\u0027\u0027):"},{"line_number":192,"context_line":"        return self.zun(\u0027container-list\u0027, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_b1180986","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":23},"in_reply_to":"1a430d35_9cb4e3d1","updated":"2017-02-14 10:17:27.000000000","message":"these methods will be used in other test","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"84d970e6534267f616b48546b8b393978d6ad8b6","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        \"\"\""},{"line_number":189,"context_line":"        self.assertEqual(sorted(field_names), sorted(table_headers))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def list_containers(self, params\u003d\u0027\u0027):"},{"line_number":192,"context_line":"        return self.zun(\u0027container-list\u0027, params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa31d9ce_5914c84b","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":23},"in_reply_to":"fa31d9ce_b1180986","updated":"2017-02-15 20:39:13.000000000","message":"I see.","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"}],"zunclient/tests/functional/hooks/post_test_hook.sh":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9a94b4c67987b7ababa609282285f88ed6e62404","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# show tempest config"},{"line_number":58,"context_line":"cat etc/tempest.conf"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"sudo -E tox -eall-plugin -- zun.tests.tempest.api --concurrency\u003d1"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"echo \"Running OSC commands test for Zun\""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a430d35_2f8f8524","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":65},"updated":"2017-02-03 17:00:56.000000000","message":"It seems this is not needed.","commit_id":"80111fe33e4cac621fa2002abd577dd113be6c8e"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"3174430526623c593f4d57a14626690d7c3a2544","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# show tempest config"},{"line_number":58,"context_line":"cat etc/tempest.conf"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"sudo -E tox -eall-plugin -- zun.tests.tempest.api --concurrency\u003d1"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"echo \"Running OSC commands test for Zun\""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a430d35_a058cdfb","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":65},"in_reply_to":"1a430d35_2f8f8524","updated":"2017-02-04 17:28:12.000000000","message":"This test the zunclient commands so I think this is needed.","commit_id":"80111fe33e4cac621fa2002abd577dd113be6c8e"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9a94b4c67987b7ababa609282285f88ed6e62404","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"echo \"Running OSC commands test for Zun\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"sudo -E tox -eall-plugin -- zunclient.tests.functional.osc.v1 --concurrency\u003d1"},{"line_number":65,"context_line":"#export ZUNCLIENT_DIR\u003d\"$BASE/new/python-zunclient\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"#sudo chown -R jenkins:stack $ZUNCLIENT_DIR"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a430d35_0fd9e921","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":24},"updated":"2017-02-03 17:00:56.000000000","message":"It seems you are not using tempest plugin, so this command won\u0027t be able to find any tests. You have several options to solve it:\n* Revise your test cases as Tempest plugin (like this one: https://github.com/openstack/zun/blob/master/zun/tests/tempest/plugin.py#L22).\n* Don\u0027t use this command, use the command at line #81","commit_id":"80111fe33e4cac621fa2002abd577dd113be6c8e"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c3c4cc3d01f3b74431e7e50935e4360988f94857","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"echo \"Running OSC commands test for Zun\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"sudo -E tox -eall-plugin -- zunclient.tests.functional.osc.v1 --concurrency\u003d1"},{"line_number":65,"context_line":"#export ZUNCLIENT_DIR\u003d\"$BASE/new/python-zunclient\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"#sudo chown -R jenkins:stack $ZUNCLIENT_DIR"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a430d35_63798ffc","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":24},"in_reply_to":"1a430d35_0070c171","updated":"2017-02-04 21:46:09.000000000","message":"I see.\n\nIf you want to use the tempest plugin command (line #64), you might need something like: https://review.openstack.org/#/c/330946/ . In particular:\n* Add an entry point at setup.cfg (https://review.openstack.org/#/c/330946/2/setup.cfg).\n* Add a class that inherits from TempestPlugin (https://review.openstack.org/#/c/330946/2/zun/tests/tempest/plugin.py).\n\nAfter that, this command should be able to find the tests.\n\nAlternatively, you can try to resolve the \"test.conf\" not found error by doing something like: https://review.openstack.org/#/c/183983/ . Basically, you can write down a sample config file, and copy it to the right location.","commit_id":"80111fe33e4cac621fa2002abd577dd113be6c8e"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"3174430526623c593f4d57a14626690d7c3a2544","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"echo \"Running OSC commands test for Zun\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"sudo -E tox -eall-plugin -- zunclient.tests.functional.osc.v1 --concurrency\u003d1"},{"line_number":65,"context_line":"#export ZUNCLIENT_DIR\u003d\"$BASE/new/python-zunclient\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"#sudo chown -R jenkins:stack $ZUNCLIENT_DIR"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a430d35_0070c171","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":24},"in_reply_to":"1a430d35_0fd9e921","updated":"2017-02-04 17:28:12.000000000","message":"Hongbin I have tried using the command at line #81 but it failed with error saying \"test.conf\" not found.\nYou can see patchset #5","commit_id":"80111fe33e4cac621fa2002abd577dd113be6c8e"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dcefd28016661c384308bb78b211a83bfbf5347f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"cd $ZUNCLIENT_DIR"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Run tests"},{"line_number":72,"context_line":"set +"},{"line_number":73,"context_line":"source $BASE/new/devstack/openrc admin admin"},{"line_number":74,"context_line":"sudo -E -H -u jenkins ./tools/run_functional.sh"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a430d35_e63d5fbc","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":5},"updated":"2017-02-06 19:54:42.000000000","message":"You mean \"set +e\"? Are you sure you want this?","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"1e1cb140f951c5b61309a4e597410eeee2776e00","unresolved":false,"context_lines":[{"line_number":69,"context_line":"cd $ZUNCLIENT_DIR"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Run tests"},{"line_number":72,"context_line":"set +"},{"line_number":73,"context_line":"source $BASE/new/devstack/openrc admin admin"},{"line_number":74,"context_line":"sudo -E -H -u jenkins ./tools/run_functional.sh"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"fa31d9ce_6c6316dd","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":5},"in_reply_to":"1a430d35_e63d5fbc","updated":"2017-02-14 10:17:27.000000000","message":"yes set +e.Yes its needed","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"dcefd28016661c384308bb78b211a83bfbf5347f","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"EXIT_CODE\u003d$?"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"set -e"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"popd"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"1a430d35_66788f90","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":6},"updated":"2017-02-06 19:54:42.000000000","message":"ditto","commit_id":"e15b9b9d9486d19739d9edb73f19d8057ae31bc8"}]}