)]}'
{"zunclient/v1/containers.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"318bdca4f9587b3697b2197d80e9b66bc7e9cde7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def unpause(self, id):"},{"line_number":135,"context_line":"        return self._action(id, \u0027/unpause\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def logs(self, id, stdout, stderr):"},{"line_number":138,"context_line":"        return self._action(id, \u0027/logs\u0027, method\u003d\u0027GET\u0027,"},{"line_number":139,"context_line":"                            qparams\u003d{\u0027stdout\u0027: stdout,"},{"line_number":140,"context_line":"                                     \u0027stderr\u0027: stderr})[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_ed7c6a74","line":137,"updated":"2017-02-06 13:00:09.000000000","message":"stdout/stderr should probably be optional fields.","commit_id":"845db3c7daa868ca900c6dc2c1ca4eb4444ce6b1"},{"author":{"_account_id":20858,"name":"prameswar","email":"engg.pram1@gmail.com","username":"prameswar"},"change_message_id":"436c3422fff92bd72a848fd05d43b5b9f5157ead","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def unpause(self, id):"},{"line_number":135,"context_line":"        return self._action(id, \u0027/unpause\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def logs(self, id, stdout, stderr):"},{"line_number":138,"context_line":"        return self._action(id, \u0027/logs\u0027, method\u003d\u0027GET\u0027,"},{"line_number":139,"context_line":"                            qparams\u003d{\u0027stdout\u0027: stdout,"},{"line_number":140,"context_line":"                                     \u0027stderr\u0027: stderr})[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_ef5d027a","line":137,"in_reply_to":"1a430d35_ed7c6a74","updated":"2017-02-07 16:10:52.000000000","message":"Thanks @Sudipta for review.\n\n@utils.arg(\u0027--stdout\u0027,\n           action\u003d\u0027store_true\u0027,\nSo, if we don\u0027t pass --stdout then it will store stdout\u003dFalse  similarly stderr so, if we don\u0027t pass both --stdout and --stderr then client will send stdout\u003dFalse stderr\u003dFalse. So, it not optional field.","commit_id":"845db3c7daa868ca900c6dc2c1ca4eb4444ce6b1"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"dbc107b79a7744cc44fa77d0d0ac04106494174e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        return self._action(id, \u0027/unpause\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def logs(self, id, stdout, stderr):"},{"line_number":138,"context_line":"        if stdout is False and stderr is False:"},{"line_number":139,"context_line":"            stdout\u003dTrue"},{"line_number":140,"context_line":"            stderr\u003dTrue"},{"line_number":141,"context_line":"        return self._action(id, \u0027/logs\u0027, method\u003d\u0027GET\u0027,"},{"line_number":142,"context_line":"                            qparams\u003d{\u0027stdout\u0027: stdout,"},{"line_number":143,"context_line":"                                     \u0027stderr\u0027: stderr})[1]"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_5af6b6f9","line":141,"range":{"start_line":138,"start_character":0,"end_line":141,"end_character":54},"updated":"2017-02-08 08:42:35.000000000","message":"Hi @prameswar,\n   Thanks~\n   I\u0027d like to know that if a user really want stdout\u003dFalse and stderr\u003dFalse, \nin that case here will be set to  stdout\u003dTrue and stderr\u003dTrue. \n   Here maybe not correct I think in that case.","commit_id":"3e3ce9f28f656adf33441b1911f48cf5f2d428a1"}],"zunclient/v1/containers_shell.py":[{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"6dad139e0722510ab23cea67a584278c0d5b32b6","unresolved":false,"context_lines":[{"line_number":283,"context_line":"@utils.arg(\u0027container\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":285,"context_line":"           help\u003d\u0027ID or name of the container to get logs for.\u0027)"},{"line_number":286,"context_line":"@utils.arg(\u0027--stdout\u0027,"},{"line_number":287,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":288,"context_line":"           help\u003d\u0027Only stdout logs of container.\u0027)"},{"line_number":289,"context_line":"@utils.arg(\u0027--stderr\u0027,"},{"line_number":290,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":291,"context_line":"           help\u003d\u0027Only stderr logs of container.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_60ae6a99","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":49},"updated":"2017-02-08 07:38:36.000000000","message":"Hi prameswar,\n   Thanks for that patch. Here I find a small problem. If user just don\u0027t want any logs, here will send:\nzun logs test\n\nGET /v1/containers/test/logs?stderr\u003dFalse\u0026stdout\u003dFalse to API, and API will do this:\nif (stdout is True and stderr is True) or \\\n               (stdout is False and stderr is False):\n    return self.driver.show_logs(container)\n \nThis may not be the real purpose for the user.\n\nSo I think set a default value maybe useful:\n@utils.arg(\u0027--stdout\u0027,\n           metavar\u003d\u0027\u003cstdout\u003e\u0027,\n           default\u003dTrue,\n           help\u003d\u0027Only stdout logs of container.\u0027)","commit_id":"de09922098be9dadf04712d6e105d063e030e7dd"},{"author":{"_account_id":20858,"name":"prameswar","email":"engg.pram1@gmail.com","username":"prameswar"},"change_message_id":"eae6ca8bbe617413bac7d4d6b82fcde5a5112d4c","unresolved":false,"context_lines":[{"line_number":283,"context_line":"@utils.arg(\u0027container\u0027,"},{"line_number":284,"context_line":"           metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":285,"context_line":"           help\u003d\u0027ID or name of the container to get logs for.\u0027)"},{"line_number":286,"context_line":"@utils.arg(\u0027--stdout\u0027,"},{"line_number":287,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":288,"context_line":"           help\u003d\u0027Only stdout logs of container.\u0027)"},{"line_number":289,"context_line":"@utils.arg(\u0027--stderr\u0027,"},{"line_number":290,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":291,"context_line":"           help\u003d\u0027Only stderr logs of container.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_c6c65667","line":288,"range":{"start_line":286,"start_character":0,"end_line":288,"end_character":49},"in_reply_to":"1a430d35_60ae6a99","updated":"2017-02-08 08:27:06.000000000","message":"Thanks @Kevin for valuable comments. \nthis will work but we have to run command like:\nzun logs test1 --stdout False\nzun logs test1 --stderr False\n\nit will be more good if it work like:\nzun logs test1 --stdout\nzun logs test1 --stderr\n\nSo, i modified zunclient/v1/containers.py for default True.\nin this case also, hongbin suggested condition will work","commit_id":"de09922098be9dadf04712d6e105d063e030e7dd"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"6dad139e0722510ab23cea67a584278c0d5b32b6","unresolved":false,"context_lines":[{"line_number":286,"context_line":"@utils.arg(\u0027--stdout\u0027,"},{"line_number":287,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":288,"context_line":"           help\u003d\u0027Only stdout logs of container.\u0027)"},{"line_number":289,"context_line":"@utils.arg(\u0027--stderr\u0027,"},{"line_number":290,"context_line":"           action\u003d\u0027store_true\u0027,"},{"line_number":291,"context_line":"           help\u003d\u0027Only stderr logs of container.\u0027)"},{"line_number":292,"context_line":"def do_logs(cs, args):"},{"line_number":293,"context_line":"    \"\"\"Get logs of a container.\"\"\""},{"line_number":294,"context_line":"    logs \u003d cs.containers.logs(args.container, args.stdout, args.stderr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_e09a5a6d","line":291,"range":{"start_line":289,"start_character":0,"end_line":291,"end_character":49},"updated":"2017-02-08 07:38:36.000000000","message":"ditto","commit_id":"de09922098be9dadf04712d6e105d063e030e7dd"}]}