)]}'
{"zunclient/osc/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2092121678f056fd6641613c893f0afc966af480","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return new"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def _websocket_attach(url, container, escape, close_wait):"},{"line_number":55,"context_line":"    if url.startswith(\"ws://\"):"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            wscls \u003d websocketclient.WebSocketClient(host_url\u003durl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_2c6fbb93","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":21},"updated":"2017-02-17 20:08:46.000000000","message":"@Kevin,\n\nIt looks this method is duplicated in osc and container_shell. I would suggest to move it to zun.common.utils so that the duplicate code can be consolidated.","commit_id":"686f6a0e42eebfbae088c273e3c1b8339b905940"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"47d316777e5ab6076ff800c51714fde27c39da71","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    return new"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def _websocket_attach(url, container, escape, close_wait):"},{"line_number":55,"context_line":"    if url.startswith(\"ws://\"):"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            wscls \u003d websocketclient.WebSocketClient(host_url\u003durl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_6311abac","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":21},"in_reply_to":"da36d5c6_2c6fbb93","updated":"2017-02-20 06:25:24.000000000","message":"Hi Hongbin,  \n   Thanks~\n   I\u0027ve addressed your comments to move the functions to zun.common.utils, but it resulted in another circulate import issue. Because that:\n   zun.common.utils will import websocketclient--\u003eimport zunclient.v1.client--\u003e import zunclient.v1.containers--\u003eimport zun.common.utils\n    Then will get import error.","commit_id":"686f6a0e42eebfbae088c273e3c1b8339b905940"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2092121678f056fd6641613c893f0afc966af480","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        raise exceptions.InvalidWebSocketLink(container)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _check_container_status(container, status):"},{"line_number":73,"context_line":"    if getattr(container, \u0027status\u0027, None) \u003d\u003d status:"},{"line_number":74,"context_line":"        return True"},{"line_number":75,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_8c0427c7","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":27},"updated":"2017-02-17 20:08:46.000000000","message":"Ditto, better to move it to common utils.","commit_id":"686f6a0e42eebfbae088c273e3c1b8339b905940"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2092121678f056fd6641613c893f0afc966af480","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            help\u003d\u0027Restart policy to apply when a container exits\u0027"},{"line_number":137,"context_line":"                 \u0027(no, on-failure[:max-retry], always, unless-stopped)\u0027)"},{"line_number":138,"context_line":"        parser.add_argument("},{"line_number":139,"context_line":"            \u0027-t\u0027, \u0027--tty\u0027,"},{"line_number":140,"context_line":"            dest\u003d\u0027tty\u0027,"},{"line_number":141,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":142,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_ec804349","line":139,"range":{"start_line":139,"start_character":12,"end_line":139,"end_character":17},"updated":"2017-02-17 20:08:46.000000000","message":"@Kevin, OSC doesn\u0027t seem to have convention of shorthand options like (\u0027-i\u0027 or \u0027-t\u0027). I would suggest simply remove it.","commit_id":"686f6a0e42eebfbae088c273e3c1b8339b905940"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"2092121678f056fd6641613c893f0afc966af480","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            default\u003dFalse,"},{"line_number":143,"context_line":"            help\u003d\u0027Allocate a pseudo-TTY\u0027)"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027-i\u0027, \u0027--interactive\u0027,"},{"line_number":146,"context_line":"            dest\u003d\u0027stdin_open\u0027,"},{"line_number":147,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":148,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_0c967794","line":145,"range":{"start_line":145,"start_character":13,"end_line":145,"end_character":15},"updated":"2017-02-17 20:08:46.000000000","message":"ditto","commit_id":"686f6a0e42eebfbae088c273e3c1b8339b905940"}]}