)]}'
{"zunclient/common/utils.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"bcbe9ddb43a605c198df936e0a382fe3998a728f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from zunclient.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def common_filters(all_tenants\u003dFalse, marker\u003dNone, limit\u003dNone, sort_key\u003dNone,"},{"line_number":25,"context_line":"                   sort_dir\u003dNone):"},{"line_number":26,"context_line":"    \"\"\"Generate common filters for any list request."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_27a462b8","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":30},"updated":"2017-03-04 18:03:35.000000000","message":"There are several problems of this approach. First, adding new parameter at the beginning will break the api (i.e. a call like common_filters(mark, limit, sort_key, sort_dir) will break). Second, it seems \"all_tenants\" is specific to \"container\" so it is a bit odd to put it here as common filters.","commit_id":"88fdb2a48aa7053c7a9263ef0221077011415383"},{"author":{"_account_id":12297,"name":"duhu","email":"xuxiaojun3@huawei.com","username":"xxj"},"change_message_id":"c73a26ee7682f99fd5b91b68309bf5e76f28c1d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from zunclient.i18n import _"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def common_filters(all_tenants\u003dFalse, marker\u003dNone, limit\u003dNone, sort_key\u003dNone,"},{"line_number":25,"context_line":"                   sort_dir\u003dNone):"},{"line_number":26,"context_line":"    \"\"\"Generate common filters for any list request."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_3c01d406","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":30},"in_reply_to":"ba2be162_27a462b8","updated":"2017-03-05 03:35:27.000000000","message":"Good catch. I will mv all_tenants to the end of parameter list.\n\nI\u0027m not sure zun image-list is also expected to support --all-tenants or not? If yes, it\u0027s better to add this parameter here. If not, I would liket to mv this logic to container.py.","commit_id":"88fdb2a48aa7053c7a9263ef0221077011415383"}],"zunclient/v1/containers_shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"bcbe9ddb43a605c198df936e0a382fe3998a728f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def do_list(cs, args):"},{"line_number":165,"context_line":"    \"\"\"Print a list of available containers.\"\"\""},{"line_number":166,"context_line":"    opts \u003d {}"},{"line_number":167,"context_line":"    opts[\u0027all_tenants\u0027] \u003d args.all_tenants"},{"line_number":168,"context_line":"    opts[\u0027marker\u0027] \u003d args.marker"},{"line_number":169,"context_line":"    opts[\u0027limit\u0027] \u003d args.limit"},{"line_number":170,"context_line":"    opts[\u0027sort_key\u0027] \u003d args.sort_key"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_e775ea31","line":167,"range":{"start_line":167,"start_character":10,"end_line":167,"end_character":21},"updated":"2017-03-04 18:03:35.000000000","message":"I think it is better to set this option only if args.all_tenants is True.","commit_id":"88fdb2a48aa7053c7a9263ef0221077011415383"},{"author":{"_account_id":12297,"name":"duhu","email":"xuxiaojun3@huawei.com","username":"xxj"},"change_message_id":"c73a26ee7682f99fd5b91b68309bf5e76f28c1d1","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def do_list(cs, args):"},{"line_number":165,"context_line":"    \"\"\"Print a list of available containers.\"\"\""},{"line_number":166,"context_line":"    opts \u003d {}"},{"line_number":167,"context_line":"    opts[\u0027all_tenants\u0027] \u003d args.all_tenants"},{"line_number":168,"context_line":"    opts[\u0027marker\u0027] \u003d args.marker"},{"line_number":169,"context_line":"    opts[\u0027limit\u0027] \u003d args.limit"},{"line_number":170,"context_line":"    opts[\u0027sort_key\u0027] \u003d args.sort_key"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_ef114053","line":167,"range":{"start_line":167,"start_character":10,"end_line":167,"end_character":21},"in_reply_to":"ba2be162_e775ea31","updated":"2017-03-05 03:35:27.000000000","message":"If all_tenants is decided to be added into common/utils.common_filters()，I think just passing the value of args.all_tenants will be OK because it will be handle in common/utils.common_filters().","commit_id":"88fdb2a48aa7053c7a9263ef0221077011415383"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a9063177147032a5f897a6c61b359614d3a5304b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def do_list(cs, args):"},{"line_number":165,"context_line":"    \"\"\"Print a list of available containers.\"\"\""},{"line_number":166,"context_line":"    opts \u003d {}"},{"line_number":167,"context_line":"    opts[\u0027all_tenants\u0027] \u003d args.all_tenants"},{"line_number":168,"context_line":"    opts[\u0027marker\u0027] \u003d args.marker"},{"line_number":169,"context_line":"    opts[\u0027limit\u0027] \u003d args.limit"},{"line_number":170,"context_line":"    opts[\u0027sort_key\u0027] \u003d args.sort_key"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_af22e8a0","line":167,"range":{"start_line":167,"start_character":10,"end_line":167,"end_character":21},"in_reply_to":"ba2be162_ef114053","updated":"2017-03-05 03:47:12.000000000","message":"I see","commit_id":"88fdb2a48aa7053c7a9263ef0221077011415383"}]}