)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ba33dae11b0845b2770528fff3d6877f4390b5eb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-04-23 14:03:26 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix confusing error message on interactive run"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I630de2414d5e36e86b246460a6d24992b06696e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_2f74ba67","line":8,"updated":"2017-04-25 22:14:31.000000000","message":"Hi Haobing,\n\nMinding linking this patch to the bug. Simply add the following in the commit message:\n\n  Closes-Bug: #1685521","commit_id":"cb45e5e8059658b932b136da2314a939338bc28f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a88cb4a0762b67d990ec288a3313306e8aaffab9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-04-26 12:59:17 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix confusing error message on interactive run"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I630de2414d5e36e86b246460a6d24992b06696e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_079d3abb","line":8,"updated":"2017-04-27 00:32:46.000000000","message":"Hi Haobing,\n\nAs I mentioned in previous review. Mind adding \"Closes-Bug: #1685521\" to here. This is the openstack commit message format for linking to a bug: https://docs.openstack.org/infra/manual/developers.html","commit_id":"26d5b6f20c0c5640b32407f15bd2e0b9b4534790"}],"zunclient/common/websocketclient/exceptions.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a88cb4a0762b67d990ec288a3313306e8aaffab9","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class ContainerStateError(ContainerWebSocketException):"},{"line_number":51,"context_line":"    message \u003d \"Container state is error,can not attach container\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_a77206ac","line":51,"range":{"start_line":51,"start_character":40,"end_line":51,"end_character":43},"updated":"2017-04-27 00:32:46.000000000","message":"nit: space between \u0027,\u0027 and \u0027can\u0027","commit_id":"26d5b6f20c0c5640b32407f15bd2e0b9b4534790"}],"zunclient/v1/containers_shell.py":[{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"933467b7f2058b1803a5d3fce6df7771d9a5d4b6","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                ready_for_attach \u003d True"},{"line_number":432,"context_line":"                break"},{"line_number":433,"context_line":"            if zun_utils.check_container_status(container, \u0027Error\u0027):"},{"line_number":434,"context_line":"                print(\"Container is Error\")"},{"line_number":435,"context_line":"                break"},{"line_number":436,"context_line":"            print(\"Waiting for container start\")"},{"line_number":437,"context_line":"            time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_cb4b5385","line":434,"updated":"2017-04-24 05:44:16.000000000","message":"I think we can improve the error message to explain more what the error is","commit_id":"cb45e5e8059658b932b136da2314a939338bc28f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ba33dae11b0845b2770528fff3d6877f4390b5eb","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                ready_for_attach \u003d True"},{"line_number":432,"context_line":"                break"},{"line_number":433,"context_line":"            if zun_utils.check_container_status(container, \u0027Error\u0027):"},{"line_number":434,"context_line":"                print(\"Container is Error\")"},{"line_number":435,"context_line":"                break"},{"line_number":436,"context_line":"            print(\"Waiting for container start\")"},{"line_number":437,"context_line":"            time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_2ff95ac7","line":434,"in_reply_to":"5ff73747_cb4b5385","updated":"2017-04-25 22:14:31.000000000","message":"+1","commit_id":"cb45e5e8059658b932b136da2314a939338bc28f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"ba33dae11b0845b2770528fff3d6877f4390b5eb","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                break"},{"line_number":433,"context_line":"            if zun_utils.check_container_status(container, \u0027Error\u0027):"},{"line_number":434,"context_line":"                print(\"Container is Error\")"},{"line_number":435,"context_line":"                break"},{"line_number":436,"context_line":"            print(\"Waiting for container start\")"},{"line_number":437,"context_line":"            time.sleep(1)"},{"line_number":438,"context_line":"        if ready_for_attach is True:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_0fe21e02","line":435,"range":{"start_line":435,"start_character":16,"end_line":435,"end_character":21},"updated":"2017-04-25 22:14:31.000000000","message":"I think it is better to raise an exception here.","commit_id":"cb45e5e8059658b932b136da2314a939338bc28f"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"a88cb4a0762b67d990ec288a3313306e8aaffab9","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                ready_for_attach \u003d True"},{"line_number":431,"context_line":"                break"},{"line_number":432,"context_line":"            if zun_utils.check_container_status(container, \u0027Error\u0027):"},{"line_number":433,"context_line":"                raise exceptions.ContainerStateError(container_uuid)"},{"line_number":434,"context_line":"            print(\"Waiting for container start\")"},{"line_number":435,"context_line":"            time.sleep(1)"},{"line_number":436,"context_line":"        if ready_for_attach is True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_876b8ab5","line":433,"range":{"start_line":433,"start_character":53,"end_line":433,"end_character":67},"updated":"2017-04-27 00:32:46.000000000","message":"nit: it looks this exception doesn\u0027t take this parameter.","commit_id":"26d5b6f20c0c5640b32407f15bd2e0b9b4534790"}]}
