)]}'
{"zunclient/v1/services.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6788ecf31c208c912db84887db780adb4cb9fa74","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        return resp, body"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _update_body(self, host, binary, disabled_reason\u003dNone,"},{"line_number":93,"context_line":"                     force_down\u003dNone):"},{"line_number":94,"context_line":"        body \u003d {\"host\": host,"},{"line_number":95,"context_line":"                \"binary\": binary}"},{"line_number":96,"context_line":"        if disabled_reason is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_b8223ca3","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":31},"updated":"2017-05-22 10:22:55.000000000","message":"This force_down param is not defined in disable method.","commit_id":"f42c5efc682af3f41e40a50ecf47af35925228b3"}],"zunclient/v1/services_shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e5bf4fa07c28dbeb38bfd4417541b40b2d35968","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \"\"\"Enable the service.\"\"\""},{"line_number":50,"context_line":"    try:"},{"line_number":51,"context_line":"        cs.services.enable(args.host, args.binary)"},{"line_number":52,"context_line":"        print(\"Request to enable binary %s on host %s has been accepted.\" %"},{"line_number":53,"context_line":"              (args.binary, args.host))"},{"line_number":54,"context_line":"    except Exception as e:"},{"line_number":55,"context_line":"        print(\"Enable for binary %(binary)s on host %(host)s failed: %(e)s\" %"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_1acf4c80","line":52,"range":{"start_line":52,"start_character":15,"end_line":52,"end_character":71},"updated":"2017-05-13 15:15:22.000000000","message":"We usually print this for a 202 response, but it seems this API returns 200. In this case, I think it is better to print the response from service instead. You could refer how we print container as an example: https://github.com/openstack/python-zunclient/blob/master/zunclient/v1/containers_shell.py#L31 .","commit_id":"8cea673a924a685638707f0067c473dd86f3d4fd"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"9e5bf4fa07c28dbeb38bfd4417541b40b2d35968","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"\"\"Disable the service.\"\"\""},{"line_number":67,"context_line":"    try:"},{"line_number":68,"context_line":"        cs.services.disable(args.host, args.binary, args.reason)"},{"line_number":69,"context_line":"        print(\"Request to disable binary %s on host %s has been accepted.\" %"},{"line_number":70,"context_line":"              (args.binary, args.host))"},{"line_number":71,"context_line":"    except Exception as e:"},{"line_number":72,"context_line":"        print(\"Disable for binary %(binary)s on host %(host)s failed: %(e)s\" %"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_fa902051","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":13},"updated":"2017-05-13 15:15:22.000000000","message":"Ditto.","commit_id":"8cea673a924a685638707f0067c473dd86f3d4fd"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6788ecf31c208c912db84887db780adb4cb9fa74","unresolved":false,"context_lines":[{"line_number":46,"context_line":"@utils.arg(\u0027host\u0027, metavar\u003d\u0027\u003chostname\u003e\u0027, help\u003d\u0027Name of host.\u0027)"},{"line_number":47,"context_line":"@utils.arg(\u0027binary\u0027, metavar\u003d\u0027\u003cbinary\u003e\u0027, help\u003d\u0027Service binary.\u0027)"},{"line_number":48,"context_line":"def do_service_enable(cs, args):"},{"line_number":49,"context_line":"    \"\"\"Enable the service.\"\"\""},{"line_number":50,"context_line":"    res \u003d cs.services.enable(args.host, args.binary)"},{"line_number":51,"context_line":"    utils.print_dict(res[1][\u0027service\u0027])"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_982538ae","line":49,"updated":"2017-05-22 10:22:55.000000000","message":"Can you replace service with \"Zun service\"?","commit_id":"f42c5efc682af3f41e40a50ecf47af35925228b3"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"6788ecf31c208c912db84887db780adb4cb9fa74","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    metavar\u003d\u0027\u003creason\u003e\u0027,"},{"line_number":59,"context_line":"    help\u003d\u0027Reason for disabling service.\u0027)"},{"line_number":60,"context_line":"def do_service_disable(cs, args):"},{"line_number":61,"context_line":"    \"\"\"Disable the service.\"\"\""},{"line_number":62,"context_line":"    res \u003d cs.services.disable(args.host, args.binary, args.reason)"},{"line_number":63,"context_line":"    utils.print_dict(res[1][\u0027service\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_783ca4c7","line":61,"updated":"2017-05-22 10:22:55.000000000","message":"ditto","commit_id":"f42c5efc682af3f41e40a50ecf47af35925228b3"}]}
