)]}'
{"zunclient/osc/v1/services.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8671d6735c3059cf423547b471aed77f03edde2d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        host \u003d parsed_args.host"},{"line_number":93,"context_line":"        binary \u003d parsed_args.binary"},{"line_number":94,"context_line":"        res \u003d client.services.enable(host, binary)"},{"line_number":95,"context_line":"        cliutils.print_dict(res[1][\u0027service\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class DisableService(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_358575ae","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":27},"updated":"2017-05-29 19:27:57.000000000","message":"nit: it is better to return a set of columns and let OSC to print it (e.g. https://github.com/openstack/python-zunclient/blob/master/zunclient/osc/v1/containers.py#L172).","commit_id":"0e7ef13c960a4f4d7080aa4a141d6bc95137c1a9"},{"author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"change_message_id":"32cf11c59c7360b3ff115a8c88e74063fef315af","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        host \u003d parsed_args.host"},{"line_number":93,"context_line":"        binary \u003d parsed_args.binary"},{"line_number":94,"context_line":"        res \u003d client.services.enable(host, binary)"},{"line_number":95,"context_line":"        cliutils.print_dict(res[1][\u0027service\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class DisableService(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_4d683420","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":27},"in_reply_to":"df140735_358575ae","updated":"2017-05-31 08:29:17.000000000","message":"Hi hongbin, Before this patch, I have tried the code below. It seems cannot print well.\n\n        columns \u003d (\u0027Host\u0027, \u0027Binary\u0027, \u0027Disabled\u0027, \u0027Disabled Reason\u0027)\n        return columns, (utils.get_dict_properties(res[1]                  [\u0027service\u0027], columns))\n\nThe output is:\nstack@tecs:/root$ openstack  appcontainer service enable tecs zun-compute\n((\u0027Host\u0027, \u0027Binary\u0027, \u0027Disabled\u0027, \u0027Disabled Reason\u0027), (u\u0027tecs\u0027, u\u0027zun-compute\u0027, False, None))","commit_id":"0e7ef13c960a4f4d7080aa4a141d6bc95137c1a9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"f7200723c4d7685b5cde5a6ffc43df56d8c66630","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        host \u003d parsed_args.host"},{"line_number":93,"context_line":"        binary \u003d parsed_args.binary"},{"line_number":94,"context_line":"        res \u003d client.services.enable(host, binary)"},{"line_number":95,"context_line":"        cliutils.print_dict(res[1][\u0027service\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class DisableService(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_37ca781a","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":27},"in_reply_to":"df140735_4d683420","updated":"2017-06-05 00:33:53.000000000","message":"I see. I guess changing line #74 to \"command.ShowOne\" might help. If not, let\u0027s merge this patch first and revisit it later.","commit_id":"0e7ef13c960a4f4d7080aa4a141d6bc95137c1a9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8671d6735c3059cf423547b471aed77f03edde2d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        binary \u003d parsed_args.binary"},{"line_number":122,"context_line":"        reason \u003d parsed_args.reason"},{"line_number":123,"context_line":"        res \u003d client.services.disable(host, binary, reason)"},{"line_number":124,"context_line":"        cliutils.print_dict(res[1][\u0027service\u0027])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class ForceDownService(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_55b1098f","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":27},"updated":"2017-05-29 19:27:57.000000000","message":"Ditto","commit_id":"0e7ef13c960a4f4d7080aa4a141d6bc95137c1a9"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8671d6735c3059cf423547b471aed77f03edde2d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        host \u003d parsed_args.host"},{"line_number":152,"context_line":"        binary \u003d parsed_args.binary"},{"line_number":153,"context_line":"        force_down \u003d parsed_args.force_down"},{"line_number":154,"context_line":"        res \u003d client.services.force_down(host, binary, force_down)"},{"line_number":155,"context_line":"        cliutils.print_dict(res[1][\u0027service\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_3524550d","line":154,"range":{"start_line":154,"start_character":30,"end_line":154,"end_character":40},"updated":"2017-05-29 19:27:57.000000000","message":"Note: this won\u0027t work until this patch is merged: https://review.openstack.org/#/c/463077/","commit_id":"0e7ef13c960a4f4d7080aa4a141d6bc95137c1a9"}]}