)]}'
{"zunclient/api_versions.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    LOG.addHandler(logging.StreamHandler())\r"},{"line_number":29,"context_line":"\r"},{"line_number":30,"context_line":"\r"},{"line_number":31,"context_line":"LEGACY_HEADER_NAME \u003d \"X-OpenStack-Container-API-Version\"\r"},{"line_number":32,"context_line":"HEADER_NAME \u003d \"OpenStack-API-Version\"\r"},{"line_number":33,"context_line":"SERVICE_TYPE \u003d \"container\"\r"},{"line_number":34,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_6db642fd","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":18},"updated":"2017-06-23 00:57:11.000000000","message":"We don\u0027t have to introduce this legacy header.","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":207,"context_line":"def check_major_version(api_version):\r"},{"line_number":208,"context_line":"    \"\"\"Checks major part of ``APIVersion`` obj is supported.\r"},{"line_number":209,"context_line":"\r"},{"line_number":210,"context_line":"    :raises novaclient.exceptions.UnsupportedVersion: if major part is not\r"},{"line_number":211,"context_line":"                                                      supported\r"},{"line_number":212,"context_line":"    \"\"\"\r"},{"line_number":213,"context_line":"    available_versions \u003d get_available_major_versions()\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_f759055a","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":22},"updated":"2017-06-23 00:57:11.000000000","message":"It is not nova.","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    \"\"\"Set microversion headers if api_version is not null\"\"\"\r"},{"line_number":242,"context_line":"\r"},{"line_number":243,"context_line":"    if not api_version.is_null() and api_version.ver_minor !\u003d 0:\r"},{"line_number":244,"context_line":"        headers[\"X-OpenStack-Container-API-Version\"] \u003d api_version.get_string()\r"},{"line_number":245,"context_line":"\r"},{"line_number":246,"context_line":"\r"},{"line_number":247,"context_line":"def _add_substitution(versioned_method):\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_6ab86875","line":244,"range":{"start_line":244,"start_character":8,"end_line":244,"end_character":79},"updated":"2017-06-23 00:57:11.000000000","message":"This is the legacy header. It is better to use the new header instead:\n\n  OpenStack-API-Version: container \u003cversion\u003e\n\nReference: https://specs.openstack.org/openstack/api-wg/guidelines/microversion_specification.html#client-interaction","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"}],"zunclient/common/apiclient/base.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.client \u003d client"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @property"},{"line_number":117,"context_line":"    def api_version(self):"},{"line_number":118,"context_line":"        return self.api.api_version"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _list(self, url, response_key\u003dNone, obj_class\u003dNone, json\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_282838e0","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":19},"updated":"2017-06-23 00:57:11.000000000","message":"This method should be in zunclient.common.base.Manager as well.","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"}],"zunclient/common/httpclient.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        kwargs[\u0027headers\u0027] \u003d copy.deepcopy(kwargs.get(\u0027headers\u0027, {}))"},{"line_number":159,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027User-Agent\u0027, USER_AGENT)"},{"line_number":160,"context_line":"        if self.api_version:"},{"line_number":161,"context_line":"            version_string \u003d \u0027container %s\u0027 % self.api_version"},{"line_number":162,"context_line":"            kwargs[\u0027headers\u0027].setdefault("},{"line_number":163,"context_line":"                \u0027OpenStack-API-Version\u0027, version_string)"},{"line_number":164,"context_line":"        if self.auth_token:"},{"line_number":165,"context_line":"            kwargs[\u0027headers\u0027].setdefault(\u0027X-Auth-Token\u0027, self.auth_token)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_838def32","line":163,"range":{"start_line":161,"start_character":12,"end_line":163,"end_character":56},"updated":"2017-06-23 00:57:11.000000000","message":"Here needs to be updated. The header should be set by the \"update_headers\" method:\n\n  api_versions.update_headers(kwargs[\"headers\"], self.api_version)","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        kwargs[\u0027headers\u0027] \u003d copy.deepcopy(kwargs.get(\u0027headers\u0027, {}))"},{"line_number":332,"context_line":"        kwargs[\u0027headers\u0027].setdefault(\u0027User-Agent\u0027, self.user_agent)"},{"line_number":333,"context_line":"        if self.api_version:"},{"line_number":334,"context_line":"            version_string \u003d \u0027container %s\u0027 % self.api_version"},{"line_number":335,"context_line":"            kwargs[\u0027headers\u0027].setdefault("},{"line_number":336,"context_line":"                \u0027OpenStack-API-Version\u0027, version_string)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        # NOTE(kevinz): osprofiler_web.get_trace_id_headers does not add any"},{"line_number":339,"context_line":"        # headers in case if osprofiler is not initialized."}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_e39ee361","line":336,"range":{"start_line":334,"start_character":12,"end_line":336,"end_character":56},"updated":"2017-06-23 00:57:11.000000000","message":"Here needs to be updated. The header should be set by the \"update_headers\" method:\n\n  api_versions.update_headers(kwargs[\"headers\"], self.api_version)","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"}],"zunclient/shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"0daff5a13c586c13c02970d37fc67f1bc94cfffe","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                zun_url\u003dbypass_url,"},{"line_number":633,"context_line":"                                endpoint_type\u003dendpoint_type,"},{"line_number":634,"context_line":"                                insecure\u003dinsecure,"},{"line_number":635,"context_line":"                                api_version\u003dzun_api_version,"},{"line_number":636,"context_line":"                                **kwargs)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        args.func(self.cs, args)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_287718d7","line":635,"range":{"start_line":635,"start_character":44,"end_line":635,"end_character":59},"updated":"2017-06-23 00:57:11.000000000","message":"This should be \u0027api_version\u0027 (which you assigned in line #495)","commit_id":"ed8c6a72229ab49bdadec4fa9d75e3159ab4d6e3"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"47cafd22b746ab3e34473be660ac88a833cbd781","unresolved":false,"context_lines":[{"line_number":61,"context_line":"from zunclient.v1 import shell as shell_v1"},{"line_number":62,"context_line":"from zunclient import version"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"DEFAULT_API_VERSION \u003d \u00271.1\u0027"},{"line_number":65,"context_line":"DEFAULT_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":66,"context_line":"DEFAULT_SERVICE_TYPE \u003d \u0027container\u0027"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_0be5ea37","line":64,"range":{"start_line":64,"start_character":25,"end_line":64,"end_character":26},"updated":"2017-07-06 23:39:56.000000000","message":"It is 1.2 now.","commit_id":"3a7bb9365107c586d93f51ea1a13e4339eaefee2"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"02e41914cfa49887cae4b9bcd2354aac7096d2d3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"from zunclient.v1 import shell as shell_v1"},{"line_number":62,"context_line":"from zunclient import version"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"DEFAULT_API_VERSION \u003d \u00271.1\u0027"},{"line_number":65,"context_line":"DEFAULT_ENDPOINT_TYPE \u003d \u0027publicURL\u0027"},{"line_number":66,"context_line":"DEFAULT_SERVICE_TYPE \u003d \u0027container\u0027"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_81331962","line":64,"range":{"start_line":64,"start_character":25,"end_line":64,"end_character":26},"in_reply_to":"3f1d235d_0be5ea37","updated":"2017-07-07 00:56:11.000000000","message":"Done","commit_id":"3a7bb9365107c586d93f51ea1a13e4339eaefee2"}]}