)]}'
{"setup.cfg":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"05dcbb15a930a210e7b708aa971db58aa59637ca","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   appcontainer_cp \u003d zunclient.osc.v1.containers:CopyContainer"},{"line_number":56,"context_line":"   appcontainer_stats \u003d zunclient.osc.v1.containers:StatsContainer"},{"line_number":57,"context_line":"   appcontainer_commit \u003d zunclient.osc.v1.containers:CommitContainer"},{"line_number":58,"context_line":"   appcontainer_add_security_group \u003d zunclient.osc.v1.images:AddSecurityGroup"},{"line_number":59,"context_line":"   appcontainer_image_list \u003d zunclient.osc.v1.images:ListImage"},{"line_number":60,"context_line":"   appcontainer_image_pull \u003d zunclient.osc.v1.images:PullImage"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"df3967d1_40b24ae8","line":58,"range":{"start_line":58,"start_character":54,"end_line":58,"end_character":60},"updated":"2017-08-01 15:34:01.000000000","message":"This should be \"containers\"","commit_id":"1517a283993d09ac6336d4509d56911cb2c35400"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"4bb6a4915f177c72e3aaf821d243c49d03ad1cbc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   appcontainer_cp \u003d zunclient.osc.v1.containers:CopyContainer"},{"line_number":56,"context_line":"   appcontainer_stats \u003d zunclient.osc.v1.containers:StatsContainer"},{"line_number":57,"context_line":"   appcontainer_commit \u003d zunclient.osc.v1.containers:CommitContainer"},{"line_number":58,"context_line":"   appcontainer_add_security_group \u003d zunclient.osc.v1.containers:AddSecurityGroup"},{"line_number":59,"context_line":"   appcontainer_image_list \u003d zunclient.osc.v1.images:ListImage"},{"line_number":60,"context_line":"   appcontainer_image_pull \u003d zunclient.osc.v1.images:PullImage"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"df3967d1_181ee06f","line":58,"range":{"start_line":58,"start_character":3,"end_line":58,"end_character":34},"updated":"2017-08-02 09:31:45.000000000","message":"I think this command is not user friendly. I mean its too long.\nHow about \"appcontainer add secgroup\" ?","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"3ccd17de7ce5d74ad3b935354c705b7aa235a0f4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   appcontainer_cp \u003d zunclient.osc.v1.containers:CopyContainer"},{"line_number":56,"context_line":"   appcontainer_stats \u003d zunclient.osc.v1.containers:StatsContainer"},{"line_number":57,"context_line":"   appcontainer_commit \u003d zunclient.osc.v1.containers:CommitContainer"},{"line_number":58,"context_line":"   appcontainer_add_security_group \u003d zunclient.osc.v1.containers:AddSecurityGroup"},{"line_number":59,"context_line":"   appcontainer_image_list \u003d zunclient.osc.v1.images:ListImage"},{"line_number":60,"context_line":"   appcontainer_image_pull \u003d zunclient.osc.v1.images:PullImage"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"df3967d1_27e05c96","line":58,"range":{"start_line":58,"start_character":3,"end_line":58,"end_character":34},"in_reply_to":"df3967d1_181ee06f","updated":"2017-08-02 12:40:01.000000000","message":"However, Nova is using the long name \"server add security group\" (http://git.openstack.org/cgit/openstack/python-openstackclient/tree/setup.cfg#n107) ...","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"bbc197ce56ec3ea5e66667a4b9eb5a2bfb812574","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   appcontainer_cp \u003d zunclient.osc.v1.containers:CopyContainer"},{"line_number":56,"context_line":"   appcontainer_stats \u003d zunclient.osc.v1.containers:StatsContainer"},{"line_number":57,"context_line":"   appcontainer_commit \u003d zunclient.osc.v1.containers:CommitContainer"},{"line_number":58,"context_line":"   appcontainer_add_security_group \u003d zunclient.osc.v1.containers:AddSecurityGroup"},{"line_number":59,"context_line":"   appcontainer_image_list \u003d zunclient.osc.v1.images:ListImage"},{"line_number":60,"context_line":"   appcontainer_image_pull \u003d zunclient.osc.v1.images:PullImage"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"df3967d1_b3b25793","line":58,"range":{"start_line":58,"start_character":3,"end_line":58,"end_character":34},"in_reply_to":"df3967d1_181ee06f","updated":"2017-08-02 09:50:19.000000000","message":"Thanks a lot. Good suggestion!","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"}],"zunclient/osc/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"05dcbb15a930a210e7b708aa971db58aa59637ca","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        parser.add_argument("},{"line_number":967,"context_line":"            \u0027security-group\u0027,"},{"line_number":968,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":969,"context_line":"            action\u003d\u0027append\u0027, default\u003d[],"},{"line_number":970,"context_line":"            help\u003d\u0027The security group for specified container. \u0027)"},{"line_number":971,"context_line":"        return parser"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_20a2a64c","line":969,"range":{"start_line":969,"start_character":12,"end_line":969,"end_character":40},"updated":"2017-08-01 15:34:01.000000000","message":"This argument is not a list so these should be removed.","commit_id":"1517a283993d09ac6336d4509d56911cb2c35400"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"4bb6a4915f177c72e3aaf821d243c49d03ad1cbc","unresolved":false,"context_lines":[{"line_number":962,"context_line":"        parser.add_argument("},{"line_number":963,"context_line":"            \u0027container\u0027,"},{"line_number":964,"context_line":"            metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":965,"context_line":"            help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":966,"context_line":"        parser.add_argument("},{"line_number":967,"context_line":"            \u0027security_group\u0027,"},{"line_number":968,"context_line":"            metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_58034810","line":965,"range":{"start_line":965,"start_character":36,"end_line":965,"end_character":48},"updated":"2017-08-02 09:31:45.000000000","message":"This should be only one container. Right?","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"bbc197ce56ec3ea5e66667a4b9eb5a2bfb812574","unresolved":false,"context_lines":[{"line_number":962,"context_line":"        parser.add_argument("},{"line_number":963,"context_line":"            \u0027container\u0027,"},{"line_number":964,"context_line":"            metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":965,"context_line":"            help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":966,"context_line":"        parser.add_argument("},{"line_number":967,"context_line":"            \u0027security_group\u0027,"},{"line_number":968,"context_line":"            metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_33f1c76c","line":965,"range":{"start_line":965,"start_character":36,"end_line":965,"end_character":48},"in_reply_to":"df3967d1_58034810","updated":"2017-08-02 09:50:19.000000000","message":"Done","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"}],"zunclient/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"05dcbb15a930a210e7b708aa971db58aa59637ca","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def add_security_group(self, id, security_group):"},{"line_number":207,"context_line":"        return self._action(id, \u0027/add_security_group\u0027,"},{"line_number":208,"context_line":"                            qparams\u003d{\u0027security_group\u0027: security_group})"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_c04aba53","line":208,"range":{"start_line":208,"start_character":38,"end_line":208,"end_character":52},"updated":"2017-08-01 15:34:01.000000000","message":"According to the schema (https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/schemas/containers.py#L154), this should be {\u0027name\u0027: security_group}.","commit_id":"1517a283993d09ac6336d4509d56911cb2c35400"}],"zunclient/v1/containers_shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"05dcbb15a930a210e7b708aa971db58aa59637ca","unresolved":false,"context_lines":[{"line_number":682,"context_line":"           help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":683,"context_line":"@utils.arg(\u0027security-group\u0027,"},{"line_number":684,"context_line":"           metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":685,"context_line":"           action\u003d\u0027append\u0027, default\u003d[],"},{"line_number":686,"context_line":"           help\u003d\u0027The security group for specified container. \u0027)"},{"line_number":687,"context_line":"def do_add_security_group(cs, args):"},{"line_number":688,"context_line":"    \"\"\"Add security group for specified container.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_3d6d3104","line":685,"range":{"start_line":685,"start_character":11,"end_line":685,"end_character":38},"updated":"2017-08-01 15:34:01.000000000","message":"I don\u0027t think this argument is a string, not a list. Therefore, action and default should be removed.","commit_id":"1517a283993d09ac6336d4509d56911cb2c35400"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"4bb6a4915f177c72e3aaf821d243c49d03ad1cbc","unresolved":false,"context_lines":[{"line_number":679,"context_line":""},{"line_number":680,"context_line":"@utils.arg(\u0027container\u0027,"},{"line_number":681,"context_line":"           metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":682,"context_line":"           help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":683,"context_line":"@utils.arg(\u0027security_group\u0027,"},{"line_number":684,"context_line":"           metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":685,"context_line":"           help\u003d\u0027The security group for specified container. \u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_b33c97c8","line":682,"range":{"start_line":682,"start_character":35,"end_line":682,"end_character":47},"updated":"2017-08-02 09:31:45.000000000","message":"ditto\ns/(container)s/container/","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"bbc197ce56ec3ea5e66667a4b9eb5a2bfb812574","unresolved":false,"context_lines":[{"line_number":679,"context_line":""},{"line_number":680,"context_line":"@utils.arg(\u0027container\u0027,"},{"line_number":681,"context_line":"           metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":682,"context_line":"           help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":683,"context_line":"@utils.arg(\u0027security_group\u0027,"},{"line_number":684,"context_line":"           metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":685,"context_line":"           help\u003d\u0027The security group for specified container. \u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_b304974b","line":682,"range":{"start_line":682,"start_character":35,"end_line":682,"end_character":47},"in_reply_to":"df3967d1_b33c97c8","updated":"2017-08-02 09:50:19.000000000","message":"Done","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"4bb6a4915f177c72e3aaf821d243c49d03ad1cbc","unresolved":false,"context_lines":[{"line_number":682,"context_line":"           help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":683,"context_line":"@utils.arg(\u0027security_group\u0027,"},{"line_number":684,"context_line":"           metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":685,"context_line":"           help\u003d\u0027The security group for specified container. \u0027)"},{"line_number":686,"context_line":"def do_add_security_group(cs, args):"},{"line_number":687,"context_line":"    \"\"\"Add security group for specified container.\"\"\""},{"line_number":688,"context_line":"    opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_933cf3bf","line":685,"updated":"2017-08-02 09:31:45.000000000","message":"nit: remove extra space.","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"},{"author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"change_message_id":"bbc197ce56ec3ea5e66667a4b9eb5a2bfb812574","unresolved":false,"context_lines":[{"line_number":682,"context_line":"           help\u003d\u0027ID or name of the (container)s to add security group.\u0027)"},{"line_number":683,"context_line":"@utils.arg(\u0027security_group\u0027,"},{"line_number":684,"context_line":"           metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":685,"context_line":"           help\u003d\u0027The security group for specified container. \u0027)"},{"line_number":686,"context_line":"def do_add_security_group(cs, args):"},{"line_number":687,"context_line":"    \"\"\"Add security group for specified container.\"\"\""},{"line_number":688,"context_line":"    opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_93ff5333","line":685,"in_reply_to":"df3967d1_933cf3bf","updated":"2017-08-02 09:50:19.000000000","message":"Done","commit_id":"6ac0ecddec3c1d29e07a9920c2a97dafe10fbd6c"}]}