)]}'
{"zunclient/osc/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"315d0b07bb1ecac0d7994ee3b7a69fd812187062","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        if parsed_args.interactive:"},{"line_number":185,"context_line":"            opts[\u0027interactive\u0027] \u003d True"},{"line_number":186,"context_line":"        if parsed_args.volume:"},{"line_number":187,"context_line":"            opts[\u0027volume_binds\u0027] \u003d parsed_args.volume"},{"line_number":188,"context_line":"        opts[\u0027hints\u0027] \u003d zun_utils.format_args(parsed_args.hint)"},{"line_number":189,"context_line":"        opts[\u0027nets\u0027] \u003d zun_utils.parse_nets(parsed_args.net)"},{"line_number":190,"context_line":"        opts[\u0027runtime\u0027] \u003d parsed_args.runtime"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_42b43cd1","line":187,"range":{"start_line":187,"start_character":47,"end_line":187,"end_character":53},"updated":"2017-10-15 23:36:22.000000000","message":"According to your code, the input will contain the host path and the container path (in the format of HOST_PATH:CONTAINER_PATH). I would suggest to create an archived file from HOST_PATH, and send the archived file to the server. You could refer the code of \u0027put_archive\u0027 as an example.\n\nThe reason why we cannot directly pass HOST_PATH to server is because it will break on multi-node environment (zunclient is not run in the same host of zun-compute). Please find more details from the reviews in the server patch: https://review.openstack.org/512000","commit_id":"0729d5828078b178268c6d245cbe889c0aaec995"}],"zunclient/tests/unit/v1/test_containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"315d0b07bb1ecac0d7994ee3b7a69fd812187062","unresolved":false,"context_lines":[{"line_number":54,"context_line":"              \u0027auto_remove\u0027: False,"},{"line_number":55,"context_line":"              \u0027runtime\u0027: \u0027runc\u0027,"},{"line_number":56,"context_line":"              \u0027hostname\u0027: \u0027testhost\u0027,"},{"line_number":57,"context_line":"              \u0027volume_binds\u0027: \u0027/test:/test:ro\u0027"},{"line_number":58,"context_line":"              }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"CREATE_CONTAINER1 \u003d copy.deepcopy(CONTAINER1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_c2c38c56","line":57,"range":{"start_line":57,"start_character":42,"end_line":57,"end_character":45},"updated":"2017-10-15 23:36:22.000000000","message":"I am not sure if it is safe to allow end-users to specify the mode (i.e. \u0027:ro\u0027). It might incur several security issues. I think we can start to support the first two fields (i.e. /test:/test), and revisit the support of the third field (i.e. \u0027:ro\u0027) later.","commit_id":"0729d5828078b178268c6d245cbe889c0aaec995"}],"zunclient/v1/containers_shell.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"315d0b07bb1ecac0d7994ee3b7a69fd812187062","unresolved":false,"context_lines":[{"line_number":124,"context_line":"@utils.arg(\u0027-v\u0027, \u0027--volume\u0027,"},{"line_number":125,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":126,"context_line":"           action\u003d\u0027append\u0027, default\u003d[],"},{"line_number":127,"context_line":"           help\u003d\u0027Bind mount a volume. \u0027"},{"line_number":128,"context_line":"                \u0027May be used multiple times.\u0027)"},{"line_number":129,"context_line":"def do_create(cs, args):"},{"line_number":130,"context_line":"    \"\"\"Create a container.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_a22f703d","line":127,"range":{"start_line":127,"start_character":30,"end_line":127,"end_character":36},"updated":"2017-10-15 23:36:22.000000000","message":"I think the help message could be more specific. Consider including the following:\n\n  Consists of two fields, separated by colon characters (:). The first field is the path to the file or directory on this host. The second field is the path where the file or directory will be mounted in the container. E.g. \u0027/target:/app\u0027","commit_id":"0729d5828078b178268c6d245cbe889c0aaec995"}]}