)]}'
{"id":"openstack%2Fpython-zunclient~523284","triplet_id":"openstack%2Fpython-zunclient~master~Ie11f57f46797dcf024452e3a98572166501954fe","project":"openstack/python-zunclient","branch":"master","hashtags":[],"change_id":"Ie11f57f46797dcf024452e3a98572166501954fe","subject":"Add size option to \"--mount\" when run container","status":"MERGED","created":"2017-11-28 03:13:05.000000000","updated":"2017-12-06 06:11:10.000000000","submitted":"2017-12-06 06:11:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"523284-1512540670679-e49740ce","meta_rev_id":"1930a94e6c3e6c714893ea92ce14269e11007001","_number":523284,"virtual_id_number":523284,"owner":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"date":"2017-11-29 03:19:56.000000000","_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":2,"date":"2017-12-06 06:11:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":2,"date":"2017-11-29 01:39:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-12-06 05:31:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"date":"2017-12-06 05:27:50.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-12-06 05:31:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-29 01:39:05.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2017-12-06 05:27:50.000000000","updated_by":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"reviewer":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"state":"REVIEWER"},{"updated":"2017-12-06 05:31:52.000000000","updated_by":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"reviewer":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"state":"REVIEWER"},{"updated":"2017-12-06 06:11:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8bb2d9df47117563f16a948e070dfb44b4a6b94f","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2017-11-28 03:13:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"550bde25b3fddb141391b2f0fc2a5369c2b50009","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-28 04:00:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/84/523284/1/check/openstack-tox-pep8/2b1005f/ : SUCCESS in 3m 16s\n- openstack-tox-py27 http://logs.openstack.org/84/523284/1/check/openstack-tox-py27/654807e/ : SUCCESS in 4m 43s\n- openstack-tox-py35 http://logs.openstack.org/84/523284/1/check/openstack-tox-py35/4868c46/ : SUCCESS in 3m 32s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/523284/1/check/build-openstack-sphinx-docs/4ef5f95/html/ : SUCCESS in 5m 15s\n- zunclient-devstack-docker-sql http://logs.openstack.org/84/523284/1/check/zunclient-devstack-docker-sql/aececce/ : SUCCESS in 45m 06s","accounts_in_message":[],"_revision_number":1},{"id":"ec38e3c289825a4dd391b457d2b59ae7c7402d36","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-11-28 04:24:25.000000000","message":"Patch Set 1:\n\nHi Kevin,\n\nThis might be my personal preference. I think the design of the --mount option is better to be consistent with Docker CLI if it is possible because this portable experience will make users easier to pick up.\n\nAccording to https://docs.docker.com/engine/admin/volumes/volumes/#start-a-container-which-creates-a-volume-using-a-volume-driver , \u0027--mount\u0027 supports four keys: \u0027type\u0027, \u0027source\u0027, \u0027destination\u0027, \u0027readonly\u0027, \u0027volume-opt\u0027. It seems the \u0027size\u0027 option fits into the \u0027volume-opt\u0027 options.\n\nIf you agree, the syntax will look like below:\n\n  --mount destination\u003d\u003cpath\u003e,volume-opt\u003dsize\u003d1\n\nWhat do you think?","accounts_in_message":[],"_revision_number":1},{"id":"c6e117609f3e99e7f9f57ba4ab3f1dda70c35886","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2017-11-29 01:39:05.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e Hi Kevin,\n \u003e \n \u003e This might be my personal preference. I think the design of the\n \u003e --mount option is better to be consistent with Docker CLI if it is\n \u003e possible because this portable experience will make users easier to\n \u003e pick up.\n \u003e \n \u003e According to https://docs.docker.com/engine/admin/volumes/volumes/#start-a-container-which-creates-a-volume-using-a-volume-driver\n \u003e , \u0027--mount\u0027 supports four keys: \u0027type\u0027, \u0027source\u0027, \u0027destination\u0027,\n \u003e \u0027readonly\u0027, \u0027volume-opt\u0027. It seems the \u0027size\u0027 option fits into the\n \u003e \u0027volume-opt\u0027 options.\n \u003e \n \u003e If you agree, the syntax will look like below:\n \u003e \n \u003e --mount destination\u003d\u003cpath\u003e,volume-opt\u003dsize\u003d1\n \u003e \n \u003e What do you think?\n\nI gave it more thoughts on this. Perhaps current solution is equally fine. The \u0027size\u0027 option in cinder is mandatory, perhaps it deserve a dedicated option for it.","accounts_in_message":[],"_revision_number":1},{"id":"e4bec773962be96ec74fe6365f6ea455792d7ba7","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2017-11-29 03:19:56.000000000","message":"Patch Set 1:\n\n\u003e \u003e Hi Kevin,\n \u003e \u003e\n \u003e \u003e This might be my personal preference. I think the design of the\n \u003e \u003e --mount option is better to be consistent with Docker CLI if it\n \u003e is\n \u003e \u003e possible because this portable experience will make users easier\n \u003e to\n \u003e \u003e pick up.\n \u003e \u003e\n \u003e \u003e According to https://docs.docker.com/engine/admin/volumes/volumes/#start-a-container-which-creates-a-volume-using-a-volume-driver\n \u003e \u003e , \u0027--mount\u0027 supports four keys: \u0027type\u0027, \u0027source\u0027, \u0027destination\u0027,\n \u003e \u003e \u0027readonly\u0027, \u0027volume-opt\u0027. It seems the \u0027size\u0027 option fits into\n \u003e the\n \u003e \u003e \u0027volume-opt\u0027 options.\n \u003e \u003e\n \u003e \u003e If you agree, the syntax will look like below:\n \u003e \u003e\n \u003e \u003e --mount destination\u003d\u003cpath\u003e,volume-opt\u003dsize\u003d1\n \u003e \u003e\n \u003e \u003e What do you think?\n \u003e \n \u003e I gave it more thoughts on this. Perhaps current solution is\n \u003e equally fine. The \u0027size\u0027 option in cinder is mandatory, perhaps it\n \u003e deserve a dedicated option for it.\n\nAha, Ok thanks hongbin.\nWe can add more in the following patch if needed","accounts_in_message":[],"_revision_number":1},{"id":"45082b8ad77e8f9de35420bc74b595f524b0537f","author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"date":"2017-12-06 05:31:52.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b6519986691f5dd747534242a533d92e90d52b25","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-06 05:32:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8f0bf59579d1a7b5b4f86e26b02dcb196ef5edfc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-06 06:11:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/84/523284/1/gate/openstack-tox-pep8/062d988/ : SUCCESS in 5m 09s\n- openstack-tox-py27 http://logs.openstack.org/84/523284/1/gate/openstack-tox-py27/6d7691e/ : SUCCESS in 6m 14s\n- openstack-tox-py35 http://logs.openstack.org/84/523284/1/gate/openstack-tox-py35/dcbd7be/ : SUCCESS in 4m 59s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/523284/1/gate/build-openstack-sphinx-docs/e14d3eb/html/ : SUCCESS in 6m 37s\n- zunclient-devstack-docker-sql http://logs.openstack.org/84/523284/1/gate/zunclient-devstack-docker-sql/37a2f1d/ : SUCCESS in 37m 22s","accounts_in_message":[],"_revision_number":1},{"id":"1930a94e6c3e6c714893ea92ce14269e11007001","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-06 06:11:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"01436550aabe54365d7ebcfdf29209ab4bbbe86a","revisions":{"01436550aabe54365d7ebcfdf29209ab4bbbe86a":{"kind":"REWORK","_number":1,"created":"2017-11-28 03:13:05.000000000","uploader":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"ref":"refs/changes/84/523284/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/84/523284/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/84/523284/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/84/523284/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/84/523284/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/84/523284/1"}}},"commit":{"parents":[{"commit":"4d4af8b0b5de75fcca1c23b3fef5208583f05998","subject":"Merge \"Add image-search support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/4d4af8b0b5de75fcca1c23b3fef5208583f05998"}]}],"author":{"name":"Kevin Zhao","email":"kevin.zhao@arm.com","date":"2017-11-28 02:30:38.000000000","tz":480},"committer":{"name":"Kevin Zhao","email":"kevin.zhao@arm.com","date":"2017-11-28 02:36:06.000000000","tz":480},"subject":"Add size option to \"--mount\" when run container","message":"Add size option to \"--mount\" when run container\n\nJira: ENTWLS-476\n\nChange-Id: Ie11f57f46797dcf024452e3a98572166501954fe\nSigned-off-by: Kevin Zhao \u003ckevin.zhao@arm.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/01436550aabe54365d7ebcfdf29209ab4bbbe86a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/01436550aabe54365d7ebcfdf29209ab4bbbe86a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}