)]}'
{"zunclient/osc/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"102cda063a61e7ceb6121bf693787fceaf48c167","unresolved":false,"context_lines":[{"line_number":1019,"context_line":""},{"line_number":1020,"context_line":"class RemoveSecurityGroup(command.Command):"},{"line_number":1021,"context_line":"    \"\"\"Remove security group for specified container.\"\"\""},{"line_number":1022,"context_line":"    log \u003d logging.getLogger(__name__ + \".AddSecurityGroup\")"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"    def get_parser(self, prog_name):"},{"line_number":1025,"context_line":"        parser \u003d super(RemoveSecurityGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_312d5695","line":1022,"range":{"start_line":1022,"start_character":41,"end_line":1022,"end_character":57},"updated":"2018-01-11 19:53:16.000000000","message":"RemoveSecurityGroup","commit_id":"85228fa8d3d2a6fa18aa12ca3b0dfb51d673df2e"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"7e4352679092d9de6f95aa3ee08a749873b0538d","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"            metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":1029,"context_line":"            help\u003d\u0027ID or name of the container to remove security group.\u0027)"},{"line_number":1030,"context_line":"        parser.add_argument("},{"line_number":1031,"context_line":"            \u0027security_group\u0027,"},{"line_number":1032,"context_line":"            metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":1033,"context_line":"            help\u003d\u0027The security group to remove from specified container. \u0027)"},{"line_number":1034,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_e3c3f2eb","line":1031,"updated":"2018-01-18 05:07:00.000000000","message":"Can this be a list of security groups to be removed?","commit_id":"ead62e03746a52e35bfe45f20ab52318f77df0ac"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"c52c817bf4b7ff015c5c13e173e423791b6855e4","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"            metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":1029,"context_line":"            help\u003d\u0027ID or name of the container to remove security group.\u0027)"},{"line_number":1030,"context_line":"        parser.add_argument("},{"line_number":1031,"context_line":"            \u0027security_group\u0027,"},{"line_number":1032,"context_line":"            metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":1033,"context_line":"            help\u003d\u0027The security group to remove from specified container. \u0027)"},{"line_number":1034,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_de5d6c79","line":1031,"in_reply_to":"7f96bb07_5b53ae39","updated":"2018-01-18 07:20:17.000000000","message":"but multiple sgs can be added. Right?","commit_id":"ead62e03746a52e35bfe45f20ab52318f77df0ac"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"23edcc4da4607382de37e5f09ed35a647b01b4ff","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"            metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":1029,"context_line":"            help\u003d\u0027ID or name of the container to remove security group.\u0027)"},{"line_number":1030,"context_line":"        parser.add_argument("},{"line_number":1031,"context_line":"            \u0027security_group\u0027,"},{"line_number":1032,"context_line":"            metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":1033,"context_line":"            help\u003d\u0027The security group to remove from specified container. \u0027)"},{"line_number":1034,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_07105556","line":1031,"in_reply_to":"7f96bb07_de5d6c79","updated":"2018-01-18 16:16:16.000000000","message":"Madhuri,\n\nYes, we can support adding multiple security groups, which is a good enhancement. My only hesitation is the consistency with nova. Here is the corresponding nova command:\n\n  $ openstack server add security group --help\n  usage: openstack server add security group [-h] \u003cserver\u003e \u003cgroup\u003e\n\n  Add security group to server\n\n  positional arguments:\n    \u003cserver\u003e    Server (name or ID)\n    \u003cgroup\u003e     Security group to add (name or ID)\n\nIt looks they don\u0027t support adding multiple security groups. If we add support for this feature, it will introduce an inconsistency with other openstack commands, which we want to avoid. However, if we would like to propose this enhancement, it should be done in both nova and zun side so that our users will be beneficial from the consistency. What do you think?","commit_id":"ead62e03746a52e35bfe45f20ab52318f77df0ac"},{"author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"change_message_id":"a08d6d16e7824c402029fd150b3decb4a15adf4e","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"            metavar\u003d\u0027\u003ccontainer\u003e\u0027,"},{"line_number":1029,"context_line":"            help\u003d\u0027ID or name of the container to remove security group.\u0027)"},{"line_number":1030,"context_line":"        parser.add_argument("},{"line_number":1031,"context_line":"            \u0027security_group\u0027,"},{"line_number":1032,"context_line":"            metavar\u003d\u0027\u003csecurity_group\u003e\u0027,"},{"line_number":1033,"context_line":"            help\u003d\u0027The security group to remove from specified container. \u0027)"},{"line_number":1034,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_5b53ae39","line":1031,"in_reply_to":"7f96bb07_e3c3f2eb","updated":"2018-01-18 06:51:35.000000000","message":"Noap, only one security group. in add security group also we are adding one security group at a time.\nref: https://review.openstack.org/#/c/526659/3/zun/network/kuryr_network.py","commit_id":"ead62e03746a52e35bfe45f20ab52318f77df0ac"}]}