)]}'
{"id":"openstack%2Fpython-zunclient~532775","triplet_id":"openstack%2Fpython-zunclient~master~I35919f3e6edd0239a4edc0b68c6622f910d85be6","project":"openstack/python-zunclient","branch":"master","topic":"bug/1737152","hashtags":[],"change_id":"I35919f3e6edd0239a4edc0b68c6622f910d85be6","subject":"Add cli for remove security group","status":"MERGED","created":"2018-01-11 09:17:12.000000000","updated":"2018-01-19 06:03:06.000000000","submitted":"2018-01-19 06:03:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"532775-1516341786815-65c4cf05","meta_rev_id":"5eb70c0ad1f94461699a2dc4c5c43e67ad8a2870","_number":532775,"virtual_id_number":532775,"owner":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":2,"date":"2018-01-19 06:03:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-01-18 06:51:35.000000000","_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":2,"date":"2018-01-16 02:16:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":1,"date":"2018-01-16 08:10:08.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},{"value":2,"date":"2018-01-19 05:20:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},{"value":1,"date":"2018-01-19 05:20:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-16 02:16:12.000000000","updated_by":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"reviewer":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"state":"REVIEWER"},{"updated":"2018-01-16 08:10:08.000000000","updated_by":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"reviewer":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"state":"REVIEWER"},{"updated":"2018-01-19 05:20:31.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2018-01-19 06:03:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c8a675f34895599c09907adef522e6704f7684de","author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"date":"2018-01-11 09:17:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a42cc7b356c6ff0164575e675d61461f3224b892","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 14:43:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/75/532775/1/check/openstack-tox-pep8/caad1d7/ : SUCCESS in 6m 08s\n- openstack-tox-py27 http://logs.openstack.org/75/532775/1/check/openstack-tox-py27/e6b2563/ : SUCCESS in 8m 56s\n- openstack-tox-py35 http://logs.openstack.org/75/532775/1/check/openstack-tox-py35/3c30274/ : SUCCESS in 6m 25s\n- build-openstack-sphinx-docs http://logs.openstack.org/75/532775/1/check/build-openstack-sphinx-docs/88e64f1/html/ : SUCCESS in 5m 52s\n- zunclient-devstack-docker-sql http://logs.openstack.org/75/532775/1/check/zunclient-devstack-docker-sql/f7cffaa/ : TIMED_OUT in 1h 18m 14s","accounts_in_message":[],"_revision_number":1},{"id":"102cda063a61e7ceb6121bf693787fceaf48c167","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-11 19:53:16.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nOne minor issue commented inline. In overall, LGTM. Thanks @\t\ncooldharma06","accounts_in_message":[],"_revision_number":1},{"id":"c5f2746925e7733ab4059a541fe0a5bae0024ba1","author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"date":"2018-01-12 10:52:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5160ed05b39e7ec9da3d4a2def0956b1a9ad6211","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 12:10:59.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/75/532775/2/check/openstack-tox-pep8/746d2ac/ : SUCCESS in 5m 17s\n- openstack-tox-py27 http://logs.openstack.org/75/532775/2/check/openstack-tox-py27/17e7383/ : SUCCESS in 4m 56s\n- openstack-tox-py35 http://logs.openstack.org/75/532775/2/check/openstack-tox-py35/5da191d/ : SUCCESS in 5m 06s\n- build-openstack-sphinx-docs http://logs.openstack.org/75/532775/2/check/build-openstack-sphinx-docs/7bf0a8e/html/ : SUCCESS in 5m 12s\n- zunclient-devstack-docker-sql http://logs.openstack.org/75/532775/2/check/zunclient-devstack-docker-sql/b75ae7e/ : FAILURE in 37m 24s","accounts_in_message":[],"_revision_number":2},{"id":"07d251992f13a397ca339ac1479073900d5dcfa5","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-16 02:10:58.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"b731ddf013e46cff89c6d222d13df783e6d9acc2","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-16 02:16:12.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"07e54719825eb26eebc0d7d08b2af1e204b8e7ab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-16 02:55:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/75/532775/2/check/openstack-tox-pep8/384ea67/ : SUCCESS in 6m 02s\n- openstack-tox-py27 http://logs.openstack.org/75/532775/2/check/openstack-tox-py27/5fb24dc/ : SUCCESS in 4m 42s\n- openstack-tox-py35 http://logs.openstack.org/75/532775/2/check/openstack-tox-py35/f010622/ : SUCCESS in 4m 00s\n- build-openstack-sphinx-docs http://logs.openstack.org/75/532775/2/check/build-openstack-sphinx-docs/47fb6f5/html/ : SUCCESS in 5m 26s\n- zunclient-devstack-docker-sql http://logs.openstack.org/75/532775/2/check/zunclient-devstack-docker-sql/cf98d83/ : SUCCESS in 34m 41s","accounts_in_message":[],"_revision_number":2},{"id":"371ff13ecdf9c9e862af0a210d5db5dd86db5b45","author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"date":"2018-01-16 08:10:08.000000000","message":"Patch Set 2: Code-Review+1\n\nwill +2 after https://review.openstack.org/#/c/526659/ merged","accounts_in_message":[],"_revision_number":2},{"id":"7e4352679092d9de6f95aa3ee08a749873b0538d","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2018-01-18 05:07:00.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\ncontainers_shell tests are remaining. Could you add them?","accounts_in_message":[],"_revision_number":2},{"id":"a08d6d16e7824c402029fd150b3decb4a15adf4e","author":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"date":"2018-01-18 06:51:35.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c52c817bf4b7ff015c5c13e173e423791b6855e4","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2018-01-18 07:20:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a2b228656fbd9c9e3142b30f7e8320fa7266395e","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2018-01-18 08:51:07.000000000","message":"Patch Set 2: -Code-Review\n\nRemoving my -1 vote as the requested change of removing multiple sgs can be done is subsequent patches as an improvement.\n \n@dharma, can you add the missing tests?","accounts_in_message":[],"_revision_number":2},{"id":"23edcc4da4607382de37e5f09ed35a647b01b4ff","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-18 16:16:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d7634ef22403f9d9bcf2afd5b8f3143bdfc5b104","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-18 16:16:45.000000000","message":"Patch Set 2: Workflow-1\n\nWaiting for the server\u0027s patch to be merged: https://review.openstack.org/#/c/526659/","accounts_in_message":[],"_revision_number":2},{"id":"1d02d551d705f75661289dbc9e9958232f0f8b68","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-18 18:06:22.000000000","message":"Patch Set 2:\n\n\u003e Removing my -1 vote as the requested change of removing multiple\n \u003e sgs can be done is subsequent patches as an improvement.\n \u003e \n \u003e @dharma, can you add the missing tests?\n\nMadhuri,\n\nIt looks the test cases for adding security group is already missing at containers_shell.py, so it might be a bit unfair to block the merging because of that. I think we can merge this patch with a tech-debt: https://bugs.launchpad.net/zun/+bug/1744134 . What do you think.","accounts_in_message":[],"_revision_number":2},{"id":"b99d6fd0defe78ed96de2348251db3be5e64523a","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-01-19 03:26:27.000000000","message":"Patch Set 2: -Workflow\n\nThe depending patch is merged: https://review.openstack.org/#/c/526659/ , so remove my workflow -1 . This patch is ready to go.","accounts_in_message":[],"_revision_number":2},{"id":"efc8f7c08048d566374aa3d7d06fe4ecb95da23e","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2018-01-19 05:20:02.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n\nOk I agree with the consistency part.","accounts_in_message":[],"_revision_number":2},{"id":"f4a3e1c93e35294745f3e79d33416edbe7594fc9","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2018-01-19 05:20:31.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2\n\n\u003e \u003e Removing my -1 vote as the requested change of removing multiple\n \u003e \u003e sgs can be done is subsequent patches as an improvement.\n \u003e \u003e\n \u003e \u003e @dharma, can you add the missing tests?\n \u003e \n \u003e Madhuri,\n \u003e \n \u003e It looks the test cases for adding security group is already\n \u003e missing at containers_shell.py, so it might be a bit unfair to\n \u003e block the merging because of that. I think we can merge this patch\n \u003e with a tech-debt: https://bugs.launchpad.net/zun/+bug/1744134 .\n \u003e What do you think.\n\nCool. Thank you for logging the bug.","accounts_in_message":[],"_revision_number":2},{"id":"2c4641ae26c4e04f5234e4a1285a19338a46d697","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-19 05:20:42.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"976c6e1071533ae4001f1f79656d56048b5b39de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-19 06:03:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c6ab4db171d201e41bcff4752abfe5018e60cccc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-19 06:03:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/75/532775/2/gate/openstack-tox-pep8/2c10713/ : SUCCESS in 3m 59s\n- openstack-tox-py27 http://logs.openstack.org/75/532775/2/gate/openstack-tox-py27/d1d5cac/ : SUCCESS in 4m 21s\n- openstack-tox-py35 http://logs.openstack.org/75/532775/2/gate/openstack-tox-py35/8142dde/ : SUCCESS in 5m 24s\n- build-openstack-sphinx-docs http://logs.openstack.org/75/532775/2/gate/build-openstack-sphinx-docs/5ad428a/html/ : SUCCESS in 3m 46s\n- zunclient-devstack-docker-sql http://logs.openstack.org/75/532775/2/gate/zunclient-devstack-docker-sql/15be636/ : SUCCESS in 40m 23s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ead62e03746a52e35bfe45f20ab52318f77df0ac","revisions":{"85228fa8d3d2a6fa18aa12ca3b0dfb51d673df2e":{"kind":"REWORK","_number":1,"created":"2018-01-11 09:17:12.000000000","uploader":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"ref":"refs/changes/75/532775/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/75/532775/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/1"}}},"commit":{"parents":[{"commit":"54054281688b91f4c97d3515429d528825a4631d","subject":"Merge \"Rename option \u0027--rm\u0027 to \u0027--auto-remove\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/54054281688b91f4c97d3515429d528825a4631d"}]}],"author":{"name":"cooldharma06","email":"cooldharma06@gmail.com","date":"2018-01-11 09:14:11.000000000","tz":330},"committer":{"name":"cooldharma06","email":"cooldharma06@gmail.com","date":"2018-01-11 09:17:48.000000000","tz":330},"subject":"Add cli for remove security group","message":"Add cli for remove security group\n\nChange-Id: I35919f3e6edd0239a4edc0b68c6622f910d85be6\nCloses-Bug: #1737152\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/85228fa8d3d2a6fa18aa12ca3b0dfb51d673df2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/85228fa8d3d2a6fa18aa12ca3b0dfb51d673df2e"}]},"branch":"refs/heads/master"},"ead62e03746a52e35bfe45f20ab52318f77df0ac":{"kind":"REWORK","_number":2,"created":"2018-01-12 10:52:08.000000000","uploader":{"_account_id":16190,"name":"dharmalingam","email":"cooldharma06@gmail.com","username":"cooldharma06"},"ref":"refs/changes/75/532775/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/75/532775/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/75/532775/2"}}},"commit":{"parents":[{"commit":"54054281688b91f4c97d3515429d528825a4631d","subject":"Merge \"Rename option \u0027--rm\u0027 to \u0027--auto-remove\u0027\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/54054281688b91f4c97d3515429d528825a4631d"}]}],"author":{"name":"cooldharma06","email":"cooldharma06@gmail.com","date":"2018-01-11 09:14:11.000000000","tz":330},"committer":{"name":"cooldharma06","email":"cooldharma06@gmail.com","date":"2018-01-12 05:12:21.000000000","tz":330},"subject":"Add cli for remove security group","message":"Add cli for remove security group\n\nChange-Id: I35919f3e6edd0239a4edc0b68c6622f910d85be6\nCloses-Bug: #1737152\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/ead62e03746a52e35bfe45f20ab52318f77df0ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/ead62e03746a52e35bfe45f20ab52318f77df0ac"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}