)]}'
{"id":"openstack%2Fpython-zunclient~543136","triplet_id":"openstack%2Fpython-zunclient~master~Ic073098c8cd30bbf7e477c22bbdc59cb6f6bd18f","project":"openstack/python-zunclient","branch":"master","topic":"bug/1747282","hashtags":[],"change_id":"Ic073098c8cd30bbf7e477c22bbdc59cb6f6bd18f","subject":"Avoid empty values in \u0027mounts\u0027 options","status":"MERGED","created":"2018-02-10 19:33:06.000000000","updated":"2018-03-28 10:12:32.000000000","submitted":"2018-03-28 10:12:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"543136-1522231952904-9b7cbe75","meta_rev_id":"4c91215022d772f583907b43f5443e3256ce8731","_number":543136,"virtual_id_number":543136,"owner":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2018-03-28 10:12:32.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-03-05 03:32:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":2,"date":"2018-03-05 03:32:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-03-06 03:08:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-13 04:12:00.000000000","updated_by":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"reviewer":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"state":"REVIEWER"},{"updated":"2018-03-06 03:08:16.000000000","updated_by":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"reviewer":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"state":"REVIEWER"},{"updated":"2018-03-28 10:12:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"79afbf9a0fc65e965768d1fd7c2ed2c05250e3d1","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-02-10 19:33:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd8a184044e7d842c1c4da60584ffd4f9d1efbf4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-10 20:10:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/36/543136/1/check/openstack-tox-pep8/06022b8/ : SUCCESS in 4m 12s\n- openstack-tox-py27 http://logs.openstack.org/36/543136/1/check/openstack-tox-py27/45b07c6/ : SUCCESS in 3m 19s\n- openstack-tox-py35 http://logs.openstack.org/36/543136/1/check/openstack-tox-py35/82d157f/ : SUCCESS in 3m 51s\n- build-openstack-sphinx-docs http://logs.openstack.org/36/543136/1/check/build-openstack-sphinx-docs/49cbe0e/html/ : SUCCESS in 3m 41s\n- zunclient-devstack-docker-sql http://logs.openstack.org/36/543136/1/check/zunclient-devstack-docker-sql/b7a118d/ : SUCCESS in 36m 31s","accounts_in_message":[],"_revision_number":1},{"id":"08df1f437c94cf30dd7670131da6c100b62f329b","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-02-10 20:18:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d06d125eaa9973bafc0d3c06f88ee4d3f9ba48fe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-10 21:02:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/36/543136/2/check/openstack-tox-pep8/eb3db98/ : SUCCESS in 4m 37s\n- openstack-tox-py27 http://logs.openstack.org/36/543136/2/check/openstack-tox-py27/c8e67b2/ : SUCCESS in 4m 39s\n- openstack-tox-py35 http://logs.openstack.org/36/543136/2/check/openstack-tox-py35/4f0e59e/ : SUCCESS in 3m 45s\n- build-openstack-sphinx-docs http://logs.openstack.org/36/543136/2/check/build-openstack-sphinx-docs/450c2f4/html/ : SUCCESS in 4m 01s\n- zunclient-devstack-docker-sql http://logs.openstack.org/36/543136/2/check/zunclient-devstack-docker-sql/51a9457/ : SUCCESS in 38m 17s","accounts_in_message":[],"_revision_number":2},{"id":"79bb12addbb3c34f8f8e91d035364e755ca22d8e","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2018-02-12 08:51:59.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"54f8e384c344d5e52e980789e1f59ae82e61a612","author":{"_account_id":23055,"name":"miaohb","email":"miao.hongbao@zte.com.cn","username":"miaohb"},"date":"2018-02-13 04:12:00.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"aa3a8168098706b4f93088f61177da9a153a4e87","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-03-05 03:32:35.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"a0fbfb7fb69d59964ee015f8f81628d472044010","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-05 04:07:30.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/36/543136/3/check/openstack-tox-pep8/0a2a1e9/ : SUCCESS in 3m 50s\n- openstack-tox-py27 http://logs.openstack.org/36/543136/3/check/openstack-tox-py27/92c0cee/ : SUCCESS in 3m 48s\n- openstack-tox-py35 http://logs.openstack.org/36/543136/3/check/openstack-tox-py35/2b8fd08/ : SUCCESS in 3m 57s\n- build-openstack-sphinx-docs http://logs.openstack.org/36/543136/3/check/build-openstack-sphinx-docs/ef99f70/html/ : SUCCESS in 3m 24s\n- zunclient-devstack-docker-sql http://logs.openstack.org/36/543136/3/check/zunclient-devstack-docker-sql/f8afc70/ : SUCCESS in 33m 07s","accounts_in_message":[],"_revision_number":3},{"id":"da6eabf536cc1818e56795fb2c7f1bd38468ea5b","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2018-03-06 03:08:16.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"7af00d23c77aa2f1a37a434f544f2cceb6fa8526","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-28 09:34:39.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"d5bdc1446f32c59ca035183cfe3044e7028e6308","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-28 10:12:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"609296415bd42ebd860a55f27c8aeb210d140430","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-28 10:12:32.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/36/543136/3/gate/openstack-tox-pep8/a8ecd26/ : SUCCESS in 4m 10s\n- openstack-tox-py27 http://logs.openstack.org/36/543136/3/gate/openstack-tox-py27/1c466b9/ : SUCCESS in 4m 20s\n- openstack-tox-py35 http://logs.openstack.org/36/543136/3/gate/openstack-tox-py35/2164620/ : SUCCESS in 4m 22s\n- build-openstack-sphinx-docs http://logs.openstack.org/36/543136/3/gate/build-openstack-sphinx-docs/00059d1/html/ : SUCCESS in 3m 50s\n- zunclient-devstack-docker-sql http://logs.openstack.org/36/543136/3/gate/zunclient-devstack-docker-sql/7de3a12/ : SUCCESS in 34m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/36/543136/3/gate/openstack-tox-lower-constraints/52dc86d/ : SUCCESS in 5m 52s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e911859388d5a6b05dbd0857a70b225ba219b732","revisions":{"0c6e3d9fab3c9c94c48c8ce80c42d0c5a0fba11c":{"kind":"REWORK","_number":1,"created":"2018-02-10 19:33:06.000000000","uploader":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"ref":"refs/changes/36/543136/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/36/543136/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/1"}}},"commit":{"parents":[{"commit":"2f77408bcf28dbe51bf535042b06a2416d5a5c12","subject":"Merge \"Update python-zunclient README.rst\u0027s url links\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/2f77408bcf28dbe51bf535042b06a2416d5a5c12"}]}],"author":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-02-10 19:31:10.000000000","tz":0},"committer":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-02-10 19:31:10.000000000","tz":0},"subject":"[WIP] Avoid empty values in \u0027mounts\u0027 options","message":"[WIP] Avoid empty values in \u0027mounts\u0027 options\n\nChange-Id: Ic073098c8cd30bbf7e477c22bbdc59cb6f6bd18f\nCloses-Bug: #1747282\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/0c6e3d9fab3c9c94c48c8ce80c42d0c5a0fba11c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/0c6e3d9fab3c9c94c48c8ce80c42d0c5a0fba11c"}]},"branch":"refs/heads/master"},"51f2a088e74543ae2b7e3cdfcc22f8a0565ca0bb":{"kind":"REWORK","_number":2,"created":"2018-02-10 20:18:18.000000000","uploader":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"ref":"refs/changes/36/543136/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/36/543136/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/2"}}},"commit":{"parents":[{"commit":"f5b6fed1572a441f1a287f1e4bf7644a374fe749","subject":"Add assertions for container arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/f5b6fed1572a441f1a287f1e4bf7644a374fe749"}]}],"author":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-02-10 19:31:10.000000000","tz":0},"committer":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-02-10 20:18:11.000000000","tz":0},"subject":"Avoid empty values in \u0027mounts\u0027 options","message":"Avoid empty values in \u0027mounts\u0027 options\n\nThe python-zunclient sends the \u0027mounts\u0027 parameter to server\nin one of the following forms:\n1. {\u0027source\u0027: xxx, \u0027destination\u0027: xxx, \u0027size\u0027: \u0027\u0027}\n2. {\u0027size\u0027: xxx, \u0027destination\u0027: xxx, \u0027source\u0027: \u0027\u0027}\n\nThis patch changes it to:\n1. {\u0027source\u0027: xxx, \u0027destination\u0027: xxx}\n2. {\u0027size\u0027: xxx, \u0027destination\u0027: xxx}\n\nThe new form doesn\u0027t contain a key with empty string value.\nThis allows a better validation on the server side in the\nfuture.\n\nChange-Id: Ic073098c8cd30bbf7e477c22bbdc59cb6f6bd18f\nCloses-Bug: #1747282\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/51f2a088e74543ae2b7e3cdfcc22f8a0565ca0bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/51f2a088e74543ae2b7e3cdfcc22f8a0565ca0bb"}]},"branch":"refs/heads/master"},"e911859388d5a6b05dbd0857a70b225ba219b732":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-03-05 03:32:35.000000000","uploader":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"ref":"refs/changes/36/543136/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/36/543136/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/36/543136/3"}}},"commit":{"parents":[{"commit":"5d14879c822e8d3ffd5cdc9360a8e8ae1d2ae680","subject":"Add assertions for container arguments","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/5d14879c822e8d3ffd5cdc9360a8e8ae1d2ae680"}]}],"author":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-02-10 19:31:10.000000000","tz":0},"committer":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-03-05 03:32:35.000000000","tz":0},"subject":"Avoid empty values in \u0027mounts\u0027 options","message":"Avoid empty values in \u0027mounts\u0027 options\n\nThe python-zunclient sends the \u0027mounts\u0027 parameter to server\nin one of the following forms:\n1. {\u0027source\u0027: xxx, \u0027destination\u0027: xxx, \u0027size\u0027: \u0027\u0027}\n2. {\u0027size\u0027: xxx, \u0027destination\u0027: xxx, \u0027source\u0027: \u0027\u0027}\n\nThis patch changes it to:\n1. {\u0027source\u0027: xxx, \u0027destination\u0027: xxx}\n2. {\u0027size\u0027: xxx, \u0027destination\u0027: xxx}\n\nThe new form doesn\u0027t contain a key with empty string value.\nThis allows a better validation on the server side in the\nfuture.\n\nChange-Id: Ic073098c8cd30bbf7e477c22bbdc59cb6f6bd18f\nCloses-Bug: #1747282\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/e911859388d5a6b05dbd0857a70b225ba219b732"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/e911859388d5a6b05dbd0857a70b225ba219b732"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}