)]}'
{"id":"openstack%2Fpython-zunclient~549669","triplet_id":"openstack%2Fpython-zunclient~master~Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17","project":"openstack/python-zunclient","branch":"master","hashtags":[],"change_id":"Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17","subject":"Avoid empty values in \u0027nets\u0027 options","status":"MERGED","created":"2018-03-05 03:49:58.000000000","updated":"2019-02-20 04:44:04.000000000","submitted":"2018-03-10 23:51:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"549669-1520725914364-7c7d7e8b","meta_rev_id":"cd34f199f1d966ac3eea1f1ab3918853e280a46f","_number":549669,"virtual_id_number":549669,"owner":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-03-10 22:42:39.000000000","_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":0,"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":2,"date":"2018-03-10 23:51:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"recommended":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":1,"date":"2018-03-07 03:01:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":2,"date":"2018-03-10 09:04:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":2,"date":"2018-03-06 03:07:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-03-07 03:01:18.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"all":[{"value":0,"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"value":1,"date":"2018-03-10 09:04:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"value":0,"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-06 03:07:49.000000000","updated_by":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"reviewer":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"state":"REVIEWER"},{"updated":"2018-03-07 03:01:18.000000000","updated_by":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"reviewer":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"state":"REVIEWER"},{"updated":"2018-03-07 03:01:49.000000000","updated_by":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"reviewer":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"state":"REVIEWER"},{"updated":"2018-03-10 09:04:24.000000000","updated_by":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"reviewer":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"state":"REVIEWER"},{"updated":"2018-03-10 23:51:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"936ebafc840c05faf148f06b03dd7b416a18031b","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-03-05 03:49:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fee1a891f89c13143bc8b69ff54fafae5e002968","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-05 04:33:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/549669/1/check/openstack-tox-pep8/901578a/ : SUCCESS in 3m 54s\n- openstack-tox-py27 http://logs.openstack.org/69/549669/1/check/openstack-tox-py27/a4e3fb0/ : SUCCESS in 4m 26s\n- openstack-tox-py35 http://logs.openstack.org/69/549669/1/check/openstack-tox-py35/4241c72/ : SUCCESS in 3m 43s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/549669/1/check/build-openstack-sphinx-docs/f2f7492/html/ : SUCCESS in 4m 57s\n- zunclient-devstack-docker-sql http://logs.openstack.org/69/549669/1/check/zunclient-devstack-docker-sql/1a8738a/ : SUCCESS in 37m 59s","accounts_in_message":[],"_revision_number":1},{"id":"35efa52428c2029f6d4d6113a0e896e95871d9d1","author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"date":"2018-03-06 03:07:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ce0d53612c60068439a76af44123ce2d068e20f4","author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"date":"2018-03-07 03:01:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"437f0d11bd941e73ce879fadcdc7c4f4f483bfff","author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"date":"2018-03-07 03:01:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"da61a48494c2a0156db77ce8992696ad67a18ba0","author":{"_account_id":23365,"name":"feng.shengqin","email":"feng.shengqin@zte.com.cn","username":"FengShengqin"},"date":"2018-03-10 09:04:24.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4994afe23cad6b897719e12bd9d49e0326bac20d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-10 09:04:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dfd51f171de42723397ad0bcd044d2a9cff6afe2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-10 09:38:38.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/69/549669/1/gate/openstack-tox-pep8/ab29162/ : SUCCESS in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/69/549669/1/gate/openstack-tox-py27/64110c9/ : SUCCESS in 3m 19s\n- openstack-tox-py35 http://logs.openstack.org/69/549669/1/gate/openstack-tox-py35/ef8e326/ : SUCCESS in 3m 40s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/549669/1/gate/build-openstack-sphinx-docs/20aa414/html/ : SUCCESS in 3m 46s\n- zunclient-devstack-docker-sql http://logs.openstack.org/69/549669/1/gate/zunclient-devstack-docker-sql/4bf5a50/ : FAILURE in 33m 14s","accounts_in_message":[],"_revision_number":1},{"id":"f6a3adc8f9e075a401e1ee0729d8aef147f2f70b","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2018-03-10 22:42:39.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"2abe25a6ec3ab4136ba71f1d0ebb1734af74935e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-10 23:19:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/549669/1/check/openstack-tox-pep8/e544cfc/ : SUCCESS in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/69/549669/1/check/openstack-tox-py27/56fa6a3/ : SUCCESS in 4m 16s\n- openstack-tox-py35 http://logs.openstack.org/69/549669/1/check/openstack-tox-py35/d1aed0a/ : SUCCESS in 4m 44s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/549669/1/check/build-openstack-sphinx-docs/2888dd0/html/ : SUCCESS in 3m 04s\n- zunclient-devstack-docker-sql http://logs.openstack.org/69/549669/1/check/zunclient-devstack-docker-sql/a280c42/ : SUCCESS in 35m 39s","accounts_in_message":[],"_revision_number":1},{"id":"6a57ba38d69337c7a159d8e5e8ebc5f6d61e9bc8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-10 23:19:26.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e0647a4fae4027398787c400383d0faedfe3ed66","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-10 23:51:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/69/549669/1/gate/openstack-tox-pep8/9c38e49/ : SUCCESS in 3m 47s\n- openstack-tox-py27 http://logs.openstack.org/69/549669/1/gate/openstack-tox-py27/e39ed3c/ : SUCCESS in 4m 09s\n- openstack-tox-py35 http://logs.openstack.org/69/549669/1/gate/openstack-tox-py35/ccb7849/ : SUCCESS in 4m 02s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/549669/1/gate/build-openstack-sphinx-docs/d2264fa/html/ : SUCCESS in 3m 42s\n- zunclient-devstack-docker-sql http://logs.openstack.org/69/549669/1/gate/zunclient-devstack-docker-sql/70b5281/ : SUCCESS in 30m 50s","accounts_in_message":[],"_revision_number":1},{"id":"18cfb2e7b54eaf007f232f2fdfc8d0f53a8f6d6c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-10 23:51:54.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"cd34f199f1d966ac3eea1f1ab3918853e280a46f","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2019-02-20 04:44:04.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit e89a40fd0381ef02e8c7fc6160d0540396179e8e","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4bc01dfb7fc07bc9f20e3f62d2b2f72a15e79081","revisions":{"4bc01dfb7fc07bc9f20e3f62d2b2f72a15e79081":{"kind":"REWORK","_number":1,"created":"2018-03-05 03:49:58.000000000","uploader":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"ref":"refs/changes/69/549669/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/69/549669/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/69/549669/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/69/549669/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/69/549669/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/69/549669/1"}}},"commit":{"parents":[{"commit":"c95b0d4c02065fa959dcd70ce6860128c7dbb576","subject":"Merge \"Don\u0027t display \u0027Created At\u0027 for service\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/c95b0d4c02065fa959dcd70ce6860128c7dbb576"}]}],"author":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-03-05 03:46:28.000000000","tz":0},"committer":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-03-05 03:46:28.000000000","tz":0},"subject":"Avoid empty values in \u0027nets\u0027 options","message":"Avoid empty values in \u0027nets\u0027 options\n\nThe python-zunclient sends the \u0027nets\u0027 parameter to server\nwith empty string. For example:\n* {\u0027network\u0027: xxx, \u0027port\u0027: \u0027\u0027, \u0027v4-fixed-ip\u0027: \u0027\u0027, \u0027v6-fixed-ip\u0027: \u0027\u0027}\n* {\u0027network\u0027: \u0027\u0027, \u0027port\u0027: xxx, \u0027v4-fixed-ip\u0027: \u0027\u0027, \u0027v6-fixed-ip\u0027: \u0027\u0027}\n\nThis patch changes it to:\n* {\u0027network\u0027: xxx}\n* {\u0027port\u0027: xxx}\n\nThe new form doesn\u0027t contain a key with empty string value.\nThis allows a better validation on the server side in the\nfuture.\n\nChange-Id: Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/4bc01dfb7fc07bc9f20e3f62d2b2f72a15e79081"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/4bc01dfb7fc07bc9f20e3f62d2b2f72a15e79081"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}