)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"6f67a2ba6d5fe0da286ac925799b5bd6ea7126e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add network-create to python-zunclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now, Zunclient supported network create."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I2b1e21b098dabf668f37558a2e7c2cc776002b9c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_ea719445","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":40},"updated":"2018-05-14 10:33:26.000000000","message":"Can you update the commit message with more description.?","commit_id":"76dc618bdcf1fbc62472fbb27104e2d37954bfa8"}],"zunclient/v1/network.py":[{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"5bf11791605eedd9e26cba6dbbb07ff38f78297d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from zunclient.common import base"},{"line_number":14,"context_line":"from zunclient.common import utils"},{"line_number":15,"context_line":"from zunclient import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class Network(base.Resource):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_217a0924","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":0},"updated":"2018-05-03 10:09:33.000000000","message":"2 blank lines are enough.","commit_id":"c175b2daaa6ece826868091104687221111898b0"}],"zunclient/v1/network_shell.py":[{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"7c6927379e61b60b64b254b0e25a79e81d2d338f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from zunclient.common import cliutils as utils"},{"line_number":14,"context_line":"from zunclient.common import utils as zun_utils"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def _show_image(image):"},{"line_number":18,"context_line":"    utils.print_dict(image._info)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@utils.arg(\u0027image\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_ff0fdc2a","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":33},"updated":"2018-04-26 04:25:52.000000000","message":"can you describe what is the purpose of this here ?","commit_id":"1777a7aa8176e8e1be56bb9e58d398f8d9e4569a"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"7c6927379e61b60b64b254b0e25a79e81d2d338f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"def _show_image(image):"},{"line_number":18,"context_line":"    utils.print_dict(image._info)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@utils.arg(\u0027image\u0027,"},{"line_number":22,"context_line":"           metavar\u003d\u0027\u003cimage\u003e\u0027,"},{"line_number":23,"context_line":"           help\u003d\u0027Name of the image\u0027)"},{"line_number":24,"context_line":"def do_pull(cs, args):"},{"line_number":25,"context_line":"    \"\"\"Pull an image.\"\"\""},{"line_number":26,"context_line":"    opts \u003d {}"},{"line_number":27,"context_line":"    opts[\u0027repo\u0027] \u003d args.image"},{"line_number":28,"context_line":"    _show_image(cs.images.create(**opts))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@utils.arg(\u0027--neutron-net\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_bf15e43e","line":28,"range":{"start_line":20,"start_character":0,"end_line":28,"end_character":41},"updated":"2018-04-26 04:25:52.000000000","message":"ditto","commit_id":"1777a7aa8176e8e1be56bb9e58d398f8d9e4569a"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"4a1c4cd530d71062f179019a4f2a0798e6ea212f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net_id"},{"line_number":29,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":30,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":31,"context_line":"    images \u003d cs.network.create(**opts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2191a953","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":10},"updated":"2018-05-03 10:12:37.000000000","message":"where are you using this variable?","commit_id":"ab65ebfcbb59ac71f8b24e257b984be5e5584416"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"5bf11791605eedd9e26cba6dbbb07ff38f78297d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net_id"},{"line_number":29,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":30,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":31,"context_line":"    networks \u003d cs.network.create(**opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e1a89178","line":31,"range":{"start_line":31,"start_character":15,"end_line":31,"end_character":40},"updated":"2018-05-03 10:09:33.000000000","message":"This is enough, we don\u0027t have to store it in a variable.","commit_id":"c175b2daaa6ece826868091104687221111898b0"},{"author":{"_account_id":25695,"name":"Deepak Mourya","email":"deepakmoriya7@gmail.com","username":"deepak_mourya"},"change_message_id":"6000dd4d0104d6f1a7ba11b734bd34df140b0cb6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net_id"},{"line_number":29,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":30,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":31,"context_line":"    networks \u003d cs.network.create(**opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_613fa1d6","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":12},"updated":"2018-05-03 10:38:19.000000000","message":"Still \u0027networks\u0027 variable value is not used anywhere.","commit_id":"48ca65e9d7e07e21a2f1387e18c2ddbfac334588"}],"zunclient/v1/networks.py":[{"author":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"change_message_id":"4fef21548c1e99c825c7f075cc921776fb8fe44c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            return \u0027/v1/networks/\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create(self, **kwargs):"},{"line_number":37,"context_line":"        new \u003d {}"},{"line_number":38,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":39,"context_line":"            if key in CREATION_ATTRIBUTES:"},{"line_number":40,"context_line":"                new[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_0f208bf6","line":37,"updated":"2018-05-15 04:43:32.000000000","message":"can you write small doc string explaining this function","commit_id":"3ba93a294c81cd9554956d60b03f984781e22248"},{"author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"change_message_id":"94a0d43e04827514b2248783a72463b1596d68ec","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            return \u0027/v1/networks/\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create(self, **kwargs):"},{"line_number":37,"context_line":"        new \u003d {}"},{"line_number":38,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":39,"context_line":"            if key in CREATION_ATTRIBUTES:"},{"line_number":40,"context_line":"                new[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ef68aff5","line":37,"in_reply_to":"5f7c97a3_0f208bf6","updated":"2018-05-15 04:57:35.000000000","message":"this is obvious. don\u0027t need add comments in this function.","commit_id":"3ba93a294c81cd9554956d60b03f984781e22248"},{"author":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"change_message_id":"6548c058806f266e973e0301a72f65270fb32c76","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            return \u0027/v1/networks/\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create(self, **kwargs):"},{"line_number":37,"context_line":"        new \u003d {}"},{"line_number":38,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":39,"context_line":"            if key in CREATION_ATTRIBUTES:"},{"line_number":40,"context_line":"                new[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_4f62030c","line":37,"in_reply_to":"5f7c97a3_ef68aff5","updated":"2018-05-15 05:08:22.000000000","message":"This is a common thing to follow OpenStack coding standards!\nBecause for common user its always better to give some explanation for easy understanding. I hope this provide you reason for my comment.","commit_id":"3ba93a294c81cd9554956d60b03f984781e22248"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e4d93deaf4c0a8606898b3c28a23c4235ebaf7a6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            return \u0027/v1/networks/\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create(self, **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Create a new networks\"\"\""},{"line_number":38,"context_line":"        new \u003d {}"},{"line_number":39,"context_line":"        for (key, value) in kwargs.items():"},{"line_number":40,"context_line":"            if key in CREATION_ATTRIBUTES:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_00f4f953","line":37,"range":{"start_line":37,"start_character":23,"end_line":37,"end_character":32},"updated":"2018-07-06 10:25:32.000000000","message":"s/networks/network/","commit_id":"bb9bd8ca9b30945abf0042736ae7caa14684a8d2"}],"zunclient/v1/networks_shell.py":[{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"ece2e80ad9fa5d3dfd840e7e0bb66ec6548183dc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    utils.print_dict(network._info)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@utils.arg(\u0027--neutron-net-id\u0027,"},{"line_number":22,"context_line":"           metavar\u003d\u0027\u003cneutron_net_id\u003e\u0027,"},{"line_number":23,"context_line":"           default\u003dNone,"},{"line_number":24,"context_line":"           help\u003d\u0027Name or UUID of the neutron private network.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_ea041d17","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":29},"updated":"2018-05-15 05:12:43.000000000","message":"I think \"--neutron-net\" would be good argument, as in help section you are mentioning that it can accept Name or UUID of neutron net, so using \"--neutron-net-id\" might confuse user in using \"neutron-network uuid\" only","commit_id":"3ba93a294c81cd9554956d60b03f984781e22248"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"953af838f66f92cbce397eb54cc6b977e09cc106","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def do_network_create(cs, args):"},{"line_number":30,"context_line":"    \"\"\"Create a zun network.\"\"\""},{"line_number":31,"context_line":"    opts \u003d {}"},{"line_number":32,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net"},{"line_number":33,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":34,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":35,"context_line":"    _show_network(cs.networks.create(**opts))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_44766540","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":25},"updated":"2018-05-15 08:07:53.000000000","message":"Change this as well.","commit_id":"a853f00f3182def963bf36b9c40d75e8e33f96a7"},{"author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"change_message_id":"e8e1cd4a3c34da27a68642dd59f9e5d6051b19b7","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def do_network_create(cs, args):"},{"line_number":30,"context_line":"    \"\"\"Create a zun network.\"\"\""},{"line_number":31,"context_line":"    opts \u003d {}"},{"line_number":32,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net"},{"line_number":33,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":34,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":35,"context_line":"    _show_network(cs.networks.create(**opts))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_c4fef569","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":25},"in_reply_to":"5f7c97a3_44766540","updated":"2018-05-15 08:10:53.000000000","message":"yes, i notice this, \u0027neutron_net_id\u0027 is consistent with service side. so this should not be changed.","commit_id":"a853f00f3182def963bf36b9c40d75e8e33f96a7"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"f4956080fed4e87b789b71c0804b152baa87fb72","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def do_network_create(cs, args):"},{"line_number":30,"context_line":"    \"\"\"Create a zun network.\"\"\""},{"line_number":31,"context_line":"    opts \u003d {}"},{"line_number":32,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net"},{"line_number":33,"context_line":"    opts[\u0027name\u0027] \u003d args.name"},{"line_number":34,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":35,"context_line":"    _show_network(cs.networks.create(**opts))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_87fb1fbf","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":25},"in_reply_to":"5f7c97a3_c4fef569","updated":"2018-05-15 08:32:32.000000000","message":"It looks good then.","commit_id":"a853f00f3182def963bf36b9c40d75e8e33f96a7"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8275165e3dd9aeb7c516fa5411c1d94bbe83c647","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@utils.arg(\u0027--neutron-net\u0027,"},{"line_number":22,"context_line":"           metavar\u003d\u0027\u003cneutron_net\u003e\u0027,"},{"line_number":23,"context_line":"           default\u003dNone,"},{"line_number":24,"context_line":"           help\u003d\u0027Name or UUID of the neutron private network.\u0027)"},{"line_number":25,"context_line":"@utils.arg(\u0027--name\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_b11a3e7a","line":22,"updated":"2018-05-30 03:25:18.000000000","message":"I think neutron_net should be a mandatory parameter so we need to add a \u0027required\u0027 argument and set it to true.\n\n@utils.arg(\u0027--neutron-net\u0027,\n           metavar\u003d\u0027\u003cneutron_net\u003e\u0027,\n           required\u003dTrue,\n           ...","commit_id":"bb9bd8ca9b30945abf0042736ae7caa14684a8d2"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e4d93deaf4c0a8606898b3c28a23c4235ebaf7a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@utils.arg(\u0027--neutron-net\u0027,"},{"line_number":22,"context_line":"           metavar\u003d\u0027\u003cneutron_net\u003e\u0027,"},{"line_number":23,"context_line":"           default\u003dNone,"},{"line_number":24,"context_line":"           help\u003d\u0027Name or UUID of the neutron private network.\u0027)"},{"line_number":25,"context_line":"@utils.arg(\u0027--name\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_809d690a","line":22,"in_reply_to":"5f7c97a3_b11a3e7a","updated":"2018-07-06 10:25:32.000000000","message":"+1","commit_id":"bb9bd8ca9b30945abf0042736ae7caa14684a8d2"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"8275165e3dd9aeb7c516fa5411c1d94bbe83c647","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@utils.arg(\u0027--neutron-net\u0027,"},{"line_number":22,"context_line":"           metavar\u003d\u0027\u003cneutron_net\u003e\u0027,"},{"line_number":23,"context_line":"           default\u003dNone,"},{"line_number":24,"context_line":"           help\u003d\u0027Name or UUID of the neutron private network.\u0027)"},{"line_number":25,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":26,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_910f0287","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":24},"updated":"2018-05-30 03:25:18.000000000","message":"If neutron-net is a mandatory parameter, we don\u0027t need to specify the default value in here.","commit_id":"bb9bd8ca9b30945abf0042736ae7caa14684a8d2"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e4d93deaf4c0a8606898b3c28a23c4235ebaf7a6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"           type\u003dstr,"},{"line_number":28,"context_line":"           help\u003d\u0027Name of the network to be created\u0027)"},{"line_number":29,"context_line":"def do_network_create(cs, args):"},{"line_number":30,"context_line":"    \"\"\"Create a zun network.\"\"\""},{"line_number":31,"context_line":"    opts \u003d {}"},{"line_number":32,"context_line":"    opts[\u0027neutron_net_id\u0027] \u003d args.neutron_net"},{"line_number":33,"context_line":"    opts[\u0027name\u0027] \u003d args.name"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_c0c041e3","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":19},"updated":"2018-07-06 10:25:32.000000000","message":"s/zun/Neutron/","commit_id":"bb9bd8ca9b30945abf0042736ae7caa14684a8d2"}],"zunclient/v1/shell.py":[{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"c3d3b46d08c0a6a4f4595b8a483f37ac5be30a65","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from zunclient.v1 import images_shell"},{"line_number":20,"context_line":"from zunclient.v1 import services_shell"},{"line_number":21,"context_line":"from zunclient.v1 import versions_shell"},{"line_number":22,"context_line":"from zunclient.v1 import network_shell"},{"line_number":23,"context_line":"COMMAND_MODULES \u003d ["},{"line_number":24,"context_line":"    containers_shell,"},{"line_number":25,"context_line":"    images_shell,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_0f4a8654","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":38},"updated":"2018-05-04 04:16:32.000000000","message":"move this to line 20","commit_id":"48ca65e9d7e07e21a2f1387e18c2ddbfac334588"},{"author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"change_message_id":"c3d3b46d08c0a6a4f4595b8a483f37ac5be30a65","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from zunclient.v1 import services_shell"},{"line_number":21,"context_line":"from zunclient.v1 import versions_shell"},{"line_number":22,"context_line":"from zunclient.v1 import network_shell"},{"line_number":23,"context_line":"COMMAND_MODULES \u003d ["},{"line_number":24,"context_line":"    containers_shell,"},{"line_number":25,"context_line":"    images_shell,"},{"line_number":26,"context_line":"    services_shell,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_2f47424e","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":19},"updated":"2018-05-04 04:16:32.000000000","message":"need a blank line before this","commit_id":"48ca65e9d7e07e21a2f1387e18c2ddbfac334588"}]}