)]}'
{"zunclient/v1/containers_shell.py":[{"author":{"_account_id":23517,"name":"chenyb4","email":"cybing4@gmail.com","username":"Yuanbin.Chen"},"change_message_id":"ab0179e1b7636a2191e5712f449af18a74303098","unresolved":false,"context_lines":[{"line_number":859,"context_line":"    \"\"\"Detach a network from the container.\"\"\""},{"line_number":860,"context_line":"    opts \u003d {}"},{"line_number":861,"context_line":"    opts[\u0027container\u0027] \u003d args.container"},{"line_number":862,"context_line":"    opts[\u0027network\u0027] \u003d args.network"},{"line_number":863,"context_line":"    opts[\u0027port\u0027] \u003d args.port"},{"line_number":864,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":865,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b227bb12","line":862,"updated":"2018-06-11 03:59:59.000000000","message":"Here only need port or network.\nLook the server patch:\nhttps://review.openstack.org/#/c/574124/1/zun/api/controllers/v1/containers.py","commit_id":"bb36935f1169129735c8ec9225ec08d01c44561e"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"84d7d6cfbc3266ea9e012490539d997e281fe919","unresolved":false,"context_lines":[{"line_number":859,"context_line":"    \"\"\"Detach a network from the container.\"\"\""},{"line_number":860,"context_line":"    opts \u003d {}"},{"line_number":861,"context_line":"    opts[\u0027container\u0027] \u003d args.container"},{"line_number":862,"context_line":"    opts[\u0027network\u0027] \u003d args.network"},{"line_number":863,"context_line":"    opts[\u0027port\u0027] \u003d args.port"},{"line_number":864,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":865,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_31d06ef7","line":862,"in_reply_to":"5f7c97a3_b227bb12","updated":"2018-06-12 02:58:36.000000000","message":"Right. I uploaded a revision to make network and port mutual exclusive. Done.","commit_id":"bb36935f1169129735c8ec9225ec08d01c44561e"},{"author":{"_account_id":23517,"name":"chenyb4","email":"cybing4@gmail.com","username":"Yuanbin.Chen"},"change_message_id":"b0959ab0bee17dfd21d03b06bdbba0d42f7901dd","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    \"\"\"Detach a network from the container.\"\"\""},{"line_number":864,"context_line":"    opts \u003d {}"},{"line_number":865,"context_line":"    opts[\u0027container\u0027] \u003d args.container"},{"line_number":866,"context_line":"    opts[\u0027network\u0027] \u003d args.network"},{"line_number":867,"context_line":"    opts[\u0027port\u0027] \u003d args.port"},{"line_number":868,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":869,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_91b86275","line":866,"updated":"2018-06-12 03:21:25.000000000","message":"if args.network:\n    opts[\u0027network\u0027] \u003d args.network\nelif args.port:\n    opts[\u0027port\u0027] \u003d args.port","commit_id":"bce797c5f32cbbd8e6c89ba27e1e7bae1b5882e4"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"6cde851b77c68c8ba2300819cb9df834b3d1f772","unresolved":false,"context_lines":[{"line_number":863,"context_line":"    \"\"\"Detach a network from the container.\"\"\""},{"line_number":864,"context_line":"    opts \u003d {}"},{"line_number":865,"context_line":"    opts[\u0027container\u0027] \u003d args.container"},{"line_number":866,"context_line":"    opts[\u0027network\u0027] \u003d args.network"},{"line_number":867,"context_line":"    opts[\u0027port\u0027] \u003d args.port"},{"line_number":868,"context_line":"    opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":869,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_84680221","line":866,"in_reply_to":"5f7c97a3_91b86275","updated":"2018-06-13 02:36:52.000000000","message":"I tried to use \"@utils.exclusive_arg\" to achieve the same result. The decorator will ensure that \u0027network\u0027 and \u0027port\u0027 are mutual exclusive. Then, either \u0027network\u0027 or \u0027port\u0027 is set and line #868 will remove the options that are not set.","commit_id":"bce797c5f32cbbd8e6c89ba27e1e7bae1b5882e4"}]}