)]}'
{"zunclient/common/utils.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c0c718f24d624501a1da2a3e59a9adc8e3989ac4","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"def _convert_healthcheck_para(time, err_msg):"},{"line_number":308,"context_line":"    ret \u003d 0"},{"line_number":309,"context_line":"    if \u0027s\u0027 in time:"},{"line_number":310,"context_line":"        ret \u003d int(time.split(\u0027s\u0027)[0])"},{"line_number":311,"context_line":"    elif not ret and \u0027m\u0027 in time:"},{"line_number":312,"context_line":"        ret \u003d int(time.split(\u0027m\u0027)[0]) * 60"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6f046a7c","line":309,"range":{"start_line":309,"start_character":7,"end_line":309,"end_character":18},"updated":"2018-08-04 18:27:05.000000000","message":"It is better to check if \u0027s\u0027 is at the end of time. For example, \u002710s\u0027 is valid but \u00271s0\u0027 is invalid.","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"5a50845c48142149addff432281b1242de96a2d0","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"def _convert_healthcheck_para(time, err_msg):"},{"line_number":308,"context_line":"    ret \u003d 0"},{"line_number":309,"context_line":"    if \u0027s\u0027 in time:"},{"line_number":310,"context_line":"        ret \u003d int(time.split(\u0027s\u0027)[0])"},{"line_number":311,"context_line":"    elif not ret and \u0027m\u0027 in time:"},{"line_number":312,"context_line":"        ret \u003d int(time.split(\u0027m\u0027)[0]) * 60"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_69d0e3ca","line":309,"range":{"start_line":309,"start_character":7,"end_line":309,"end_character":18},"in_reply_to":"3f79a3b5_6f046a7c","updated":"2018-08-06 02:31:23.000000000","message":"Yes, it is better to use endswith() to judge. Maybe it can be  matched strictly by re.","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c0c718f24d624501a1da2a3e59a9adc8e3989ac4","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        ret \u003d int(time.split(\u0027m\u0027)[0]) * 60"},{"line_number":313,"context_line":"    elif not ret and \u0027h\u0027 in time:"},{"line_number":314,"context_line":"        ret \u003d int(time.split(\u0027h\u0027)[0]) * 3600"},{"line_number":315,"context_line":"    else:"},{"line_number":316,"context_line":"        raise apiexec.CommandError(err_msg)"},{"line_number":317,"context_line":"    return ret"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4fff2e67","line":315,"range":{"start_line":315,"start_character":4,"end_line":315,"end_character":8},"updated":"2018-08-04 18:27:05.000000000","message":"A suggestion. What do you think if we add support for default time unit as second. For example:\n\n  --healthcheck cmd\u003d\u003c...\u003e,interval\u003d1\n\nThen, the interval would be 1 second, which is the same as:\n\n  --healthcheck cmd\u003d\u003c...\u003e,interval\u003d1s","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"5a50845c48142149addff432281b1242de96a2d0","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        ret \u003d int(time.split(\u0027m\u0027)[0]) * 60"},{"line_number":313,"context_line":"    elif not ret and \u0027h\u0027 in time:"},{"line_number":314,"context_line":"        ret \u003d int(time.split(\u0027h\u0027)[0]) * 3600"},{"line_number":315,"context_line":"    else:"},{"line_number":316,"context_line":"        raise apiexec.CommandError(err_msg)"},{"line_number":317,"context_line":"    return ret"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ac836956","line":315,"range":{"start_line":315,"start_character":4,"end_line":315,"end_character":8},"in_reply_to":"3f79a3b5_4fff2e67","updated":"2018-08-06 02:31:23.000000000","message":"Maybe it can be handled by re.","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"}],"zunclient/osc/v1/containers.py":[{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c0c718f24d624501a1da2a3e59a9adc8e3989ac4","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        opts[\u0027disk\u0027] \u003d parsed_args.disk"},{"line_number":224,"context_line":"        opts[\u0027availability_zone\u0027] \u003d parsed_args.availability_zone"},{"line_number":225,"context_line":"        opts[\u0027auto_heal\u0027] \u003d parsed_args.auto_heal"},{"line_number":226,"context_line":"        opts[\u0027healthcheck\u0027] \u003d zun_utils.parse_health(parsed_args.healthcheck)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":229,"context_line":"        container \u003d client.containers.create(**opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4fb16ee1","line":226,"range":{"start_line":226,"start_character":65,"end_line":226,"end_character":76},"updated":"2018-08-04 18:27:05.000000000","message":"To make python-zunclient work with older version of zun server (i.e. stable/queens, stable/pike), we would like to avoid sending \u0027healthcheck\u0027 to server if it is unspecified (because \u0027healthcheck\u0027 is not supported in legacy server). In particular, I suggest to do this instead (UNTESTED):\n\n  if parsed_args.healthcheck:\n      opts[\u0027healthcheck\u0027] \u003d zun_utils.parse_health(parsed_args.healthcheck)","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"},{"author":{"_account_id":23829,"name":"weikeyou","email":"wei.keyou@zte.com.cn","username":"weikeyou"},"change_message_id":"5a50845c48142149addff432281b1242de96a2d0","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        opts[\u0027disk\u0027] \u003d parsed_args.disk"},{"line_number":224,"context_line":"        opts[\u0027availability_zone\u0027] \u003d parsed_args.availability_zone"},{"line_number":225,"context_line":"        opts[\u0027auto_heal\u0027] \u003d parsed_args.auto_heal"},{"line_number":226,"context_line":"        opts[\u0027healthcheck\u0027] \u003d zun_utils.parse_health(parsed_args.healthcheck)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":229,"context_line":"        container \u003d client.containers.create(**opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2c975993","line":226,"range":{"start_line":226,"start_character":65,"end_line":226,"end_character":76},"in_reply_to":"3f79a3b5_4fb16ee1","updated":"2018-08-06 02:31:23.000000000","message":"Thank you for your good suggestion.","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"c0c718f24d624501a1da2a3e59a9adc8e3989ac4","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        opts[\u0027disk\u0027] \u003d parsed_args.disk"},{"line_number":856,"context_line":"        opts[\u0027availability_zone\u0027] \u003d parsed_args.availability_zone"},{"line_number":857,"context_line":"        opts[\u0027auto_heal\u0027] \u003d parsed_args.auto_heal"},{"line_number":858,"context_line":"        opts[\u0027healthcheck\u0027] \u003d zun_utils.parse_health(parsed_args.healthcheck)"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        opts \u003d zun_utils.remove_null_parms(**opts)"},{"line_number":861,"context_line":"        container \u003d client.containers.run(**opts)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6fb6aadc","line":858,"range":{"start_line":858,"start_character":14,"end_line":858,"end_character":25},"updated":"2018-08-04 18:27:05.000000000","message":"Ditto. Avoid setting \u0027healthcheck\u0027 if it is unspecified.","commit_id":"52b1acfa93489c626814b113e9db8bb200a29a90"}]}