)]}'
{"id":"openstack%2Fpython-zunclient~638078","triplet_id":"openstack%2Fpython-zunclient~stable%2Fqueens~Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17","project":"openstack/python-zunclient","branch":"stable/queens","hashtags":[],"change_id":"Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17","subject":"Avoid empty values in \u0027nets\u0027 options","status":"ABANDONED","created":"2019-02-20 04:44:04.000000000","updated":"2019-02-23 21:05:11.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4caae8a1da975d90411b5d88b3b93a3a3fb0d7e1","_number":638078,"virtual_id_number":638078,"owner":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":1,"date":"2019-02-20 05:25:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"all":[{"value":-1,"date":"2019-02-20 04:50:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-20 05:25:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cf21e421f615f2d18b33a8ffe753f00fcf17e050","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2019-02-20 04:44:04.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"eea24614902c484f2de670552f0c751b4f70f8ea","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2019-02-20 04:50:50.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"92449d2fbb462f513d103da24ef174ff778244f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-20 05:25:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/78/638078/1/check/openstack-tox-pep8/5362a41/ : SUCCESS in 4m 48s\n- openstack-tox-py27 http://logs.openstack.org/78/638078/1/check/openstack-tox-py27/e1008c5/ : SUCCESS in 4m 21s\n- openstack-tox-py35 http://logs.openstack.org/78/638078/1/check/openstack-tox-py35/8664d82/ : SUCCESS in 4m 52s\n- build-openstack-sphinx-docs http://logs.openstack.org/78/638078/1/check/build-openstack-sphinx-docs/b4ff8d3/html/ : SUCCESS in 5m 20s\n- zunclient-devstack-docker-sql http://logs.openstack.org/78/638078/1/check/zunclient-devstack-docker-sql/819693c/ : SUCCESS in 34m 12s","accounts_in_message":[],"_revision_number":1},{"id":"4caae8a1da975d90411b5d88b3b93a3a3fb0d7e1","author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"date":"2019-02-23 21:05:11.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e89a40fd0381ef02e8c7fc6160d0540396179e8e","revisions":{"e89a40fd0381ef02e8c7fc6160d0540396179e8e":{"kind":"REWORK","_number":1,"created":"2019-02-20 04:44:04.000000000","uploader":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"ref":"refs/changes/78/638078/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-zunclient","ref":"refs/changes/78/638078/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/78/638078/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/78/638078/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-zunclient refs/changes/78/638078/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-zunclient refs/changes/78/638078/1"}}},"commit":{"parents":[{"commit":"20ede94ab07dbee0c667d1e26c10ce16ed835de0","subject":"Merge \"Allow wss as websocket protocol\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/20ede94ab07dbee0c667d1e26c10ce16ed835de0"}]}],"author":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2018-03-05 03:46:28.000000000","tz":0},"committer":{"name":"Hongbin Lu","email":"hongbin034@gmail.com","date":"2019-02-20 04:44:04.000000000","tz":0},"subject":"Avoid empty values in \u0027nets\u0027 options","message":"Avoid empty values in \u0027nets\u0027 options\n\nThe python-zunclient sends the \u0027nets\u0027 parameter to server\nwith empty string. For example:\n* {\u0027network\u0027: xxx, \u0027port\u0027: \u0027\u0027, \u0027v4-fixed-ip\u0027: \u0027\u0027, \u0027v6-fixed-ip\u0027: \u0027\u0027}\n* {\u0027network\u0027: \u0027\u0027, \u0027port\u0027: xxx, \u0027v4-fixed-ip\u0027: \u0027\u0027, \u0027v6-fixed-ip\u0027: \u0027\u0027}\n\nThis patch changes it to:\n* {\u0027network\u0027: xxx}\n* {\u0027port\u0027: xxx}\n\nThe new form doesn\u0027t contain a key with empty string value.\nThis allows a better validation on the server side in the\nfuture.\n\nChange-Id: Iebb3ddb53e5e9d31175e6e7eeb170a66a8630a17\n(cherry picked from commit 4bc01dfb7fc07bc9f20e3f62d2b2f72a15e79081)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/e89a40fd0381ef02e8c7fc6160d0540396179e8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-zunclient/commit/e89a40fd0381ef02e8c7fc6160d0540396179e8e"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}