)]}'
{"specs/consistent-service-method-names.rst":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"79fb888a03a732502f00da1c19e9dcabe51cf2ca","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Naming rule: \"delete_\u003cresource name\u003e\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"There are two patterns for deletion method, \"delete_\u003cresource name\u003e\" and"},{"line_number":67,"context_line":"\"remove_\u003cresource name\u003e\". The count of \"delete_\u003cresource name\u003e\" is 72, and"},{"line_number":68,"context_line":"the one of the other is 11. In addition, \"delete_\u003cresource name\u003e\" is simple"},{"line_number":69,"context_line":"name because it is the same as HTTP method."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa963961_9ce504aa","line":67,"updated":"2015-03-27 06:15:23.000000000","message":"I don\u0027t understand the meaning of these \u0027count\u0027. So how about s/count/number? And I feel adding the explanation of this word is better.\n\nOr how about like this? (overkill?)\n\n   method name               # of methods\n -------------------------------------------------------------\n delete_\u003cresource_name\u003e   72\n remove_\u003cresource_name\u003e   11","commit_id":"78d7d5ea12b684e6bbd2bed3e4b35ed62e94c110"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"86b0b545d386713c424459addbef9b861a3d3b17","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Naming rule: \"delete_\u003cresource name\u003e\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"There are two patterns for deletion method, \"delete_\u003cresource name\u003e\" and"},{"line_number":67,"context_line":"\"remove_\u003cresource name\u003e\". The count of \"delete_\u003cresource name\u003e\" is 72, and"},{"line_number":68,"context_line":"the one of the other is 11. In addition, \"delete_\u003cresource name\u003e\" is simple"},{"line_number":69,"context_line":"name because it is the same as HTTP method."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da9b358b_5e9c1b69","line":67,"in_reply_to":"fa963961_9ce504aa","updated":"2015-03-29 22:48:39.000000000","message":"thanks for your comment, number is better as you said.\nI will change them.","commit_id":"78d7d5ea12b684e6bbd2bed3e4b35ed62e94c110"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e4be35a15aa3dbb8ebc8d640023ca52f2b0432ba","unresolved":false,"context_lines":[{"line_number":102,"context_line":"are get_hypervisor_list_details and get_availability_zone_list_detail now."},{"line_number":103,"context_line":"This spec proposes all \"GET /resources/detail\" should be named to"},{"line_number":104,"context_line":"\"list_detail_of_\u003cresource name\u003es\" for clarifying the meanings."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa963961_6a36e004","line":105,"updated":"2015-03-27 14:51:41.000000000","message":"I\u0027m curious what we do for compound methods. I think some of the clients have helper methods to do more than one call. Is there any guidance there? How do those interact with the proposed hacking rule? Would it make sense to split those out into a separte file?","commit_id":"78d7d5ea12b684e6bbd2bed3e4b35ed62e94c110"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"86b0b545d386713c424459addbef9b861a3d3b17","unresolved":false,"context_lines":[{"line_number":102,"context_line":"are get_hypervisor_list_details and get_availability_zone_list_detail now."},{"line_number":103,"context_line":"This spec proposes all \"GET /resources/detail\" should be named to"},{"line_number":104,"context_line":"\"list_detail_of_\u003cresource name\u003es\" for clarifying the meanings."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Implementation"},{"line_number":107,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da9b358b_feaacf84","line":105,"in_reply_to":"fa963961_6a36e004","updated":"2015-03-29 22:48:39.000000000","message":"a helper method is interesting idea, does that means for example:\n\n list_availability_zones(self, detail\u003dFalse):\n     url \u003d \u0027os-availability-zone\u0027\n     if detail:\n         url +\u003d \u0027/detail\u0027\n     resp, body \u003d self.get(url)\n     ...\n\nSo we don\u0027t need to create special methods for these detail APIs.\nIs this the same as your idea?\nIf so, I will apply it to the next spec.","commit_id":"78d7d5ea12b684e6bbd2bed3e4b35ed62e94c110"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e4be35a15aa3dbb8ebc8d640023ca52f2b0432ba","unresolved":false,"context_lines":[{"line_number":127,"context_line":"----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Rename service clients\u0027 methods based on this proposal."},{"line_number":130,"context_line":"* Add hacking rules based on this proposal."}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa963961_2a40d855","line":130,"updated":"2015-03-27 14:51:41.000000000","message":"I think we need details on exactly what the hacking check will be enforcing in the proposed change section","commit_id":"78d7d5ea12b684e6bbd2bed3e4b35ed62e94c110"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"86b0b545d386713c424459addbef9b861a3d3b17","unresolved":false,"context_lines":[{"line_number":127,"context_line":"----------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"* Rename service clients\u0027 methods based on this proposal."},{"line_number":130,"context_line":"* Add hacking rules based on this proposal."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da9b358b_9e92a356","line":130,"in_reply_to":"fa963961_2a40d855","updated":"2015-03-29 22:48:39.000000000","message":"Oh, nice point.\nOK, I will try to write checks on the next spec.","commit_id":"78d7d5ea12b684e6bbd2bed3e4b35ed62e94c110"}]}