)]}'
{"specs/rest-clients-return-obj.rst":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"681051cfc97a9e14cfc1a025c9b697bfd86bf8b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"-----------------"},{"line_number":18,"context_line":"Create a single object return from our rest clients. Embed the"},{"line_number":19,"context_line":"httplib2.Response as the ``resp`` attribute of this new response"},{"line_number":20,"context_line":"object."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Map __getattr__ to make a call into the dictionary for that object, so"},{"line_number":23,"context_line":"that we\u0027d have code that looks like follows::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F%2FS%2FI%3D","line":20,"updated":"2014-03-18 19:47:06.000000000","message":"Since we haven\u0027t actually mandated unit tests for this sort of thing yet, maybe we should mention it here because it will be required .(hopefully after summit)","commit_id":"a290798bef8652f89498ed24ad51d6a803888f60"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"681051cfc97a9e14cfc1a025c9b697bfd86bf8b7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"object."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Map __getattr__ to make a call into the dictionary for that object, so"},{"line_number":23,"context_line":"that we\u0027d have code that looks like follows::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  resp \u003d self.client.assign_user_role_on_project("},{"line_number":26,"context_line":"      self.project[\u0027id\u0027], self.user_body[\u0027id\u0027], self.role[\u0027id\u0027])"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F%2FS%2Fc%3D","line":23,"updated":"2014-03-18 19:47:06.000000000","message":"So the getattr will handle the response side of things, but what about the body then. Is there a way we can do this as a backwards compatible change? (at least at first) That way we can iterate over updating all the client calls. Or were you thinking this would be a monolithic all at once sort of thing.","commit_id":"a290798bef8652f89498ed24ad51d6a803888f60"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"681051cfc97a9e14cfc1a025c9b697bfd86bf8b7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Map __getattr__ to make a call into the dictionary for that object, so"},{"line_number":23,"context_line":"that we\u0027d have code that looks like follows::"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  resp \u003d self.client.assign_user_role_on_project("},{"line_number":26,"context_line":"      self.project[\u0027id\u0027], self.user_body[\u0027id\u0027], self.role[\u0027id\u0027])"},{"line_number":27,"context_line":"  self.assertEqual(resp.status, \u0027204\u0027)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F%2FTBY%3D","line":25,"updated":"2014-03-18 19:47:06.000000000","message":"I\u0027m fine with this change, I\u0027m not sure it really makes it cleaner though. Also review fun will ensue, how many client calls are made in the api tests? Is the benefit really worth the review effort?","commit_id":"a290798bef8652f89498ed24ad51d6a803888f60"}]}