)]}'
{"specs/nova-api-test-inheritance.rst":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ab591bc2f971d93285da578ea5807c97296a88e2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  of BaseV2ComputeTest/BaseV3ComputeTest. The class instance can switch its"},{"line_number":48,"context_line":"  behavior based on some variable which represents an API version."},{"line_number":49,"context_line":"  After applying this common class to every API test classes, the existing"},{"line_number":50,"context_line":"  BaseV2ComputeTest and BaseV3ComputeTest can be removed."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"(2) Make each v2 test class inherit the v3 test class"},{"line_number":53,"context_line":"  We need to change v3 test classes\u0027 inheritances to the common base test class"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FynI%3D","line":50,"updated":"2014-04-10 11:48:28.000000000","message":"I would actually like to move as much as possible out of the class hierarchy directly and into mixins (static methods that we call outside of the hierarch). I think we\u0027re using the class hierarchy for things that can be addressed better with mixins.","commit_id":"8979b52c01a331387a82a3ea7dc1710a06ecf58d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"70cd22205d9d7a485b002ea68f3ce523ad62b39b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  of BaseV2ComputeTest/BaseV3ComputeTest. The class instance can switch its"},{"line_number":48,"context_line":"  behavior based on some variable which represents an API version."},{"line_number":49,"context_line":"  After applying this common class to every API test classes, the existing"},{"line_number":50,"context_line":"  BaseV2ComputeTest and BaseV3ComputeTest can be removed."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"(2) Make each v2 test class inherit the v3 test class"},{"line_number":53,"context_line":"  We need to change v3 test classes\u0027 inheritances to the common base test class"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Frug%3D","line":50,"in_reply_to":"AAAAW3%2F%2FynI%3D","updated":"2014-04-11 06:52:50.000000000","message":"I also agree to reducing the class hierarchy as possible.\nI guess this your comment means the line 55 should be\n\n [v2 test class] - [v3 test class] - [CommonComputeTest]\n\nwithout [BaseComputeTest], right?\nIf so, I agree. and will remove it.","commit_id":"8979b52c01a331387a82a3ea7dc1710a06ecf58d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ab591bc2f971d93285da578ea5807c97296a88e2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  and change v2 test classes\u0027 inheritances to v3 test class:"},{"line_number":55,"context_line":"    [v2 test class] - [v3 test class] - [CommonComputeTest] - [BaseComputeTest]"},{"line_number":56,"context_line":"  In v2 test class, the variable which represents an API version should be \"2\","},{"line_number":57,"context_line":"  and the variable should be \"3\" in v3 test class."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"(3) Change the Nova API test directory structure"},{"line_number":60,"context_line":"  Current the test directory structure is:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Fylk%3D","line":57,"updated":"2014-04-10 11:48:28.000000000","message":"I like this idea that old API inherits from new API, as that would let us remove old API down the road more easily.\n\nHow are you supposing we handle differences in the API? I\u0027m a little concerned that is going to get somewhat complicated.\n\nAlso can you provide a good code snippet demonstrating a case where this is going to work?","commit_id":"8979b52c01a331387a82a3ea7dc1710a06ecf58d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"70cd22205d9d7a485b002ea68f3ce523ad62b39b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  and change v2 test classes\u0027 inheritances to v3 test class:"},{"line_number":55,"context_line":"    [v2 test class] - [v3 test class] - [CommonComputeTest] - [BaseComputeTest]"},{"line_number":56,"context_line":"  In v2 test class, the variable which represents an API version should be \"2\","},{"line_number":57,"context_line":"  and the variable should be \"3\" in v3 test class."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"(3) Change the Nova API test directory structure"},{"line_number":60,"context_line":"  Current the test directory structure is:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Frr0%3D","line":57,"in_reply_to":"AAAAW3%2F%2Fylk%3D","updated":"2014-04-11 06:52:50.000000000","message":"nice point, some v2/v3 specific API tests will be necessary and we cannot apply this way to these test cases. In this case, the hierarchy would be\n\n [v2 test class] - [CommonComputeTest]\n [v3 test class] - [CommonComputeTest]\n\nand these test files would be stored to\n\n tempest/api/compute/v2/\n tempest/api/compute/v3/","commit_id":"8979b52c01a331387a82a3ea7dc1710a06ecf58d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ab591bc2f971d93285da578ea5807c97296a88e2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    tempest/api/compute/v3/ : v3 API specific test files"},{"line_number":70,"context_line":"  The test files which can be inherited with the way(2) will be stored to"},{"line_number":71,"context_line":"  \"tempest/api/compute/\". Otherwise, the files will be stored to the specific"},{"line_number":72,"context_line":"  directories."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FymU%3D","line":72,"updated":"2014-04-10 11:48:28.000000000","message":"100% agree, I actually think we should do the move first, as we should be able to approve that in a single patch. Then we can do the extract from the new directory structure.","commit_id":"8979b52c01a331387a82a3ea7dc1710a06ecf58d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":".."},{"line_number":7,"context_line":"  This template should be in ReSTructured text. The filename in the git"},{"line_number":8,"context_line":"  repository should match the launchpad URL, for example a URL of"},{"line_number":9,"context_line":"  https://blueprints.launchpad.net/tempest/+spec/awesome-thing should be named"},{"line_number":10,"context_line":"  awesome-thing.rst .  Please do not delete any of the sections in this"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg9I%3D","line":7,"updated":"2014-04-14 03:21:11.000000000","message":"You don\u0027t need this section.","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":".."},{"line_number":7,"context_line":"  This template should be in ReSTructured text. The filename in the git"},{"line_number":8,"context_line":"  repository should match the launchpad URL, for example a URL of"},{"line_number":9,"context_line":"  https://blueprints.launchpad.net/tempest/+spec/awesome-thing should be named"},{"line_number":10,"context_line":"  awesome-thing.rst .  Please do not delete any of the sections in this"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYbc%3D","line":7,"in_reply_to":"AAAAW3%2F%2Fg9I%3D","updated":"2014-04-15 01:23:42.000000000","message":"Done","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":" Improve Nova API test maintenancebility"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"https://blueprints.launchpad.net/tempest/+spec/nova-api-test-inheritance"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg9M%3D","line":16,"updated":"2014-04-14 03:21:11.000000000","message":"I\u0027m not sure that maintenancebility is an English word, I think that serviceability is the correct word here.\n\nAlthough, I think maintenancebility should be an English word it makes sense to me.","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":" Improve Nova API test maintenancebility"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"https://blueprints.launchpad.net/tempest/+spec/nova-api-test-inheritance"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYbI%3D","line":16,"in_reply_to":"AAAAW3%2F%2Fg9M%3D","updated":"2014-04-15 01:23:42.000000000","message":"Thanks,  serviceability is a nice word. I will apply it.","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":39,"context_line":"2. Make each v2 test class inherit the v3 test class"},{"line_number":40,"context_line":"3. Change the Nova API test directory structure"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"1. Create common base test class"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  Now each Nova API test class inherits like:"},{"line_number":45,"context_line":"    [v2 test class] - [BaseV2ComputeTest] - [BaseComputeTest]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg7g%3D","line":42,"updated":"2014-04-14 03:21:11.000000000","message":"I think using subsections here would make this a bit clearer:\nhttp://sphinx-doc.org/rest.html#sections","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"2. Make each v2 test class inherit the v3 test class"},{"line_number":40,"context_line":"3. Change the Nova API test directory structure"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"1. Create common base test class"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  Now each Nova API test class inherits like:"},{"line_number":45,"context_line":"    [v2 test class] - [BaseV2ComputeTest] - [BaseComputeTest]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYaY%3D","line":42,"in_reply_to":"AAAAW3%2F%2Fg7g%3D","updated":"2014-04-15 01:23:42.000000000","message":"Done","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":42,"context_line":"1. Create common base test class"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  Now each Nova API test class inherits like:"},{"line_number":45,"context_line":"    [v2 test class] - [BaseV2ComputeTest] - [BaseComputeTest]"},{"line_number":46,"context_line":"    [v3 test class] - [BaseV3ComputeTest] - [BaseComputeTest]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  To share API test classes, we need to create common base test class instead"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg6A%3D","line":45,"updated":"2014-04-14 03:21:11.000000000","message":"You should probably use \u0027-\u003e\u0027 to make it clear which direction the inheritance   is. It\u0027d be really cool if you used the graphviz sphinx module here:\n\nhttp://sphinx-doc.org/ext/graphviz.html\n\nbut that would be going above and beyond, just using \u0027-\u003e\u0027 is fine.\n\n(this is true for all the inheritance uses below too)","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"1. Create common base test class"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  Now each Nova API test class inherits like:"},{"line_number":45,"context_line":"    [v2 test class] - [BaseV2ComputeTest] - [BaseComputeTest]"},{"line_number":46,"context_line":"    [v3 test class] - [BaseV3ComputeTest] - [BaseComputeTest]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  To share API test classes, we need to create common base test class instead"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYaA%3D","line":45,"in_reply_to":"AAAAW3%2F%2Fg6A%3D","updated":"2014-04-15 01:23:42.000000000","message":"Done","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    [v2 test class] - [v3 test class] - [CommonComputeTest]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  In v2 test class, the variable which represents an API version should be \"2\","},{"line_number":62,"context_line":"  and the variable should be \"3\" in v3 test class."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"3. Change the Nova API test directory structure"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg7A%3D","line":62,"updated":"2014-04-14 03:21:11.000000000","message":"I think having an example test class here would make this clearer. I get what your going for but for someone not as familiar with the test class structure a simple code example would be good.","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    [v2 test class] - [v3 test class] - [CommonComputeTest]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  In v2 test class, the variable which represents an API version should be \"2\","},{"line_number":62,"context_line":"  and the variable should be \"3\" in v3 test class."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"3. Change the Nova API test directory structure"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYW0%3D","line":62,"in_reply_to":"AAAAW3%2F%2Fg7A%3D","updated":"2014-04-15 01:23:42.000000000","message":"Nice point. I will add some sample class code here.","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  This structure is not understandable, and it is better to move v2 API test"},{"line_number":71,"context_line":"  files to some directory which shows v2\u0027s one clearly."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  This blueprint proposes to change the structure to:"},{"line_number":74,"context_line":"    tempest/api/compute/    : common test files"},{"line_number":75,"context_line":"    tempest/api/compute/v2/ : v2 API specific test files"},{"line_number":76,"context_line":"    tempest/api/compute/v3/ : v3 API specific test files"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg8o%3D","line":73,"updated":"2014-04-14 03:21:11.000000000","message":"I\u0027d use double \u0027:\u0027 here so the block will be offset. A table might also make sense:\n\nhttp://sphinx-doc.org/rest.html#source-code","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  This structure is not understandable, and it is better to move v2 API test"},{"line_number":71,"context_line":"  files to some directory which shows v2\u0027s one clearly."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  This blueprint proposes to change the structure to:"},{"line_number":74,"context_line":"    tempest/api/compute/    : common test files"},{"line_number":75,"context_line":"    tempest/api/compute/v2/ : v2 API specific test files"},{"line_number":76,"context_line":"    tempest/api/compute/v3/ : v3 API specific test files"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYXs%3D","line":73,"in_reply_to":"AAAAW3%2F%2Fg8o%3D","updated":"2014-04-15 01:23:42.000000000","message":"Nice advice. Thanks","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"cd49d7c594ab1f5e4823e56d478c4859c03cb471","unresolved":false,"context_lines":[{"line_number":102,"context_line":"----------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Target Milestone for completion:"},{"line_number":105,"context_line":"  Juno-1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2Fg80%3D","line":105,"updated":"2014-04-14 03:21:11.000000000","message":"How much manual effort is required for this? Do you think J2 is more realistic here?","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f317936586add51505e4eb139eca5e48c946ab0a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"----------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Target Milestone for completion:"},{"line_number":105,"context_line":"  Juno-1"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"Work Items"},{"line_number":108,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"AAAAW3%2F%2FYYQ%3D","line":105,"in_reply_to":"AAAAW3%2F%2Fg80%3D","updated":"2014-04-15 01:23:42.000000000","message":"Nice catch. Juno-2 is better as you said, because this work requires a lot of patches due to nova API tests.","commit_id":"8b869fde456b8358de985036cba3bb0fa7596652"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3ffdc797a52851c5ca728946ff920f2ea0dc8baa","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"Improve Nova API test serviceability"}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAAXH%2F%2FgY0%3D","line":8,"updated":"2014-04-21 05:11:26.000000000","message":"A blank comment?","commit_id":"0b94929d69e205ce3c9a60a6057111e8dd37bb8d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"436f765757df7dffc420b3a13183856a68cddff8","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":"Improve Nova API test serviceability"}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAAXH%2F%2FgV0%3D","line":8,"in_reply_to":"AAAAXH%2F%2FgY0%3D","updated":"2014-04-21 05:35:01.000000000","message":"Sorry, I am not sure this comment.\nDoes it mean a new blank line?\n\nThis is the same as the merged specs(specs/config-verification.rst, etc).","commit_id":"0b94929d69e205ce3c9a60a6057111e8dd37bb8d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3ffdc797a52851c5ca728946ff920f2ea0dc8baa","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":"1. Create common base test class"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Now each Nova API test class inherits like:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAAXH%2F%2FgZM%3D","line":39,"updated":"2014-04-21 05:11:26.000000000","message":"You should probably use \u0027---\u0027 here to use a subheading here, If you look at the formatted output: \n\nhttp://docs-draft.openstack.org/42/85242/6/check/gate-qa-specs-docs/ea2e18d/doc/build/html/\n\nUsing equals puts it at the same level as the proposed change heading but this is really a subheading.","commit_id":"0b94929d69e205ce3c9a60a6057111e8dd37bb8d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"436f765757df7dffc420b3a13183856a68cddff8","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":38,"context_line":"1. Create common base test class"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Now each Nova API test class inherits like:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAAXH%2F%2FgVs%3D","line":39,"in_reply_to":"AAAAXH%2F%2FgZM%3D","updated":"2014-04-21 05:35:01.000000000","message":"Nice info, the docs-draft is good for checking. Thanks. and I will fix them.","commit_id":"0b94929d69e205ce3c9a60a6057111e8dd37bb8d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3ffdc797a52851c5ca728946ff920f2ea0dc8baa","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":"2. Make each v2 test class inherit the v3 test class"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"We need to change v3 test classes\u0027 inheritances to the common base test class"},{"line_number":57,"context_line":"and change v2 test classes\u0027 inheritances to v3 test class:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAAXH%2F%2FgZI%3D","line":54,"updated":"2014-04-21 05:11:26.000000000","message":"Same here","commit_id":"0b94929d69e205ce3c9a60a6057111e8dd37bb8d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3ffdc797a52851c5ca728946ff920f2ea0dc8baa","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":73,"context_line":"3. Change the Nova API test directory structure"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Current test directory structure is::"},{"line_number":77,"context_line":"  tempest/api/compute/    : v2 API test files"}],"source_content_type":"text/x-rst","patch_set":6,"id":"AAAAXH%2F%2FgYg%3D","line":74,"updated":"2014-04-21 05:11:26.000000000","message":"Here too","commit_id":"0b94929d69e205ce3c9a60a6057111e8dd37bb8d"}]}
