)]}'
{"specs/run-without-admin.rst":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":4,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":".."},{"line_number":7,"context_line":"  This template should be in ReSTructured text. The filename in the git"},{"line_number":8,"context_line":"  repository should match the launchpad URL, for example a URL of"},{"line_number":9,"context_line":"  https://blueprints.launchpad.net/tempest/+spec/awesome-thing should be named"},{"line_number":10,"context_line":"  awesome-thing.rst .  Please do not delete any of the sections in this"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhBg%3D","line":7,"updated":"2014-04-14 02:57:30.000000000","message":"You don\u0027t need this block","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":"Run Tempest skipping tests that require admin creds "},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"https://blueprints.launchpad.net/tempest/+spec/run-without-admin"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhBk%3D","line":16,"updated":"2014-04-14 02:57:30.000000000","message":"Whitespace","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"06045939c07f09e7d9284d8aa3e778d044a8d0cf","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Problem description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Running tempest without admin credentials is an important use case. Right now"},{"line_number":25,"context_line":"this is sort of implemented in that many admin tests are skipped if the admin"},{"line_number":26,"context_line":"credentials in tempest.conf are empty. The problem is that not all tests"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FeWQ%3D","line":23,"updated":"2014-04-14 11:27:01.000000000","message":"I\u0027d like to redo this language somewhat something like:\n\nTempest should run equally well in any OpenStack environment. This includes those where the user running Tempest does not have admin privileges or access to the admin API for various services.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Running tempest without admin credentials is an important use case. Right now"},{"line_number":25,"context_line":"this is sort of implemented in that many admin tests are skipped if the admin"},{"line_number":26,"context_line":"credentials in tempest.conf are empty. The problem is that not all tests"},{"line_number":27,"context_line":"requiring admin creds do this. Also, whether admin tests are run should be"},{"line_number":28,"context_line":"specified with its own flag as we do for enabled features."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhAQ%3D","line":26,"updated":"2014-04-14 02:57:30.000000000","message":"I don\u0027t think the issue is the manner in which we detect whether we have admin creds or not. It\u0027s more that things are inconsistently applied. Which is something that we need to get better about everywhere in tempest, especially if we move to a branchless rolling release.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":25,"context_line":"this is sort of implemented in that many admin tests are skipped if the admin"},{"line_number":26,"context_line":"credentials in tempest.conf are empty. The problem is that not all tests"},{"line_number":27,"context_line":"requiring admin creds do this. Also, whether admin tests are run should be"},{"line_number":28,"context_line":"specified with its own flag as we do for enabled features."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhAM%3D","line":28,"updated":"2014-04-14 02:57:30.000000000","message":"Why? We can just abstract this with a helper/decorator.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"06045939c07f09e7d9284d8aa3e778d044a8d0cf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"credentials in tempest.conf are empty. The problem is that not all tests"},{"line_number":27,"context_line":"requiring admin creds do this. Also, whether admin tests are run should be"},{"line_number":28,"context_line":"specified with its own flag as we do for enabled features."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"1. Add a new config option: DEFAULT.has_admin_creds\u003dTrue"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FeVg%3D","line":29,"updated":"2014-04-14 11:27:01.000000000","message":"How does this handle the tenant isolation problem with non-admin users? I feel like that\u0027s somewhat coupled here, and want to make sure that gets address in Juno as well.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"1. Add a new config option: DEFAULT.has_admin_creds\u003dTrue"},{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhCA%3D","line":32,"updated":"2014-04-14 02:57:30.000000000","message":"This is not needed, we have a separate field for admin credentials which defaults to none. Adding a flag here seems like we are just duplicating effort doesn\u0027t really add anything. Maybe a better help message for the config option would clear up some of the problems you see with things as they are now.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c93d6c2740b60eb98d3ee44df1abd8cb6850292c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"1. Add a new config option: DEFAULT.has_admin_creds\u003dTrue"},{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Fc9M%3D","line":32,"in_reply_to":"AAAAW3%2F%2FdeE%3D","updated":"2014-04-14 14:17:50.000000000","message":"Those are 2 different things, the first is a matter of configuration and the second is a matter of filtering. It\u0027s the same reason we have both service tags and service_available config section. The config file should be used to only specify what tempest can or cannot do Which will determine the set of tests which tempest *can* run. We should avoid using to make determinations about what *should* be run, like running only non-admin tests, in the config file.\n\nRunning only non-admin tests in parallel is pretty easy you just add an exclude regex with admin (or maybe Admin).","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"352e3660afd03e8aa81df0ac67d57d041b069150","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"1. Add a new config option: DEFAULT.has_admin_creds\u003dTrue"},{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FdeE%3D","line":32,"in_reply_to":"AAAAW3%2F%2FhCA%3D","updated":"2014-04-14 13:56:27.000000000","message":"So you are making a different assumption than I was. I was separating the notion of \"does tempest have admin?\" from \"should the admin tests be run\". For example, I don\u0027t see why it should not be possible to run all the non-admin tests, but in parallel.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":"1. Add a new config option: DEFAULT.has_admin_creds\u003dTrue"},{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhBs%3D","line":33,"updated":"2014-04-14 02:57:30.000000000","message":"I see this as making a separate skip decorator that checks to see if admin credentials were set. It makes sense to split the check and the decorator so you can raise skip exceptions inline where decorators don\u0027t make sense.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":32,"context_line":"1. Add a new config option: DEFAULT.has_admin_creds\u003dTrue"},{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhBc%3D","line":35,"updated":"2014-04-14 02:57:30.000000000","message":"This should be use the decorator or helper method to skip tests","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implementation"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Fg%2F4%3D","line":36,"updated":"2014-04-14 02:57:30.000000000","message":"How do you plan to deal with Admin test classes vs regular test classes? Should there be a base Admin test class which does the check in the base setupclass? What files need to be changed?","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c93d6c2740b60eb98d3ee44df1abd8cb6850292c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implementation"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Fc7s%3D","line":36,"in_reply_to":"AAAAW3%2F%2FdKA%3D","updated":"2014-04-14 14:17:50.000000000","message":"Yes, I know, that\u0027s why I was asking. You should outline how you were planning to handle this duplication. I also believe it is inconsistently checked which was part of my reason for bringing it up. You should make it clear how you plan to handle this.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"352e3660afd03e8aa81df0ac67d57d041b069150","unresolved":false,"context_lines":[{"line_number":33,"context_line":"2. Make failure to specify admin creds in tempest.conf fail tempest if the new"},{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implementation"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FdKA%3D","line":36,"in_reply_to":"AAAAW3%2F%2Fg%2F4%3D","updated":"2014-04-14 13:56:27.000000000","message":"Right now this check, when it is being done, is done in each **Admin** base class. We could have a base mixin that did this.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":34,"context_line":" flag is True."},{"line_number":35,"context_line":"3. Use the new flag to skip all tests that fail due to lack of admin creds."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implementation"},{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhA4%3D","line":37,"updated":"2014-04-14 02:57:30.000000000","message":"Another thing that should be part of this is to raise InvalidConfiguration errors for configurations that require admin but don\u0027t specify them. For example, tenant isolation without admin creds at least with v2 auth.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Primary assignee:"},{"line_number":42,"context_line":"  david-kranz"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Milestones"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FhAw%3D","line":42,"updated":"2014-04-14 02:57:30.000000000","message":"So on the other specs we\u0027ve been using the format: Name \u003cemail\u003e here. I realize the template does say launchpad-id, may be we should just update it. I\u0027m not sure which is better. The launchpad-id will be in the linked bp.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7361ad7ea80176d40fd0c786086641707b1f7201","unresolved":false,"context_lines":[{"line_number":46,"context_line":"----------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Target Milestone for completion:"},{"line_number":49,"context_line":"  Juno-1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2Fg%2Fs%3D","line":49,"updated":"2014-04-14 02:57:30.000000000","message":"Is this a realistic goal? I\u0027d like to see it happen by then, but how many individual admin tests need to be updated vs base classes? Depending on how many manual skips are needed I feel like this might be a stretch.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"352e3660afd03e8aa81df0ac67d57d041b069150","unresolved":false,"context_lines":[{"line_number":46,"context_line":"----------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Target Milestone for completion:"},{"line_number":49,"context_line":"  Juno-1"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":2,"id":"AAAAW3%2F%2FdHo%3D","line":49,"in_reply_to":"AAAAW3%2F%2Fg%2Fs%3D","updated":"2014-04-14 13:56:27.000000000","message":"I did an initial run without admin and almost all of the errors were class-based. This was on havana. Master won\u0027t even start running without admin creds because they are now used at import-time by InputScenarioUtils.","commit_id":"a10b544349f5fd927923b0dffe83f2f3b49bc75e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"3aa537bcfc1eeb59929665a7bf2206fd4d02c11e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":"1. Create a new \u0027admin\u0027 service-tag-like decorator and add it to all tests"},{"line_number":44,"context_line":"requiring admin creds."},{"line_number":45,"context_line":"2. Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":46,"context_line":"without admin creds."},{"line_number":47,"context_line":"3. Generate a config error if there are no admin creds"}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAAXH%2F%2FilE%3D","line":44,"updated":"2014-04-19 21:30:13.000000000","message":"On compute API tests, admin setting is operated in BaseV2ComputeAdminTest setUpClass(). and a skipException happens if admin config is not enough as the above \"Problem description\" mentioned.\n\nShould we add \"admin\" tag to all tests which are inherited from BaseV2ComputeAdminTest also? or is it OK to keep them without \"admin\" tag?\n\nMy main concern is we forget to add \"skip\" tag to new admin tests which are from BaseV2ComputeAdminTest, because Tempest already contains a lot of API tests and many developers join to Tempest development now.","commit_id":"ddff31d980f3b78fb6f1e6946a391af577c67838"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"91d947e5eab4ff73ab7521fce66c3dd530231f97","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":"1. Create a new \u0027admin\u0027 service-tag-like decorator and add it to all tests"},{"line_number":44,"context_line":"requiring admin creds."},{"line_number":45,"context_line":"2. Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":46,"context_line":"without admin creds."},{"line_number":47,"context_line":"3. Generate a config error if there are no admin creds"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad9bd40_21c4335e","line":44,"in_reply_to":"9ad9bd40_8789b8cc","updated":"2014-05-03 03:30:21.000000000","message":"Thanks for your explanation, it seems reasonable changes.","commit_id":"ddff31d980f3b78fb6f1e6946a391af577c67838"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"07da9073247c2fe878334348c34a930e65e9ec74","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Proposed change"},{"line_number":42,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":43,"context_line":"1. Create a new \u0027admin\u0027 service-tag-like decorator and add it to all tests"},{"line_number":44,"context_line":"requiring admin creds."},{"line_number":45,"context_line":"2. Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":46,"context_line":"without admin creds."},{"line_number":47,"context_line":"3. Generate a config error if there are no admin creds"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9ad9bd40_8789b8cc","line":44,"in_reply_to":"AAAAXH%2F%2FilE%3D","updated":"2014-05-01 19:42:30.000000000","message":"I expect admin base classes to skip as we do for other services that may or not be present. The admin tag is for individual tests that require admin but are not in a class that skips during setUpClass. As far as forgetting to skip, when this is done we should have a gate job that runs as non-admin to prevent mistakes like this.","commit_id":"ddff31d980f3b78fb6f1e6946a391af577c67838"},{"author":{"_account_id":8434,"name":"Rochelle Grober","email":"rochelle.grober@huawei.com","username":"rockyg"},"change_message_id":"42025f4f22e1b714bc89a814729eb017a59ee75c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Tempest should run equally well in any OpenStack environment. This includes"},{"line_number":18,"context_line":"those where the user running Tempest does not have admin privileges or access"},{"line_number":19,"context_line":"to the admin API for various services. Right now"},{"line_number":20,"context_line":"this is partially implemented in that many admin tests are skipped if the admin"},{"line_number":21,"context_line":"credentials in tempest.conf are empty. The problem is that not all tests"},{"line_number":22,"context_line":"requiring admin creds do this, and there are issues where the basic setup of"},{"line_number":23,"context_line":"tempest fails if there are no admin creds available."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7adec928_cfd942f6","line":20,"updated":"2014-05-21 01:17:03.000000000","message":"Refstack (and I assume Rally) require the ability for a non admin to run tempest tests against various cloud configurations.  You might want to add this to the problem statement.  Currently, all tests that have been spec\u0027ed by Defcore for \"core capabilities\" are supposed to be non-admin, but that doesn\u0027t mean the tests will run without the admin creds.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e02a298698898fef4e8966750e267d820cd61472","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Tempest should run equally well in any OpenStack environment. This includes"},{"line_number":18,"context_line":"those where the user running Tempest does not have admin privileges or access"},{"line_number":19,"context_line":"to the admin API for various services. Right now"},{"line_number":20,"context_line":"this is partially implemented in that many admin tests are skipped if the admin"},{"line_number":21,"context_line":"credentials in tempest.conf are empty. The problem is that not all tests"},{"line_number":22,"context_line":"requiring admin creds do this, and there are issues where the basic setup of"},{"line_number":23,"context_line":"tempest fails if there are no admin creds available."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7adec928_f9c85b77","line":20,"in_reply_to":"7adec928_cfd942f6","updated":"2014-05-22 14:22:52.000000000","message":"All (API) tests which aim to verify admin APIs are stored in \"admin\" folders, so it\u0027s pretty straight-forward to exclude them. However a lot of non-admin tests require admin credentials / access to admin API to prepare the environment for their execution. I expect such tests to be part of \"core capabilities\". The fact that they require admin credentials could be seen as a tempest limitation. For instance tempest could give a public cloud provider the option to prepare required resources before the test run, and then run tempest without admin credentials configured.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da9e2a2ef3742ba90556bcaa19ad252ef3386878","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"devstack should create a domain for tempest to use and create the demo and"},{"line_number":41,"context_line":"alt_demo users/tenants in that domain. It should also create a domain_admin"},{"line_number":42,"context_line":"user/tenant in that domain."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad9bd40_384a7d26","line":42,"updated":"2014-05-05 16:54:36.000000000","message":"I would not assume that demo users and domain admin must be in the same domain. Of course it is a valid combination.\nIn https://review.openstack.org/#/c/81872/ I introduced a domain_name for demo, demo_alt, identity_admin and compute_admin, which allow for having the demo users in their own domain if needed.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":8434,"name":"Rochelle Grober","email":"rochelle.grober@huawei.com","username":"rockyg"},"change_message_id":"42025f4f22e1b714bc89a814729eb017a59ee75c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"user/tenant in that domain."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":"- Generalize the current compute-admin conf to be service-admin."},{"line_number":47,"context_line":"- Add to the identity section: domain_name, domain_admin_username,"},{"line_number":48,"context_line":"  domain_admin_tenant_name, domain_admin_password."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7adec928_2fe1c69a","line":45,"updated":"2014-05-21 01:17:03.000000000","message":"Would it be reasonable to either decorate or otherwise identify (maybe in docstrings if not with tags) the tests with which creds are needed to run the test?","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da9e2a2ef3742ba90556bcaa19ad252ef3386878","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Proposed change"},{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":"- Generalize the current compute-admin conf to be service-admin."},{"line_number":47,"context_line":"- Add to the identity section: domain_name, domain_admin_username,"},{"line_number":48,"context_line":"  domain_admin_tenant_name, domain_admin_password."},{"line_number":49,"context_line":"- Create a new \u0027admin\u0027 service-tag-like decorator with possible variants of"},{"line_number":50,"context_line":"  (default, domain, service) and add it to all tests requiring some kind of"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad9bd40_3867ddea","line":47,"updated":"2014-05-05 16:54:36.000000000","message":"This sounds ok, but perhaps the name should suggest that the domain_name is the that of the domain used for tenant isolation.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da9e2a2ef3742ba90556bcaa19ad252ef3386878","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- Generalize the current compute-admin conf to be service-admin."},{"line_number":47,"context_line":"- Add to the identity section: domain_name, domain_admin_username,"},{"line_number":48,"context_line":"  domain_admin_tenant_name, domain_admin_password."},{"line_number":49,"context_line":"- Create a new \u0027admin\u0027 service-tag-like decorator with possible variants of"},{"line_number":50,"context_line":"  (default, domain, service) and add it to all tests requiring some kind of"},{"line_number":51,"context_line":"  admin creds."},{"line_number":52,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad9bd40_b8bdadb9","line":49,"updated":"2014-05-05 16:54:36.000000000","message":"You may need some work on unit tests for the generator.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da9e2a2ef3742ba90556bcaa19ad252ef3386878","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  domain_admin_tenant_name, domain_admin_password."},{"line_number":49,"context_line":"- Create a new \u0027admin\u0027 service-tag-like decorator with possible variants of"},{"line_number":50,"context_line":"  (default, domain, service) and add it to all tests requiring some kind of"},{"line_number":51,"context_line":"  admin creds."},{"line_number":52,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":53,"context_line":"  without admin creds."},{"line_number":54,"context_line":"- Generate a config error if there are no admin domain creds"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad9bd40_d8243162","line":51,"updated":"2014-05-05 16:54:36.000000000","message":"There is hierarchy among the admins, so it may be that a a test requires multiple admins. The decorator should allow for specifying a list of required admin types.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da9e2a2ef3742ba90556bcaa19ad252ef3386878","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  (default, domain, service) and add it to all tests requiring some kind of"},{"line_number":51,"context_line":"  admin creds."},{"line_number":52,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":53,"context_line":"  without admin creds."},{"line_number":54,"context_line":"- Generate a config error if there are no admin domain creds"},{"line_number":55,"context_line":"  and allow_tenant_isolation\u003dTrue"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad9bd40_58ef41e9","line":53,"updated":"2014-05-05 16:54:36.000000000","message":"https://review.openstack.org/#/c/80246/ will help removing a lot of unnecessary use of the \"default\" admin to get credentials IDs.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da9e2a2ef3742ba90556bcaa19ad252ef3386878","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  without admin creds."},{"line_number":54,"context_line":"- Generate a config error if there are no admin domain creds"},{"line_number":55,"context_line":"  and allow_tenant_isolation\u003dTrue"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Implementation"},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad9bd40_d897d138","line":56,"updated":"2014-05-05 16:54:36.000000000","message":"The demo/alt_demo settings and the domain_admin/tenant_isolation ones are kind of mutually-exclusive. Either we have tenant isolation off and use the demo users, or we have it on, and we need the domain_admin to generate users and tenants, in which case we (mostly) ignore demo/demo_alt. I think it would be nice to make sure demo/alt_demo are not used at all if tenant isolation is on, so we know we don\u0027t need to specify them in the config.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":8434,"name":"Rochelle Grober","email":"rochelle.grober@huawei.com","username":"rockyg"},"change_message_id":"42025f4f22e1b714bc89a814729eb017a59ee75c","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Dependencies"},{"line_number":73,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7adec928_0ffb2a48","line":74,"updated":"2014-05-21 01:17:03.000000000","message":"Refstack is dependent on this spec being implemented.  Are there any security or doc impacts?","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"8904439d407ef9aad7cca11b6990dfceeffa3fc6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Dependencies"},{"line_number":73,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7adec928_01fe9638","line":74,"in_reply_to":"7adec928_0ffb2a48","updated":"2014-05-21 09:08:04.000000000","message":"Not that I can see.","commit_id":"c0a35814c02549c7e3ecd511ee769b9b783bdd0f"},{"author":{"_account_id":8434,"name":"Rochelle Grober","email":"rochelle.grober@huawei.com","username":"rockyg"},"change_message_id":"cdce3b2c18a990d9cf345f15d6001616948c4d29","unresolved":false,"context_lines":[{"line_number":53,"context_line":"alt_demo users/tenants in that domain. It should also create a domain_admin"},{"line_number":54,"context_line":"user/tenant in that domain. devstack should ensure that keystone policy is"},{"line_number":55,"context_line":"properly configured to allow for domain-level administration."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Proposed change"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":"- Generalize the current compute-admin conf to be service-admin."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_06cf122b","line":56,"updated":"2014-06-03 22:58:49.000000000","message":"Forgive me for not having a very deep knowledge of devstack, but this section seems to me to say devstack must be running on any cloud which you want run tests on. For test independence, all setup of the test environment has to be from config files, by hand, by env variables and/or by a gui that does this under the covers. Am I missing something about devstack\u0027s role here?","commit_id":"261b35c8c769c276746b6a510c8ad4813ecb0cf5"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"ab7a9f05e9d8f1f6593130a1d2700d32c67be5ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"alt_demo users/tenants in that domain. It should also create a domain_admin"},{"line_number":54,"context_line":"user/tenant in that domain. devstack should ensure that keystone policy is"},{"line_number":55,"context_line":"properly configured to allow for domain-level administration."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Proposed change"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":59,"context_line":"- Generalize the current compute-admin conf to be service-admin."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ae5cdf2_2c24edad","line":56,"in_reply_to":"1ae5cdf2_06cf122b","updated":"2014-06-03 23:04:50.000000000","message":"Fair enough, it\u0027s not only devstack. \nI think the confusion here comes from the fact that we include here all the work which is required to have this working in the gate as well. \nThe statement above could say that the cloud under test should provide certain accounts /domains.\nThe work to make sure that devstack in particular is compliant with this can be added in the work items below.\nI\u0027ll fix this in the next patch-set.","commit_id":"261b35c8c769c276746b6a510c8ad4813ecb0cf5"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7253321f53b3217d4279034b62b62ce3df4d9e68","unresolved":false,"context_lines":[{"line_number":59,"context_line":"policy is properly configured to allow for domain-level administration."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Tempest shall support the different kind of admins by introducing"},{"line_number":62,"context_line":"configuration and test tagging for service and domain admins."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_943abc96","line":62,"updated":"2014-07-09 21:48:07.000000000","message":"So the thing I\u0027m wondering about is the test tagging part. Right now we handle credentials on a per class basis. We allocate credentials at setupClass and reuse them for each test in the class. We organize our tests with this assumption too. How are you going to handle this by tagging indivdual tests?  Unless the proposal is just to tag the test and not skip based on the decorator.\n\nEither way I think some elaboration on how the test decoration will work is needed.","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"93f4d80d5eec1497146ea82add10ef6f2b030c63","unresolved":false,"context_lines":[{"line_number":59,"context_line":"policy is properly configured to allow for domain-level administration."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Tempest shall support the different kind of admins by introducing"},{"line_number":62,"context_line":"configuration and test tagging for service and domain admins."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Alternatives"},{"line_number":65,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_a16f1d91","line":62,"in_reply_to":"baada198_943abc96","updated":"2014-07-13 15:47:19.000000000","message":"Good point. At the moment we have tests that inherit from and \"Admin\" base class because they test an admin API, so they need admin as main account to run the tests. Other tests they use admin because they need them to setup a precondition or verify a result, while the main test is executed with a regular account. \n\nThe first category of tests is fine having a skip at class level. Where now loading admin credentials causes an InvalidConfiguration exception and thus ERROR, it will instead skip during setup because of a tag at class level, and missing credentials in the configuration.\n\nThe second category would benefit instead of more granularity. A single test that uses admin credentials should not cause the entire class to be skipped.\nThis can be handled via lazy load: required credentials are referred to in the setUpClass like now, but not actually created. The first test using them will trigger the creation (in case of tenant isolation). If all tests which use admin credentials are tagged properly, the request to create the admin credentials will never be triggered.\n\nA completely different approach, perhaps much simpler, could be to forget about the tagging, make credentials properties at class level, and when a test tries to access them, if that result in InvalidConfiguration exception, trigger a skip, for any other kind of exception, let it through and let the test ERROR as it should. \nThe property can cache the InvalidConfiguration result after the first invocation, to be more efficient.\nThis way tests would always be skipped one by one based on what they actually do, and we would not have additional tagging to be maintained.","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7253321f53b3217d4279034b62b62ce3df4d9e68","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  (default, domain, service) and add it to all tests requiring some kind of"},{"line_number":89,"context_line":"  admin creds."},{"line_number":90,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":91,"context_line":"  without admin creds."},{"line_number":92,"context_line":"- Generate a config error if there are no admin domain creds"},{"line_number":93,"context_line":"  and allow_tenant_isolation\u003dTrue, and no pre-created demo users are"},{"line_number":94,"context_line":"  available"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_0659265b","line":91,"updated":"2014-07-09 21:48:07.000000000","message":"So I actually think you can at least start to handle this item and the one before it without the dependencies listed in the section below. So we probably should move them to the top of the list along with the rename compute-admin to service-admin.(which is also independent)","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"93f4d80d5eec1497146ea82add10ef6f2b030c63","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  (default, domain, service) and add it to all tests requiring some kind of"},{"line_number":89,"context_line":"  admin creds."},{"line_number":90,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":91,"context_line":"  without admin creds."},{"line_number":92,"context_line":"- Generate a config error if there are no admin domain creds"},{"line_number":93,"context_line":"  and allow_tenant_isolation\u003dTrue, and no pre-created demo users are"},{"line_number":94,"context_line":"  available"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_56299e99","line":91,"in_reply_to":"baada198_0659265b","updated":"2014-07-13 15:47:19.000000000","message":"ok","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7253321f53b3217d4279034b62b62ce3df4d9e68","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  admin creds."},{"line_number":90,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":91,"context_line":"  without admin creds."},{"line_number":92,"context_line":"- Generate a config error if there are no admin domain creds"},{"line_number":93,"context_line":"  and allow_tenant_isolation\u003dTrue, and no pre-created demo users are"},{"line_number":94,"context_line":"  available"},{"line_number":95,"context_line":"- Extend the identity setup in devstack to match the requirements above"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_e33ee428","line":92,"updated":"2014-07-09 21:48:07.000000000","message":"So we already do this. It\u0027s a bit of a trace to figure out where the exception get\u0027s raised in the call graph. The exception will get raised:\n\nhttp://git.openstack.org/cgit/openstack/tempest/tree/tempest/auth.py#n582\n\nThe way that you\u0027re proposing to refactor should take this into account since the is_valid() method will still handle whether the creds exist in CONF or not.","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"93f4d80d5eec1497146ea82add10ef6f2b030c63","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  admin creds."},{"line_number":90,"context_line":"- Clean up the setup code so that all the tests not marked as admin can run"},{"line_number":91,"context_line":"  without admin creds."},{"line_number":92,"context_line":"- Generate a config error if there are no admin domain creds"},{"line_number":93,"context_line":"  and allow_tenant_isolation\u003dTrue, and no pre-created demo users are"},{"line_number":94,"context_line":"  available"},{"line_number":95,"context_line":"- Extend the identity setup in devstack to match the requirements above"}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_1623a6bd","line":92,"in_reply_to":"baada198_e33ee428","updated":"2014-07-13 15:47:19.000000000","message":"ok","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"7253321f53b3217d4279034b62b62ce3df4d9e68","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Hierarchical multi-tenancy available to service specific, domain level admin"},{"line_number":102,"context_line":"Soft depency to bp:test-accounts. It would be easier to implement test accounts"},{"line_number":103,"context_line":"first and bp:run-withou-admin then."}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_e0c33a88","line":103,"updated":"2014-07-09 21:48:07.000000000","message":"well besides the typo which I don\u0027t really care about.\n\nI\u0027m going to mark this as dependent on test-accounts when it\u0027s ready to merge.","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"93f4d80d5eec1497146ea82add10ef6f2b030c63","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Hierarchical multi-tenancy available to service specific, domain level admin"},{"line_number":102,"context_line":"Soft depency to bp:test-accounts. It would be easier to implement test accounts"},{"line_number":103,"context_line":"first and bp:run-withou-admin then."}],"source_content_type":"text/x-rst","patch_set":8,"id":"baada198_b60f5a38","line":103,"in_reply_to":"baada198_e0c33a88","updated":"2014-07-13 15:47:19.000000000","message":"ok","commit_id":"211dcab2a91d841efe085dff0c64f441ae52e8b2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3e0acdd472a471b748ff1e719debcd3467482946","unresolved":false,"context_lines":[{"line_number":60,"context_line":"credentials from the setUpClass of test classes which are not directly"},{"line_number":61,"context_line":"required for the API under test. For example nova admin tests will define"},{"line_number":62,"context_line":"nova admin credentials in the setup."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We create a test decorator that enable tests to define the type"},{"line_number":65,"context_line":"(and amount?) of additional admin credentials they require."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a890539_0be875b3","line":63,"updated":"2014-11-11 07:26:30.000000000","message":"Class level skip looks fine. I think admin base class does the same https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L389 \n\nFor  test level granularity can we do it in simple way -\n\nFor tests class where not all but some tests need admin cred\n\n- Create admin cred in setUpClass and set the admin_client/cred to \u0027None\u0027 if not available (InvalidConfiguration exception)\n- Tests need admin cred will be skipped if admin_client/cred is None.\n\nAbove approach is simple and we do not need to have logic/decorators for creating admin cred/manager on first request and cleanup those at class teardown level.","commit_id":"4e926a9a70d80a417046ba6c7a237da331ed44c4"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ccc95029a6fda37cc02ad167cf13f1c3ce07cef5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"credentials from the setUpClass of test classes which are not directly"},{"line_number":61,"context_line":"required for the API under test. For example nova admin tests will define"},{"line_number":62,"context_line":"nova admin credentials in the setup."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"We create a test decorator that enable tests to define the type"},{"line_number":65,"context_line":"(and amount?) of additional admin credentials they require."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a890539_6934ce49","line":63,"in_reply_to":"5a890539_0be875b3","updated":"2014-11-18 15:08:44.000000000","message":"+1 on gmann\u0027s idea","commit_id":"4e926a9a70d80a417046ba6c7a237da331ed44c4"},{"author":{"_account_id":7227,"name":"Timur Nurlygayanov","email":"tnurlygayanov@mirantis.com","username":"tnurlygayanov"},"change_message_id":"e8e89795aa219a505cb6e355e8c70ac1807451ef","unresolved":false,"context_lines":[{"line_number":114,"context_line":"----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Target Milestone for completion:"},{"line_number":117,"context_line":"  Juno-2"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Work Items"},{"line_number":120,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"7a8c0949_3ac0f3df","line":117,"updated":"2014-11-05 07:59:06.000000000","message":"probably we need to set Kilo-1 or Kilo-2 here?","commit_id":"4e926a9a70d80a417046ba6c7a237da331ed44c4"}]}