)]}'
{"specs/cinder-v2-api-tests.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c84bdd07bb91f928eacde5ed616593346a2e984d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    [..]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  class SomeApiV1Test(SomeApiV2Test):"},{"line_number":79,"context_line":"    _api_version \u003d 2"},{"line_number":80,"context_line":"    [..]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"4. Change the Cinder API test directory structure"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAXX%2F%2FxFw%3D","line":79,"updated":"2014-04-28 05:36:04.000000000","message":"here should be\n\n _api_version \u003d 1","commit_id":"ec59638608488f7f556b1a145e9fdbd4bd786db1"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"d5668687d1460292fe0ef4666de7b407c062f429","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    [..]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  class SomeApiV1Test(SomeApiV2Test):"},{"line_number":79,"context_line":"    _api_version \u003d 2"},{"line_number":80,"context_line":"    [..]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"4. Change the Cinder API test directory structure"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAXX%2F%2FxCk%3D","line":79,"in_reply_to":"AAAAXX%2F%2FxFw%3D","updated":"2014-04-28 05:56:20.000000000","message":"oops!! Thank you. I\u0027ll fix it in next patch.","commit_id":"ec59638608488f7f556b1a145e9fdbd4bd786db1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b436ad048aa5481322872a55d3104e84b2a32c7e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Tempest don\u0027t have Cinder v2 api test. We need to add tests for it."},{"line_number":23,"context_line":"Cinder v2 api only has some small updates, so v1 and v2 tests could share"},{"line_number":24,"context_line":"service client and test code. In this way, we don\u0027t need to maintain many"},{"line_number":25,"context_line":"duplictate test codes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAAXX%2F%2FxBA%3D","line":22,"updated":"2014-04-28 06:04:31.000000000","message":"Tempest has already contained some API tests for Cinder, so it is better to change here to:\n\n Tempest doesn\u0027t have enough Cinder v2 api tests.\n\none nit is included(don\u0027t -\u003e doesn\u0027t, test -\u003e tests)","commit_id":"cc9ebbaf4f146151f42c77bbbecc9062aae92371"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"02a83e96666057cb9237561fc7f8eb7f6e008b10","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Tempest don\u0027t have Cinder v2 api test. We need to add tests for it."},{"line_number":23,"context_line":"Cinder v2 api only has some small updates, so v1 and v2 tests could share"},{"line_number":24,"context_line":"service client and test code. In this way, we don\u0027t need to maintain many"},{"line_number":25,"context_line":"duplictate test codes."}],"source_content_type":"text/x-rst","patch_set":4,"id":"AAAAXX%2F%2Fv6Y%3D","line":22,"in_reply_to":"AAAAXX%2F%2FxBA%3D","updated":"2014-04-28 09:10:45.000000000","message":"thanks! Done","commit_id":"cc9ebbaf4f146151f42c77bbbecc9062aae92371"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e8152baefeadb0cca1b15ea1fbd39225c24f86b3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* tempest/api/volume/v1/ : v1 API specific test files"},{"line_number":97,"context_line":"* tempest/api/volume/v2/ : v2 API specific test files"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The test files which can be inherited with the way(3) will be stored to"},{"line_number":100,"context_line":"\"tempest/api/volume/\". Otherwise, the hierarchy would be"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* [v1 test class] -\u003e [CommonVolumeTest]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad9bd40_dd9c1612","line":99,"updated":"2014-05-06 01:36:38.000000000","message":"Honestly I feel like this should be under an alternatives section. I realize that this is just based on nova-api-test-inheritance, and it\u0027s the same way there. But, reading this it\u0027s a little confusing I did a double take, thinking this was actually the proposal. (which would be weird because it contradicts everything else in this file)\n\nI\u0027ll go and push a fix for the nova-api spec to be the same way.","commit_id":"8f8895125f435488bf1bbbd4d0aa2aa57f57a215"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"24bbf72e85fd04d69769e4ea694ceb1897267e8f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* tempest/api/volume/v1/ : v1 API specific test files"},{"line_number":97,"context_line":"* tempest/api/volume/v2/ : v2 API specific test files"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The test files which can be inherited with the way(3) will be stored to"},{"line_number":100,"context_line":"\"tempest/api/volume/\". Otherwise, the hierarchy would be"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* [v1 test class] -\u003e [CommonVolumeTest]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad9bd40_fd39daf2","line":99,"in_reply_to":"9ad9bd40_dd9c1612","updated":"2014-05-06 01:43:07.000000000","message":"Oh actually I think this just needs to be cleaned up/reworded a little. I just misread this section of the proposal as this being mutual exclusive to what\u0027s outlined in (3) but it\u0027s actually complementary, for a specific case where there is no shared code.\n\nI think you just need to clearly and explicitly state that this is when there is no shared code between v2 and v3 so the intheritence model from (3) won\u0027t work. This should avoid the confusion like I had just a minute ago. :)","commit_id":"8f8895125f435488bf1bbbd4d0aa2aa57f57a215"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"15c74d4e26cf25a1c30375a43448900b367953b3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"* tempest/api/volume/v1/ : v1 API specific test files"},{"line_number":97,"context_line":"* tempest/api/volume/v2/ : v2 API specific test files"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"The test files which can be inherited with the way(3) will be stored to"},{"line_number":100,"context_line":"\"tempest/api/volume/\". Otherwise, the hierarchy would be"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* [v1 test class] -\u003e [CommonVolumeTest]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad9bd40_35e196fe","line":99,"in_reply_to":"9ad9bd40_fd39daf2","updated":"2014-05-06 07:13:59.000000000","message":"Thank you! I\u0027ll fix it in next patch.","commit_id":"8f8895125f435488bf1bbbd4d0aa2aa57f57a215"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e8152baefeadb0cca1b15ea1fbd39225c24f86b3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- Add common service client for v1 and v2"},{"line_number":130,"context_line":"- Add a common class for Cinder v1/v2 API tests"},{"line_number":131,"context_line":"- Add a common admin class for Cinder v1/v2 API tests"},{"line_number":132,"context_line":"- Share API test classes"},{"line_number":133,"context_line":"  An etherpad to manage the task progress:"},{"line_number":134,"context_line":"  https://etherpad.openstack.org/p/cinder-v2-api-tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad9bd40_bdbe7263","line":132,"updated":"2014-05-06 01:36:38.000000000","message":"I think you should reword this a little to something like:\n\n    Add new test cases using the new shared test classes\n    Using an etherpad to manage the task progress:\n    https://etherpad.openstack.org/p/cinder-v2-api-tests","commit_id":"8f8895125f435488bf1bbbd4d0aa2aa57f57a215"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"15c74d4e26cf25a1c30375a43448900b367953b3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- Add common service client for v1 and v2"},{"line_number":130,"context_line":"- Add a common class for Cinder v1/v2 API tests"},{"line_number":131,"context_line":"- Add a common admin class for Cinder v1/v2 API tests"},{"line_number":132,"context_line":"- Share API test classes"},{"line_number":133,"context_line":"  An etherpad to manage the task progress:"},{"line_number":134,"context_line":"  https://etherpad.openstack.org/p/cinder-v2-api-tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad9bd40_b5ecc6f4","line":132,"in_reply_to":"9ad9bd40_bdbe7263","updated":"2014-05-06 07:13:59.000000000","message":"google docs is a better choice. I\u0027ll reword it and create a google docs to track them. Thanks!","commit_id":"8f8895125f435488bf1bbbd4d0aa2aa57f57a215"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e8152baefeadb0cca1b15ea1fbd39225c24f86b3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"- Add a common admin class for Cinder v1/v2 API tests"},{"line_number":132,"context_line":"- Share API test classes"},{"line_number":133,"context_line":"  An etherpad to manage the task progress:"},{"line_number":134,"context_line":"  https://etherpad.openstack.org/p/cinder-v2-api-tests"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9ad9bd40_bd9752eb","line":134,"updated":"2014-05-06 01:36:38.000000000","message":"Is etherpad the best choice here?\n\nI\u0027m fine with however you guys want to track this. But, I know for some of the nova v3 api work they used google docs spreadsheets to track things and that structured format worked very well for them.","commit_id":"8f8895125f435488bf1bbbd4d0aa2aa57f57a215"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8beb4c429a6abc9d2c2e96da8042f43141cb9c96","unresolved":false,"context_lines":[{"line_number":134,"context_line":"- Add new test cases using the new shared test classes"},{"line_number":135,"context_line":"  Using a google docs spreadsheet to manage the task progress:"},{"line_number":136,"context_line":"  (`cinder_v2_api_tests \u003chttps://docs.google.com/spreadsheets/d/"},{"line_number":137,"context_line":"    1ztFAn1D677zTVBahZB0sLjQkcU2_oIthZ-eRNRHI4LM\u003e`_)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7adec928_1f55e7c5","line":137,"updated":"2014-05-22 13:35:51.000000000","message":"I don\u0027t believe this line compiles correctly with sphinx:\n\nsphinx.errors.SphinxWarning: /git/qa-specs/doc/source/specs/cinder-v2-api-tests.rst:137: ERROR: Unexpected indentation.","commit_id":"64d1da0af55f51ffbf305460731e2a37a743be78"}]}