)]}'
{"specs/minversion-check-for-cli-tests.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0976e0abc9a5b7264e5355b33d807dd1edbd23d3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"----------"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"#. Write the decorator code. Matt Treinish has provided a basic reference:"},{"line_number":78,"context_line":"   http://paste.openstack.org/show/shoB3CNF9pJugIKdLAqx/ "},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"#. Apply the decorator to the CLI tests, with a primary focus on any tests"},{"line_number":81,"context_line":"   added after the 2014.1 Icehouse release, especially for those tests which"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_5384235d","line":78,"updated":"2014-06-13 18:42:07.000000000","message":"oops","commit_id":"7663ad64676866fc41c3dcaad352fa7496bb94a9"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c91ce9b3076843786e0e8c1fa17a7bf89d4ef38e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"packagers/deployers if they are not running CI against trunk levels of code"},{"line_number":51,"context_line":"for the clients. They can reset HEAD for Tempest to some arbitrary commit"},{"line_number":52,"context_line":"around the time of the server release they are testing, e.g. sometime around"},{"line_number":53,"context_line":"the 2014.1 release for stable/icehouse testing, but then they are frozen to"},{"line_number":54,"context_line":"that commit in Tempest and do not get future bug fixes that would have been"},{"line_number":55,"context_line":"backported when there were stable branches for Tempest. The other alternative"},{"line_number":56,"context_line":"is manually excluding the unsupported CLI tests but this is cumbersome and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_538a631b","line":53,"updated":"2014-06-13 18:54:50.000000000","message":"We do have the tempest-1 release which corresponds roughly with icehouse. Tempest-3 will be the next release that lines up with an openstack release (being Juno)","commit_id":"50f5beeb1be54fc739ec95edfe5b3eac5c56054f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"366d7ffdd902afa91f0433ff3b28ff03483c8bfc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"packagers/deployers if they are not running CI against trunk levels of code"},{"line_number":51,"context_line":"for the clients. They can reset HEAD for Tempest to some arbitrary commit"},{"line_number":52,"context_line":"around the time of the server release they are testing, e.g. sometime around"},{"line_number":53,"context_line":"the 2014.1 release for stable/icehouse testing, but then they are frozen to"},{"line_number":54,"context_line":"that commit in Tempest and do not get future bug fixes that would have been"},{"line_number":55,"context_line":"backported when there were stable branches for Tempest. The other alternative"},{"line_number":56,"context_line":"is manually excluding the unsupported CLI tests but this is cumbersome and"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ae5cdf2_13753bf9","line":53,"in_reply_to":"1ae5cdf2_538a631b","updated":"2014-06-13 19:05:57.000000000","message":"OK, didn\u0027t realize that, but it\u0027s a tag that won\u0027t move so still kind of stuck there when we\u0027re talking about backporting bug fixes and things like that.","commit_id":"50f5beeb1be54fc739ec95edfe5b3eac5c56054f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b5cff993959ad3083bf87d52fe61831c7647d966","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator to tempest/test.py that can be used in the tempest/cli"},{"line_number":43,"context_line":"tests for checking that the installed version of the client is at a minimum"},{"line_number":44,"context_line":"version to support the test, otherwise the test is skipped."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e62dc190","line":42,"updated":"2014-06-24 18:57:03.000000000","message":"Well you didn\u0027t actually put it in tempest/test.py but that\u0027s ok :)","commit_id":"e9defe8c99ddaf30c8496a1cd3b746efb3364fe9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21829ba95c8c603ed9a7df23a3c3261356e2b316","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Proposed change"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator to tempest/test.py that can be used in the tempest/cli"},{"line_number":43,"context_line":"tests for checking that the installed version of the client is at a minimum"},{"line_number":44,"context_line":"version to support the test, otherwise the test is skipped."},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_a8daed76","line":42,"in_reply_to":"1ae5cdf2_e62dc190","updated":"2014-06-24 21:21:56.000000000","message":"Derp, I should remove that...","commit_id":"e9defe8c99ddaf30c8496a1cd3b746efb3364fe9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"241e7e230016b1ef0b4fb06037c8db307a02da96","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator to tempest/test.py that can be used in the tempest/cli"},{"line_number":43,"context_line":"tests for checking that the installed version of the client is at a minimum"},{"line_number":44,"context_line":"version to support the test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_8259e9fe","line":44,"updated":"2014-06-14 18:21:22.000000000","message":"Looks like we might need to make the check configurable because a decorated nova client test is being skipped now:\n\nhttp://logs.openstack.org/31/100031/4/check/check-tempest-dsvm-full/e8aba3e/console.html#_2014-06-14_15_06_26_599\n\nThe version in pip-freeze output is a bit weird:\n\n-e git+https://git.openstack.org/openstack/python-novaclient@939cf46efee6913fc361e827640d708dbd497747#egg\u003dpython_novaclient-origin/HEAD\n\nSo I\u0027m thinking we use a tempest config value that defaults to running the version check but put something in devstack that configures tempest to not do the validation check for check/gate runs.","commit_id":"e9defe8c99ddaf30c8496a1cd3b746efb3364fe9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1dd07928da45bce605fe7646de75ce3700ce8b3e","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator to tempest/test.py that can be used in the tempest/cli"},{"line_number":43,"context_line":"tests for checking that the installed version of the client is at a minimum"},{"line_number":44,"context_line":"version to support the test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_62805df7","line":44,"in_reply_to":"1ae5cdf2_8259e9fe","updated":"2014-06-14 18:28:10.000000000","message":"I did run this against our internal stable/icehouse CI and the test was skipped as expected:\n\n[root@rhel62 ~]# nova --version\n2.17.0\n\n\ntempest.cli.simple_read_only.test_nova.SimpleReadOnlyNovaClientTest.test_admin_server_group_list ... SKIP: requires nova client version \u003e\u003d 2.18","commit_id":"e9defe8c99ddaf30c8496a1cd3b746efb3364fe9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a6e8aef07c5cf348eea4f9b69b6047e3a731e93","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator to tempest/test.py that can be used in the tempest/cli"},{"line_number":43,"context_line":"tests for checking that the installed version of the client is at a minimum"},{"line_number":44,"context_line":"version to support the test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_e57eaa1a","line":44,"in_reply_to":"1ae5cdf2_8259e9fe","updated":"2014-06-18 14:04:47.000000000","message":"Maybe rather than a config value in tempest.conf to ignore trunk versions, the code is smart enough to determine a trunk version, i.e. check if the version starts with \"-e git+\" and/or ends with \"origin/HEAD\" and if so, ignore it and assume the version is valid for the test.\n\nAs a test I built python-novaclient from master and this is the version in the egg:\n\nmriedem@ubuntu:/opt/stack/python-novaclient$ grep Version python_novaclient.egg-info/PKG-INFO \n\nMetadata-Version: 1.1\n\nVersion: 2.17.0.167.gfa2f38a\n\nLicense: Apache License, Version 2.0\nmriedem@ubuntu:/opt/stack/python-novaclient$ \n\nSo the version that we\u0027d get from pip/site-packages via a devstack/tempest run looks like it wouldn\u0027t conflict with that version built via \u0027python setup.py build\u0027.","commit_id":"e9defe8c99ddaf30c8496a1cd3b746efb3364fe9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"514d0679cf738a210a173b3e44450b307e44ddba","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator to tempest/test.py that can be used in the tempest/cli"},{"line_number":43,"context_line":"tests for checking that the installed version of the client is at a minimum"},{"line_number":44,"context_line":"version to support the test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1ae5cdf2_129ca80d","line":44,"in_reply_to":"1ae5cdf2_e57eaa1a","updated":"2014-06-18 20:15:54.000000000","message":"I had a bug in my WIP patch, so this is probably not actually an issue.","commit_id":"e9defe8c99ddaf30c8496a1cd3b746efb3364fe9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bb5179adbeea068d0e3705ecddf5464f1200e537","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator that can be used in the tempest/cli tests for checking"},{"line_number":43,"context_line":"that the installed version of the client is at a minimum version to support the"},{"line_number":44,"context_line":"test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_47bf95fb","line":44,"updated":"2014-07-02 06:16:29.000000000","message":"I guess we don\u0027t need to add the decorator to all CLI tests, this might be just for newer CLIs like Icehouse or later as line81 mentioned.\n\nIt is better to mention the scope clearly here.\n(I just want to avoid -1ing CLI test patches due to this decorator less for older CLIs)","commit_id":"6aff872f4bad67b7238f1af5f39eaf35dad4a308"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bae41e01b701997343ae8941c7795bcbe6769b07","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator that can be used in the tempest/cli tests for checking"},{"line_number":43,"context_line":"that the installed version of the client is at a minimum version to support the"},{"line_number":44,"context_line":"test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_dda3744d","line":44,"in_reply_to":"baada198_47bf95fb","updated":"2014-07-02 07:34:56.000000000","message":"There is a spec for CLI test coverage(I5963849662b6fa1fbcd0c861c5936393afea6a68), so I feel it is necessary to describe the above now.","commit_id":"6aff872f4bad67b7238f1af5f39eaf35dad4a308"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"f9bf419c3b259d2d1aac93fe41193754146d4f93","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator that can be used in the tempest/cli tests for checking"},{"line_number":43,"context_line":"that the installed version of the client is at a minimum version to support the"},{"line_number":44,"context_line":"test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_498343cc","line":44,"in_reply_to":"baada198_47bf95fb","updated":"2014-07-09 14:10:12.000000000","message":"Yeah it should just be icehouse features forward. it\u0027s to avoid wedging ourselves because we\u0027re branchless now.","commit_id":"6aff872f4bad67b7238f1af5f39eaf35dad4a308"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"36013207b062eb58b4a7cd118370387df650abcd","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add a simple decorator that can be used in the tempest/cli tests for checking"},{"line_number":43,"context_line":"that the installed version of the client is at a minimum version to support the"},{"line_number":44,"context_line":"test, otherwise the test is skipped."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Alternatives"},{"line_number":47,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_e902570a","line":44,"in_reply_to":"baada198_498343cc","updated":"2014-07-09 14:18:04.000000000","message":"Done","commit_id":"6aff872f4bad67b7238f1af5f39eaf35dad4a308"}]}