)]}'
{"qinling/api/controllers/v1/function_alias.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        super(FunctionAliasesController, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @tenacity.retry("},{"line_number":40,"context_line":"        wait\u003dtenacity.wait_fixed(1),"},{"line_number":41,"context_line":"        stop\u003dtenacity.stop_after_attempt(30),"},{"line_number":42,"context_line":"        retry\u003d(tenacity.retry_if_result(lambda result: result is False))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5fbebe00","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":19},"updated":"2018-06-19 02:50:31.000000000","message":"why you are using retry for this db operation?","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        super(FunctionAliasesController, self).__init__(*args, **kwargs)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @tenacity.retry("},{"line_number":40,"context_line":"        wait\u003dtenacity.wait_fixed(1),"},{"line_number":41,"context_line":"        stop\u003dtenacity.stop_after_attempt(30),"},{"line_number":42,"context_line":"        retry\u003d(tenacity.retry_if_result(lambda result: result is False))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0ad226d2","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":19},"in_reply_to":"5f7c97a3_5fbebe00","updated":"2018-06-20 03:17:44.000000000","message":"Removed","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        body\u003dresources.FunctionAlias,"},{"line_number":58,"context_line":"        status_code\u003d201"},{"line_number":59,"context_line":"    )"},{"line_number":60,"context_line":"    def post(self, function_id, body):"},{"line_number":61,"context_line":"        \"\"\"Create a new alias point to the function version."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        The supported boy params:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_df608ea7","line":60,"range":{"start_line":60,"start_character":19,"end_line":60,"end_character":30},"updated":"2018-06-19 02:50:31.000000000","message":"\u0027function_id\u0027 should be a param in the body.","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        body\u003dresources.FunctionAlias,"},{"line_number":58,"context_line":"        status_code\u003d201"},{"line_number":59,"context_line":"    )"},{"line_number":60,"context_line":"    def post(self, function_id, body):"},{"line_number":61,"context_line":"        \"\"\"Create a new alias point to the function version."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        The supported boy params:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_aad8d2ef","line":60,"range":{"start_line":60,"start_character":19,"end_line":60,"end_character":30},"in_reply_to":"5f7c97a3_df608ea7","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        The supported boy params:"},{"line_number":64,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":65,"context_line":"            - function_version: Required. Version number the alias point to."},{"line_number":66,"context_line":"            - description: Optional. The description of the new alias."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        ctx \u003d context.get_ctx()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7f061a1f","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":40},"updated":"2018-06-19 02:50:31.000000000","message":"the \u0027function_version\u0027 has a default value, so it\u0027s optional","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        The supported boy params:"},{"line_number":64,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":65,"context_line":"            - function_version: Required. Version number the alias point to."},{"line_number":66,"context_line":"            - description: Optional. The description of the new alias."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        ctx \u003d context.get_ctx()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cad3ced2","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":40},"in_reply_to":"5f7c97a3_7f061a1f","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":65,"context_line":"            - function_version: Required. Version number the alias point to."},{"line_number":66,"context_line":"            - description: Optional. The description of the new alias."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        ctx \u003d context.get_ctx()"},{"line_number":69,"context_line":"        acl.enforce(\u0027function_alias:create\u0027, ctx)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9f5a16f0","line":67,"updated":"2018-06-19 02:50:31.000000000","message":"\u0027function_id\u0027 is missing","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":65,"context_line":"            - function_version: Required. Version number the alias point to."},{"line_number":66,"context_line":"            - description: Optional. The description of the new alias."},{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        ctx \u003d context.get_ctx()"},{"line_number":69,"context_line":"        acl.enforce(\u0027function_alias:create\u0027, ctx)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6ae2baa2","line":67,"in_reply_to":"5f7c97a3_9f5a16f0","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        ctx \u003d context.get_ctx()"},{"line_number":69,"context_line":"        acl.enforce(\u0027function_alias:create\u0027, ctx)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        params \u003d body.to_dict()"},{"line_number":72,"context_line":"        values \u003d {"},{"line_number":73,"context_line":"            \u0027name\u0027: params.get(\u0027name\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1f6606bd","line":70,"updated":"2018-06-19 02:50:31.000000000","message":"The params checking is missing.","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"\"\""},{"line_number":68,"context_line":"        ctx \u003d context.get_ctx()"},{"line_number":69,"context_line":"        acl.enforce(\u0027function_alias:create\u0027, ctx)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        params \u003d body.to_dict()"},{"line_number":72,"context_line":"        values \u003d {"},{"line_number":73,"context_line":"            \u0027name\u0027: params.get(\u0027name\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8addd6de","line":70,"in_reply_to":"5f7c97a3_1f6606bd","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        acl.enforce(\u0027function_alias:get\u0027, context.get_ctx())"},{"line_number":87,"context_line":"        LOG.info(\"Getting function alias  %s.\", alias_name)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        with db_api.transaction():"},{"line_number":90,"context_line":"            alias \u003d db_api.get_function_alias(alias_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        print(alias)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7f0cdaeb","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":34},"updated":"2018-06-19 02:50:31.000000000","message":"no need to use transaction here","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        acl.enforce(\u0027function_alias:get\u0027, context.get_ctx())"},{"line_number":87,"context_line":"        LOG.info(\"Getting function alias  %s.\", alias_name)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        with db_api.transaction():"},{"line_number":90,"context_line":"            alias \u003d db_api.get_function_alias(alias_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        print(alias)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2aee028b","line":89,"range":{"start_line":89,"start_character":8,"end_line":89,"end_character":34},"in_reply_to":"5f7c97a3_7f0cdaeb","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        with db_api.transaction():"},{"line_number":90,"context_line":"            alias \u003d db_api.get_function_alias(alias_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        print(alias)"},{"line_number":93,"context_line":"        return resources.FunctionAlias.from_db_obj(alias)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3ff662da","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":20},"updated":"2018-06-19 02:50:31.000000000","message":"please remove this.","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        with db_api.transaction():"},{"line_number":90,"context_line":"            alias \u003d db_api.get_function_alias(alias_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        print(alias)"},{"line_number":93,"context_line":"        return resources.FunctionAlias.from_db_obj(alias)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0aeb0678","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":20},"in_reply_to":"5f7c97a3_3ff662da","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2c9755ba7ba630a399be9b776d88cf4637d5a4c4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        status_code\u003d201"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    def post(self, body):"},{"line_number":48,"context_line":"        \"\"\"Create a new alias point to the function version."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The supported boy params:"},{"line_number":51,"context_line":"            - function_id: Required. Function id the alias point to."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d537c1e2","line":48,"range":{"start_line":48,"start_character":11,"end_line":48,"end_character":59},"updated":"2018-06-21 22:42:41.000000000","message":"Suggestion: Create a new alias for the specified function.","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4ba61aeb965ac73a36e9a2ab4ab38a2d3d8d2f66","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        status_code\u003d201"},{"line_number":46,"context_line":"    )"},{"line_number":47,"context_line":"    def post(self, body):"},{"line_number":48,"context_line":"        \"\"\"Create a new alias point to the function version."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The supported boy params:"},{"line_number":51,"context_line":"            - function_id: Required. Function id the alias point to."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ecd8eff0","line":48,"range":{"start_line":48,"start_character":11,"end_line":48,"end_character":59},"in_reply_to":"5f7c97a3_d537c1e2","updated":"2018-06-22 08:10:44.000000000","message":"Done","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2c9755ba7ba630a399be9b776d88cf4637d5a4c4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def post(self, body):"},{"line_number":48,"context_line":"        \"\"\"Create a new alias point to the function version."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The supported boy params:"},{"line_number":51,"context_line":"            - function_id: Required. Function id the alias point to."},{"line_number":52,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":53,"context_line":"            - function_version: Optional. Version number the alias point to."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3262cb17","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":25},"updated":"2018-06-21 22:42:41.000000000","message":"nit: body","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4ba61aeb965ac73a36e9a2ab4ab38a2d3d8d2f66","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def post(self, body):"},{"line_number":48,"context_line":"        \"\"\"Create a new alias point to the function version."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The supported boy params:"},{"line_number":51,"context_line":"            - function_id: Required. Function id the alias point to."},{"line_number":52,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":53,"context_line":"            - function_version: Optional. Version number the alias point to."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0cd68bc4","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":25},"in_reply_to":"5f7c97a3_3262cb17","updated":"2018-06-22 08:10:44.000000000","message":"Done","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2c9755ba7ba630a399be9b776d88cf4637d5a4c4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027description\u0027: params.get(\u0027description\u0027),"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        # Try to create a new alias in db transaction"},{"line_number":73,"context_line":"        with db_api.transaction():"},{"line_number":74,"context_line":"            alias \u003d db_api.create_function_alias(**values)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        LOG.info(\"New alias created.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_32308b07","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":34},"updated":"2018-06-21 22:42:41.000000000","message":"The db transaction is not needed.","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4ba61aeb965ac73a36e9a2ab4ab38a2d3d8d2f66","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027description\u0027: params.get(\u0027description\u0027),"},{"line_number":71,"context_line":"        }"},{"line_number":72,"context_line":"        # Try to create a new alias in db transaction"},{"line_number":73,"context_line":"        with db_api.transaction():"},{"line_number":74,"context_line":"            alias \u003d db_api.create_function_alias(**values)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        LOG.info(\"New alias created.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_acde77d8","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":34},"in_reply_to":"5f7c97a3_32308b07","updated":"2018-06-22 08:10:44.000000000","message":"Done","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\"Create a new alias for the specified function."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        The supported body params:"},{"line_number":51,"context_line":"            - function_id: Required. Function id the alias point to."},{"line_number":52,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":53,"context_line":"            - function_version: Optional. Version number the alias point to."},{"line_number":54,"context_line":"            - description: Optional. The description of the new alias."}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1693e35d","line":51,"range":{"start_line":51,"start_character":59,"end_line":51,"end_character":64},"updated":"2018-06-25 02:11:13.000000000","message":"nit, points","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        The supported body params:"},{"line_number":51,"context_line":"            - function_id: Required. Function id the alias point to."},{"line_number":52,"context_line":"            - name: Required. Alias name, must be unique within the project."},{"line_number":53,"context_line":"            - function_version: Optional. Version number the alias point to."},{"line_number":54,"context_line":"            - description: Optional. The description of the new alias."},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        ctx \u003d context.get_ctx()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d6980b77","line":53,"range":{"start_line":53,"start_character":67,"end_line":53,"end_character":72},"updated":"2018-06-25 02:11:13.000000000","message":"ditto","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"}],"qinling/api/controllers/v1/resources.py":[{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    updated_at \u003d wsme.wsattr(wtypes.text, readonly\u003dTrue)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"class FunctionAliases(ResourceList):"},{"line_number":405,"context_line":"    function_aliases \u003d [FunctionAlias]"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def __init__(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_16cf6357","line":404,"range":{"start_line":404,"start_character":0,"end_line":404,"end_character":21},"updated":"2018-06-25 02:11:13.000000000","message":"Did you forget the get_all() method in the controller? I can\u0027t find where this class is used in this commit. Or are you going to add the get_all() method into the controller codes with a separate commit?","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"}],"qinling/db/api.py":[{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    return IMPL.get_function_alias(name, **kwargs)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def get_function_aliases(**kwargs):"},{"line_number":238,"context_line":"    return IMPL.get_function_aliases(**kwargs)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def update_function_alias(name, **kwargs):"},{"line_number":242,"context_line":"    return IMPL.update_function_alias(name, **kwargs)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# For unit test first"},{"line_number":246,"context_line":"def delete_function_alias(name, **kwargs):"},{"line_number":247,"context_line":"    return IMPL.delete_function_alias(name, **kwargs)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def delete_function_aliases(**kwargs):"},{"line_number":251,"context_line":"    return IMPL.delete_function_aliases(**kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_56087b7e","line":251,"range":{"start_line":237,"start_character":0,"end_line":251,"end_character":49},"updated":"2018-06-25 02:11:13.000000000","message":"Only delete_function_aliases() is required for testing. The other three doesn\u0027t seem to be related to this change. get_function_aliases() may be related if the get_all logic is going to be in this change.","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"64250f05b32a86dac523bb8425678ba21853319c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    return IMPL.get_function_aliases(**kwargs)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def delete_function_alias(name, **kwargs):"},{"line_number":242,"context_line":"    return IMPL.delete_function_alias(name, **kwargs)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# For unit test"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_07be2f64","line":242,"range":{"start_line":241,"start_character":0,"end_line":242,"end_character":53},"updated":"2018-06-26 06:47:19.000000000","message":"this isn\u0027t needed.","commit_id":"8c21c7ec0aae2b582166b7cd4e059d8e3dab9a51"}],"qinling/db/sqlalchemy/api.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"@db_base.session_aware()"},{"line_number":561,"context_line":"def create_function_alias(function_id, session\u003dNone, **kwargs):"},{"line_number":562,"context_line":"    alias \u003d models.FunctionAlias()"},{"line_number":563,"context_line":"    kwargs.update("},{"line_number":564,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7f25ba5b","line":561,"range":{"start_line":561,"start_character":26,"end_line":561,"end_character":37},"updated":"2018-06-19 02:50:31.000000000","message":"function_id should be treated as a normal param.","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"@db_base.session_aware()"},{"line_number":561,"context_line":"def create_function_alias(function_id, session\u003dNone, **kwargs):"},{"line_number":562,"context_line":"    alias \u003d models.FunctionAlias()"},{"line_number":563,"context_line":"    kwargs.update("},{"line_number":564,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cafc2e41","line":561,"range":{"start_line":561,"start_character":26,"end_line":561,"end_character":37},"in_reply_to":"5f7c97a3_7f25ba5b","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3e3cedc94923c26d65601c131bc3ceaf64c20ce0","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"@db_base.session_aware()"},{"line_number":581,"context_line":"def get_function_alias(name, session\u003dNone):"},{"line_number":582,"context_line":"    query \u003d db_base.model_query(models.FunctionAlias)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    alias_db \u003d query.filter_by("},{"line_number":585,"context_line":"        name\u003dname"},{"line_number":586,"context_line":"    ).first()"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    if not alias_db:"},{"line_number":589,"context_line":"        raise exc.DBEntityNotFoundError("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3fe4220e","line":586,"range":{"start_line":582,"start_character":0,"end_line":586,"end_character":13},"updated":"2018-06-19 02:50:31.000000000","message":"You could add a method called `_get_db_object_by_name` just similar to `_get_db_object_by_id`","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"fe75ddf915f5869f27f806ce945f4fce8d85b5a7","unresolved":false,"context_lines":[{"line_number":579,"context_line":""},{"line_number":580,"context_line":"@db_base.session_aware()"},{"line_number":581,"context_line":"def get_function_alias(name, session\u003dNone):"},{"line_number":582,"context_line":"    query \u003d db_base.model_query(models.FunctionAlias)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    alias_db \u003d query.filter_by("},{"line_number":585,"context_line":"        name\u003dname"},{"line_number":586,"context_line":"    ).first()"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    if not alias_db:"},{"line_number":589,"context_line":"        raise exc.DBEntityNotFoundError("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8af6365d","line":586,"range":{"start_line":582,"start_character":0,"end_line":586,"end_character":13},"in_reply_to":"5f7c97a3_3fe4220e","updated":"2018-06-20 03:17:44.000000000","message":"Done","commit_id":"a9848063149e78d93c01c7d25f982b1f2c25e76c"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"@db_base.insecure_aware()"},{"line_number":204,"context_line":"def _get_db_object_by_name(model, name, insecure\u003dNone):"},{"line_number":205,"context_line":"    query \u003d db_base.model_query(model) if insecure else _secure_query(model)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    return query.filter_by(name\u003dname).first()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f6d187f9","line":204,"range":{"start_line":204,"start_character":40,"end_line":204,"end_character":53},"updated":"2018-06-25 02:11:13.000000000","message":"Isn\u0027t this a boolean param? Better default it to False?","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":595,"context_line":"    return alias"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"@db_base.session_aware()"},{"line_number":599,"context_line":"def get_function_aliases(session\u003dNone, **kwargs):"},{"line_number":600,"context_line":"    return _get_collection_sorted_by_time(models.FunctionAlias, **kwargs)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"@db_base.session_aware()"},{"line_number":604,"context_line":"def update_function_alias(name, session\u003dNone, **kwargs):"},{"line_number":605,"context_line":"    alias_db \u003d get_function_alias(name, session\u003dsession)"},{"line_number":606,"context_line":"    alias_db.update(kwargs.copy())"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    return alias_db"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"@db_base.session_aware()"},{"line_number":612,"context_line":"def delete_function_alias(name, session\u003dNone):"},{"line_number":613,"context_line":"    alias_db \u003d get_function_alias(name)"},{"line_number":614,"context_line":"    session.delete(alias_db)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"@db_base.session_aware()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f618a7cd","line":614,"range":{"start_line":598,"start_character":0,"end_line":614,"end_character":28},"updated":"2018-06-25 02:11:13.000000000","message":"See my comment in db/api.py.","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"}],"qinling/tests/unit/api/controllers/v1/test_function_alias.py":[{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2c9755ba7ba630a399be9b776d88cf4637d5a4c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context.set_ctx(self.ctx)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        with db_api.transaction():"},{"line_number":42,"context_line":"            func_alias_db \u003d db_api.get_function_alias(name)"},{"line_number":43,"context_line":"            self.assertEqual(name, func_alias_db.name)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_32196b87","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":34},"updated":"2018-06-21 22:42:41.000000000","message":"This is not needed.","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4ba61aeb965ac73a36e9a2ab4ab38a2d3d8d2f66","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        context.set_ctx(self.ctx)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        with db_api.transaction():"},{"line_number":42,"context_line":"            func_alias_db \u003d db_api.get_function_alias(name)"},{"line_number":43,"context_line":"            self.assertEqual(name, func_alias_db.name)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8cca9b17","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":34},"in_reply_to":"5f7c97a3_32196b87","updated":"2018-06-22 08:10:44.000000000","message":"Done","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"2c9755ba7ba630a399be9b776d88cf4637d5a4c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f7c97a3_354cf574","line":61,"updated":"2018-06-21 22:42:41.000000000","message":"Could you please add one more test that asserts the exception raised when creating alias without some required param?","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"4ba61aeb965ac73a36e9a2ab4ab38a2d3d8d2f66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f7c97a3_2ccb471d","line":61,"in_reply_to":"5f7c97a3_354cf574","updated":"2018-06-22 08:10:44.000000000","message":"Done","commit_id":"1f4b88ff2737e11cfe70782764e3d7d0a17a8eac"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        name \u003d \u0027TestAlias\u0027"},{"line_number":29,"context_line":"        function_version \u003d 0"},{"line_number":30,"context_line":"        body \u003d {\u0027function_id\u0027: self.func_id,"},{"line_number":31,"context_line":"                \u0027function_version\u0027: function_version,"},{"line_number":32,"context_line":"                \u0027name\u0027: name,"},{"line_number":33,"context_line":"                \u0027description\u0027: \u0027new alias\u0027}"},{"line_number":34,"context_line":"        resp \u003d self.app.post_json(\u0027/v1/aliases\u0027, body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_56563b60","line":31,"range":{"start_line":31,"start_character":16,"end_line":31,"end_character":53},"updated":"2018-06-25 02:11:13.000000000","message":"As function_version is an optional param, will you add another test posting without function_version to see whether it defaults to 0 or not?","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"},{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"20fbd428d714ada3f953816a919afa43731fa98c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(200, resp.status_int)"},{"line_number":59,"context_line":"        self.assertEqual(\"new alias\", resp.json.get(\u0027description\u0027))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_post_without_params(self):"},{"line_number":62,"context_line":"        body \u003d {}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        resp \u003d self.app.post_json(\u0027/v1/aliases\u0027,"},{"line_number":65,"context_line":"                                  body,"},{"line_number":66,"context_line":"                                  expect_errors\u003dTrue)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertEqual(400, resp.status_int)"},{"line_number":69,"context_line":"        self.assertIn(\"Required param is missing.\", resp.json[\u0027faultstring\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_d649ebb7","line":69,"range":{"start_line":61,"start_character":0,"end_line":69,"end_character":77},"updated":"2018-06-25 02:11:13.000000000","message":"Better to place this before test_get().","commit_id":"36c130200c287419f21c46d9cb50555c30ab07ae"}],"qinling/utils/rest_utils.py":[{"author":{"_account_id":21781,"name":"Hunt Xu","email":"mhuntxu@gmail.com","username":"huntxu"},"change_message_id":"64250f05b32a86dac523bb8425678ba21853319c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    for column, data in params.items():"},{"line_number":88,"context_line":"        if data is not None:"},{"line_number":89,"context_line":"            if isinstance(data, six.string_types):"},{"line_number":90,"context_line":"                f_type, value \u003d _extract_filter_type_and_value(data)"},{"line_number":91,"context_line":"                create_or_update_filter(column, value, f_type, filters)"},{"line_number":92,"context_line":"            else:"},{"line_number":93,"context_line":"                create_or_update_filter(column, data, _filter\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_47a74751","line":90,"updated":"2018-06-26 06:47:19.000000000","message":"irrelevant change","commit_id":"8c21c7ec0aae2b582166b7cd4e059d8e3dab9a51"}]}
