)]}'
{"tests/ci/playbooks/roles/prepare-rally/defaults/main.yaml":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e8522187a4d4934bd25e99e6cb923b21be4f5703","unresolved":false,"context_lines":[{"line_number":1,"context_line":"existing_user_name_1: \"rally-test-user-1\""},{"line_number":2,"context_line":"existing_user_password_1: \"rally-test-password-1\""},{"line_number":3,"context_line":"existing_user_project_1: \"rally-test-project-1\""},{"line_number":4,"context_line":"existing_user_name_2: \"rally-test-user-2\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"1f9dbf25_6af530cb","line":1,"updated":"2018-03-01 21:12:47.000000000","message":"I would move this to global_vars/all instad of putting it deep in repo, it would be way simpler to find all available variables, when they are in the same place","commit_id":"b0a8f6f2b6c922e0e08b52739dc65e584c5277f9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ef99529a14d24ea35acdb5bee0ad63da69bddf7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"existing_user_name_1: \"rally-test-user-1\""},{"line_number":2,"context_line":"existing_user_password_1: \"rally-test-password-1\""},{"line_number":3,"context_line":"existing_user_project_1: \"rally-test-project-1\""},{"line_number":4,"context_line":"existing_user_name_2: \"rally-test-user-2\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"1f9dbf25_eb47eb1c","line":1,"in_reply_to":"1f9dbf25_6af530cb","updated":"2018-03-01 21:31:07.000000000","message":"I\u0027m planning to experiment with this, but it looks like it is impossible to do this. Zuul aggregates playbooks from different places and inventory is taken for separate hosts which means that we have limited things to use.","commit_id":"b0a8f6f2b6c922e0e08b52739dc65e584c5277f9"}],"tests/ci/playbooks/roles/run-rally/tasks/main.yaml":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e8522187a4d4934bd25e99e6cb923b21be4f5703","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      set +e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      rally --rally-debug task start --task {{ rally.task }} $TASK_ARGS"},{"line_number":14,"context_line":"      retval\u003d$?"},{"line_number":15,"context_line":"      if [[ $? -eq 1 ]]; then"},{"line_number":16,"context_line":"          # 1 exit code means that something unexpected had happened"},{"line_number":17,"context_line":"          exit $retval"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"1f9dbf25_0a4fccbd","line":14,"updated":"2018-03-01 21:12:47.000000000","message":"so why these lines are needed, this command is going to exit in any case with code 1 (if 14 fails..)","commit_id":"b0a8f6f2b6c922e0e08b52739dc65e584c5277f9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ef99529a14d24ea35acdb5bee0ad63da69bddf7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      set +e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      rally --rally-debug task start --task {{ rally.task }} $TASK_ARGS"},{"line_number":14,"context_line":"      retval\u003d$?"},{"line_number":15,"context_line":"      if [[ $? -eq 1 ]]; then"},{"line_number":16,"context_line":"          # 1 exit code means that something unexpected had happened"},{"line_number":17,"context_line":"          exit $retval"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"1f9dbf25_6b0afbd2","line":14,"in_reply_to":"1f9dbf25_0a4fccbd","updated":"2018-03-01 21:31:07.000000000","message":"no. You are wrong(you missed a bunch of changes in Rally). \n\nWe played a bit with error codes to simplify usage via bash:\n\n1) it returns 2 if SLA fails - https://github.com/openstack/rally/blob/master/rally/cli/commands/task.py#L314-L315\n2) it returns 1 if something with a deployment(bad credentials?!) - https://github.com/openstack/rally/blob/master/rally/cli/commands/task.py#L310-L312\n3) it returns X if rally exception is raised - https://github.com/openstack/rally/blob/master/rally/cli/cliutils.py#L682-L687\n\n\nSo 1 means unexpected failure. even validation error has not 1 error code.","commit_id":"b0a8f6f2b6c922e0e08b52739dc65e584c5277f9"}]}
