)]}'
{"rally_openstack/cleanup/resources.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dcec071e5d3c7c20c19ed37b650169434a588c71","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"@base.resource(\"gnocchi\", \"metric\", order\u003dnext(_gnocchi_order),"},{"line_number":880,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":881,"context_line":"class GnocchiMetric(GnocchiMixin):"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_32e1819c","line":880,"range":{"start_line":880,"start_character":15,"end_line":880,"end_character":64},"updated":"2018-03-22 16:47:15.000000000","message":"I suppose it is not True and metrics are created by the regular user. By the way, can userA see metrics of userB?","commit_id":"4d8c40e2a9fca0afdec3a7b1dd7d9ccc1a5aa1fe"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0df666ae95c4ee9465a9c4e061754f1b80d46434","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"@base.resource(\"gnocchi\", \"metric\", order\u003dnext(_gnocchi_order),"},{"line_number":880,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":881,"context_line":"class GnocchiMetric(GnocchiMixin):"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_fbcccb62","line":880,"range":{"start_line":880,"start_character":15,"end_line":880,"end_character":64},"in_reply_to":"bf659307_3b0d6337","updated":"2018-03-23 16:42:55.000000000","message":"hm... does metric includes some owner-ship? like tenant id/name, so we can perform post-filtering after listening?\n\nRally supports deployment/envs with specifying existing users[*]. In this case, \"admin\" is become optional, which means that if the workload doesn\u0027t require admin user, it can be launched. The Metric scenarios look like something which possibly can be launched without admin user. This cleanup makes it impossible. If there is an ability to filter metrics in the right way, it would be nice to do it (I can go to telemetry team for suggestions). Otherwise, we can wrap delete requests with try..except block and hide NotFound error.\n\n[*] - https://github.com/openstack/rally-openstack/blob/master/samples/deployments/existing-with-predefined-users.json#L11","commit_id":"4d8c40e2a9fca0afdec3a7b1dd7d9ccc1a5aa1fe"},{"author":{"_account_id":14749,"name":"Juha Kosonen","email":"juha.kosonen@nokia.com","username":"jukosone"},"change_message_id":"8cf83ec79d2fb9ee577fefb5a048322b7d516f24","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"@base.resource(\"gnocchi\", \"metric\", order\u003dnext(_gnocchi_order),"},{"line_number":880,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":881,"context_line":"class GnocchiMetric(GnocchiMixin):"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f1c295e9","line":880,"range":{"start_line":880,"start_character":15,"end_line":880,"end_character":64},"in_reply_to":"bf659307_fbcccb62","updated":"2018-03-25 14:46:34.000000000","message":"Metric list do include an info about project/user who created it. So I think the approach to post filter is the way to go. I\u0027ll take a closer look and submit a change.","commit_id":"4d8c40e2a9fca0afdec3a7b1dd7d9ccc1a5aa1fe"},{"author":{"_account_id":14749,"name":"Juha Kosonen","email":"juha.kosonen@nokia.com","username":"jukosone"},"change_message_id":"139bf42bb2da4e73b74ed92e4c2585f9228e99aa","unresolved":false,"context_lines":[{"line_number":877,"context_line":""},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"@base.resource(\"gnocchi\", \"metric\", order\u003dnext(_gnocchi_order),"},{"line_number":880,"context_line":"               admin_required\u003dTrue, perform_for_admin_only\u003dTrue)"},{"line_number":881,"context_line":"class GnocchiMetric(GnocchiMixin):"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    def id(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3b0d6337","line":880,"range":{"start_line":880,"start_character":15,"end_line":880,"end_character":64},"in_reply_to":"df7087c5_32e1819c","updated":"2018-03-23 16:29:23.000000000","message":"Metrics are created by regular users. When a user retrieves a list of metrics it will get a list which includes all metrics, also those created by other users. A user can also delete a metric if it was created by a user on same project. This perhaps is something that can be customized via policy.json.\n\nA quite a lot of warnings about attempting to delete non-existing resource is generated if using tenant_resource in cleanup.","commit_id":"4d8c40e2a9fca0afdec3a7b1dd7d9ccc1a5aa1fe"}],"tests/ci/osresources.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8680b1e4000afd241ba6cbc29b960182221edf6f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    def list_resource_type(self):"},{"line_number":327,"context_line":"        return self.client.resource_type.list()"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def list_metric(self):"},{"line_number":330,"context_line":"        result \u003d []"},{"line_number":331,"context_line":"        marker \u003d None"},{"line_number":332,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_2d0c3b41","line":329,"range":{"start_line":329,"start_character":8,"end_line":329,"end_character":19},"updated":"2018-04-05 08:51:50.000000000","message":"osresources script iterates over all list methods. The name of listed resources is taken from methods names by cutting \"list_\" and the last character (see L68). Please add \"s\" to the end of method name(as well to L323 and L326), otherwise\nthe name of resource looks wrong - http://logs.openstack.org/28/558828/1/check/rally-task-telemetry/64dfc4b/job-output.txt.gz#_2018-04-04_14_37_19_357010","commit_id":"79ccc1d0bbe6fce094fa450d0ba1389d718e9db6"}]}