)]}'
{"rally_openstack/osclients.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ae2e9c12fa9b3c897c6147258d5e5e09a775e22","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.credential \u003d credential"},{"line_number":68,"context_line":"        if isinstance(self.credential, dict):"},{"line_number":69,"context_line":"            self.credential \u003d utils.Struct(**self.credential)"},{"line_number":70,"context_line":"            api_info \u003d api_info or credential.get(\"api_info\", {})"},{"line_number":71,"context_line":"        self.api_info \u003d api_info"},{"line_number":72,"context_line":"        self.cache \u003d cache_obj"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3f79a3b5_9fe1069e","line":70,"range":{"start_line":70,"start_character":12,"end_line":70,"end_character":65},"updated":"2018-08-28 08:56:08.000000000","message":"it should not be under `if` block","commit_id":"1ed28a939d298ff21b435ef351678b9be3a72768"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9cdc5949e12def4f6a4e95b5a83e925cfe5971f5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"class OSClient(plugin.Plugin):"},{"line_number":108,"context_line":"    \"\"\"Base class for OpenStack clients\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self, credential, api_info, cache_obj):"},{"line_number":111,"context_line":"        self.credential \u003d credential"},{"line_number":112,"context_line":"        if not isinstance(self.credential, oscred.OpenStackCredential):"},{"line_number":113,"context_line":"            self.credential \u003d oscred.OpenStackCredential(**self.credential)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_5c4faabd","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":54},"updated":"2018-08-31 06:03:41.000000000","message":"You can add \"None\" as default for both arguments and in case if `not None` in api_info write message that it is deprecated.","commit_id":"0a73f8ae805c8bc671d88a6c885690e980e31752"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"5086ffc76c6acc9c2fe7645ce87816c27136fa60","unresolved":false,"context_lines":[{"line_number":107,"context_line":"class OSClient(plugin.Plugin):"},{"line_number":108,"context_line":"    \"\"\"Base class for OpenStack clients\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self, credential, api_info, cache_obj):"},{"line_number":111,"context_line":"        self.credential \u003d credential"},{"line_number":112,"context_line":"        if not isinstance(self.credential, oscred.OpenStackCredential):"},{"line_number":113,"context_line":"            self.credential \u003d oscred.OpenStackCredential(**self.credential)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_5c59ea58","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":54},"in_reply_to":"3f79a3b5_5c4faabd","updated":"2018-08-31 06:24:41.000000000","message":"So we still save api_info argument to be back compatibility ? In my thought, will remove it at another patch.","commit_id":"0a73f8ae805c8bc671d88a6c885690e980e31752"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"660b92c7084d124182420bdf3fd28d7b117560ed","unresolved":false,"context_lines":[{"line_number":107,"context_line":"class OSClient(plugin.Plugin):"},{"line_number":108,"context_line":"    \"\"\"Base class for OpenStack clients\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self, credential, api_info, cache_obj):"},{"line_number":111,"context_line":"        self.credential \u003d credential"},{"line_number":112,"context_line":"        if not isinstance(self.credential, oscred.OpenStackCredential):"},{"line_number":113,"context_line":"            self.credential \u003d oscred.OpenStackCredential(**self.credential)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f79a3b5_b7cdb7b8","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":54},"in_reply_to":"3f79a3b5_5c59ea58","updated":"2018-08-31 06:37:50.000000000","message":"it would be nice to leave it for at least one release. But I\u0027m ok about doing it in the separate patch","commit_id":"0a73f8ae805c8bc671d88a6c885690e980e31752"}],"rally_openstack/platforms/existing.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"76f66828939fce2ef271b87d1b410038dfbee370","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                    }"},{"line_number":73,"context_line":"                ],"},{"line_number":74,"context_line":"            },"},{"line_number":75,"context_line":"            \"api_info\": {"},{"line_number":76,"context_line":"                \"type\": \"object\","},{"line_number":77,"context_line":"                \"patternProperties\": {"},{"line_number":78,"context_line":"                    \"^[a-z]+$\": {"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f79a3b5_ca53096c","line":75,"updated":"2018-08-30 06:27:27.000000000","message":"This jsonschema becomes bigger and bigger and despite the fact it is good in validation, the resulting error messages are not informative at all. Let\u0027s simplify it.","commit_id":"dc41ced3e4b8b1e1f5735afdde961924be74fa64"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"76f66828939fce2ef271b87d1b410038dfbee370","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                \"patternProperties\": {"},{"line_number":78,"context_line":"                    \"^[a-z]+$\": {"},{"line_number":79,"context_line":"                        \"type\": \"object\","},{"line_number":80,"context_line":"                        \"oneOf\": ["},{"line_number":81,"context_line":"                            {"},{"line_number":82,"context_line":"                                \"description\": \"version only\","},{"line_number":83,"context_line":"                                \"properties\": {"},{"line_number":84,"context_line":"                                    \"version\": VERSION_SCHEMA"},{"line_number":85,"context_line":"                                },"},{"line_number":86,"context_line":"                                \"required\": [\"version\"],"},{"line_number":87,"context_line":"                                \"additionalProperties\": False"},{"line_number":88,"context_line":"                            },"},{"line_number":89,"context_line":"                            {"},{"line_number":90,"context_line":"                                \"description\": \"version and service_type\","},{"line_number":91,"context_line":"                                \"properties\": {"},{"line_number":92,"context_line":"                                    \"version\": VERSION_SCHEMA,"},{"line_number":93,"context_line":"                                    \"service_type\": {\"type\": \"string\"}"},{"line_number":94,"context_line":"                                },"},{"line_number":95,"context_line":"                                \"required\": [\"service_type\"],"},{"line_number":96,"context_line":"                                \"additionalProperties\": False"},{"line_number":97,"context_line":"                            }"},{"line_number":98,"context_line":"                        ]"},{"line_number":99,"context_line":"                    }"},{"line_number":100,"context_line":"                },"},{"line_number":101,"context_line":"                \"minProperties\": 1,"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f79a3b5_0a6b41f1","line":98,"range":{"start_line":80,"start_character":24,"end_line":98,"end_character":25},"updated":"2018-08-30 06:27:27.000000000","message":"let\u0027s merge it:\n\n    \"properties\": {\n        \"version\": VERSION_SCHEMA,\n        \"service_type\": {\"type\": \"string\"},\n        \"service_name\": {\"type\": \"string\"}\n    },\n    \"minProperties\": 1,\n    \"additionalProperties\": False","commit_id":"dc41ced3e4b8b1e1f5735afdde961924be74fa64"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"76f66828939fce2ef271b87d1b410038dfbee370","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                        ]"},{"line_number":99,"context_line":"                    }"},{"line_number":100,"context_line":"                },"},{"line_number":101,"context_line":"                \"minProperties\": 1,"},{"line_number":102,"context_line":"                \"additionalProperties\": False"},{"line_number":103,"context_line":"            }"},{"line_number":104,"context_line":"        },"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f79a3b5_aa7b2dbc","line":101,"range":{"start_line":101,"start_character":11,"end_line":101,"end_character":35},"updated":"2018-08-30 06:27:27.000000000","message":"let\u0027s remove this. if user specifies `api_info: {}`, it will not break anything.","commit_id":"dc41ced3e4b8b1e1f5735afdde961924be74fa64"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"76f66828939fce2ef271b87d1b410038dfbee370","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        api_info \u003d self.platform_data.get(\"api_info\", {})"},{"line_number":190,"context_line":"        if self.platform_data[\"admin\"]:"},{"line_number":191,"context_line":"            try:"},{"line_number":192,"context_line":"                cred \u003d credential.OpenStackCredential("},{"line_number":193,"context_line":"                    api_info\u003dapi_info,"},{"line_number":194,"context_line":"                    **self.platform_data[\"admin\"]"},{"line_number":195,"context_line":"                )"},{"line_number":196,"context_line":"                osclients.Clients(cred).verified_keystone()"},{"line_number":197,"context_line":"            except Exception:"},{"line_number":198,"context_line":"                d \u003d copy.deepcopy(self.platform_data[\"admin\"])"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f79a3b5_8ad8b11e","line":195,"range":{"start_line":192,"start_character":16,"end_line":195,"end_character":17},"updated":"2018-08-30 06:27:27.000000000","message":"it is better to unify this place. See like it is done here - https://review.openstack.org/#/c/595811/7/rally_openstack/osclients.py\n\nI prefer to merge your patch first and then rebase my patch.","commit_id":"dc41ced3e4b8b1e1f5735afdde961924be74fa64"}],"rally_openstack/scenario.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9f996a21c90599eebff68be04bc0f5fe1bddba0a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, context\u003dNone, admin_clients\u003dNone, clients\u003dNone):"},{"line_number":39,"context_line":"        super(OpenStackScenario, self).__init__(context)"},{"line_number":40,"context_line":"        if context:"},{"line_number":41,"context_line":"            if \"platforms\" in context.get(\"env\", {}):"},{"line_number":42,"context_line":"                api_info \u003d context[\"env\"][\"platforms\"][\"openstack\"].get("},{"line_number":43,"context_line":"                    \"api_info\", {})"},{"line_number":44,"context_line":"            else:"},{"line_number":45,"context_line":"                api_info \u003d {}"},{"line_number":46,"context_line":"            if \"api_versions@openstack\" in context.get(\"config\", {}):"},{"line_number":47,"context_line":"                api_versions \u003d context[\"config\"][\"api_versions@openstack\"]"},{"line_number":48,"context_line":"                for service in api_versions:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_56705072","line":45,"range":{"start_line":41,"start_character":12,"end_line":45,"end_character":29},"updated":"2018-08-27 12:11:08.000000000","message":"I\u0027m about this as a first step, but it doesn\u0027t fix one critical issue: It is easy to forget to grep this data.\n\nhttps://github.com/openstack/rally-openstack/blob/master/rally_openstack/contexts/heat/stacks.py#L77-L79 \n\nHere is an example of a \"wrong\" usage of scenario utils and it is located in our code. By \"wrong usage\" I mean forgotten transmission of `context\u003d{\"api_versions@openstack\": self.context[\"api_versions@openstack\"]}`.\n\nIt would be great if we can get rid of such places. For example, we can iterate over all users and admin here - https://github.com/openstack/rally-openstack/blob/master/rally_openstack/contexts/keystone/users.py#L305  and extend each credential with api_info. The same can be done in api_versions contexts, it can also change credentials.\nIn such case, we will not need transmitting api_versions context anywhere.","commit_id":"f5b1e07fbfae9fbfb680a71e3c42aeb773da3988"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"3102ae879cc883591d28151d98d098a262399572","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, context\u003dNone, admin_clients\u003dNone, clients\u003dNone):"},{"line_number":39,"context_line":"        super(OpenStackScenario, self).__init__(context)"},{"line_number":40,"context_line":"        if context:"},{"line_number":41,"context_line":"            if \"platforms\" in context.get(\"env\", {}):"},{"line_number":42,"context_line":"                api_info \u003d context[\"env\"][\"platforms\"][\"openstack\"].get("},{"line_number":43,"context_line":"                    \"api_info\", {})"},{"line_number":44,"context_line":"            else:"},{"line_number":45,"context_line":"                api_info \u003d {}"},{"line_number":46,"context_line":"            if \"api_versions@openstack\" in context.get(\"config\", {}):"},{"line_number":47,"context_line":"                api_versions \u003d context[\"config\"][\"api_versions@openstack\"]"},{"line_number":48,"context_line":"                for service in api_versions:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f79a3b5_56b27ee6","line":45,"range":{"start_line":41,"start_character":12,"end_line":45,"end_character":29},"in_reply_to":"3f79a3b5_56705072","updated":"2018-08-28 02:01:19.000000000","message":"hmm...... you are right, it can not specify the client version of Context.","commit_id":"f5b1e07fbfae9fbfb680a71e3c42aeb773da3988"}]}
