)]}'
{"rally_openstack/cleanup/manager.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dce612120ef6fcf36d77ec364567c465a02ba110","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                       Scenario resources."},{"line_number":271,"context_line":"    :param task_id: The UUID of task"},{"line_number":272,"context_line":"    \"\"\""},{"line_number":273,"context_line":"    if not api_versions:"},{"line_number":274,"context_line":"        LOG.warning(\"api_versions argument is deprecated, it will be removed\""},{"line_number":275,"context_line":"                    \" after releasing several versions.\")"},{"line_number":276,"context_line":"    resource_classes \u003d [cls for cls in discover.itersubclasses(superclass)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e6530a15","line":273,"range":{"start_line":273,"start_character":7,"end_line":273,"end_character":23},"updated":"2018-09-06 13:08:26.000000000","message":"The wrong condition, it should be ``if api_verions``","commit_id":"4308f27acd348301bb1d31c5a779b593d705bd30"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dce612120ef6fcf36d77ec364567c465a02ba110","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    :param task_id: The UUID of task"},{"line_number":272,"context_line":"    \"\"\""},{"line_number":273,"context_line":"    if not api_versions:"},{"line_number":274,"context_line":"        LOG.warning(\"api_versions argument is deprecated, it will be removed\""},{"line_number":275,"context_line":"                    \" after releasing several versions.\")"},{"line_number":276,"context_line":"    resource_classes \u003d [cls for cls in discover.itersubclasses(superclass)"},{"line_number":277,"context_line":"                        if issubclass(cls, rutils.RandomNameGeneratorMixin)]"},{"line_number":278,"context_line":"    if not resource_classes and issubclass(superclass,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_469f5eb3","line":275,"range":{"start_line":274,"start_character":20,"end_line":275,"end_character":56},"updated":"2018-09-06 13:08:26.000000000","message":"1) it is not clear argument of which method is deprecated(logging will print only module name)\n2) let\u0027s add a reason\n3) it would be nice to specify release of deprecation\n\n    \u0027api_version\u0027 argument of \u0027cleanup\u0027 method is deprecated since rally-openstack 1.3.0 . API information should be included into credentials object.`","commit_id":"4308f27acd348301bb1d31c5a779b593d705bd30"}],"rally_openstack/contexts/manila/manila_share_networks.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dce612120ef6fcf36d77ec364567c465a02ba110","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            manila_scenario \u003d manila_utils.ManilaScenario({"},{"line_number":121,"context_line":"                \"user\": existing_user,"},{"line_number":122,"context_line":"                \"config\": {"},{"line_number":123,"context_line":"                    \"api_versions\": self.context[\"config\"].get("},{"line_number":124,"context_line":"                        \"api_versions\", [])}"},{"line_number":125,"context_line":"            })"},{"line_number":126,"context_line":"            existing_sns \u003d manila_scenario._list_share_networks("},{"line_number":127,"context_line":"                detailed\u003dFalse, search_opts\u003d{\"project_id\": tenant_id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a6af52e1","side":"PARENT","line":124,"range":{"start_line":122,"start_character":16,"end_line":124,"end_character":44},"updated":"2018-09-06 13:08:26.000000000","message":"I really like that we remove this. It was easy to forget transmit api_versions","commit_id":"99c475809138f1ed49f5b2bd60bf2f72b7a5f1fd"}],"rally_openstack/osclients.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dce612120ef6fcf36d77ec364567c465a02ba110","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        if not isinstance(self.credential, oscred.OpenStackCredential):"},{"line_number":113,"context_line":"            self.credential \u003d oscred.OpenStackCredential(**self.credential)"},{"line_number":114,"context_line":"        if api_info:"},{"line_number":115,"context_line":"            LOG.warning(\"api_info is deprecated. api information has been\""},{"line_number":116,"context_line":"                        \" moved into credential argument.\")"},{"line_number":117,"context_line":"            self.credential.api_info.update(api_info)"},{"line_number":118,"context_line":"        self.cache \u003d cache_obj"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_66b5ba31","line":115,"range":{"start_line":115,"start_character":25,"end_line":115,"end_character":48},"updated":"2018-09-06 13:08:26.000000000","message":"please include class name. \"api_info argument of %s is deprecated \" % self.__class__.__name__","commit_id":"4308f27acd348301bb1d31c5a779b593d705bd30"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dce612120ef6fcf36d77ec364567c465a02ba110","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            LOG.warning(\"api_info is deprecated. api information has been\""},{"line_number":116,"context_line":"                        \" moved into credential argument.\")"},{"line_number":117,"context_line":"            self.credential.api_info.update(api_info)"},{"line_number":118,"context_line":"        self.cache \u003d cache_obj"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def choose_version(self, version\u003dNone):"},{"line_number":121,"context_line":"        \"\"\"Return version string."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_46ed1e23","line":118,"range":{"start_line":118,"start_character":7,"end_line":118,"end_character":30},"updated":"2018-09-06 13:08:26.000000000","message":"since None is a default value, everything can be broken while trying to access cache. add something like:\n\n     self.cache \u003d cache_obj if cache_obj is not None else {}","commit_id":"4308f27acd348301bb1d31c5a779b593d705bd30"}],"rally_openstack/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dce612120ef6fcf36d77ec364567c465a02ba110","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                        \"a long time and latest novaclient doesn\u0027t support \""},{"line_number":465,"context_line":"                        \"it, so we too.\")"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        if \"api_versions\" in config.get(\"contexts\", {}):"},{"line_number":468,"context_line":"            api_versions \u003d config[\"contexts\"][\"api_versions\"]"},{"line_number":469,"context_line":"        else:"},{"line_number":470,"context_line":"            api_versions \u003d config.get(\"contexts\", {}).get("},{"line_number":471,"context_line":"                \"api_versions@openstack\", {})"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_66e37a35","side":"PARENT","line":469,"range":{"start_line":467,"start_character":7,"end_line":469,"end_character":13},"updated":"2018-09-06 13:08:26.000000000","message":"I think it is still valid. api_versions context can be specified in the task as `api_versions` or `api_versions@opensdack`. Both ways are valid now.","commit_id":"99c475809138f1ed49f5b2bd60bf2f72b7a5f1fd"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"cc8659d3d098c80a0832d3f836b6b4968b980911","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                        \"a long time and latest novaclient doesn\u0027t support \""},{"line_number":465,"context_line":"                        \"it, so we too.\")"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        if \"api_versions\" in config.get(\"contexts\", {}):"},{"line_number":468,"context_line":"            api_versions \u003d config[\"contexts\"][\"api_versions\"]"},{"line_number":469,"context_line":"        else:"},{"line_number":470,"context_line":"            api_versions \u003d config.get(\"contexts\", {}).get("},{"line_number":471,"context_line":"                \"api_versions@openstack\", {})"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_980aa376","side":"PARENT","line":469,"range":{"start_line":467,"start_character":7,"end_line":469,"end_character":13},"in_reply_to":"3f79a3b5_66e37a35","updated":"2018-09-07 06:24:56.000000000","message":"Does config only contain the configure of workload ?","commit_id":"99c475809138f1ed49f5b2bd60bf2f72b7a5f1fd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4a9c6e5b8c3a742bfe3bb5f3703ca856a1144d81","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                        \"a long time and latest novaclient doesn\u0027t support \""},{"line_number":465,"context_line":"                        \"it, so we too.\")"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        if \"api_versions\" in config.get(\"contexts\", {}):"},{"line_number":468,"context_line":"            api_versions \u003d config[\"contexts\"][\"api_versions\"]"},{"line_number":469,"context_line":"        else:"},{"line_number":470,"context_line":"            api_versions \u003d config.get(\"contexts\", {}).get("},{"line_number":471,"context_line":"                \"api_versions@openstack\", {})"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dbffb263","side":"PARENT","line":469,"range":{"start_line":467,"start_character":7,"end_line":469,"end_character":13},"in_reply_to":"3f79a3b5_980aa376","updated":"2018-09-07 09:57:22.000000000","message":"yes.","commit_id":"99c475809138f1ed49f5b2bd60bf2f72b7a5f1fd"}]}
