)]}'
{"rally_openstack/contexts/barbican/secrets.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ef09db88298301e6e190c15573b789a087e02bd","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@context.configure(name\u003d\"key_manager\", platform\u003d\"openstack\", order\u003d1500)"},{"line_number":25,"context_line":"class BarbicanGenerator(context.Context):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":28,"context_line":"        \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f880dbf8","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":41},"updated":"2018-11-05 12:58:34.000000000","message":"Can you add a docstring with an explanation for this plugin?","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"f7088eb122698622ae698f08bf57cf155f7a3ebf","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@context.configure(name\u003d\"key_manager\", platform\u003d\"openstack\", order\u003d1500)"},{"line_number":25,"context_line":"class BarbicanGenerator(context.Context):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":28,"context_line":"        \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_601ff4b7","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":41},"in_reply_to":"3f79a3b5_f880dbf8","updated":"2018-11-14 20:26:12.000000000","message":"Done","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ef09db88298301e6e190c15573b789a087e02bd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                \"minimum\": 1"},{"line_number":40,"context_line":"            }"},{"line_number":41,"context_line":"        },"},{"line_number":42,"context_line":"        \"required\": [\"secret\", \"secrets_per_tenant\"],"},{"line_number":43,"context_line":"        \"additionalProperties\": False"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b872634a","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":50},"updated":"2018-11-05 12:58:34.000000000","message":"you can use DEFAULT_CONFIG[1] variable to set \u00271\u0027 as default for this option. I do not see any reason to require setting it.\n\n[1] - https://github.com/openstack/rally-openstack/blob/master/rally_openstack/contexts/nova/servers.py#L84-L87","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"f7088eb122698622ae698f08bf57cf155f7a3ebf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                \"minimum\": 1"},{"line_number":40,"context_line":"            }"},{"line_number":41,"context_line":"        },"},{"line_number":42,"context_line":"        \"required\": [\"secret\", \"secrets_per_tenant\"],"},{"line_number":43,"context_line":"        \"additionalProperties\": False"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f417429d","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":50},"in_reply_to":"3f79a3b5_b872634a","updated":"2018-11-14 20:26:12.000000000","message":"Done","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ef09db88298301e6e190c15573b789a087e02bd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        payload \u003d self.config[\"payload\"]"},{"line_number":49,"context_line":"        secrets_per_tenant \u003d self.config[\"secrets_per_tenant\"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":52,"context_line":"                self.context[\"users\"]):"},{"line_number":53,"context_line":"            self.context[\"tenants\"][tenant_id].setdefault(\"key_manager\", [])"},{"line_number":54,"context_line":"            clients \u003d osclients.Clients(user[\"credentials\"])"},{"line_number":55,"context_line":"            barbican_service \u003d barbican.BarbicanService("},{"line_number":56,"context_line":"                clients,"},{"line_number":57,"context_line":"                name_generator\u003dself.generate_random_name,"},{"line_number":58,"context_line":"                atomic_inst\u003dself.atomic_actions())"},{"line_number":59,"context_line":"            for i in range(secrets_per_tenant):"},{"line_number":60,"context_line":"                secret \u003d barbican_service.create_secret("},{"line_number":61,"context_line":"                    secret, payload\u003dpayload)"},{"line_number":62,"context_line":"                self.context[\"tenants\"][tenant_id][\"key_manager\"].append("},{"line_number":63,"context_line":"                    secret._as_dict())"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def cleanup(self):"},{"line_number":66,"context_line":"        resource_manager.cleanup("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f8953b32","line":63,"range":{"start_line":51,"start_character":7,"end_line":63,"end_character":38},"updated":"2018-11-05 12:58:34.000000000","message":"previously I thought that creating secrets requires admin privileges. Is not it?","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"f7088eb122698622ae698f08bf57cf155f7a3ebf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        payload \u003d self.config[\"payload\"]"},{"line_number":49,"context_line":"        secrets_per_tenant \u003d self.config[\"secrets_per_tenant\"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":52,"context_line":"                self.context[\"users\"]):"},{"line_number":53,"context_line":"            self.context[\"tenants\"][tenant_id].setdefault(\"key_manager\", [])"},{"line_number":54,"context_line":"            clients \u003d osclients.Clients(user[\"credentials\"])"},{"line_number":55,"context_line":"            barbican_service \u003d barbican.BarbicanService("},{"line_number":56,"context_line":"                clients,"},{"line_number":57,"context_line":"                name_generator\u003dself.generate_random_name,"},{"line_number":58,"context_line":"                atomic_inst\u003dself.atomic_actions())"},{"line_number":59,"context_line":"            for i in range(secrets_per_tenant):"},{"line_number":60,"context_line":"                secret \u003d barbican_service.create_secret("},{"line_number":61,"context_line":"                    secret, payload\u003dpayload)"},{"line_number":62,"context_line":"                self.context[\"tenants\"][tenant_id][\"key_manager\"].append("},{"line_number":63,"context_line":"                    secret._as_dict())"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def cleanup(self):"},{"line_number":66,"context_line":"        resource_manager.cleanup("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b40eaa8c","line":63,"range":{"start_line":51,"start_character":7,"end_line":63,"end_character":38},"in_reply_to":"3f79a3b5_f8953b32","updated":"2018-11-14 20:26:12.000000000","message":"Done","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"}],"rally_openstack/scenarios/barbican/secrets.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ef09db88298301e6e190c15573b789a087e02bd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup@openstack\": [\"barbican\"]},"},{"line_number":57,"context_line":"                    name\u003d\"BarbicanSecrets.create_and_delete\")"},{"line_number":58,"context_line":"class BarbicanSecretsCreateAndDelete(BarbicanBase):"},{"line_number":59,"context_line":"    def run(self, secret, payload):"},{"line_number":60,"context_line":"        \"\"\"Create and Delete secret.\"\"\""},{"line_number":61,"context_line":"        secret_ref \u003d self.admin_barbican.create_secret(secret, payload\u003dpayload)"},{"line_number":62,"context_line":"        self.admin_barbican.delete_secret(secret_ref.secret_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f8a77bba","line":59,"range":{"start_line":59,"start_character":18,"end_line":59,"end_character":26},"updated":"2018-11-05 12:58:34.000000000","message":"In general, we never allow passing resource name. In case of crashing Rally in the middle of workload, it will be impossible to identify which resources were created by Rally and which are not.","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5ef09db88298301e6e190c15573b789a087e02bd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup@openstack\": [\"barbican\"]},"},{"line_number":57,"context_line":"                    name\u003d\"BarbicanSecrets.create_and_delete\")"},{"line_number":58,"context_line":"class BarbicanSecretsCreateAndDelete(BarbicanBase):"},{"line_number":59,"context_line":"    def run(self, secret, payload):"},{"line_number":60,"context_line":"        \"\"\"Create and Delete secret.\"\"\""},{"line_number":61,"context_line":"        secret_ref \u003d self.admin_barbican.create_secret(secret, payload\u003dpayload)"},{"line_number":62,"context_line":"        self.admin_barbican.delete_secret(secret_ref.secret_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_38873314","line":59,"range":{"start_line":59,"start_character":26,"end_line":59,"end_character":33},"updated":"2018-11-05 12:58:34.000000000","message":"It would be nice to make \u0027payload\u0027 option optional.","commit_id":"fc6e304ffc6ba98a62ede1ca854f35b1c00453a2"}]}
