)]}'
{"rally_openstack/cleanup/resources.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8afa9f2413676bbcefbd910821e224b25b6c9867","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"@base.resource(\"octavia\", \"loadbalancer\", order\u003dnext(_neutron_order),"},{"line_number":328,"context_line":"               tenant_resource\u003dTrue)"},{"line_number":329,"context_line":"class OctaviaLoadbalancer(base.ResourceManager):"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def _client(self):"},{"line_number":332,"context_line":"        return octavia.Octavia(self.admin or self.user)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_8c8354a7","line":329,"range":{"start_line":329,"start_character":5,"end_line":329,"end_character":37},"updated":"2018-12-09 09:46:46.000000000","message":"should we add a separate cleanup resource for pools ?","commit_id":"b4f44e1009e7179bad638e7c5079b389d9537a02"}],"rally_openstack/scenarios/octavia/pools.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally_openstack import scenario"},{"line_number":21,"context_line":"from rally_openstack.scenarios.octavia import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\"\"\"Scenarios for Octavia Loadbalancer pools.\"\"\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5066b4bf","line":23,"updated":"2018-12-03 11:58:16.000000000","message":"LOG is unused.","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally_openstack import scenario"},{"line_number":21,"context_line":"from rally_openstack.scenarios.octavia import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\"\"\"Scenarios for Octavia Loadbalancer pools.\"\"\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5648ecb3","line":23,"in_reply_to":"3f79a3b5_5066b4bf","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        Measure the \"Octavia loadbalancer pool list\" command performance."},{"line_number":40,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":41,"context_line":"        loadbalancers."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"},{"line_number":44,"context_line":"                               request options"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_10603c9e","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":21},"updated":"2018-12-03 11:58:16.000000000","message":"pools","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        Measure the \"Octavia loadbalancer pool list\" command performance."},{"line_number":40,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":41,"context_line":"        loadbalancers."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"},{"line_number":44,"context_line":"                               request options"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d68f1cd0","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":21},"in_reply_to":"3f79a3b5_10603c9e","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def run(self, lb_create_args\u003dNone, pool_create_args\u003dNone,"},{"line_number":101,"context_line":"            pool_update_args\u003dNone):"},{"line_number":102,"context_line":"        \"\"\"Create a loadbalancer per each subnet and then update"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        Measure the \"Octavia loadbalancer update\" command performance."},{"line_number":105,"context_line":"        The scenario creates a loadbalancer for every subnet and then"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_701f300b","line":102,"updated":"2018-12-03 11:58:16.000000000","message":"Please fix comments","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def run(self, lb_create_args\u003dNone, pool_create_args\u003dNone,"},{"line_number":101,"context_line":"            pool_update_args\u003dNone):"},{"line_number":102,"context_line":"        \"\"\"Create a loadbalancer per each subnet and then update"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        Measure the \"Octavia loadbalancer update\" command performance."},{"line_number":105,"context_line":"        The scenario creates a loadbalancer for every subnet and then"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b68ce0de","line":102,"in_reply_to":"3f79a3b5_701f300b","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"class CreateAndShowPools(utils.OctaviaBase):"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def run(self, lb_create_args\u003dNone, pool_create_args\u003dNone):"},{"line_number":140,"context_line":"        \"\"\"Create a loadbalancer per each subnet and then compare"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        Mearsure the \"Octavia loadbalancer show\" command performance."},{"line_number":143,"context_line":"        The scenario creates a loadbalancer and check the id of the"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_501474eb","line":140,"updated":"2018-12-03 11:58:16.000000000","message":"the same here","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"class CreateAndShowPools(utils.OctaviaBase):"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def run(self, lb_create_args\u003dNone, pool_create_args\u003dNone):"},{"line_number":140,"context_line":"        \"\"\"Create a loadbalancer per each subnet and then compare"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        Mearsure the \"Octavia loadbalancer show\" command performance."},{"line_number":143,"context_line":"        The scenario creates a loadbalancer and check the id of the"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_16f03460","line":140,"in_reply_to":"3f79a3b5_501474eb","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                loadbalancer[\"loadbalancer\"][\"id\"], **pool_create_args)"},{"line_number":162,"context_line":"            pool \u003d self.octavia.pool_show("},{"line_number":163,"context_line":"                pools[\"id\"])"},{"line_number":164,"context_line":"            self.assertEqual(pools[\"id\"], pool[\"id\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_901c4c66","line":164,"updated":"2018-12-03 11:58:16.000000000","message":"looks this line is redundant.","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d50f322a45da3697b33aea2d80dc5089d613463e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally_openstack import scenario"},{"line_number":21,"context_line":"from rally_openstack.scenarios.octavia import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\"\"\"Scenarios for Octavia Loadbalancer pools.\"\"\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6185f6aa","line":23,"updated":"2018-12-05 01:42:31.000000000","message":"We could remove this line due to be unused.","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cdbf5fdc2e58ba6c9c0d9544b696baa1477d32c5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from rally_openstack import scenario"},{"line_number":21,"context_line":"from rally_openstack.scenarios.octavia import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\"\"\"Scenarios for Octavia Loadbalancer pools.\"\"\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_3e9e2952","line":23,"in_reply_to":"3f79a3b5_6185f6aa","updated":"2018-12-05 14:25:29.000000000","message":"Done","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d50f322a45da3697b33aea2d80dc5089d613463e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Create a loadbalancer pool per each subnet and then pools."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        Measure the \"Octavia loadbalancer pool list\" command performance."},{"line_number":40,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":41,"context_line":"        pools."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_81a93227","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":52},"updated":"2018-12-05 01:42:31.000000000","message":"load balancer","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cdbf5fdc2e58ba6c9c0d9544b696baa1477d32c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \"\"\"Create a loadbalancer pool per each subnet and then pools."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        Measure the \"Octavia loadbalancer pool list\" command performance."},{"line_number":40,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":41,"context_line":"        pools."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_feb511d0","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":52},"in_reply_to":"3f79a3b5_81a93227","updated":"2018-12-05 14:25:29.000000000","message":"Done","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d50f322a45da3697b33aea2d80dc5089d613463e","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        Measure the \"Octavia loadbalancer pool update\" command performance."},{"line_number":105,"context_line":"        The scenario creates a loadbalancer for every subnet and then"},{"line_number":106,"context_line":"        updates the loadbalancer."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"},{"line_number":109,"context_line":"                               request options"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_21b93e7a","line":106,"updated":"2018-12-05 01:42:31.000000000","message":"create a pool for every load balancer and then update the pool.","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cdbf5fdc2e58ba6c9c0d9544b696baa1477d32c5","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        Measure the \"Octavia loadbalancer pool update\" command performance."},{"line_number":105,"context_line":"        The scenario creates a loadbalancer for every subnet and then"},{"line_number":106,"context_line":"        updates the loadbalancer."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"},{"line_number":109,"context_line":"                               request options"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9ea65da8","line":106,"in_reply_to":"3f79a3b5_21b93e7a","updated":"2018-12-05 14:25:29.000000000","message":"Done","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d50f322a45da3697b33aea2d80dc5089d613463e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\"Create a pool per each subnet and show it"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        Mearsure the \"Octavia loadbalancer pool show\" command performance."},{"line_number":143,"context_line":"        The scenario creates a loadbalancer and check the id of the"},{"line_number":144,"context_line":"        created loadbalancer and the result of the \"Octavia loadbalancer"},{"line_number":145,"context_line":"        show pool command\"."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"},{"line_number":148,"context_line":"                               request options"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_619e56fb","line":145,"range":{"start_line":143,"start_character":0,"end_line":145,"end_character":27},"updated":"2018-12-05 01:42:31.000000000","message":"Please fix this comment for pools","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cdbf5fdc2e58ba6c9c0d9544b696baa1477d32c5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        \"\"\"Create a pool per each subnet and show it"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        Mearsure the \"Octavia loadbalancer pool show\" command performance."},{"line_number":143,"context_line":"        The scenario creates a loadbalancer and check the id of the"},{"line_number":144,"context_line":"        created loadbalancer and the result of the \"Octavia loadbalancer"},{"line_number":145,"context_line":"        show pool command\"."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        :param lb_create_args: dict, POST /v2/lbaas/loadbalancer"},{"line_number":148,"context_line":"                               request options"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9edbbd1d","line":145,"range":{"start_line":143,"start_character":0,"end_line":145,"end_character":27},"in_reply_to":"3f79a3b5_619e56fb","updated":"2018-12-05 14:25:29.000000000","message":"Done","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8afa9f2413676bbcefbd910821e224b25b6c9867","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":31,"context_line":"class CreateAndListPools(utils.OctaviaBase):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def run(self, lb_create_args\u003dNone, pool_create_args\u003dNone):"},{"line_number":34,"context_line":"        \"\"\"Create a loadbalancer pool per each subnet and then pools."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        Measure the \"Octavia loadbalancer pool list\" command performance."}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_ecad2834","line":33,"range":{"start_line":33,"start_character":18,"end_line":33,"end_character":60},"updated":"2018-12-09 09:46:46.000000000","message":"the same comment as for previous patch in the chain","commit_id":"b4f44e1009e7179bad638e7c5079b389d9537a02"}],"rally_openstack/services/loadbalancer/octavia.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return loadbalancers"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @atomic.action_timer(\"octavia.load_balancer_delete\")"},{"line_number":78,"context_line":"    def load_balancer_delete(self, lb_id, cascade\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Delete a load balancer"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param string lb_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_30de983d","line":78,"range":{"start_line":78,"start_character":42,"end_line":78,"end_character":49},"updated":"2018-12-03 11:58:16.000000000","message":"Please add comment for cascade argument","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return loadbalancers"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @atomic.action_timer(\"octavia.load_balancer_delete\")"},{"line_number":78,"context_line":"    def load_balancer_delete(self, lb_id, cascade\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Delete a load balancer"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param string lb_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f61818cf","line":78,"range":{"start_line":78,"start_character":42,"end_line":78,"end_character":49},"in_reply_to":"3f79a3b5_30de983d","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        params \u003d {}"},{"line_number":87,"context_line":"        if cascade:"},{"line_number":88,"context_line":"            params \u003d {\"cascade\": True}"},{"line_number":89,"context_line":"        return self._clients.octavia().load_balancer_delete(lb_id, **params)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @atomic.action_timer(\"octavia.load_balancer_set\")"},{"line_number":92,"context_line":"    def load_balancer_set(self, lb_id, **lb_update_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_30753835","line":89,"updated":"2018-12-03 11:58:16.000000000","message":"looks we could directly use \u0027load_balancer_delete(lb_id, cascade\u003dcascade)\u0027 instead.","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        params \u003d {}"},{"line_number":87,"context_line":"        if cascade:"},{"line_number":88,"context_line":"            params \u003d {\"cascade\": True}"},{"line_number":89,"context_line":"        return self._clients.octavia().load_balancer_delete(lb_id, **params)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @atomic.action_timer(\"octavia.load_balancer_set\")"},{"line_number":92,"context_line":"    def load_balancer_set(self, lb_id, **lb_update_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d6739c1a","line":89,"in_reply_to":"3f79a3b5_30753835","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if getattr(e, \"status_code\", 400) \u003d\u003d 404:"},{"line_number":214,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dpool)"},{"line_number":215,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dpool, err\u003de)"},{"line_number":216,"context_line":"        return new_pool"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @atomic.action_timer(\"octavia.pool_create\")"},{"line_number":219,"context_line":"    def pool_create(self, lb_id, **pool_create):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_301f78ba","line":216,"updated":"2018-12-03 11:58:16.000000000","message":"new_pool or new_pool[\"pool\"] ? Sorry, i do not clear it.","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if getattr(e, \"status_code\", 400) \u003d\u003d 404:"},{"line_number":214,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dpool)"},{"line_number":215,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dpool, err\u003de)"},{"line_number":216,"context_line":"        return new_pool"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @atomic.action_timer(\"octavia.pool_create\")"},{"line_number":219,"context_line":"    def pool_create(self, lb_id, **pool_create):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d65cfc80","line":216,"in_reply_to":"3f79a3b5_301f78ba","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"2c60f9c32dfe5676ab87034e21b177fbc660b51a","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :param lb_id:"},{"line_number":223,"context_line":"            Loadbalancer id to be used for the pool."},{"line_number":224,"context_line":"        :param kwargs:"},{"line_number":225,"context_line":"            Parameters to create a listener with (expects json\u003d)"},{"line_number":226,"context_line":"        :return:"},{"line_number":227,"context_line":"            A dict of the created pool\u0027s settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_109fdc4e","line":224,"updated":"2018-12-03 11:58:16.000000000","message":"pool_create","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"44aca66b5ee7131503090d8a840a969b767142d5","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        :param lb_id:"},{"line_number":223,"context_line":"            Loadbalancer id to be used for the pool."},{"line_number":224,"context_line":"        :param kwargs:"},{"line_number":225,"context_line":"            Parameters to create a listener with (expects json\u003d)"},{"line_number":226,"context_line":"        :return:"},{"line_number":227,"context_line":"            A dict of the created pool\u0027s settings"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9656845d","line":224,"in_reply_to":"3f79a3b5_109fdc4e","updated":"2018-12-03 13:22:07.000000000","message":"Done","commit_id":"7c9680d177f4ad87252f2b5c2f6bedec71dbad96"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"a11b20da9f67afb1309d312520761b7b21bdd8fd","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if getattr(e, \"status_code\", 400) \u003d\u003d 404:"},{"line_number":214,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dpool)"},{"line_number":215,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dpool, err\u003de)"},{"line_number":216,"context_line":"        return new_pool[\"pool\"]"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @atomic.action_timer(\"octavia.pool_create\")"},{"line_number":219,"context_line":"    def pool_create(self, lb_id, **pool_create):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_17a104f5","line":216,"updated":"2018-12-04 00:59:55.000000000","message":"HI Chuck, Sorry, log shown the fail, new_pool is ok. I saw the api has a pool key, https://developer.openstack.org/api-ref/load-balancer/v2/?expanded\u003dremove-a-load-balancer-detail,create-pool-detail,show-pool-details-detail#prov-status","commit_id":"c02fb36fddfaf72456a092be651e7184baf00d50"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"7d33300afb53ac0df6aae2265c87abe6f1cbc800","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if getattr(e, \"status_code\", 400) \u003d\u003d 404:"},{"line_number":214,"context_line":"                raise exceptions.GetResourceNotFound(resource\u003dpool)"},{"line_number":215,"context_line":"            raise exceptions.GetResourceFailure(resource\u003dpool, err\u003de)"},{"line_number":216,"context_line":"        return new_pool[\"pool\"]"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    @atomic.action_timer(\"octavia.pool_create\")"},{"line_number":219,"context_line":"    def pool_create(self, lb_id, **pool_create):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6fcdf1b7","line":216,"in_reply_to":"3f79a3b5_17a104f5","updated":"2018-12-04 14:09:17.000000000","message":"Done","commit_id":"c02fb36fddfaf72456a092be651e7184baf00d50"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"d50f322a45da3697b33aea2d80dc5089d613463e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        :param lb_id:"},{"line_number":223,"context_line":"            Loadbalancer id to be used for the pool."},{"line_number":224,"context_line":"        :param pool_create:"},{"line_number":225,"context_line":"            Parameters to create a listener with (expects json\u003d)"},{"line_number":226,"context_line":"        :return:"},{"line_number":227,"context_line":"            A dict of the created pool\u0027s settings"},{"line_number":228,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e13586f6","line":225,"range":{"start_line":225,"start_character":12,"end_line":225,"end_character":64},"updated":"2018-12-05 01:42:31.000000000","message":"Parameters to create a pool for a load balancer","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"cdbf5fdc2e58ba6c9c0d9544b696baa1477d32c5","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        :param lb_id:"},{"line_number":223,"context_line":"            Loadbalancer id to be used for the pool."},{"line_number":224,"context_line":"        :param pool_create:"},{"line_number":225,"context_line":"            Parameters to create a listener with (expects json\u003d)"},{"line_number":226,"context_line":"        :return:"},{"line_number":227,"context_line":"            A dict of the created pool\u0027s settings"},{"line_number":228,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_feed118d","line":225,"range":{"start_line":225,"start_character":12,"end_line":225,"end_character":64},"in_reply_to":"3f79a3b5_e13586f6","updated":"2018-12-05 14:25:29.000000000","message":"Done","commit_id":"8a70aeecc5e58dea743f53b80d560ee851771950"}]}
