)]}'
{"id":"openstack%2Frally-openstack~742641","triplet_id":"openstack%2Frally-openstack~master~I7a33995b749fc806a1866f68dd7334be343610b7","project":"openstack/rally-openstack","branch":"master","hashtags":[],"change_id":"I7a33995b749fc806a1866f68dd7334be343610b7","subject":"Rename ext_network to floating_network in Nova tasks","status":"ABANDONED","created":"2020-07-23 11:13:29.000000000","updated":"2020-08-06 10:35:20.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9e676d275261fe08852af9db31e24ed55c55ee29","_number":742641,"virtual_id_number":742641,"owner":{"_account_id":11692,"name":"Cédric OLLIVIER","email":"ollivier.cedric@gmail.com","username":"col"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-07-23 12:55:34.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-07-23 12:34:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-23 12:34:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-23 12:55:34.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"}],"messages":[{"id":"a414b6c18f7a57157269fd97d78cdd0532d596d1","author":{"_account_id":11692,"name":"Cédric OLLIVIER","email":"ollivier.cedric@gmail.com","username":"col"},"date":"2020-07-23 11:13:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"407a6019e3a98eece3a62f9ece8e989ee0f067dc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-23 12:34:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- rally-tox-cover https://zuul.opendev.org/t/openstack/build/11ac098091714bdf95b96bf408d18c70 : SUCCESS in 5m 28s\n- rally-tox-pep8 https://zuul.opendev.org/t/openstack/build/5a26bcd3cc95465da298b22ec2368025 : SUCCESS in 4m 03s\n- rally-tox-py36 https://zuul.opendev.org/t/openstack/build/663c14f3ed2f409cad0c06f880bf9725 : SUCCESS in 4m 24s\n- rally-tox-py37 https://zuul.opendev.org/t/openstack/build/b604a7ce702f49f3acdee8b1b74f7dbe : SUCCESS in 5m 15s\n- rally-tox-py38 https://zuul.opendev.org/t/openstack/build/5c0c0c2da3704f43bd122c26798c7a13 : SUCCESS in 4m 49s\n- rally-dsvm-tox-functional https://zuul.opendev.org/t/openstack/build/02662f484c594946ac87969090394795 : SUCCESS in 40m 41s\n- rally-openstack-docker-build https://zuul.opendev.org/t/openstack/build/4708f4723a7349ba835b9cba00a36fb2 : SUCCESS in 8m 49s\n- rally-task-basic-with-existing-users https://zuul.opendev.org/t/openstack/build/192547cfb6c340bd87de392d50afc6ab : SUCCESS in 25m 34s\n- rally-task-simple-job https://zuul.opendev.org/t/openstack/build/c53f575036944baf901eabaa4cf4d067 : SUCCESS in 31m 42s\n- rally-task-cinder https://zuul.opendev.org/t/openstack/build/2863fe12050646309682952499d75717 : SUCCESS in 53m 25s\n- rally-task-heat https://zuul.opendev.org/t/openstack/build/917a10e969f6472f9277362eb77d5cd6 : FAILURE in 52m 55s (non-voting)\n- rally-task-ironic https://zuul.opendev.org/t/openstack/build/52275939ec734909aa68c16856ae1be4 : SUCCESS in 35m 21s\n- rally-task-keystone-glance-swift https://zuul.opendev.org/t/openstack/build/619190f74c354a9381635a06f3e748d4 : SUCCESS in 28m 56s\n- rally-task-manila-no-ss https://zuul.opendev.org/t/openstack/build/c46e5820c31b4548888883aef6591638 : SUCCESS in 37m 47s (non-voting)\n- rally-task-manila-ss https://zuul.opendev.org/t/openstack/build/50c99cc3e344450bbe5a8bc829b99cc5 : SUCCESS in 37m 54s (non-voting)\n- rally-task-mistral https://zuul.opendev.org/t/openstack/build/accc612870774e1b961ece5a64948eb5 : SUCCESS in 37m 17s\n- rally-task-murano https://zuul.opendev.org/t/openstack/build/5cb4fab847db485ebbe4aa0ed238f001 : FAILURE in 34m 53s (non-voting)\n- rally-task-neutron https://zuul.opendev.org/t/openstack/build/1116e3f121284c248460cb9f295d9183 : SUCCESS in 1h 13m 14s\n- rally-task-neutron-with-extensions https://zuul.opendev.org/t/openstack/build/70e49f7615be4487ab5a314318bf9696 : SUCCESS in 25m 15s (non-voting)\n- rally-task-nova https://zuul.opendev.org/t/openstack/build/6dbafa16930143c6bab137dcf1365031 : FAILURE in 1h 04m 54s (non-voting)\n- rally-task-telemetry https://zuul.opendev.org/t/openstack/build/eac21f15455b49baa6d47a8c6ff63239 : SUCCESS in 35m 50s\n- rally-task-watcher https://zuul.opendev.org/t/openstack/build/b0a1654143cd4a489086630b7104ae30 : SUCCESS in 31m 19s (non-voting)\n- rally-task-zaqar https://zuul.opendev.org/t/openstack/build/f03d5a67047848878258cdd9d9bcf084 : SUCCESS in 37m 26s\n- rally-verify-tempest https://zuul.opendev.org/t/openstack/build/5f137795fae740f79cbe1cfe788f0c89 : SUCCESS in 36m 03s","accounts_in_message":[],"_revision_number":1},{"id":"c5e700ae78f4f98eee9e05f70387629e57228b4b","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2020-07-23 12:55:34.000000000","message":"Patch Set 1:\n\nThanks for pointing to the issue. I missed this compatibility stuff while doing https://github.com/openstack/rally-openstack/commit/4c207ae082427adf642860f25a789b2bc8951bfd \n\nSince original breaking change was not released yet, it is better to fix incompatibility. \n\n`create_floating_address` dict was transmitted to netwrok_wrapper\nhttps://github.com/openstack/rally-openstack/blob/2.0.0/rally_openstack/task/scenarios/nova/servers.py#L929-L930\n\nThe only thing was possible to transmit there was ext_network - https://github.com/openstack/rally-openstack/blob/2.0.0/rally_openstack/common/wrappers/network.py#L372\n\nI suggest to deprecate create_floating_address arg (like https://github.com/openstack/rally-openstack/blob/2.0.0/rally_openstack/task/scenarios/cinder/volumes.py#L422-L424) and introduce a new argument that is used for setting floating network id + backward compatible check for old arg.\n\nThoughts?","accounts_in_message":[],"_revision_number":1},{"id":"9e676d275261fe08852af9db31e24ed55c55ee29","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2020-08-06 10:35:20.000000000","message":"Abandoned\n\naddressed by https://review.opendev.org/#/c/744693/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"96c67ba8f4ba05ee06411616a3f782391ea9edcc","revisions":{"96c67ba8f4ba05ee06411616a3f782391ea9edcc":{"kind":"REWORK","_number":1,"created":"2020-07-23 11:13:29.000000000","uploader":{"_account_id":11692,"name":"Cédric OLLIVIER","email":"ollivier.cedric@gmail.com","username":"col"},"ref":"refs/changes/41/742641/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rally-openstack","ref":"refs/changes/41/742641/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rally-openstack refs/changes/41/742641/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rally-openstack refs/changes/41/742641/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rally-openstack refs/changes/41/742641/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rally-openstack refs/changes/41/742641/1"}}},"commit":{"parents":[{"commit":"4c207ae082427adf642860f25a789b2bc8951bfd","subject":"Use NeutronService helper instead of network wrapper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally-openstack/commit/4c207ae082427adf642860f25a789b2bc8951bfd"}]}],"author":{"name":"Cédric Ollivier","email":"cedric.ollivier@orange.com","date":"2020-07-23 11:11:26.000000000","tz":120},"committer":{"name":"Cédric Ollivier","email":"ollivier.cedric@gmail.com","date":"2020-07-23 11:13:22.000000000","tz":120},"subject":"Rename ext_network to floating_network in Nova tasks","message":"Rename ext_network to floating_network in Nova tasks\n\nIt now fails [1]:\n    Traceback (most recent call last):\n      File \"/src/rally/rally/task/runner.py\", line 70, in _run_scenario_once\n        getattr(scenario_inst, method_name)(**scenario_kwargs)\n      File \"/usr/lib/python3.8/site-packages/rally_openstack/task/scenarios/nova/servers.py\", line 1115, in run\n        floatingip \u003d self.neutron.create_floatingip(**create_floating_ip_args)\n      File \"/src/rally/rally/task/service.py\", line 114, in wrapper\n        return func(instance, *args, **kwargs)\n      File \"/src/rally/rally/task/atomic.py\", line 91, in func_atomic_actions\n        f \u003d func(self, *args, **kwargs)\n    TypeError: create_floatingip() got an unexpected keyword argument \u0027ext_network\u0027\n\n[1] http://artifacts.opnfv.org/functest/JOGVTC31O1IL/functest-opnfv-functest-smoke-latest-rally_sanity-run-905/rally_sanity/rally_sanity.html#/NovaServers.boot_server_associate_and_dissociate_floating_ip/failures\n\nChange-Id: I7a33995b749fc806a1866f68dd7334be343610b7\nSigned-off-by: Cédric Ollivier \u003ccedric.ollivier@orange.com\u003e\nSigned-off-by: Cédric Ollivier \u003collivier.cedric@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally-openstack/commit/96c67ba8f4ba05ee06411616a3f782391ea9edcc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally-openstack/commit/96c67ba8f4ba05ee06411616a3f782391ea9edcc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}