)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3db2c94f87dbf3fb843ed1fdb383a3c4fbe528a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ffdd01a_2a3adec6","updated":"2021-12-23 15:13:15.000000000","message":"Thanks for submitting the change and fixing a bug. The proposed change LGTM, but it would be nice to do some backward compatibility at least for the scenario part (rally-openstack 2.2.0 transmitted existing name to the API).","commit_id":"36f85f8e44ffcbf0f8cd871f743d0e477c94c9f9"},{"author":{"_account_id":34367,"name":"AlexV","display_name":"AlexV","email":"alexv@mirantis.com","username":"alexv"},"change_message_id":"74af535c7884899de859a7e00ee29dc8bb4a5893","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e87fb25_09e8918c","in_reply_to":"1ffdd01a_2a3adec6","updated":"2022-01-18 13:52:06.000000000","message":"Done","commit_id":"36f85f8e44ffcbf0f8cd871f743d0e477c94c9f9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e60bddd3d693a2214ae9d0d95e42cde68c5d671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0ba5b716_9334c1a2","updated":"2022-01-20 17:01:19.000000000","message":"LGTM, but pep8 should be fixed first","commit_id":"9e3dfa6ad68dda8813e010fdf5a9588f218bfd61"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a921478e51ef233ed90e63da02c717494bcc7dc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d86923aa_b82da453","updated":"2022-01-20 20:18:14.000000000","message":"see output of `tox -e pep8` here -https://zuul.opendev.org/t/openstack/build/84756bb038954087a56321caa63c8a8d","commit_id":"9e3dfa6ad68dda8813e010fdf5a9588f218bfd61"},{"author":{"_account_id":34367,"name":"AlexV","display_name":"AlexV","email":"alexv@mirantis.com","username":"alexv"},"change_message_id":"dd02af91ded523962beb4d3baae3229c590cbf7b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0598fe6a_91c9cc11","in_reply_to":"0ba5b716_9334c1a2","updated":"2022-01-20 17:31:43.000000000","message":"Can more specific?","commit_id":"9e3dfa6ad68dda8813e010fdf5a9588f218bfd61"},{"author":{"_account_id":34367,"name":"AlexV","display_name":"AlexV","email":"alexv@mirantis.com","username":"alexv"},"change_message_id":"d37723fc81a90b61ebd404a486a71df314ae124a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f87a8e1d_a566d8da","in_reply_to":"d86923aa_b82da453","updated":"2022-01-21 10:14:43.000000000","message":"It`s a joke? 80 symbols in 2021 year? Ohh, ok...\nI changed first 2, but on ./rally_openstack/task/scenarios/cinder/volume_types.py:96 exist only one variant to format for accepted by pep8\n\n```\n            name\u003dupdate_name\n            and self.generate_random_name()\n            or volume_type.name,\n```\nand it make this code unreadable. I will make this change only if you insist.\n\nP.S. Perhaps should change rule to 120 symbols, because people many years not used display with 80 symbols width.","commit_id":"9e3dfa6ad68dda8813e010fdf5a9588f218bfd61"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c2c55b637960b5e43776046671f8c2813dd8e79e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"82859797_fe025df3","updated":"2022-01-25 16:43:15.000000000","message":"Sorry, I found one more issue with this scenario so decided to make a quick change to merge this change soon.\n\nas for 80 chars limitation - it comes from official guideline of openstack styling. Changing that stuff should happen in coordination of the whole community.\n\nPS: Thanks for proposing this fix. I approved it quickly and it should be merged as soon as it passes CI.","commit_id":"078d06240da4e382c977a581a56c0695307ca261"}],"rally_openstack/task/scenarios/cinder/volume_types.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3db2c94f87dbf3fb843ed1fdb383a3c4fbe528a7","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        volume_type \u003d self.admin_cinder.create_volume_type("},{"line_number":88,"context_line":"            description\u003ddescription,"},{"line_number":89,"context_line":"            is_public\u003dis_public)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.admin_cinder.update_volume_type("},{"line_number":92,"context_line":"            volume_type,"},{"line_number":93,"context_line":"            name\u003dupdate_name and self.generate_random_name() or None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b7eb2b6_0529b557","line":90,"updated":"2021-12-23 15:13:15.000000000","message":"it would be nice to add a check here for verifying that at least one of update_name, update_description and update_is_public is specified. In case of false statement, let\u0027s print a warning and fallback to previous flow (transmit an existing name).","commit_id":"36f85f8e44ffcbf0f8cd871f743d0e477c94c9f9"},{"author":{"_account_id":34367,"name":"AlexV","display_name":"AlexV","email":"alexv@mirantis.com","username":"alexv"},"change_message_id":"74af535c7884899de859a7e00ee29dc8bb4a5893","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        volume_type \u003d self.admin_cinder.create_volume_type("},{"line_number":88,"context_line":"            description\u003ddescription,"},{"line_number":89,"context_line":"            is_public\u003dis_public)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.admin_cinder.update_volume_type("},{"line_number":92,"context_line":"            volume_type,"},{"line_number":93,"context_line":"            name\u003dupdate_name and self.generate_random_name() or None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"326aa2a4_dca2e397","line":90,"in_reply_to":"4b7eb2b6_0529b557","updated":"2022-01-18 13:52:06.000000000","message":"Done","commit_id":"36f85f8e44ffcbf0f8cd871f743d0e477c94c9f9"}]}