)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"f93dc6b20e76bef842b876f0edf7812fac0804f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"07bd6206_4e157e28","updated":"2023-01-23 11:18:48.000000000","message":"recheck rally-task-neutron-trunk","commit_id":"46379ec1e90f88c04d298a28ba4b666041394370"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"0b2a124ef4841a9e4f35f390acc78d718133971f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"15b8ff3e_d4cc8d5c","updated":"2023-03-28 13:45:13.000000000","message":"@Andrey hello, can you help me on this change?","commit_id":"e75bfab4dbd3e50481bef80a9badbb401d7e9058"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"f4b550e89c463660bbb8b6f9d681eecacd5c61f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"427413ad_5731ff60","updated":"2023-03-13 14:05:24.000000000","message":"rally-core","commit_id":"e75bfab4dbd3e50481bef80a9badbb401d7e9058"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"2ec5db46747f6a1d59917ef099f5eea0bda33699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1165e892_0bfb0301","updated":"2023-03-13 08:38:11.000000000","message":"recheck rally-tox-cover","commit_id":"e75bfab4dbd3e50481bef80a9badbb401d7e9058"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"701ad4738be5ca209857b5b782d6ac6639525c2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6f1dbe64_8c072e7b","updated":"2023-05-24 19:59:58.000000000","message":"sorry for late reply. CI is restored now and I\u0027m ready to approve this commit regardless of not yet merged neutron\u0027s change https://review.opendev.org/c/openstack/neutron/+/861169.\nHave one inline question. Trying to understand the context","commit_id":"9a9ae2e2244cefb0f631a513d12fbc3a15dab568"}],"rally_openstack/task/scenarios/neutron/trunk.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"701ad4738be5ca209857b5b782d6ac6639525c2a","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        trunk_payload \u003d {\"port_id\": parent[\"port\"][\"id\"],"},{"line_number":55,"context_line":"                         \"sub_ports\": subport_payload}"},{"line_number":56,"context_line":"        trunk \u003d self._create_trunk(trunk_payload)"},{"line_number":57,"context_line":"        self._update_port(parent, {\"device_id\": \"sometrunk\"})"},{"line_number":58,"context_line":"        self._list_trunks()"},{"line_number":59,"context_line":"        self._list_subports_by_trunk(trunk[\"trunk\"][\"id\"])"},{"line_number":60,"context_line":"        self._list_ports_by_device_id(\"sometrunk\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"40407bd3_fdc47b16","side":"PARENT","line":57,"updated":"2023-05-24 19:59:58.000000000","message":"Do you have any ideas why this line was implemented before?","commit_id":"d66486874dafa4a43e3a12155676aef6402ffe6b"},{"author":{"_account_id":33607,"name":"Pierre Libeau","email":"pierre.libeau@ovhcloud.com","username":"plibeau"},"change_message_id":"82c27a04e8b1140a40a74859dcca6b5bf9638766","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        trunk_payload \u003d {\"port_id\": parent[\"port\"][\"id\"],"},{"line_number":55,"context_line":"                         \"sub_ports\": subport_payload}"},{"line_number":56,"context_line":"        trunk \u003d self._create_trunk(trunk_payload)"},{"line_number":57,"context_line":"        self._update_port(parent, {\"device_id\": \"sometrunk\"})"},{"line_number":58,"context_line":"        self._list_trunks()"},{"line_number":59,"context_line":"        self._list_subports_by_trunk(trunk[\"trunk\"][\"id\"])"},{"line_number":60,"context_line":"        self._list_ports_by_device_id(\"sometrunk\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"412350eb_362e8f42","side":"PARENT","line":57,"in_reply_to":"40407bd3_fdc47b16","updated":"2023-05-31 09:30:06.000000000","message":"Good question. I have dig and the code come from this commit without explanation inside. https://review.opendev.org/c/openstack/neutron/+/409267\n\nIf I understand correctly, port update is just used to found the port after in the function _list_ports_by_device_id so I can also remove this function.\n\nI will do it.","commit_id":"d66486874dafa4a43e3a12155676aef6402ffe6b"}]}