)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"e4f93b8d9344609b4369840f5cfcf49606b8eaf9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Rather than calling _generate_random_name() multiple times in scenarios."},{"line_number":10,"context_line":"Better to call it once inside utils."},{"line_number":11,"context_line":"Affected method _create_image() of glance secnario."},{"line_number":12,"context_line":"Similar to Bug: 1412014"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If0b6f358f4087d9c35d4af9cd4e22ea601c757d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_abd76e22","line":12,"updated":"2015-02-27 14:12:20.000000000","message":"I\u0027ve changed the bug status to \"In progress\", and since it seems like your change shifts all the_generate_random_name() calls that can be shifted, you can close the bug here:\n\n    Closes-Bug: 1412014","commit_id":"2589e9f57ec6d9ab7db5a77723a9152d1f4f6e73"}],"rally/benchmark/scenarios/glance/utils.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"e4f93b8d9344609b4369840f5cfcf49606b8eaf9","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @base.atomic_action_timer(\"glance.create_image\")"},{"line_number":61,"context_line":"    def _create_image(self, container_format,"},{"line_number":62,"context_line":"                      image_location, disk_format, image_name\u003dNone, **kwargs):"},{"line_number":63,"context_line":"        \"\"\"Create a new image."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        :param container_format: container format of image. Acceptable"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_8b9aaac3","line":62,"updated":"2015-02-27 14:12:20.000000000","message":"Better just \u0027name\u0027 instead of \u0027image_name\u0027, to be consisten with your previous patch:\n\nhttps://github.com/stackforge/rally/blob/master/rally/benchmark/scenarios/nova/utils.py#L83","commit_id":"2589e9f57ec6d9ab7db5a77723a9152d1f4f6e73"}],"tests/unit/benchmark/scenarios/glance/test_utils.py":[{"author":{"_account_id":9180,"name":"Olga Kopylova","email":"olkonami@gmail.com","username":"olkonami"},"change_message_id":"8549f0db90603448cc20eeebcd8a426dc395b37b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        scenario \u003d utils.GlanceScenario()"},{"line_number":71,"context_line":"        return_image \u003d scenario._create_image(\"container_format\","},{"line_number":72,"context_line":"                                              image_location.name,"},{"line_number":73,"context_line":"                                              \"disk_format\")"},{"line_number":74,"context_line":"        self.wait_for.mock.assert_called_once_with(self.image,"},{"line_number":75,"context_line":"                                                   update_resource\u003dself.gfm(),"},{"line_number":76,"context_line":"                                                   is_ready\u003dself.res_is.mock(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_36b67a8b","line":73,"updated":"2015-02-27 16:40:55.000000000","message":"I think now we need add check that _generate_random_name() is called if image name is not specified.\nAlso it\u0027s better to have additional test for _create_image if image name is specified","commit_id":"6ba78e39441f426f892f3a80d32673bdf52a6f0f"}]}