)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-12 14:12:14 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds median metric to summary report of task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd154c9f00b5e9d6df11797685fe8f92c4fdbb1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_4bce435b","line":8,"updated":"2015-03-15 09:00:17.000000000","message":"is there bp/spec?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"abcd7e04501ea09d49e8dce4bbf22cfb67eb86bc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-12 14:12:14 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds median metric to summary report of task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd154c9f00b5e9d6df11797685fe8f92c4fdbb1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_a662963b","line":8,"in_reply_to":"9a80dd14_26d30605","updated":"2015-03-15 11:37:27.000000000","message":"Just wondering if one exists. no need to create one if not.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"12baa2aa2b6c480a66717a9f1e3a965920ab1d26","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-12 14:12:14 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds median metric to summary report of task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd154c9f00b5e9d6df11797685fe8f92c4fdbb1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_26d30605","line":8,"in_reply_to":"9a80dd14_4bce435b","updated":"2015-03-15 11:09:15.000000000","message":"Such changes do not require any BP/specs","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-12 14:12:14 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds median metric to summary report of task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Icd154c9f00b5e9d6df11797685fe8f92c4fdbb1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_05709306","line":8,"in_reply_to":"9a80dd14_a662963b","updated":"2015-03-16 16:44:04.000000000","message":"@Yair\n\nThis commit started simple, just adding a new column to the summary report. It ended up with all the other things changed. :S\n\nI will update commit accordingly. Thanks for the review.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"}],"rally/benchmark/processing/plot.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    round(utils.median(durations), 3),"},{"line_number":238,"context_line":"                    round(utils.percentile(durations, 0.90), 3),"},{"line_number":239,"context_line":"                    round(utils.percentile(durations, 0.95), 3),"},{"line_number":240,"context_line":"                    round(max(durations), 3),"},{"line_number":241,"context_line":"                    round(utils.mean(durations), 3),"},{"line_number":242,"context_line":"                    \"%.1f%%\" % (len(durations) * 100.0 / len(raw)),"},{"line_number":243,"context_line":"                    len(raw)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_ebfc5774","line":240,"updated":"2015-03-15 09:00:17.000000000","message":"why change the order?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1ab3e539c3efc1f9803eacbf674788e67d8ec865","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    round(utils.median(durations), 3),"},{"line_number":238,"context_line":"                    round(utils.percentile(durations, 0.90), 3),"},{"line_number":239,"context_line":"                    round(utils.percentile(durations, 0.95), 3),"},{"line_number":240,"context_line":"                    round(max(durations), 3),"},{"line_number":241,"context_line":"                    round(utils.mean(durations), 3),"},{"line_number":242,"context_line":"                    \"%.1f%%\" % (len(durations) * 100.0 / len(raw)),"},{"line_number":243,"context_line":"                    len(raw)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_b3f623d7","line":240,"in_reply_to":"9a80dd14_20d5851b","updated":"2015-03-16 19:53:50.000000000","message":"Ok, so if there\u0027s logic to the re-order - please state so in commit message","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                    round(utils.median(durations), 3),"},{"line_number":238,"context_line":"                    round(utils.percentile(durations, 0.90), 3),"},{"line_number":239,"context_line":"                    round(utils.percentile(durations, 0.95), 3),"},{"line_number":240,"context_line":"                    round(max(durations), 3),"},{"line_number":241,"context_line":"                    round(utils.mean(durations), 3),"},{"line_number":242,"context_line":"                    \"%.1f%%\" % (len(durations) * 100.0 / len(raw)),"},{"line_number":243,"context_line":"                    len(raw)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_20d5851b","line":240,"in_reply_to":"9a80dd14_ebfc5774","updated":"2015-03-16 16:44:04.000000000","message":"min, median, %iles, max describe \"order\" statistics, or percentiles, with this commit they will be in sorted increasing order.\n\nAverage, or mean, is not like the others, it describes the central tendency of the samples, and nothing about order.\n\nIf other metrics are added later like, confidence intervals,  imho, adding them next to average would be a good place, for same reasons, unless those metrics are percentiles.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    for result in results:"},{"line_number":263,"context_line":"        table_cols \u003d [\"Action\","},{"line_number":264,"context_line":"                      \"Min (sec)\","},{"line_number":265,"context_line":"                      \"Median (sec)\","},{"line_number":266,"context_line":"                      \"90%ile (sec)\","},{"line_number":267,"context_line":"                      \"95%ile (sec)\","},{"line_number":268,"context_line":"                      \"Max (sec)\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_6bd94721","line":265,"updated":"2015-03-15 09:00:17.000000000","message":"Why change the order?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"}],"rally/benchmark/processing/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e98fb3bd7dbb4f148f12921cce1024c2628f795b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    :returns: float value"},{"line_number":41,"context_line":"     \"\"\""},{"line_number":42,"context_line":"    if not values:"},{"line_number":43,"context_line":"        raise exceptions.InvalidArgumentsException(\"no median for empty data\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    values \u003d sorted(values)"},{"line_number":46,"context_line":"    size \u003d len(values)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_553bc2ea","line":43,"updated":"2015-03-11 23:55:41.000000000","message":"I would like to cleanup usage of strange exceptions in Rally. Could you rise here just ValueError ?","commit_id":"7937d9c7ec9ca95676a5824b028ce56fddad4a82"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"b3ee89fd6af5556eb939cbedf6fd8256067cea0c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    :returns: float value"},{"line_number":41,"context_line":"     \"\"\""},{"line_number":42,"context_line":"    if not values:"},{"line_number":43,"context_line":"        raise exceptions.InvalidArgumentsException(\"no median for empty data\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    values \u003d sorted(values)"},{"line_number":46,"context_line":"    size \u003d len(values)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_7b151548","line":43,"in_reply_to":"9a80dd14_553bc2ea","updated":"2015-03-12 00:59:05.000000000","message":"Done","commit_id":"7937d9c7ec9ca95676a5824b028ce56fddad4a82"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :returns: float value"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if not values:"},{"line_number":30,"context_line":"        msg \u003d \"the list should be non-empty\""},{"line_number":31,"context_line":"        raise exceptions.InvalidArgumentsException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    return math.fsum(values) / len(values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_4bf56381","line":30,"updated":"2015-03-15 09:00:17.000000000","message":"I\u0027m not an expert in this, but since you add \"_\", why is this msg not using it?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"1ab3e539c3efc1f9803eacbf674788e67d8ec865","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :returns: float value"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if not values:"},{"line_number":30,"context_line":"        msg \u003d \"the list should be non-empty\""},{"line_number":31,"context_line":"        raise exceptions.InvalidArgumentsException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    return math.fsum(values) / len(values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_7324ab60","line":30,"in_reply_to":"9a80dd14_0047a1a3","updated":"2015-03-16 19:53:50.000000000","message":"agreed - please avoid unrelated changes in patch","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    :returns: float value"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if not values:"},{"line_number":30,"context_line":"        msg \u003d \"the list should be non-empty\""},{"line_number":31,"context_line":"        raise exceptions.InvalidArgumentsException(msg)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    return math.fsum(values) / len(values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_0047a1a3","line":30,"in_reply_to":"9a80dd14_4bf56381","updated":"2015-03-16 16:44:04.000000000","message":"The \"_\" is a wrapper to facilitate translation. I didn\u0027t using on msg, since I didn\u0027t want to change the behavior of the mean function, because it\u0027s not related to this commit. \n\nProbably I should have not touched this function at all.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    :returns: float value"},{"line_number":42,"context_line":"     \"\"\""},{"line_number":43,"context_line":"    if not values:"},{"line_number":44,"context_line":"        raise ValueError(_(\"no median for empty data\"))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    values \u003d sorted(values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_8bebdba2","line":43,"updated":"2015-03-15 09:00:17.000000000","message":"why not use the same Exception and msg like mean(values)?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    :returns: float value"},{"line_number":42,"context_line":"     \"\"\""},{"line_number":43,"context_line":"    if not values:"},{"line_number":44,"context_line":"        raise ValueError(_(\"no median for empty data\"))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    values \u003d sorted(values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_e0736d4b","line":43,"in_reply_to":"9a80dd14_8bebdba2","updated":"2015-03-16 16:44:04.000000000","message":"Boris requested to move to Python provided exceptions (ValueError specifically). Initially it was like the mean exception.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"8a06280a5c12bb04f2fc6a473c72ddaa075e3c45","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :returns: float value"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if not values:"},{"line_number":30,"context_line":"        msg \u003d \"the list should be non-empty\""},{"line_number":31,"context_line":"        raise exceptions.InvalidArgumentsException(msg)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab921fb_c2df7d38","line":29,"updated":"2015-04-27 08:06:37.000000000","message":"why touch this?","commit_id":"0e1a10ce3a01c0e674711db7b53b575ab8a8e848"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"14fc696d996b025b71760e3fb6d869ed6451318d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    :returns: float value"},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    if not values:"},{"line_number":30,"context_line":"        msg \u003d \"the list should be non-empty\""},{"line_number":31,"context_line":"        raise exceptions.InvalidArgumentsException(msg)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7ad32947_6acb9f73","line":29,"in_reply_to":"bab921fb_c2df7d38","updated":"2015-04-27 14:52:45.000000000","message":"I think initially Boris wanted me to clean up the some of the exceptions, and I modified it. But you are right that should go in its own commit separate from this one.","commit_id":"0e1a10ce3a01c0e674711db7b53b575ab8a8e848"}],"rally/cmd/cliutils.py":[{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        have mixed case names (e.g., \u0027serverId\u0027)"},{"line_number":96,"context_line":"    :param field_labels: Labels to use in the heading of the table, default to"},{"line_number":97,"context_line":"        fields."},{"line_number":98,"context_line":"    :param table_label: Label to use as header for the whole table."},{"line_number":99,"context_line":"    \"\"\""},{"line_number":100,"context_line":"    formatters \u003d formatters or {}"},{"line_number":101,"context_line":"    mixed_case_fields \u003d mixed_case_fields or []"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_4b3c832f","line":98,"updated":"2015-03-15 09:00:17.000000000","message":"why is this change related?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        print(encodeutils.safe_encode(table_body))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def make_table_header(table_label, table_width,"},{"line_number":147,"context_line":"                      junction_char\u003d\"+\", horizontal_char\u003d\"-\","},{"line_number":148,"context_line":"                      vertical_char\u003d\"|\"):"},{"line_number":149,"context_line":"    \"\"\"Generalized way make a table header string."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_ab141fa0","line":146,"updated":"2015-03-15 09:00:17.000000000","message":"This seems like a good but unrelated change.\nI could be wrong. Please explain in commit message","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        print(encodeutils.safe_encode(table_body))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def make_table_header(table_label, table_width,"},{"line_number":147,"context_line":"                      junction_char\u003d\"+\", horizontal_char\u003d\"-\","},{"line_number":148,"context_line":"                      vertical_char\u003d\"|\"):"},{"line_number":149,"context_line":"    \"\"\"Generalized way make a table header string."}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_404fd991","line":146,"in_reply_to":"9a80dd14_ab141fa0","updated":"2015-03-16 16:44:04.000000000","message":"The quick version is that previously we were using the units (sec) in each column metric label, and was making the table really long. So we decided to remove the duplicity by factoring it out to the table header.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"}],"rally/cmd/commands/task.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"53b3f60cd18aef356120b457a13780b6abe6ba3f","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            raw \u003d result[\"data\"][\"raw\"]"},{"line_number":329,"context_line":"            table_cols \u003d [\"action\", \"min (sec)\", \"avg (sec)\", \"max (sec)\","},{"line_number":330,"context_line":"                          \"median (sec)\", \"90 percentile\", \"95 percentile\","},{"line_number":331,"context_line":"                          \"success\", \"count\"]"},{"line_number":332,"context_line":"            float_cols \u003d [\"min (sec)\", \"avg (sec)\", \"max (sec)\","},{"line_number":333,"context_line":"                          \"median (sec)\", \"90 percentile\", \"95 percentile\"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_b03bd5cf","line":330,"updated":"2015-03-07 11:47:30.000000000","message":"I think it would be more natural to have median before max:\n\nmin - mean - median - max - ...\n\nThe same below","commit_id":"2a47afb25e44e57940796b5b8cdeb41d775b70c6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e98fb3bd7dbb4f148f12921cce1024c2628f795b","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raw \u003d result[\"data\"][\"raw\"]"},{"line_number":329,"context_line":"            table_cols \u003d [\"action\", \"min (sec)\", \"median (sec)\","},{"line_number":330,"context_line":"                          \"90%ile (sec)\", \"95%ile (sec)\", \"max (sec)\","},{"line_number":331,"context_line":"                          \"avg (sec)\", \"success\", \"count\"]"},{"line_number":332,"context_line":"            float_cols \u003d [\"min (sec)\", \"median (sec)\","},{"line_number":333,"context_line":"                          \"90%ile (sec)\", \"95%ile (sec)\", \"max (sec)\","},{"line_number":334,"context_line":"                          \"avg (sec)\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_15186a83","line":331,"updated":"2015-03-11 23:55:41.000000000","message":"It will be better to put \"avg\" just after min() \n\nBtw what do you think about putting only once (sec) form example\n\n  \"action (sec)\"\n\nand remove rest. This will reduce size of table and make simpler interface.","commit_id":"7937d9c7ec9ca95676a5824b028ce56fddad4a82"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            pprint.pprint(key[\"kw\"])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            raw \u003d result[\"data\"][\"raw\"]"},{"line_number":329,"context_line":"            table_cols \u003d [\"action\", \"min\", \"median\","},{"line_number":330,"context_line":"                          \"90%ile\", \"95%ile\", \"max\","},{"line_number":331,"context_line":"                          \"avg\", \"success\", \"count\"]"},{"line_number":332,"context_line":"            float_cols \u003d [\"min\", \"median\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_2b282fe1","line":329,"updated":"2015-03-15 09:00:17.000000000","message":"Why change the order here instead of just adding the \"median\"?","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":326,"context_line":"            pprint.pprint(key[\"kw\"])"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"            raw \u003d result[\"data\"][\"raw\"]"},{"line_number":329,"context_line":"            table_cols \u003d [\"action\", \"min\", \"median\","},{"line_number":330,"context_line":"                          \"90%ile\", \"95%ile\", \"max\","},{"line_number":331,"context_line":"                          \"avg\", \"success\", \"count\"]"},{"line_number":332,"context_line":"            float_cols \u003d [\"min\", \"median\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_5b07c817","line":329,"in_reply_to":"9a80dd14_2b282fe1","updated":"2015-03-16 16:44:04.000000000","message":"See previous reply to earlier comment.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"3f33392cbdb4acb49d427367a17905ee70f312ed","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            for action in actions_data:"},{"line_number":342,"context_line":"                durations \u003d actions_data[action]"},{"line_number":343,"context_line":"                if durations:"},{"line_number":344,"context_line":"                    data \u003d [action,"},{"line_number":345,"context_line":"                            round(min(durations), 3),"},{"line_number":346,"context_line":"                            round(utils.median(durations), 3),"},{"line_number":347,"context_line":"                            round(utils.percentile(durations, 0.90), 3),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_ab7b3ff3","line":344,"updated":"2015-03-15 09:00:17.000000000","message":"You are also doing some rounding of values. This is reasonable but please add this to commit message.","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"},{"author":{"_account_id":8840,"name":"Carlos L. Torres","email":"carlos.torres@rackspace.com","username":"carl6796"},"change_message_id":"2219283ba3fb7ce866fea010afd344db818935de","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            for action in actions_data:"},{"line_number":342,"context_line":"                durations \u003d actions_data[action]"},{"line_number":343,"context_line":"                if durations:"},{"line_number":344,"context_line":"                    data \u003d [action,"},{"line_number":345,"context_line":"                            round(min(durations), 3),"},{"line_number":346,"context_line":"                            round(utils.median(durations), 3),"},{"line_number":347,"context_line":"                            round(utils.percentile(durations, 0.90), 3),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_a00df53f","line":344,"in_reply_to":"9a80dd14_ab7b3ff3","updated":"2015-03-16 16:44:04.000000000","message":"Done","commit_id":"88174e61c7317e85dc39b55ea0335dbac3d29c66"}]}