)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8c59dd4264e210ce7bba88879b90c6ae51a907c9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Sahara] Improve Image context"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The context now supports exisng images via \u0027existing_id\u0027 parameter."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I87648a97b03b0a271e822f29ec472851734ae5a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa963961_37f3b90c","line":9,"updated":"2015-03-26 22:46:42.000000000","message":"typo *existing","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"}],"rally/benchmark/context/sahara/sahara_image.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"9cf3f71a9293905184b5233d0717789ee51ab226","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            },"},{"line_number":49,"context_line":"        },"},{"line_number":50,"context_line":"        \"additionalProperties\": False,"},{"line_number":51,"context_line":"        \"required\": [\"image_url\", \"username\", \"plugin_name\", \"hadoop_version\"]"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_bcd09154","side":"PARENT","line":51,"updated":"2015-03-23 15:45:33.000000000","message":"jsonschema does support \"oneOf\"\n\ne.g. https://github.com/stackforge/rally/blob/master/rally/deploy/engines/existing.py#L65-L82","commit_id":"13de04f09c43c4825467130da69f693f8ae131f1"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"9cf3f71a9293905184b5233d0717789ee51ab226","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        existing_id \u003d self.config.get(\"existing_id\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        image_url \u003d self.config[\"image_url\"]"},{"line_number":87,"context_line":"        plugin_name \u003d self.config[\"plugin_name\"]"},{"line_number":88,"context_line":"        hadoop_version \u003d self.config[\"hadoop_version\"]"},{"line_number":89,"context_line":"        user_name \u003d self.config[\"username\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_bc05f1c3","line":86,"updated":"2015-03-23 15:45:33.000000000","message":"this code is called in any case, and it will fail with KeyError if there is no \"image_url\" in config.\n\nseems like it should be moved under \"if not existing_id\" (line 95)","commit_id":"aa47f2df1cd9357fc63514129aba56adda71cf57"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8c59dd4264e210ce7bba88879b90c6ae51a907c9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            clients\u003dclients)"},{"line_number":70,"context_line":"        image_name \u003d scenarios_base.Scenario._generate_random_name("},{"line_number":71,"context_line":"            prefix\u003d\"sahara_image_\", length\u003d15)"},{"line_number":72,"context_line":"        image \u003d glance_util_class._create_image(image_name,"},{"line_number":73,"context_line":"                                                \"bare\","},{"line_number":74,"context_line":"                                                image_url,"},{"line_number":75,"context_line":"                                                \"qcow2\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_258dc231","line":72,"updated":"2015-03-26 22:46:42.000000000","message":"We don\u0027t use other image properties except id","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8c59dd4264e210ce7bba88879b90c6ae51a907c9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        clients.sahara().images.update_tags(image_id\u003dimage.id,"},{"line_number":80,"context_line":"                                            new_tags\u003d[plugin_name,"},{"line_number":81,"context_line":"                                                      hadoop_version])"},{"line_number":82,"context_line":"        return image"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Enter context: `Sahara Image`\"))"},{"line_number":85,"context_line":"    def setup(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_a5e4320d","line":82,"updated":"2015-03-26 22:46:42.000000000","message":"Why we return image if use only image.id in setup?","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"df2a2ce6dff8286ec5718f356292507e3e33b773","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        clients.sahara().images.update_tags(image_id\u003dimage.id,"},{"line_number":80,"context_line":"                                            new_tags\u003d[plugin_name,"},{"line_number":81,"context_line":"                                                      hadoop_version])"},{"line_number":82,"context_line":"        return image"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Enter context: `Sahara Image`\"))"},{"line_number":85,"context_line":"    def setup(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_b2eeac89","line":82,"in_reply_to":"fa963961_a5e4320d","updated":"2015-03-27 09:25:39.000000000","message":"Agree. Id is enough.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8c59dd4264e210ce7bba88879b90c6ae51a907c9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Enter context: `Sahara Image`\"))"},{"line_number":85,"context_line":"    def setup(self):"},{"line_number":86,"context_line":"        # The user may want to use the existing image. In this case he should"},{"line_number":87,"context_line":"        # make sure that the image is public and has all required metadata."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        existing_id \u003d self.config.get(\"existing_id\")"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_e5d59ab9","line":87,"updated":"2015-03-26 22:46:42.000000000","message":"Where we check this info? I think it must be done in validation.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"df2a2ce6dff8286ec5718f356292507e3e33b773","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Enter context: `Sahara Image`\"))"},{"line_number":85,"context_line":"    def setup(self):"},{"line_number":86,"context_line":"        # The user may want to use the existing image. In this case he should"},{"line_number":87,"context_line":"        # make sure that the image is public and has all required metadata."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        existing_id \u003d self.config.get(\"existing_id\")"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_32dcdce3","line":87,"in_reply_to":"fa963961_e5d59ab9","updated":"2015-03-27 09:25:39.000000000","message":"Yes, we can check that the image exists and it is public.\nChecking the tags will require user to provide the \"username\", \"plugin_name\" and \"hadoop_version\" parameters. This validation will be done anyway inside Sahara, so I think there is no reason to duplicate it here.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8c59dd4264e210ce7bba88879b90c6ae51a907c9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d False"},{"line_number":106,"context_line":"                image_id \u003d existing_id"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            self.context[\"tenants\"][tenant_id][\"sahara_image\"] \u003d image_id"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Exit context: `Sahara Image`\"))"},{"line_number":111,"context_line":"    def cleanup(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_a55b1254","line":108,"updated":"2015-03-26 22:46:42.000000000","message":"What if there is no image with such id?","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"df2a2ce6dff8286ec5718f356292507e3e33b773","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d False"},{"line_number":106,"context_line":"                image_id \u003d existing_id"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            self.context[\"tenants\"][tenant_id][\"sahara_image\"] \u003d image_id"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Exit context: `Sahara Image`\"))"},{"line_number":111,"context_line":"    def cleanup(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_92096898","line":108,"in_reply_to":"fa963961_a55b1254","updated":"2015-03-27 09:25:39.000000000","message":"If so, the benchmark will fail almost immediately. User will see the image exception from Sahara.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c2073e251e726d708304d279e8d7cfbcdf97f7df","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def cleanup(self):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(boris-42): Delete only resources created by this context"},{"line_number":114,"context_line":"        if self.context[\"need_sahara_image_cleanup\"]:"},{"line_number":115,"context_line":"            resource_manager.cleanup(names\u003d[\"glance.images\"],"},{"line_number":116,"context_line":"                                     users\u003dself.context.get(\"users\", []))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_85900e97","line":114,"updated":"2015-03-26 22:09:43.000000000","message":"Why we use bool variable to call cleanup? If we use sahara context then cleanup would be surely called by engine. If we don\u0027t use the wouldn\u0027t.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8c59dd4264e210ce7bba88879b90c6ae51a907c9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def cleanup(self):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(boris-42): Delete only resources created by this context"},{"line_number":114,"context_line":"        if self.context[\"need_sahara_image_cleanup\"]:"},{"line_number":115,"context_line":"            resource_manager.cleanup(names\u003d[\"glance.images\"],"},{"line_number":116,"context_line":"                                     users\u003dself.context.get(\"users\", []))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_b790e996","line":114,"in_reply_to":"fa963961_85900e97","updated":"2015-03-26 22:46:42.000000000","message":"After a while I have understand what you whant to do.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"df2a2ce6dff8286ec5718f356292507e3e33b773","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def cleanup(self):"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(boris-42): Delete only resources created by this context"},{"line_number":114,"context_line":"        if self.context[\"need_sahara_image_cleanup\"]:"},{"line_number":115,"context_line":"            resource_manager.cleanup(names\u003d[\"glance.images\"],"},{"line_number":116,"context_line":"                                     users\u003dself.context.get(\"users\", []))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_12f6788f","line":114,"in_reply_to":"fa963961_b790e996","updated":"2015-03-27 09:25:39.000000000","message":"To make it clear for everyone, the cleanup should not touch the image if it was not downloaded by this context.","commit_id":"0e9f55371da24a2fcd50256c59726a1ea3580196"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ce82076adace6d2bd02325b9b457fb9085abf5b3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"image_url\": {"},{"line_number":42,"context_line":"                \"type\": \"string\","},{"line_number":43,"context_line":"            },"},{"line_number":44,"context_line":"            \"username\": {"},{"line_number":45,"context_line":"                \"type\": \"string\""},{"line_number":46,"context_line":"            },"},{"line_number":47,"context_line":"            \"plugin_name\": {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_a8dd3a72","line":44,"updated":"2015-04-06 15:22:55.000000000","message":"What does username means if we already have name for all users generated in user context? Just a specifying question\u003d)","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"ddc63708fb8f1651757bb7d13114099b2e6d01f6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \"image_url\": {"},{"line_number":42,"context_line":"                \"type\": \"string\","},{"line_number":43,"context_line":"            },"},{"line_number":44,"context_line":"            \"username\": {"},{"line_number":45,"context_line":"                \"type\": \"string\""},{"line_number":46,"context_line":"            },"},{"line_number":47,"context_line":"            \"plugin_name\": {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_327a67f2","line":44,"in_reply_to":"9aa53dc9_a8dd3a72","updated":"2015-04-08 08:42:24.000000000","message":"This username is used by Sahara to log in to vm via ssh. It is different for Ubuntu, CentOS, etc/","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"61f881f7d6b11b753a0a5bc41fb28fd523998aeb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        glance_util_class \u003d glance_utils.GlanceScenario("},{"line_number":70,"context_line":"            clients\u003dclients)"},{"line_number":71,"context_line":"        image_name \u003d scenarios_base.Scenario._generate_random_name("},{"line_number":72,"context_line":"            prefix\u003d\"sahara_image_\", length\u003d15)"},{"line_number":73,"context_line":"        image \u003d glance_util_class._create_image(image_name,"},{"line_number":74,"context_line":"                                                \"bare\","},{"line_number":75,"context_line":"                                                image_url,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_f97d57e8","line":72,"updated":"2015-04-06 15:16:49.000000000","message":"Why length is exactly 15 not 16 as by default?","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"ddc63708fb8f1651757bb7d13114099b2e6d01f6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        glance_util_class \u003d glance_utils.GlanceScenario("},{"line_number":70,"context_line":"            clients\u003dclients)"},{"line_number":71,"context_line":"        image_name \u003d scenarios_base.Scenario._generate_random_name("},{"line_number":72,"context_line":"            prefix\u003d\"sahara_image_\", length\u003d15)"},{"line_number":73,"context_line":"        image \u003d glance_util_class._create_image(image_name,"},{"line_number":74,"context_line":"                                                \"bare\","},{"line_number":75,"context_line":"                                                image_url,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_92693328","line":72,"in_reply_to":"9aa53dc9_f97d57e8","updated":"2015-04-08 08:42:24.000000000","message":"I don\u0027t remember why. There may be no reason at all :)","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"93523566b9aa78c62532cf837c16946cac90c305","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def _check_existing_image(self, image_id, user):"},{"line_number":86,"context_line":"        clients \u003d osclients.Clients(user[\"endpoint\"])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        image \u003d clients.glance().images.get(image_id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if not image.is_public:"},{"line_number":91,"context_line":"            raise exceptions.BenchmarkSetupFailure("}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_ff03ff74","line":88,"updated":"2015-04-06 12:07:34.000000000","message":"If user mistyped image id, then here will be glance HTTPNotFound raised (http://paste.openstack.org/show/198469/).\n\nSo please add try/except here and raise one more BenchmarkSetupFailure in this case, with the message that image is not found","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"ddc63708fb8f1651757bb7d13114099b2e6d01f6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    def _check_existing_image(self, image_id, user):"},{"line_number":86,"context_line":"        clients \u003d osclients.Clients(user[\"endpoint\"])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        image \u003d clients.glance().images.get(image_id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if not image.is_public:"},{"line_number":91,"context_line":"            raise exceptions.BenchmarkSetupFailure("}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_92501360","line":88,"in_reply_to":"9aa53dc9_ff03ff74","updated":"2015-04-08 08:42:24.000000000","message":"Ok, willdo.","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"93523566b9aa78c62532cf837c16946cac90c305","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @rutils.log_task_wrapper(LOG.info, _(\"Enter context: `Sahara Image`\"))"},{"line_number":95,"context_line":"    def setup(self):"},{"line_number":96,"context_line":"        # The user may want to use the existing image. In this case he should"},{"line_number":97,"context_line":"        # make sure that the image is public and has all required metadata."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        existing_id \u003d self.config.get(\"existing_id\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_7ff92fc8","line":96,"updated":"2015-04-06 12:07:34.000000000","message":"Grammar nits, rename:\n\n The user may want to use the existing image.\n to:\n User can use an existing image.","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"61f881f7d6b11b753a0a5bc41fb28fd523998aeb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":102,"context_line":"                self.context[\"users\"]):"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            if not existing_id:"},{"line_number":105,"context_line":"                image_url \u003d self.config[\"image_url\"]"},{"line_number":106,"context_line":"                plugin_name \u003d self.config[\"plugin_name\"]"},{"line_number":107,"context_line":"                hadoop_version \u003d self.config[\"hadoop_version\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_141202b5","line":104,"updated":"2015-04-06 15:16:49.000000000","message":"Why this if inside of cycle? As I understand existing_id doesn\u0027t change during execution of context.","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"83fa9a2a2ae5fc517fa70429b093e099b6b18427","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                hadoop_version \u003d self.config[\"hadoop_version\"]"},{"line_number":108,"context_line":"                user_name \u003d self.config[\"username\"]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"                image_id \u003d self._create_image(hadoop_version, image_url,"},{"line_number":111,"context_line":"                                              plugin_name, user, user_name)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_681a9219","line":110,"updated":"2015-04-06 15:25:21.000000000","message":"Do we really need to create new image for each tenant? This looks strange","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"93523566b9aa78c62532cf837c16946cac90c305","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                image_id \u003d self._create_image(hadoop_version, image_url,"},{"line_number":111,"context_line":"                                              plugin_name, user, user_name)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d True"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d False"},{"line_number":116,"context_line":"                self._check_existing_image(existing_id, user)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_df083b94","line":113,"updated":"2015-04-06 12:07:34.000000000","message":"This can be done once after L99\n\n existing_id \u003d self.config.get(\"existing_id\")\n self.context[\"need_sahara_image_cleanup\"] \u003d bool(existing_id)","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"93523566b9aa78c62532cf837c16946cac90c305","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d True"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d False"},{"line_number":116,"context_line":"                self._check_existing_image(existing_id, user)"},{"line_number":117,"context_line":"                image_id \u003d existing_id"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_9f02b36e","line":115,"updated":"2015-04-06 12:07:34.000000000","message":"ditto","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"83fa9a2a2ae5fc517fa70429b093e099b6b18427","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d True"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                self.context[\"need_sahara_image_cleanup\"] \u003d False"},{"line_number":116,"context_line":"                self._check_existing_image(existing_id, user)"},{"line_number":117,"context_line":"                image_id \u003d existing_id"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"            self.context[\"tenants\"][tenant_id][\"sahara_image\"] \u003d image_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"9aa53dc9_68c85275","line":116,"updated":"2015-04-06 15:25:21.000000000","message":"Why do we check image many times (in this cycle)? Do that once above the `for\u0027 L101","commit_id":"7024b6c5607a3ab3dce0fbdfe747153e3385a7ba"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"cad1bd23621cd25ac273a02deee1507a04036e9d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        glance_util_class \u003d glance_utils.GlanceScenario("},{"line_number":70,"context_line":"            clients\u003dclients)"},{"line_number":71,"context_line":"        image_name \u003d scenarios_base.Scenario._generate_random_name("},{"line_number":72,"context_line":"            prefix\u003d\"sahara_image_\", length\u003d15)"},{"line_number":73,"context_line":"        image \u003d glance_util_class._create_image(image_name,"},{"line_number":74,"context_line":"                                                \"bare\","},{"line_number":75,"context_line":"                                                image_url,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_dc464e7a","line":72,"updated":"2015-04-10 10:49:01.000000000","message":"It\u0027s preferable to use for the future here prefix\u003d\"rally_\" because of https://blueprints.launchpad.net/openstack/?searchtext\u003dadd-cleanup-option.","commit_id":"ff6ed84aaffec486e7d49a97dc983c95841a8cd1"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"040c8112d1e6682bc5877caa00ae0789b8883768","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"type\": \"object\","},{"line_number":36,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"},{"line_number":37,"context_line":"        \"properties\": {"},{"line_number":38,"context_line":"            \"existing_id\": {"},{"line_number":39,"context_line":"                \"type\": \"string\""},{"line_number":40,"context_line":"            },"},{"line_number":41,"context_line":"            \"image_url\": {"}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_e4b66d89","line":38,"updated":"2015-05-02 10:41:41.000000000","message":"It\u0027s better to more common for OpenStack and Rally code, something like: \n\n  image_uuid","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"59405ac0f4898401b364d8a12d921a793a77f28c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"type\": \"object\","},{"line_number":36,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"},{"line_number":37,"context_line":"        \"properties\": {"},{"line_number":38,"context_line":"            \"existing_id\": {"},{"line_number":39,"context_line":"                \"type\": \"string\""},{"line_number":40,"context_line":"            },"},{"line_number":41,"context_line":"            \"image_url\": {"}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_9065811f","line":38,"in_reply_to":"3acd31a7_e4b66d89","updated":"2015-05-05 08:50:04.000000000","message":"ok.","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"040c8112d1e6682bc5877caa00ae0789b8883768","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                                \"bare\","},{"line_number":75,"context_line":"                                                image_url,"},{"line_number":76,"context_line":"                                                \"qcow2\")"},{"line_number":77,"context_line":"        clients.sahara().images.update_image(image_id\u003dimage.id,"},{"line_number":78,"context_line":"                                             user_name\u003duser_name,"},{"line_number":79,"context_line":"                                             desc\u003d\"\")"},{"line_number":80,"context_line":"        clients.sahara().images.update_tags(image_id\u003dimage.id,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_64593d5a","line":77,"updated":"2015-05-02 10:41:41.000000000","message":"Why we are not doing this for existing image?  Or another good question why we are using here sahara API","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"59405ac0f4898401b364d8a12d921a793a77f28c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                                \"bare\","},{"line_number":75,"context_line":"                                                image_url,"},{"line_number":76,"context_line":"                                                \"qcow2\")"},{"line_number":77,"context_line":"        clients.sahara().images.update_image(image_id\u003dimage.id,"},{"line_number":78,"context_line":"                                             user_name\u003duser_name,"},{"line_number":79,"context_line":"                                             desc\u003d\"\")"},{"line_number":80,"context_line":"        clients.sahara().images.update_tags(image_id\u003dimage.id,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_10b3b199","line":77,"in_reply_to":"3acd31a7_64593d5a","updated":"2015-05-05 08:50:04.000000000","message":"The ACLs may not allow us modify public image metadata. The Sahara API is used because it\u0027s going to be used by Sahara later. This call was intentionally added to saharaclient to set the right meta for the images, so why not use it?","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"040c8112d1e6682bc5877caa00ae0789b8883768","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        image \u003d clients.glance().images.get(image_id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if not image.is_public:"},{"line_number":91,"context_line":"            raise exceptions.BenchmarkSetupFailure("},{"line_number":92,"context_line":"                \"Image provided in the Sahara context should be public.\")"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_84ac5936","line":90,"updated":"2015-05-02 10:41:41.000000000","message":"why it should be public?\n\nIf users can see it everything should be fine.","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"59405ac0f4898401b364d8a12d921a793a77f28c","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        image \u003d clients.glance().images.get(image_id)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if not image.is_public:"},{"line_number":91,"context_line":"            raise exceptions.BenchmarkSetupFailure("},{"line_number":92,"context_line":"                \"Image provided in the Sahara context should be public.\")"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_30d46dbb","line":90,"in_reply_to":"3acd31a7_84ac5936","updated":"2015-05-05 08:50:04.000000000","message":"The idea is to use one image in all benchmarking tenants. That\u0027s why it should be public.","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"040c8112d1e6682bc5877caa00ae0789b8883768","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        existing_id \u003d self.config.get(\"existing_id\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.context[\"need_sahara_image_cleanup\"] \u003d not bool(existing_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if existing_id:"},{"line_number":104,"context_line":"            # Using the first user to check the existing image."}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_044e0996","line":101,"updated":"2015-05-02 10:41:41.000000000","message":"self.context[\"need_sahara_image_cleanup\"] \u003d not existing_id,\n\n  not None -\u003e True as well as not bool(None) -\u003e True","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"59405ac0f4898401b364d8a12d921a793a77f28c","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        existing_id \u003d self.config.get(\"existing_id\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.context[\"need_sahara_image_cleanup\"] \u003d not bool(existing_id)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        if existing_id:"},{"line_number":104,"context_line":"            # Using the first user to check the existing image."}],"source_content_type":"text/x-python","patch_set":13,"id":"3acd31a7_50cfe928","line":101,"in_reply_to":"3acd31a7_044e0996","updated":"2015-05-05 08:50:04.000000000","message":"Does it really matter?","commit_id":"537fd2bfe730345b10e5f26096ac22850805675b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"66a6efa526cd4fae4164b68f2f0efc6aaf906174","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from rally.benchmark.context import base"},{"line_number":16,"context_line":"from rally.benchmark.context.cleanup import manager as resource_manager"},{"line_number":17,"context_line":"from rally.benchmark.scenarios import base as scenario_base"},{"line_number":18,"context_line":"from rally.benchmark.scenarios.glance import utils as glance_utils"},{"line_number":19,"context_line":"from rally.common.i18n import _"},{"line_number":20,"context_line":"from rally.common import log as logging"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a0c5dc1_8dadd333","line":17,"updated":"2015-05-12 12:50:14.000000000","message":"This import is not required (see my comment below)","commit_id":"54b1b3f6571cef9776e1c7e346adcf9f6606d518"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"66a6efa526cd4fae4164b68f2f0efc6aaf906174","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def _create_image(self, hadoop_version, image_url, plugin_name, user,"},{"line_number":67,"context_line":"                      user_name):"},{"line_number":68,"context_line":"        clients \u003d osclients.Clients(user[\"endpoint\"])"},{"line_number":69,"context_line":"        glance_util_class \u003d glance_utils.GlanceScenario("},{"line_number":70,"context_line":"            clients\u003dclients)"},{"line_number":71,"context_line":"        image_name \u003d scenario_base.Scenario._generate_random_name("},{"line_number":72,"context_line":"            prefix\u003d\"rally_sahara_image_\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a0c5dc1_e840bd09","line":69,"updated":"2015-05-12 12:50:14.000000000","message":"s/glance_util_class/scenario/\n\n`glance_util_class\u0027 is not a class (that is actually an instance), just name it `scenario\u0027","commit_id":"54b1b3f6571cef9776e1c7e346adcf9f6606d518"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"66a6efa526cd4fae4164b68f2f0efc6aaf906174","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        clients \u003d osclients.Clients(user[\"endpoint\"])"},{"line_number":69,"context_line":"        glance_util_class \u003d glance_utils.GlanceScenario("},{"line_number":70,"context_line":"            clients\u003dclients)"},{"line_number":71,"context_line":"        image_name \u003d scenario_base.Scenario._generate_random_name("},{"line_number":72,"context_line":"            prefix\u003d\"rally_sahara_image_\")"},{"line_number":73,"context_line":"        image \u003d glance_util_class._create_image(name\u003dimage_name,"},{"line_number":74,"context_line":"                                                container_format\u003d\"bare\","}],"source_content_type":"text/x-python","patch_set":15,"id":"9a0c5dc1_8d095334","line":71,"updated":"2015-05-12 12:50:14.000000000","message":"It is better to avoid usage (if possible) of scenarios code in context.\n\nUse `rutils.generate_random_name\u0027 here, and remove import for `scenario_base\u0027 above","commit_id":"54b1b3f6571cef9776e1c7e346adcf9f6606d518"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"66a6efa526cd4fae4164b68f2f0efc6aaf906174","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if image_uuid:"},{"line_number":104,"context_line":"            # Using the first user to check the existing image."},{"line_number":105,"context_line":"            user \u003d self.context[\"users\"][0]"},{"line_number":106,"context_line":"            self._check_existing_image(image_uuid, user)"},{"line_number":107,"context_line":"            image_id \u003d image_uuid"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            for user, tenant_id in rutils.iterate_per_tenants("}],"source_content_type":"text/x-python","patch_set":15,"id":"9a0c5dc1_357e33af","line":106,"updated":"2015-05-12 12:50:14.000000000","message":"Is method `_check_existing_image\u0027 really needed?\n\nIt is:\n * called only once\n * probably would never be called from anywhere else\n * contains only 5 lines of code\n\nI think it would be better to put it\u0027s code right here and get rid of extra method","commit_id":"54b1b3f6571cef9776e1c7e346adcf9f6606d518"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"66a6efa526cd4fae4164b68f2f0efc6aaf906174","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":114,"context_line":"                    self.context[\"users\"]):"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"                image_url \u003d self.config[\"image_url\"]"},{"line_number":117,"context_line":"                plugin_name \u003d self.config[\"plugin_name\"]"},{"line_number":118,"context_line":"                hadoop_version \u003d self.config[\"hadoop_version\"]"},{"line_number":119,"context_line":"                user_name \u003d self.config[\"username\"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a0c5dc1_2874959a","line":116,"updated":"2015-05-12 12:50:14.000000000","message":"I would recommend to use `self.config\u0027 in L124 directly, and do not spawn these 4 variables, since there is no advantage of their use, and they are used only once:\n\n image_id \u003d self._create_image(self.config[\"hadoop_version\"],\n                               self.config[\"image_url\"],\n                               self.config[\"plugin_name\"],\n                               user,\n                               self.config[\"username\"])","commit_id":"54b1b3f6571cef9776e1c7e346adcf9f6606d518"}]}
