)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13555,"name":"Pradeep K Surisetty","username":"pradeepkumars","inactive":true},"change_message_id":"691be3f8da7e473d881eedbe6ae65bbb6b1724f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kun Huang \u003cgareth@openstacker.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-15 09:10:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add test for deployment check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"missing this would cause other issues on dsvm works."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aaa499b_6b6fbfc5","line":7,"updated":"2015-04-15 08:45:36.000000000","message":"s/Add/add","commit_id":"b1e24e3adbb196d0e80856ce164f99a6b3547097"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"51da966dde83d86db5674e43f257849ede3ea885","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kun Huang \u003cgareth@openstacker.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-15 09:10:54 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add test for deployment check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"missing this would cause other issues on dsvm works."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5ad0253b_38bccf6b","line":7,"in_reply_to":"7aaa499b_6b6fbfc5","updated":"2015-04-29 03:53:45.000000000","message":"no problem","commit_id":"b1e24e3adbb196d0e80856ce164f99a6b3547097"},{"author":{"_account_id":13555,"name":"Pradeep K Surisetty","username":"pradeepkumars","inactive":true},"change_message_id":"691be3f8da7e473d881eedbe6ae65bbb6b1724f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add test for deployment check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"missing this would cause other issues on dsvm works."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I6c661dbda30bdd7873ce2b8ebc2a3d9ad4f241d5"},{"line_number":12,"context_line":"Closes-Bug: #1439936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aaa499b_8b78cb90","line":9,"updated":"2015-04-15 08:45:36.000000000","message":"Can you provide few more details please.","commit_id":"b1e24e3adbb196d0e80856ce164f99a6b3547097"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"51da966dde83d86db5674e43f257849ede3ea885","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add test for deployment check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"missing this would cause other issues on dsvm works."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I6c661dbda30bdd7873ce2b8ebc2a3d9ad4f241d5"},{"line_number":12,"context_line":"Closes-Bug: #1439936"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5ad0253b_789367fb","line":9,"in_reply_to":"7aaa499b_8b78cb90","updated":"2015-04-29 03:53:45.000000000","message":"in #1439936\n\nWithout any tests on this, some mistake would stop dsvm job, not unit test. Need more details in this commit message?","commit_id":"b1e24e3adbb196d0e80856ce164f99a6b3547097"}],"tests/unit/cmd/commands/test_deployment.py":[{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"9c4264f0b75ae954ab0f1159a58ef4a998d2bccf","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    @mock.patch(\"rally.osclients.Clients.verified_keystone\")"},{"line_number":277,"context_line":"    @mock.patch(\"rally.cmd.commands.deployment.db.deployment_get\")"},{"line_number":278,"context_line":"    def test_deployment_check(self, mock_deployment_get, mock_client):"},{"line_number":279,"context_line":"        endpoint \u003d objects.endpoint"},{"line_number":280,"context_line":"        deployment_id \u003d \"e87e4dca-b515-4477-888d-5f6103f13b42\""},{"line_number":281,"context_line":"        sample_endpoint \u003d endpoint.Endpoint(\"http://192.168.1.1:5000/v2.0/\","},{"line_number":282,"context_line":"                                            \"admin\", \"adminpass\").to_dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_d866bf28","line":279,"updated":"2015-04-08 07:10:06.000000000","message":"No need for this. In lines 281/297, you can use just\n\n    ... \u003d objects.Endpoint(...)","commit_id":"4536d22b4ac585f1bdc2b82d156363a56030064c"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"3240e769a200aa4179ce1aadfd03b242c7a78824","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    @mock.patch(\"rally.osclients.Clients.verified_keystone\")"},{"line_number":277,"context_line":"    @mock.patch(\"rally.cmd.commands.deployment.db.deployment_get\")"},{"line_number":278,"context_line":"    def test_deployment_check(self, mock_deployment_get, mock_client):"},{"line_number":279,"context_line":"        endpoint \u003d objects.endpoint"},{"line_number":280,"context_line":"        deployment_id \u003d \"e87e4dca-b515-4477-888d-5f6103f13b42\""},{"line_number":281,"context_line":"        sample_endpoint \u003d endpoint.Endpoint(\"http://192.168.1.1:5000/v2.0/\","},{"line_number":282,"context_line":"                                            \"admin\", \"adminpass\").to_dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_de4d879a","line":279,"in_reply_to":"9aa53dc9_d866bf28","updated":"2015-04-08 08:21:08.000000000","message":"ha, okay","commit_id":"4536d22b4ac585f1bdc2b82d156363a56030064c"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"9c4264f0b75ae954ab0f1159a58ef4a998d2bccf","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            self.deployment.check(deployment_id)"},{"line_number":288,"context_line":"        except Exception as e:"},{"line_number":289,"context_line":"            # no self.assertNotRaises yet, so use try...except instead"},{"line_number":290,"context_line":"            self.assertFalse(e)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\"rally.osclients.Clients.verified_keystone\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_d8347ffc","line":289,"updated":"2015-04-08 07:10:06.000000000","message":"Can we do this without a try...except statement at all?\n\n    ...\n    mock_client.services.list.return_value \u003d []\n    self.deployment.check(deployment_id)","commit_id":"4536d22b4ac585f1bdc2b82d156363a56030064c"},{"author":{"_account_id":9180,"name":"Olga Kopylova","email":"olkonami@gmail.com","username":"olkonami"},"change_message_id":"5f13800dfbd8528cb3f3ef92c4d32019d7734404","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            self.deployment.check(deployment_id)"},{"line_number":288,"context_line":"        except Exception as e:"},{"line_number":289,"context_line":"            # no self.assertNotRaises yet, so use try...except instead"},{"line_number":290,"context_line":"            self.assertFalse(e)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\"rally.osclients.Clients.verified_keystone\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_99bb7de5","line":289,"in_reply_to":"9aa53dc9_12ed2325","updated":"2015-04-08 18:25:25.000000000","message":"I also don\u0027t understand why do we need try...except here at all. This is normal way how unit tests works - to see trace if there is unexpected exception in test. I don\u0027t understand, why should we remake this.","commit_id":"4536d22b4ac585f1bdc2b82d156363a56030064c"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"5d9e9f0ac8f7492548f661ba20599d2c8839c153","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            self.deployment.check(deployment_id)"},{"line_number":288,"context_line":"        except Exception as e:"},{"line_number":289,"context_line":"            # no self.assertNotRaises yet, so use try...except instead"},{"line_number":290,"context_line":"            self.assertFalse(e)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\"rally.osclients.Clients.verified_keystone\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_2f9d390a","line":289,"in_reply_to":"9aa53dc9_99bb7de5","updated":"2015-04-09 01:28:41.000000000","message":"this is an *expected* exception, if some other work has been done incorrectly, some exception would be raised here\n\njust think about self.assertNotRaises here","commit_id":"4536d22b4ac585f1bdc2b82d156363a56030064c"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"3240e769a200aa4179ce1aadfd03b242c7a78824","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            self.deployment.check(deployment_id)"},{"line_number":288,"context_line":"        except Exception as e:"},{"line_number":289,"context_line":"            # no self.assertNotRaises yet, so use try...except instead"},{"line_number":290,"context_line":"            self.assertFalse(e)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    @mock.patch(\"rally.osclients.Clients.verified_keystone\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_12ed2325","line":289,"in_reply_to":"9aa53dc9_d8347ffc","updated":"2015-04-08 08:21:08.000000000","message":"actually the wrong test case here could raise something out\n\nthe difference of using try...except is python trace stack or standard error report you would see in unit test output, so I choose using it(let\u0027s complain no assertNotRaise here :))","commit_id":"4536d22b4ac585f1bdc2b82d156363a56030064c"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"e20cca7c2b60587b6e1da69dd5958eaa8f27fca7","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    @mock.patch(\"rally.cmd.commands.deployment.db.deployment_get\")"},{"line_number":278,"context_line":"    def test_deployment_check(self, mock_deployment_get, mock_client):"},{"line_number":279,"context_line":"        deployment_id \u003d \"e87e4dca-b515-4477-888d-5f6103f13b42\""},{"line_number":280,"context_line":"        sample_endpoint \u003d objects.endpoint.Endpoint("},{"line_number":281,"context_line":"            \"http://192.168.1.1:5000/v2.0/\","},{"line_number":282,"context_line":"            \"admin\", \"adminpass\").to_dict()"},{"line_number":283,"context_line":"        mock_deployment_get.return_value \u003d {\"admin\": sample_endpoint}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_62ea6311","line":280,"updated":"2015-04-14 10:10:28.000000000","message":"I meant that this can be even simpler:\n\n     objects.Endpoint(\n\nBecause we import this class here:\nhttps://github.com/stackforge/rally/blob/master/rally/objects/__init__.py","commit_id":"94a634ea3b48ab0be83adb22fbc0ad51c20eb688"},{"author":{"_account_id":8507,"name":"Mikhail Dubov","email":"mdubov@mirantis.com","username":"msdubov"},"change_message_id":"e20cca7c2b60587b6e1da69dd5958eaa8f27fca7","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    @mock.patch(\"rally.cmd.commands.deployment.db.deployment_get\")"},{"line_number":290,"context_line":"    def test_deployment_check_raise(self, mock_deployment_get, mock_client):"},{"line_number":291,"context_line":"        deployment_id \u003d \"e87e4dca-b515-4477-888d-5f6103f13b42\""},{"line_number":292,"context_line":"        sample_endpoint \u003d objects.endpoint.Endpoint("},{"line_number":293,"context_line":"            \"http://192.168.1.1:5000/v2.0/\","},{"line_number":294,"context_line":"            \"admin\", \"adminpass\").to_dict()"},{"line_number":295,"context_line":"        sample_endpoint[\"not-exist-key\"] \u003d \"error\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_22f45bf0","line":292,"updated":"2015-04-14 10:10:28.000000000","message":"same here","commit_id":"94a634ea3b48ab0be83adb22fbc0ad51c20eb688"}]}
